Jump to content
  • 0

Adding markers for party members


Question

Posted (edited)

Hello,

I'm wondering how can I add from server side these markers that indicates a player.

Have seen something like that on Kain.ws server for example (dead project tho)

 

My main goal is to add these markers to party members so they can be more visible during mass pvp and stuff like that.

Since now I have been searching throught PartyDuel and Duel itself. Thing that might've been the closest to what I'm searching for is called "snapshot" but I'm not sure.

Whenever I changed TeamType to opposite team the color beneath has changed aswell.

 

What I'm looking for:

Any information how these markers are called for L2j/Mythras (High Five chronicle) servers so I can relate that to Party.java

Second thing is where can I find this marker in client (player) files?

 

Would love to get any hint

markers.jpg

Edited by Vision

11 answers to this question

Recommended Posts

  • 1
Posted

        final Player tmp = getClient().getPlayer();
        final Party party = tmp.getParty();
        if (tmp != null && party != null && party.equals(_player.getParty()) && !party.isLeader(_player))
            writeC(0x01); // team circle around feet 1= Blue, 2 = red
        else if (tmp != null && party != null && party.equals(_player.getParty()) && party.isLeader(_player))
            writeC(0x02); // team circle around feet 1= Blue, 2 = red    
        else
            writeC(_player.getTeam().getId());

 

this is for red and blue. Also broadcastCharInfo in Party/Disband, Leave and you are good. for different colors im not sure if its possible.

  • 1
Posted (edited)

CharInfo.java

 

	final Player tmp = getClient().getPlayer();
        if (tmp != null && tmp.isInSameParty(_player))
        {
            writeC(1); //1 for blue circle, 2 for red circle
        }
	else 
	{
		writeC((Config.PLAYER_SPAWN_PROTECTION > 0 && _player.isSpawnProtected()) ? TeamType.BLUE.getId() : _player.getTeam().getId());
	}

 

 

Thats atleast for acis.

 

EDIT:
Also you need to add broadcastCharInfo in Party.java on member leave, otherwise ppl will still have circles even if you leave party.

 

Edited by xJustMe
  • 0
Posted

Thank You guys for Your activity below this post. I've tried just to add it manually but it requires few things. So since I caught Your attention here... 😄

How to add two new colors? Let's say green and yellow as it can indicate PTL and party members.

 

Cheers

  • 0
Posted

Thank You so much guys. For my files it required a lot of refactoring since I've had the same name of method and it was making me confused everytime I called let's say visiblePlayers(). @xJustMe answer was a good hint but @andy1984 got the best solution.

 

Thanks so much once again

  • 0
Posted

Tried to achieve the same goal today, I did it with the following line of code but it has a critical issue.

activeChar.getParty().getMembers().forEach(member -> member.setTeam(Team.BLUE));

The issue is that the effect is visible for everyone and not only for the party members or the guy that did the request (prefer the second one to be honest). Do you guys can think any solution about that? Thank you!

  • 0
Posted
So let me represent You what I've done for fandC files. Hope it will help ya there
//initialized variables
private final Player _activeChar;
private final Creature _cha;
private int partyMarker;
public CharInfo(Creature cha, Player target){
   _activeChar = target;
   _cha = cha;
}
      //writeImpl() 
      final Party party = tmp.getParty();
      Player ptarget = _cha.getActingPlayer();
      boolean checkPartyPlayers = ((ptarget != null) && (_activeChar != null) && (_activeChar.getParty() != null) && _activeChar.getParty().containsMember(ptarget));
      if ( tmp != null && party != null && party.equals(_activeChar.getParty()) && checkPartyPlayers && (!party.isLeader(ptarget))){
               partyMarker = 0x01;
      }else if ( tmp != null && party != null && party.equals(_activeChar.getParty()) && checkPartyPlayers && party.isLeader(ptarget)){
               partyMarker = 0x02;
      }else{
         partyMarker = _team.ordinal();
      }
      //writeImpl() 
if(!tmp.isInSameParty(_activeChar))
   partyMarker = 0x00;
if(!_activeChar.isInSameParty(tmp))
   partyMarker = 0x00;

writeC(partyMarker);

Had the same lambda that You have used there but the value was overwritting next voids writeC. For an example when I had 4 ppl in pt all of them were in "fishing mode" 😉

  • 0
Posted
14 hours ago, Ugleethyn said:

Tried to achieve the same goal today, I did it with the following line of code but it has a critical issue.

activeChar.getParty().getMembers().forEach(member -> member.setTeam(Team.BLUE));

The issue is that the effect is visible for everyone and not only for the party members or the guy that did the request (prefer the second one to be honest). Do you guys can think any solution about that? Thank you!

 

YOUR character 'appears' through UserInfo packet, OTHER characters appear through 'CharInfo' packet. So basically when you want one other character A to appear on someone else's B screen, you send a CharInfo with A information to B. So you have to check when CharInfo of A is created what is his relation to the player you send it to B and change the team accordingly only for the CharInfo packet sent to B and not for everyone. So basically you need to edit the method in Player.java/L2PcInstance.java that is responsible for broadcasting the player's information (usually broadcastCharInfo).

 

If you want YOUR character to have a circle as well, you need to modify UserInfo packet and check:

if player is in party && player party leader is player -> team is red

else if player is in party -> team is blue

else -> no team 0x00

 

  • Upvote 1
  • 0
Posted
@Ugleethyn

Setting the TeamType isn't enough, if you only do that it will be sent the same way for everyone. That's basically what does Duel.

If you check shares, you will see isInSameParty check over CharInfo, which enforces conditional appearance depending if being part of the same Party or not.

So sending the "same" packet generate different output, due to inner packet conditions.
  • 0
Posted
On 12/28/2022 at 4:56 PM, Tryskell said:

@Ugleethyn

Setting the TeamType isn't enough, if you only do that it will be sent the same way for everyone. That's basically what does Duel.

If you check shares, you will see isInSameParty check over CharInfo, which enforces conditional appearance depending if being part of the same Party or not.

So sending the "same" packet generate different output, due to inner packet conditions.

 

it is possible to be visible only by the party?

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now


  • Posts

    • in conclusion when somebody who has a project for 10+ years still on development writes an e-say to try until you succeed and then advertises his project, one of the reasons is he needs money, so l2j has once more become pure expensive hobby, you wont make money out of it.   You can still use L2jFrozen and get better results for this, i know some people that done it    keep in mind that C in aCis stands for Crappy, and after all these years its not a cool wordplay anymore, its a fact, prove me wrong.
    • First, don't really follow the "main voice", moreover if you consider it an hobby. Simply do what you want, you got only one life so use it as you want. If you make it an hobby, it's exactly like piano, or velo - only practice makes you better.   Secondly, how do you learn things ? It's actually a really important question, since some can simply be scholar, read books (theory) then practice ; and some simply can't read books. I'm the second type, I hated school, I find it boring - my knowledge in Java comes from try-and-fail. You improve your coding style every year or so, I can myself rewrite my own code (which I already considered top-notched) after a while. You always learn something new - even if Java barely evolves. L2J is a fun way to learn programming, it's a giant sandbox where you can edit anything, and I believe it should be taken as it.   My own way of learning was as follow : Add existing customs, no matter what they are : the point is to know main classes used by L2J / customs. L2J is barely Java knowledge ; the true knowledge is to know WHAT to search in WHICH location (what I call, organization). You have to understand than EVERYTHING you think already exists, in a form on another, in the source code. A custom is only the association of the different mechanisms you found "here and there", glued together in a proper goal. Once you know main classes to edit, and the customs you added are compiling fine, the main point is to know WHAT exactly you DID. Try to understand WHY and WHERE you actually copied the code. Third point would be to MANIPULATE the customs you added in order to fit your wish. First edit little values, then logic conditions ; eventually add a new Config, or a new functionality to the custom. Fourth point would be to begin to craft your own ideas. Once again, EVERYTHING already exists, in a form or another. You want a cycled event ? You got Seven Signs main task as exemple. Npc ? Search any type of Npc and figure out what it does. Fifth point would be to understand Java - mostly containers (WHAT and WHERE to use them), variables types and main Java mechanisms (inheritance, static modifier, etc). You should also begin to cut your code into maintainable classes or methods. Java can actually run without optimization, but bigger your ideas, more optimized and well-thought it should be. It's direct saved time in the future, and you would thank yourself doing so. Main tips : ALWAYS use any type of versioning system - GIT or SVN. It allows to save your work, step by step and eventually revert back anytime you want if you terribly messed up. L2J is 80% organization knowledge, and 20% Java knowledge. Basically, if you know WHAT and WHERE to search, if you aren't dumb, it's easy to replicate and re-use things. Cherry on top is to use a already good coded pack to avoid copy-paste crap and get bad habits. Avoid any type of russian or brazilian packs, for exemple - their best ability is to leak someone's else code. Obviously you need some default sense of logic, but Java and programming in general help you to improve it.   Finally, most of your questions could be solved joining related Discord (at least for aCis, I can't speak for others) - from the moment your question was correctly asked (and you seemed to search for the answer). My community (and myself) welcomes newbies, but got some issues with noobies.   The simpliest is to try, fail and repeat until you succeed - it sounds stupid, but that's basically how life works.   PS : about Java ressources, before ChatGPT, it was mostly about stackoverflow website, and site like Baeldung's one. With ChatGPT and alike, you generally double-cross AI output to avoid fucked up answers. Also, care about AI, they are often hallucinating really hard, even today. They can give you complete wrong answer, you tell them they are wrong, and they say "indeed, I suck, sorry - here's a new fucked up answer". You shouldn't 100% rely over AI answer, even if that can give sometimes legit answers, full code or just skeletons of ideas.   PPS : I don't think there are reliable ressources regarding L2J itself, also most of the proposed code decays pretty fast if the source code is actually maintained (at least for aCis). Still, old coded customs for old aCis sources are actually a good beginner challenge to apply on latest source.
    • WTS: - AQ - Baium - Zaken  - Frintezza - Vesper Fighter Focus Fire Element   pm for detalis
  • Topics

×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock