Jump to content

Question

Posted (edited)

Hello i found something that i didnt think of and i cant fix it that when i kill a mob the drop i have put on this if it is more than 1 it has to be shared to every one in the party but i dont know how but i doesnt getting shared here is what i mean i killed this mob 3 times and http://prntscr.com/ifoopd ..i've  tried changing by here but nothing.

 

	public void distributeItem(Player player, ItemInstance item)
	{
		if (item.getItemId() == 57 && item.getItemId() == 6577)
		{
			distributeAdena(player, item.getCount(), player);
			ItemTable.getInstance().destroyItem("Party", item, player, null);
			return;
		}
		
      and here
        
        public void distributeItem(Player player, IntIntHolder item, boolean spoil, Attackable target)
	{
		if (item == null)
			return;
		
		if (item.getId() == 57 && item.getId() == 6577)
		{
			distributeAdena(player, item.getValue(), target);
			return;
		}
		

 

Edited by ThelwHelpRePaidia

Recommended Posts

  • 0
Posted

[GR] edo les an to item einai adena kai to item einai scroll

na kanei ta parakato mipos thes na to pis kapos alios p.x.

an to item einai = 57 || to item einai = 6577 ?

opos leei kai o hater adis gia " && na balis || "

if (item.getItemId() == 57 && item.getItemId() == 6577)

{

             distributeAdena(player, item.getCount(), player);

            ItemTable.getInstance().destroyItem("Party", item, player, null);

            return;

}

  • 0
Posted (edited)

[GR] opou exei to " distributeAdena " kai apo pano to check item = 57 mporis na baleis ta item pou thes gia paradigma item.getItemId() == 57 || item.getItemId() == 5541

alios gia na min kaneis oli tin ora add sto source to pernas me config kai mirazi ta item sta 2 analoga posa party member exeis

Edited by tazerman2
  • 0
Posted (edited)

@tazerman2 άστο αγόρι μου δε σε θέλει με το && εκεί παραβιάζεις κάθε λογική

Edited by xxdem
  • 0
Posted (edited)

What you don't understand?

If you want the item to be split among party members change:

if (item.getItemId() == 57 && item.getItemId() == 6577)

to

if (item.getItemId() == 57 || item.getItemId() == 6577)

 

Edited by Evie Frye
  • 0
Posted (edited)

i had to change all this because i was getting an error in party.java when i added new distrubeditem..here is what  i did and got this message when i tried to loot from the monster the drops are working fine and thanks for the help but i dont know how to solve this message @melron

pcinventory.java

 
	public static final int COIN_ID = 6577;
	public static final int ADENA_ID = 57;
	public static final int ANCIENT_ADENA_ID = 5575;
	
	private final Player _owner;
	private ItemInstance _coin;
	private ItemInstance _adena;
    public int getCoin()
    {
        return _coin != null ? _coun.getCount() : 0;
    }

    public ItemInstance getCoinInstance()
    {
        return _count;
    }
    public void addCoin(String process, int count, Player actor, WorldObject reference)
	{
		if (count > 0)
			addItem(process, COIN_ID, count, actor, reference);
	}

public ItemInstance addItem(String process, ItemInstance item, Player actor, WorldObject reference)
	{
		item = super.addItem(process, item, actor, reference);
		if (item == null)
			return null;
		
		if (item.getItemId() == COIN_ID && !item.equals(_coin))
			_coin = item;
		
		if (item.getItemId() == ADENA_ID && !item.equals(_adena))
			_adena = item;
            
 public ItemInstance addItem(String process, int itemId, int count, Player actor, WorldObject reference)
	{
		ItemInstance item = super.addItem(process, itemId, count, actor, reference);
		if (item == null)
			return null;
		
          if (item.getItemId() == COIN_ID && !item.equals(_coin))
			_coin = item;
		
		if (item.getItemId() == ADENA_ID && !item.equals(_adena))
			_adena = item;

	public ItemInstance transferItem(String process, int objectId, int count, ItemContainer target, Player actor, WorldObject reference)
	{
		ItemInstance item = super.transferItem(process, objectId, count, target, actor, reference);
		
		if (_coin != null && (_coin.getCount() <= 0 || _coin.getOwnerId() != getOwnerId()))
			_coin = null;
		
		if (_adena != null && (_adena.getCount() <= 0 || _adena.getOwnerId() != getOwnerId()))
			_adena = null;
  
  public ItemInstance dropItem(String process, ItemInstance item, Player actor, WorldObject reference)
	{
		item = super.dropItem(process, item, actor, reference);
		
		if (_coin != null && (_coin.getCount() <= 0 || _coin.getOwnerId() != getOwnerId()))
			_coin = null;
            
            	public ItemInstance dropItem(String process, int objectId, int count, Player actor, WorldObject reference)
	{
ItemInstance item = super.dropItem(process, objectId, count, actor, reference);
		
		if (_coin != null && (_coin.getCount() <= 0 || _coin.getOwnerId() != getOwnerId()))
			_coin = null;
		
		if (_adena != null && (_adena.getCount() <= 0 || _adena.getOwnerId() != getOwnerId()))
			_adena = null;
            
         if (item.getItemId() == COIN_ID)
			_coin = null;
		if (item.getItemId() == ADENA_ID)
			_adena = null;
            
            	public void restore()
	{
		super.restore();
		_coin = getItemByItemId(COIN_ID);
		_adena = getItemByItemId(ADENA_ID);

systemmessageid.java


    public static final SystemMessageId EARNED_S1_COIN;

 

EARNED_S1_COIN = new SystemMessageId(2032);

player.java


    public int getCoin()
    {
        return _inventory.getCoin();
    }

public void addCoin(String process, int count, WorldObject reference, boolean sendMessage)
    {
        if (sendMessage)
            sendPacket(SystemMessage.getSystemMessage(SystemMessageId.EARNED_S1_COIN).addNumber(count));
        
        if (count > 0)
        {
            _inventory.addCoin(process, count, this, reference);
            
            InventoryUpdate iu = new InventoryUpdate();
            
            if (_inventory.getCoinInstance() != null)
                iu.addModifiedItem(_inventory.getCoinInstance());
            else
                iu.addItem(_inventory.getCoinInstance());
            
            sendPacket(iu);
        }
    }

    public void doAutoLoot(Attackable target, IntIntHolder item)
    {
        if (isInParty())
            getParty().distributeItem(this, item, false, target);
        else if (item.getId() == 57)
            addAdena("Loot", item.getValue(), target, true);
        else if (item.getId() == 6577)
            addCoin("Loot", item.getValue(), target, true);
        else
            addItem("Loot", item.getId(), item.getValue(), target, true);
    }

// Check if a Party is in progress
            if (isInParty())
                getParty().distributeItem(this, item);
            // Target is adena
            else if (item.getItemId() == 57 && getInventory().getAdenaInstance() != null)
            {
                addAdena("Pickup", item.getCount(), null, true);
                ItemTable.getInstance().destroyItem("Pickup", item, this, null);
            }
            else if (item.getItemId() == 6577 && getInventory().getCoinInstance() != null)
            {
                addCoin("Pickup", item.getCount(), null, true);
                ItemTable.getInstance().destroyItem("Pickup", item, this, null);
            }
            // Target is regular item

party.java


    public void distributeItem(Player player, IntIntHolder item, boolean spoil, Attackable target)
    {
        if (item == null)
            return;
        
        if (item.getId() == 57)
        {
            distributeAdena(player, item.getValue(), target);
            return;
        }
        if (item.getId() == 6577)
        {
            distributeCoin(player, item.getValue(), target);
            return;
        }

 

public void distributeCoin(Player player, int Coin, Creature target)
    {
        List<Player> toReward = new ArrayList<>(_members.size());
        for (Player member : _members)
        {
            if (!MathUtil.checkIfInRange(Config.PARTY_RANGE, target, member, true) || member.getCoin() == Integer.MAX_VALUE)
                continue;
            
            // Pass the check so will be rewarded.
            toReward.add(member);
        }
        
        // After all playes checked we got them in the list
        // Avoid divisions by 0.
        if (toReward.isEmpty())
            return;
        
        // Calculation for drop in example of 1kk adena's. 1kk / 4 = 250k
        final int count = Coin / toReward.size(); // 250k
        
        // Adding 250k for each player
        for (Player member : toReward)
            member.addCoin("Party", count, player, true);
    }

if (item.getItemId() == 6577)
        {
            distributeCoin(player, item.getCount(), player);
            ItemTable.getInstance().destroyItem("Party", item, player, null);
            return;
        }

 

Edited by ThelwHelpRePaidia
  • 0
Posted (edited)

ok i made it working with the message you have earned but it doesnt broadcast to the other members what the player 1 picked to player 2

Edited by ThelwHelpRePaidia
  • 0
Posted
5 hours ago, ThelwHelpRePaidia said:

ok i made it working with the message you have earned but it doesnt broadcast to the other members what the player 1 picked to player 2

// Send messages to other party members about reward
if (item.getCount() > 1)
	broadcastToPartyMembers(target, SystemMessage.getSystemMessage(SystemMessageId.S1_OBTAINED_S3_S2).addPcName(target).addItemName(item).addItemNumber(item.getCount()));
else if (item.getEnchantLevel() > 0)
	broadcastToPartyMembers(target, SystemMessage.getSystemMessage(SystemMessageId.S1_OBTAINED_S2_S3).addPcName(target).addNumber(item.getEnchantLevel()).addItemName(item));
else
	broadcastToPartyMembers(target, SystemMessage.getSystemMessage(SystemMessageId.S1_OBTAINED_S2).addPcName(target).addItemName(item));

 

Guest
This topic is now closed to further replies.


  • Posts

    • in conclusion when somebody who has a project for 10+ years still on development writes an e-say to try until you succeed and then advertises his project, one of the reasons is he needs money, so l2j has once more become pure expensive hobby, you wont make money out of it.   You can still use L2jFrozen and get better results for this, i know some people that done it    keep in mind that C in aCis stands for Crappy, and after all these years its not a cool wordplay anymore, its a fact, prove me wrong.
    • First, don't really follow the "main voice", moreover if you consider it an hobby. Simply do what you want, you got only one life so use it as you want. If you make it an hobby, it's exactly like piano, or velo - only practice makes you better.   Secondly, how do you learn things ? It's actually a really important question, since some can simply be scholar, read books (theory) then practice ; and some simply can't read books. I'm the second type, I hated school, I find it boring - my knowledge in Java comes from try-and-fail. You improve your coding style every year or so, I can myself rewrite my own code (which I already considered top-notched) after a while. You always learn something new - even if Java barely evolves. L2J is a fun way to learn programming, it's a giant sandbox where you can edit anything, and I believe it should be taken as it.   My own way of learning was as follow : Add existing customs, no matter what they are : the point is to know main classes used by L2J / customs. L2J is barely Java knowledge ; the true knowledge is to know WHAT to search in WHICH location (what I call, organization). You have to understand than EVERYTHING you think already exists, in a form on another, in the source code. A custom is only the association of the different mechanisms you found "here and there", glued together in a proper goal. Once you know main classes to edit, and the customs you added are compiling fine, the main point is to know WHAT exactly you DID. Try to understand WHY and WHERE you actually copied the code. Third point would be to MANIPULATE the customs you added in order to fit your wish. First edit little values, then logic conditions ; eventually add a new Config, or a new functionality to the custom. Fourth point would be to begin to craft your own ideas. Once again, EVERYTHING already exists, in a form or another. You want a cycled event ? You got Seven Signs main task as exemple. Npc ? Search any type of Npc and figure out what it does. Fifth point would be to understand Java - mostly containers (WHAT and WHERE to use them), variables types and main Java mechanisms (inheritance, static modifier, etc). You should also begin to cut your code into maintainable classes or methods. Java can actually run without optimization, but bigger your ideas, more optimized and well-thought it should be. It's direct saved time in the future, and you would thank yourself doing so. Main tips : ALWAYS use any type of versioning system - GIT or SVN. It allows to save your work, step by step and eventually revert back anytime you want if you terribly messed up. L2J is 80% organization knowledge, and 20% Java knowledge. Basically, if you know WHAT and WHERE to search, if you aren't dumb, it's easy to replicate and re-use things. Cherry on top is to use a already good coded pack to avoid copy-paste crap and get bad habits. Avoid any type of russian or brazilian packs, for exemple - their best ability is to leak someone's else code. Obviously you need some default sense of logic, but Java and programming in general help you to improve it.   Finally, most of your questions could be solved joining related Discord (at least for aCis, I can't speak for others) - from the moment your question was correctly asked (and you seemed to search for the answer). My community (and myself) welcomes newbies, but got some issues with noobies.   The simpliest is to try, fail and repeat until you succeed - it sounds stupid, but that's basically how life works.   PS : about Java ressources, before ChatGPT, it was mostly about stackoverflow website, and site like Baeldung's one. With ChatGPT and alike, you generally double-cross AI output to avoid fucked up answers. Also, care about AI, they are often hallucinating really hard, even today. They can give you complete wrong answer, you tell them they are wrong, and they say "indeed, I suck, sorry - here's a new fucked up answer". You shouldn't 100% rely over AI answer, even if that can give sometimes legit answers, full code or just skeletons of ideas.   PPS : I don't think there are reliable ressources regarding L2J itself, also most of the proposed code decays pretty fast if the source code is actually maintained (at least for aCis). Still, old coded customs for old aCis sources are actually a good beginner challenge to apply on latest source.
    • WTS: - AQ - Baium - Zaken  - Frintezza - Vesper Fighter Focus Fire Element   pm for detalis
  • Topics

×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock