Welcome to MaxCheaters.com

Register now to gain access to all of our features. Once registered and logged in, you will be able to create topics, post replies to existing threads

  • 0

Help Acis party drops


Question

Hello i found something that i didnt think of and i cant fix it that when i kill a mob the drop i have put on this if it is more than 1 it has to be shared to every one in the party but i dont know how but i doesnt getting shared here is what i mean i killed this mob 3 times and http://prntscr.com/ifoopd ..i've  tried changing by here but nothing.

 

	public void distributeItem(Player player, ItemInstance item)
	{
		if (item.getItemId() == 57 && item.getItemId() == 6577)
		{
			distributeAdena(player, item.getCount(), player);
			ItemTable.getInstance().destroyItem("Party", item, player, null);
			return;
		}
		
      and here
        
        public void distributeItem(Player player, IntIntHolder item, boolean spoil, Attackable target)
	{
		if (item == null)
			return;
		
		if (item.getId() == 57 && item.getId() == 6577)
		{
			distributeAdena(player, item.getValue(), target);
			return;
		}
		

 

Edited by ThelwHelpRePaidia

Share this post


Link to post
Share on other sites

Recommended Posts

  • 0

[GR] edo les an to item einai adena kai to item einai scroll

na kanei ta parakato mipos thes na to pis kapos alios p.x.

an to item einai = 57 || to item einai = 6577 ?

opos leei kai o hater adis gia " && na balis || "

if (item.getItemId() == 57 && item.getItemId() == 6577)

{

             distributeAdena(player, item.getCount(), player);

            ItemTable.getInstance().destroyItem("Party", item, player, null);

            return;

}

Share this post


Link to post
Share on other sites
  • 0

[GR] evala to && me tin logiki oti tha to piasi san adena kai tha to diamirasi sto party opws kanei kai me ta adena alla mallon htan vlakeia mou xD

Share this post


Link to post
Share on other sites
  • 0

[GR] opou exei to " distributeAdena " kai apo pano to check item = 57 mporis na baleis ta item pou thes gia paradigma item.getItemId() == 57 || item.getItemId() == 5541

alios gia na min kaneis oli tin ora add sto source to pernas me config kai mirazi ta item sta 2 analoga posa party member exeis

Edited by tazerman2

Share this post


Link to post
Share on other sites
  • 0

What you don't understand?

If you want the item to be split among party members change:

if (item.getItemId() == 57 && item.getItemId() == 6577)

to

if (item.getItemId() == 57 || item.getItemId() == 6577)

 

Edited by Evie Frye

Share this post


Link to post
Share on other sites
  • 0

i had to change all this because i was getting an error in party.java when i added new distrubeditem..here is what  i did and got this message when i tried to loot from the monster the drops are working fine and thanks for the help but i dont know how to solve this message @melron

pcinventory.java

 
	public static final int COIN_ID = 6577;
	public static final int ADENA_ID = 57;
	public static final int ANCIENT_ADENA_ID = 5575;
	
	private final Player _owner;
	private ItemInstance _coin;
	private ItemInstance _adena;
    public int getCoin()
    {
        return _coin != null ? _coun.getCount() : 0;
    }

    public ItemInstance getCoinInstance()
    {
        return _count;
    }
    public void addCoin(String process, int count, Player actor, WorldObject reference)
	{
		if (count > 0)
			addItem(process, COIN_ID, count, actor, reference);
	}

public ItemInstance addItem(String process, ItemInstance item, Player actor, WorldObject reference)
	{
		item = super.addItem(process, item, actor, reference);
		if (item == null)
			return null;
		
		if (item.getItemId() == COIN_ID && !item.equals(_coin))
			_coin = item;
		
		if (item.getItemId() == ADENA_ID && !item.equals(_adena))
			_adena = item;
            
 public ItemInstance addItem(String process, int itemId, int count, Player actor, WorldObject reference)
	{
		ItemInstance item = super.addItem(process, itemId, count, actor, reference);
		if (item == null)
			return null;
		
          if (item.getItemId() == COIN_ID && !item.equals(_coin))
			_coin = item;
		
		if (item.getItemId() == ADENA_ID && !item.equals(_adena))
			_adena = item;

	public ItemInstance transferItem(String process, int objectId, int count, ItemContainer target, Player actor, WorldObject reference)
	{
		ItemInstance item = super.transferItem(process, objectId, count, target, actor, reference);
		
		if (_coin != null && (_coin.getCount() <= 0 || _coin.getOwnerId() != getOwnerId()))
			_coin = null;
		
		if (_adena != null && (_adena.getCount() <= 0 || _adena.getOwnerId() != getOwnerId()))
			_adena = null;
  
  public ItemInstance dropItem(String process, ItemInstance item, Player actor, WorldObject reference)
	{
		item = super.dropItem(process, item, actor, reference);
		
		if (_coin != null && (_coin.getCount() <= 0 || _coin.getOwnerId() != getOwnerId()))
			_coin = null;
            
            	public ItemInstance dropItem(String process, int objectId, int count, Player actor, WorldObject reference)
	{
ItemInstance item = super.dropItem(process, objectId, count, actor, reference);
		
		if (_coin != null && (_coin.getCount() <= 0 || _coin.getOwnerId() != getOwnerId()))
			_coin = null;
		
		if (_adena != null && (_adena.getCount() <= 0 || _adena.getOwnerId() != getOwnerId()))
			_adena = null;
            
         if (item.getItemId() == COIN_ID)
			_coin = null;
		if (item.getItemId() == ADENA_ID)
			_adena = null;
            
            	public void restore()
	{
		super.restore();
		_coin = getItemByItemId(COIN_ID);
		_adena = getItemByItemId(ADENA_ID);

systemmessageid.java


    public static final SystemMessageId EARNED_S1_COIN;

 

EARNED_S1_COIN = new SystemMessageId(2032);

player.java


    public int getCoin()
    {
        return _inventory.getCoin();
    }

public void addCoin(String process, int count, WorldObject reference, boolean sendMessage)
    {
        if (sendMessage)
            sendPacket(SystemMessage.getSystemMessage(SystemMessageId.EARNED_S1_COIN).addNumber(count));
        
        if (count > 0)
        {
            _inventory.addCoin(process, count, this, reference);
            
            InventoryUpdate iu = new InventoryUpdate();
            
            if (_inventory.getCoinInstance() != null)
                iu.addModifiedItem(_inventory.getCoinInstance());
            else
                iu.addItem(_inventory.getCoinInstance());
            
            sendPacket(iu);
        }
    }

    public void doAutoLoot(Attackable target, IntIntHolder item)
    {
        if (isInParty())
            getParty().distributeItem(this, item, false, target);
        else if (item.getId() == 57)
            addAdena("Loot", item.getValue(), target, true);
        else if (item.getId() == 6577)
            addCoin("Loot", item.getValue(), target, true);
        else
            addItem("Loot", item.getId(), item.getValue(), target, true);
    }

// Check if a Party is in progress
            if (isInParty())
                getParty().distributeItem(this, item);
            // Target is adena
            else if (item.getItemId() == 57 && getInventory().getAdenaInstance() != null)
            {
                addAdena("Pickup", item.getCount(), null, true);
                ItemTable.getInstance().destroyItem("Pickup", item, this, null);
            }
            else if (item.getItemId() == 6577 && getInventory().getCoinInstance() != null)
            {
                addCoin("Pickup", item.getCount(), null, true);
                ItemTable.getInstance().destroyItem("Pickup", item, this, null);
            }
            // Target is regular item

party.java


    public void distributeItem(Player player, IntIntHolder item, boolean spoil, Attackable target)
    {
        if (item == null)
            return;
        
        if (item.getId() == 57)
        {
            distributeAdena(player, item.getValue(), target);
            return;
        }
        if (item.getId() == 6577)
        {
            distributeCoin(player, item.getValue(), target);
            return;
        }

 

public void distributeCoin(Player player, int Coin, Creature target)
    {
        List<Player> toReward = new ArrayList<>(_members.size());
        for (Player member : _members)
        {
            if (!MathUtil.checkIfInRange(Config.PARTY_RANGE, target, member, true) || member.getCoin() == Integer.MAX_VALUE)
                continue;
            
            // Pass the check so will be rewarded.
            toReward.add(member);
        }
        
        // After all playes checked we got them in the list
        // Avoid divisions by 0.
        if (toReward.isEmpty())
            return;
        
        // Calculation for drop in example of 1kk adena's. 1kk / 4 = 250k
        final int count = Coin / toReward.size(); // 250k
        
        // Adding 250k for each player
        for (Player member : toReward)
            member.addCoin("Party", count, player, true);
    }

if (item.getItemId() == 6577)
        {
            distributeCoin(player, item.getCount(), player);
            ItemTable.getInstance().destroyItem("Party", item, player, null);
            return;
        }

 

Edited by ThelwHelpRePaidia

Share this post


Link to post
Share on other sites
  • 0

ok i made it working with the message you have earned but it doesnt broadcast to the other members what the player 1 picked to player 2

Edited by ThelwHelpRePaidia

Share this post


Link to post
Share on other sites
  • 0
5 hours ago, ThelwHelpRePaidia said:

ok i made it working with the message you have earned but it doesnt broadcast to the other members what the player 1 picked to player 2

// Send messages to other party members about reward
if (item.getCount() > 1)
	broadcastToPartyMembers(target, SystemMessage.getSystemMessage(SystemMessageId.S1_OBTAINED_S3_S2).addPcName(target).addItemName(item).addItemNumber(item.getCount()));
else if (item.getEnchantLevel() > 0)
	broadcastToPartyMembers(target, SystemMessage.getSystemMessage(SystemMessageId.S1_OBTAINED_S2_S3).addPcName(target).addNumber(item.getEnchantLevel()).addItemName(item));
else
	broadcastToPartyMembers(target, SystemMessage.getSystemMessage(SystemMessageId.S1_OBTAINED_S2).addPcName(target).addItemName(item));

 

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.