Jump to content

Recommended Posts

  • 1 month later...
Posted

not complet if you remove " ifs from the licence" need create other file for config.

all files extenson c++ need .

Making it work I also did, but the courage to test online with a bunch of players and risky without first testing.
Most modules will not work due to the file interconnections that need to be removed because of missing source files.

Good luck

Posted

To my view the library License.h and License.cpp are just to make the product activation key request a "Backdoor" by removing it in na pi, but asks for a license generated with KeyGenerator.exe, just and does not expire. and all the custons work for me, PINkey, Pvp / pk Announce, Npc Maker, among others that asked for License.h

  • 2 months later...
Posted

Did anyone manage to make this work with the Datapack @Pulentolento shared ? I stumbled upon 3 issues:

 

1) L2Server.exe crashed when loading Script/SkillEnchantData.txt, so I just temporarily emptied it, it throws error then that it failed to parse the file (obviously) but continues to load, so OK

2) L2Server.exe crashes when L2Npc.exe is loading ~3800th NPC (L2Server.exe generates no crash logfile)

3) L2Server.exe crashes when loading a character into the world (L2Server.exe generates no crash logfile)

 

If anyone made this work with the source code, could he please share his exact datapack or perhaps tell me what I might be doing wrong / what to do differently ? Thanks a lot.

 

Posted

As far I remember, when I got this data pack from Vanganth SVN server before He closed, I have never gotten those errors you mentioned.

 

You might did something on script folder or something on sources code... Im not expert to answer your issue, but like I said before, never got any error using this data pack.

 

 

Posted
Just now, Pulentolento said:

As far I remember, when I got this data pack from Vanganth SVN server before He closed, I have never gotten those errors you mentioned.

 

You might did something on script folder or something on sources code... Im not expert to answer your issue, but like I said before, never got any error using this data pack.

 

 

Thanks for reply. The problem is most likely on my side since I compiled it using VS 2013 and its respective toolchain. I compared the official class sizes with expected sizes and of course they are different. When I compile it with VS 2008 toolchain (or do I need 2005 ?) I will post the result here.

Posted

Alright, it works perfectly when compiled with VS 2005, thanks.

 

xafgGCI.jpg

 

On 9/7/2017 at 11:13 AM, agnitium said:

In this source code there are 2 exploits because of which the server can shut down.

not to mention some  bugs. I do not think that 90% of people have the mind to fix it.

On 9/7/2017 at 8:18 PM, Fotislol said:

1st. the sources are the real one, confirmed.

2nd. in case that you dont know how to use them then someone will destroy your server inside some minutes, there is an exploit.

3rd. you can modify a lot of things but in xase you want to do nore hardwork you will need an IDA databse too.

4th. about the one who wrote that vang last dll was 8mb, use your brain and check up the sources, vang is doing somthing after he builds the dll.

5th. i recomend to change some keys before use them cause it will be really easy for someone to bypass your protection(in case you will use this cliext.dll).

6th. i reccomend everyone who use the latest vang dll to find someone who can setup these sources for him cause soon or later will have problems...

On 9/6/2017 at 2:17 PM, Pulentolento said:

I have those sources and I compared them. The only file its added in this pack, it is KeyGenerator.exe.

You just have to delete it and you will be fine, and you wont have any complain of your AntiVirus.

The rest of the files are exactly the same  (with some changes like licence) like mine. This pack doesn't have any backdoor.

If you know C++, just delete the files related with Key generator and Licence.

 

I knew someone will shared it but as far I know from other users comments, are a new exploit out there where it can crash l2server.exe. if you use this pack.

So, if you planing to open a server using this sources, you better hire someone to fix this issue.

 

cheers

 

 

@agnitium 

@Fotislol

@Pulentolento

 

Would you please care to elaborate what causes the crashes / what are the possible exploits so I might fix / prevent them ? Thank you :)

 

Posted

since you don't have to bytecode encrypt your code it will be less mb about the exploits, none said spesificly what are they... they just exist right?

propably some guys that paid for this version and don't want you to have it free now spread rumors of shit cause thats a mega share no?

 

Posted (edited)

I would bet the first one is sending RequestExEnchantSkillInfoDetail with enchant type > 3 (first dword in the packet data) - this crashes the server immediately.

The second one is maybe using malformed pledge/ally crest or pledge emblem to crash everyone's client?

 

EDIT: Fix for the first one (didn't try to compile, please let me know if something is wrong)

Edited by eressea
Posted
1 hour ago, eressea said:

I would bet the first one is sending RequestExEnchantSkillInfoDetail with enchant type > 3 (first dword in the packet data) - this crashes the server immediately.

The second one is maybe using malformed pledge/ally crest or pledge emblem to crash everyone's client?

 

EDIT: Fix for the first one (didn't try to compile, please let me know if something is wrong)

 

Thanks a lot, really appreciate it ! I have no problem fixing / plugging any exploits, but the prerequisite for that is knowing which exploits are actually present and ideally how they are triggered.

 

The packet-related stuff should be easily tested by using some packet "program", like l2phx (or is something else better suited for it ?), right ?

Posted (edited)
1 hour ago, tyrkysovej said:

The packet-related stuff should be easily tested by using some packet "program", like l2phx (or is something else better suited for it ?), right ?

 

Yes, but don't forget to run both server and client without cliext protection enabled.

 

As for malformed crests it's not so easy to test (the easiest way I've found is by using patched engine.dll that just cripples the crest data enough before sending them to server) and it doesn't do anything wrong on the server itself (you even won't see any error message, server doesn't check what's in crest data, it just saves it and later sends it to other players) - it just crashes all clients that try to load the malformed crest as a texture via D3D (e.g. chars who see someone from that clan) - also it's easier to fix by patching the client d3ddrv.dll to not throw exception but ignore the texture error and leave crest white.

 

EDIT: Oh crap, I forgot this is about Vanganth IL, not GF - the skill enchant type error isn't present there (because there were no skill enchant types in C4 core, it's implemented in the extender). But the second bug with crests exists and can be fixed with this patched d3ddrv.dll (Interlude).

Edited by eressea
  • Like 2
  • Thanks 1
  • Upvote 2

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


×
×
  • Create New...