Code Random Fight

[Lioy]

Asked by discorder25 , made for practice

 

Description:

Here is an idea I had while ago. It is an auto event that will start and announce to players that the event is starting, with a voice command players will join and the event will random pick 2 players from all players that registered and will teleport then to an area where they can't go out, logout, restart, etc. They will pvp and the winner will take the prize.

 

 

CODE[V2]:

http://codecrap.com/content/1229/

 

Default delay: 3 minutes(it was for test)

Configuarable(including reward id,count,allow or no the event and delay)

?register to register

?unregister to unregister

Tested(no errors)

For bugs: pm me in the forum or let a comment in this topic,thank you.

 

 

For more code requests pm me , I do this only for practice.

Edited April 21, 2014 by Lioy

[SweeTs]

Hoho, nice one :)

[Lioy]

Hoho, nice one :)

Thank you :P

Edited April 20, 2014 by Lioy

[badriniki]

now the hard part will be to adapt it to acis ;)

[WolfGiaS3na]

Thanks for share i just want help a little "noobiews" 

if you use freya-high5 either gracia whatever you may need adopt few lines 

 

First of all change configs to this

 

From this

+           ALLOW_RANDOM_FIGHT = players.getProperty("AllowRandomFight",true);
+           EVERY_MINUTES = players.getProperty("EveryMinutes",3);
+           RANDOM_FIGHT_REWARD_ID = players.getProperty("RewardId" , 8762);
+           RANDOM_FIGHT_REWARD_COUNT = players.getProperty("RewardCount" , 5);

To this

ALLOW_RANDOM_FIGHT = Boolean.parseBoolean(L2JModSettings.getProperty("AllowRandomFight", "True"));
					        					           EVERY_MINUTES = Integer.parseInt(L2JModSettings.getProperty("EveryMinutes","3"));
					        					           RANDOM_FIGHT_REWARD_ID = Integer.parseInt(L2JModSettings.getProperty("RewardId", "8762"));
					        					           RANDOM_FIGHT_REWARD_COUNT = Integer.parseInt(L2JModSettings.getProperty("RewardCount" , "5"));

Change this

p.teleToLocation(82698,148638,-3473,0);

To this

p.teleToLocation(82698,148638,-3473);

And this

void announce(String str)
   {
       Announcements.announceToAll(str);
   }

To this

void announce(String str)
   {
	   Broadcast.announceToOnlinePlayers(str);
   }

[Lioy]

now the hard part will be to adapt it to acis ;)

Its coded in acis -.- :P

[Tryskell]

Use directly Broadcast.announceToOnlinePlayers( it avoids to call announce, which calls Announcements.announceToAll, which call itself Broadcast.announceToOnlinePlayers(.

 

Fix "protected" methods to avoid synthetic accesses warnings and put stuff private and create getters (notably players Vector).

 

Your pickPlayers() method is kinda strange.

[Lioy]

Use directly Broadcast.announceToOnlinePlayers( it avoids to call announce, which calls Announcements.announceToAll, which call itself Broadcast.announceToOnlinePlayers(.

 

Fix "protected" methods to avoid synthetic accesses warnings and put stuff private and create getters (notably players Vector).

 

Your pickPlayers() method is kinda strange.

 

create getters?

By this you mean isInEvent() for example at L2PcInstance?

[dendrinos]

i would call it Random Duel Mod :D it reminds me kind of FOC duel system :D nice to bring it on L2 :D discorder25 had an awesome idea :D

 

can you work mine now? ;p or you wont at all? :D

[xdem]

create getters?

By this you mean isInEvent() for example at L2PcInstance?

 

 

He talks about encapsulation but in the case of your code I dont find it neceserry neither implementable

[xdem]

get rid of while loops

+       while(players.get(rnd1).isInOlympiadMode())
+           rnd1=Rnd.get(players.size());
+ 
+      
+       while(rnd2==rnd1)
+       {  
+           rnd2=Rnd.get(players.size());
+           while(players.get(rnd2).isInOlympiadMode())
+               rnd2=Rnd.get(players.size());
+       }

use a for and continue instead

 

PS: you didnt checked if the player2 isInOlympiadMode if rnd2==rnd1

+       while(rnd2==rnd1)
+       {   
+           rnd2=Rnd.get(players.size());
+           while(players.get(rnd2).isInOlympiadMode())
+               rnd2=Rnd.get(players.size());
+       }

Edited April 20, 2014 by xdem

[dendrinos]

αυτά που τα μαθαίνετε ? θέλω να μάθω και εγώ.. το μόνο παρόμοιο που έχω χρησημοποιήσει είναι το C# για να φτιαξω fps γαμε για την unity.. πριν 3 χρονια..

υπαρχει καποια σχολη η τιποτα  τετοιο? βλεπω παρα πολλά άτομα το χρησημοποιουν..

[xdem]

αυτά που τα μαθαίνετε ? θέλω να μάθω και εγώ.. το μόνο παρόμοιο που έχω χρησημοποιήσει είναι το C# για να φτιαξω fps γαμε για την unity.. πριν 3 χρονια..

υπαρχει καποια σχολη η τιποτα  τετοιο? βλεπω παρα πολλά άτομα το χρησημοποιουν..

 

to pio?

[`NeverMore]

After longtime again something fresh!
+1 rep from me
 

to pio?

to java

Edited April 20, 2014 by `NeverMore

[dendrinos]

to pio?

to java code..