Tryskell

You have to store your running task to a ScheduledFuture<?> _task (stored in L2PcInstance / Player) and then if (_task != null) { _task.cancel(false); _task = null; } over it if you need to abort it. That code section can be put in a public method to be triggered anywhere, anytime. You got over 50+ occurrences on any regular L2J pack of that way of coding.

All gameserver/votereward pathing files need to be added, since they don't exist. Generate a class in your project with the good name and copy-paste content without the "+" in beginning of each line. Player class is specific to aCis (the patch is made using my pack), in L2J it's still in model.actor.instance but is called L2PcInstance. Other packs can rename it L2Player, PLayerInstance, etc. It uses a system called VoicedCommandHandler (custom .commands usable for players), which, in aCis is dropped, but not on the vast majority of other packs. Elfo's patch only show what you need to add if it already exists. The leftover is shared with other packs, and the patch itself is pretty basic.

It means the file path isn't reachable, or the file not loadable. Default path for regular Npc is "data/html/default/" + npcId + ".htm" For specific instances, you have to check if it overrides Npc#getHtmlPath

Changeset 395 (2038) GeoEngine, StatSet / MemoSet, AggroList, Gatekeeper, Raid Curses, Bugfixes, Organization GeoEngine - Ty Hasha - Added MoveDirectionType enum with pre-calculated constants. - Added getValidSwimLocation, which calculates last accessible swimming location. It also handles getting out of water correctly. - Dropped geo coordinate validation when converting from world coordinates (getGeoX, getGeoY). - Added world coordinate or geo coordinate checks in various can/get methods. GeoEngine now support processing of coords, when outside of world. - Fix LoM check giving false positive result, when target is on "balcony". - Simplified GeoEngine#getWorldX/Y calculation. - Added new admin command "geo_fly" to check LoF. - Fixing movement blocked / pathfinding fail / by dual-layer (e.g. Sirra's pond). StatSet / MemoSet - Implementation of MemoSet, a CHMap storing String pairs. - StatsSet is renamed StatSet and moved to common.data. - NpcMemo and AbstractMemo are deleted. - Lazy initialization concept is deleted from PlayerMemo and ServerMemoTable. AggroList - Introduce AggroList container, gathering all methods related to aggro. - Move few methods here and there for an easier and more logical use (notably, hold AggroInfo instead of Creature and compute back getHating). - Rework and cleanup methods, for easier use and/or optimization. - AggroList#stopHate/reduceAllHate trigger an AI reaction when a most hated isn't foundable. - Implement //info aggro for easier aggro management, include it in the existing panel. - Fixes related to that refactor : - AggroList#reconsiderTarget doesn't consider anymore actual most hated as a valid choice. - The aggro isn't cleared anymore if the most hated becomes out of range (so the second on the list inherits the attack stance). - Fix multiple aggro values (all are checked). "Raid related" use their own formula. - AggroList#randomizeAttack() don't build anymore aggro like crazy and can now work on non aggressive, 0 getAggroRange(). Gatekeeper - Delete 35001 > 35341 instant locations / associated HTMs. - Fix all Ivory Tower Gatekeepers, using proper systems. - Fix few HTMs typos. - RaceTrack > MonsterRaceTrack script rename. Raid Curses - Correct implementation of Raid Boss curse system. Ty shyr for report. - Trigger it exclusively for Playable during a regular hit. - Regular RaidBoss now casts AntiStrider skill during a regular hit. Bugfixes - Fix revive animation. Remove the paralyze effect upon revive. Ty StinkyMadness. - Fix deadlock over AttackableAI#onEvtAttacked. - Fix broken movement Intention (fix few, linked, issues such as boat moving in ground, etc). - Secure all spawns position using World borders. - Fix doAttackHitByPole logic (ss consumption is fixed, add allowPeaceAttack() check) and optimize it. - Fix "Focus Attack" skill target amount. - Implement missing Seal of Strife siege banish behavior. - Fix rewardNewbieShots for Q273 and alike. Ty shyr for report. - Fix skillId 2217 leading to Inventory NPE. Ty shyr for report. - Fix Peace Zone messages/checks for attack/cast. Ty StinkyMadness. - Add RandomizeHate effect, used by 3 different skills (used notably by Confusion). Ty shyr for report. - Delete PenaltyMonster instance and introduce FishingBlocker script using L2OFF. - Rework Monastery script to fit with L2OFF. - Fix ON_SKILL_SEE being centered on actor and not on acting player. - canScheduleAfter is desactivated for AttackableAI. Fix onSpellFinished behavior, mage AI, aggro movement over a Confusion cast, etc. - Fix //reload npc, add //reload script. Ty nighty for report. - Shift Z upon teleport action. - Fix the NPE over CreatureAttack#onHitTimer. Organization - Add World#isOutOfWorld method. - Remove all -100 / +100 from WorldObject#spawnMe/setXYZInvisible. - Add Location#addRandomOffsetBetweenTwoValues method. - Optimize Attack process. - Baium script heavy cleanup. Introduce Quest#addGrandBossSpawn. - Delete unused SummonCast. - //info is slightly edited / reorganized. 2 buttons are added, AggroList and knownlist - Quest#onSkillSee handle Creature[] targets, not WorldObject[]. - Quest#showResult is slightly edited (secured html tags, move few null checks). - All "data containers" holding a single Queue/Map/List now directly extends it.

https://monopoly.fandom.com/wiki/Bankruptcy

When you do Party#removePartyMember, it does what it says ; therefore all additional checks about Player's Party will return false, since he is ALREADY OUT OF THE PARTY. Interrogating Player#getParty() will therefore return ALWAYS NULL, which is PERFECTLY LOGICAL. If you want to code such thing, you have to either : In case of a second method using Party#removePartyMember (what you currently do) : RETAIN the Party of the Player into a variable, and reuse it just after Party#removePartyMember if != null (Party can be disband by default in removePartyMember) In case of Party#removePartyMember method edit : write directly in the method whatever check (there are already such checks for Duel and Dimensional Rift, DuelManager/DimensionalRiftManager#onPartyEdit - in L2J, EVERYTHING ALREADY EXISTS). The good approach is the SECOND approach, since some vars are already validated inside the method (notably, player != null and Party#contains)

//spawn_once doesn't save the Spawn into db, other than that there is no reason it bugs (from memory). Verify first if there are correctly on db, if not, it's normal it can't load - magic can't happen. If they are on db, there are only few cases where it won't generate a Spawn, and most of them got an error message associated to it (wrong NpcTemplate, wrong type of Npc - Guards, Bosses, etc).

Changeset 394 (1972) Scripts, Teleport system, Seven Signs, Organization, Bugfixes Scripts - Introduction of Tutorial / NewbieGuide - Ty howlrang/Marcatu for initial cleanup of L2J script. - Fix following quests : 101, 102, 103, 104, 105, 106, 107, 108, 257, 260, 265, 273, 293. - Rewards are done using rewardItems instead of giveItems. - Fix ss/sps beginners rewards amount. - Rewards are now secured by a PlayerMemo var instead of QuestState var, making it exploit-free (case of 257, 260, 265, 273, 293). - Q105 now rewards regular ss/sps ng, aswell as potions. - Q260 / Q265 reward formulas are fixed using L2OFF. Teleport system - Revamp whole teleport system, using lord_rex initial share. - goto/tele/etc bypasses are deleted, and replaced by only those 2 versions : instant_teleport and teleport_request. Move the teleport logic to Npc. Children classes can override isTeleportAllowed(Player). - Implement TeleportType enum, based on L2OFF AI content. - Implement instantTeleports.xml. Those teleports only check Npc#isTeleportAllowed(Player), while regular teleports check siege, item consumption and Npc#isTeleportAllowed(Player). - Improve teleports.xml, reparsing the content using L2OFF. The model now holds the Castle, teleports are organized by npcId and by TeleportType. The initial data was double check with RooT's work, allowing to add 10 missing ids and cut 60+ pointless ones. - The HTM which shows teleports is now built out of nothing from data. All existing, related HTMs are deleted (scripts and regular teleporters). - Add few missing "-pk" HTMs (30162, 30836, 31964). - Add (back ?) FREE_TELEPORT config. - Rename "teleporter" HTM folder to "gatekeeper" (to match class names). - Rename script ToIVortex > DimensionalVortex. - Add castle chamberlains teleports aswell - parsed from L2OFF GF, since the content of Vanganth and AdvExt was lacking. They are not yet implemented. Seven Signs - Ty Hasha. - Updated all HTMLs to L2OFF GF, formated them, fixed obvious mistakes, typos and names. - Added missing HTML with - not enough adena to purchase Records of Seven Signs. - Fix xxxx_priest_2c.htm to not containCatacomb/Necropolis teleport location link (Seal of Gnosis owner lost -> no teleport). - Fix "Failed to retrieve cabal from bypass command." upon trying to contribute Seal Stones while Seven Signs is in Competition period. - Characters with 1st class transfer can now join any side. - Delete ALT_GAME_CASTLE_DAWN / ALT_GAME_CASTLE_DUSK configs. Replace it by SEVEN_SIGNS_BYPASS_PREREQUISITES. Organization - Add //show html, which toggles on/off the HTML path for GMs (similar to L2OFF). There is no associated config, and is set to false by default. - Secure //set class, which now checks dummy ClassIds, and provide more infos upon fail. - Introduce QuestState#rewardNewbieShots method for easier management of beginner reward. - RadarList#addMarker/removeMarker now accept a Location as parameter. - QuestState#addRadar/removeRadar only accept Location as parameter. - Hardcode all Locations used in Quests for easier management. Replace some int[][] for Location[]. - MIMYU SpawnLocations are downgraded to Locations. - Delete all unused SkillTypes. - Drop all "Alt" and "Game" from either Config .properties or java side. Few Config renames. - Cleanup all checks regarding TAKE_CASTLE, STRIDER_SIEGE_ASSAULT, SIEGE_FLAG and SUMMON_FRIEND - moving methods from Player to dedicated handlers. - Generate NpcTalkCond enum. Rename and generate on Npc #validateCondition(Player) > Npc#getNpcTalkCond(Player), which now acts as overriden. Cleanup all uses. Bugfixes - Fix Benom spawn timer. - Fix trade NPE, upon empty lists pushing "Start" button. - Fix frozen actions upon invalid trade windows checks. - Fix Summon Friend and alike skills. Remove the 50 radius check. Add a SystemMessage and avoid the cast on yourself. - Fix Gate Chant, adding SUMMON_PARTY SkillType. - Fix Elpy AI. Ty Bruns87. - Allow Config.OLY_MIN_MATCHES to be correctly spread over queries when a Config reload occurs. - Fix a stackoverflow over siege end. Ty Kitsos for report/fix. - Fix StriderSiegeAssault, using skill target instead of getTarget(). - Fix bow attack reuse over CreatureAttack#stop() call. Ty MonKEY fo report. - Delete active siege check on Wyvern Managers + class cleanup. - Switch Schuttgart CHs to correct order, fixing CHs doors and spawn. - Auto loot Config properly checks inventory size. PS : Q257 is now race bound to HUMAN. While NOT RETAIL, it looks like a NCSOFT fail : - It defeats the C3 layout being than "all races get access to 13k ss / 6k sps". - Out of 13 newbie quests, it's the only "race unbound" quest. If you manage to find any retail info about why it has been done that wrong way, I'm willing to revert it.

Simply call getInstance() from L2ZoneManager... See all existing uses of the method to figure out.

Don't edit the parts you shown, it's pointless to edit them.

You can check pagination system on aCis. It basically store all elements in a List than sublist it based on given page number. Simply check one of the 7 occurences of MathUtil#countPagesNumber. https://gitlab.com/Tryskell/acis_public/-/blob/master/aCis_gameserver/java/net/sf/l2j/commons/math/MathUtil.java Exemple of use #showBookmarks : https://gitlab.com/Tryskell/acis_public/-/blob/master/aCis_gameserver/java/net/sf/l2j/gameserver/handler/admincommandhandlers/AdminBookmark.java By default L2J got also some handwritten pagination, maybe 1 or 2 times, but I don't find it really readable.

Well, L2OFF is kinda splitted into 2 main projects, Vanganth and AdvExt, and both got issues and differences between them. There are no official leaks between C4 and GF, meaning it's handcrafted. I don't think there are any real active developers, and edits are extremely limited.

I work since 10y on L2J and my own IL emulator, I simply say than what you ask doesn't exist as a valid offer and it can't be filled. Simply make your search over the existing IL forks. Oh, and people saying "100% working things" - avoid them :).

What you ask doesn't exist, you have to cut multiple criterias. And "balance" isn't a criteria.

About diff patches specifically, there's probably multiple hundreds of tutorials for Java, simply search on google. About L2J in general, you can either search on MxC, on aCis forums (I explain some concepts), and probably on youtube. Unfortunately, I doubt someone would make such tutorials, I invite you to test to apply a lighter diff patch with less lines first if you feel unable to handle such a diff patch. It's really about copy and pasting things, reading which file and around which place to copy-paste. Not even what I could call "developement".

It's not a script, but a .diff patch. A script in L2J world is basically an AI script, editing behaviors using listeners (onKill, onTalk, etc), mostly used by quests, grandbosses, etc. If you got the good revision, you can normally automatically apply a .diff patch but virtually, it almost never happens due to numerous facts (you either edited sources, you use another revision, etc) so you have to edit your sources at hand. On the diff patch, "index" is the file to edit. Lines to add got a +, lines to remove got a -. To help you, you got also line numbers under @@ numbers @@. If you don't see any +/-, it means that line already existed on the file, at the time of the patch. So you can easily copy paste it to find it and find back on an easy way where other modified lines can be added/removed.

You have to store the Npc reference on the Quest instance level, with a static Npc _npc when it spawns. addSpawn normally return the created Npc, simply store the instance on the famous _npc variable for further usage. _npc has to be cleaned in same time you delete the instance, otherwise it's possible to refer to a non-existing instance. There are few exemples in quests with such variables, I'm sure some quests in aCis got some "_pilgrim" Npc references saved for further usage. Q024/Q025 FoD quest serie also got a chamberlain ghost which walk to a point and is deleted once he did his track. PS : you also have to check if such _npc reference is already filled to avoid to duplicate Npc AND to lose references (meaning a _npc.deleteMe() wouldn't work anymore). A null check is enough. If the solution of a unique static instance isn't ok for you, you have to track all references for every single Player ; you also have to delete the reference once Player logout otherwise it fills the Map for nothing.

The russian text can be translated as "can't open shared object file: No such file or directory", so I suppose it's about crest or whatever image which can't be found. ImagesCache.resizeImage(ImagesCache.java:128) is what throw the error.

If L2JFrozen got the related task, then simply make it manually following the diff patch. + means it's added, - removed. You would probably be interested by my other exploit fix, regarding Enterworld and ENTERING implementation.

If you do what request people, you will end in a black hole - because people are different, and will request different things. Therefore, you simply can't provide everything to everyone. The best is to fully assume/embrace the type of server you decide to open, and to develop it to get its own identity.

addExpAndSp is the way to go, simply check //set level (previously //setlevel) admincommand.

Changeset 393 (1913) L2DatabaseFactory, CreatureStatus, tryToX, Weight system, Organization, Bugfixes L2DatabaseFactory - Rename it ConnectionPool. Move it to commons.concurrent, use static instead of Singleton. - Use MariaDbPoolDataSource instead of C3P0. Delete related JARs. - Indirectly fix "SQLNonTransientConnectionException: (conn=13) unexpected end of stream, read 0 bytes from 4" after inactivity time. - Update MariaDb connector to 2.6.1. CreatureStatus - Merge CreatureStatus and CreatureStat. Use of generics, add Javadoc. Use internal variables instead of getter/setter. - Delete all getters used as shortcuts from Creature/Player. - Rename setCurrentX to setX (right for CP, MP, HP). - Move Cp related methods to PlayerStatus. - Delete all redundant StatusUpdate calls. Basically, whatever which was calling setX()- X being HP, MP, CP. - AddMp and reduceMp are slightly edited to avoid to call setMp if value isn't worthy to be edited. Implement CreatureStatus#addHp based on those. - Implement setMaxHp/HpMp/CPHpMp. Those are optmized to call StatusUpdate only once. tryToX - Intentions use direct methods to avoid to "guess" parameters type. It also shortcuts writting style by a lot. - Delete SkillUseHolder container/use, which was generating a lot of objects. - Players previous stance isn't hidden anymore by ACTIVE triggering IDLE. When a Player calls ACTIVE or IDLE, it goes directly to IDLE. Weight system - Ty Hasha - Addition of PlayerStatus#isOverbuden (80% volume check), with uses. - Fixed pet weight calculation. AltWeightLimit applied to pets too. - Fixing AltWeightLimit config being double parameter read as int. - Fix potential bug, when removing weight penalty functions from Pet. - Fix multiple item extraction to first check available slot and than create items. - Update ConditionPlayerWeight to use weight penalty, updated XMLs. - Added missing WEIGHT_PENALTY stat, updated XMLs to AdvExt values. - Dropped Creature#_isOverloaded, as only Player and Pet may get overloaded. Overload solved by checking speed == 0, as L2OFF. - Added missing system message in MoveBackwardsToLocation. - Fixed Pet not getting effect of weight penalty. Organization - Rename commons.concurrent > commons.pool. - Delete unused effect EffectCombatPointHealOverTime and EffectType.COMBAT_POINT_HEAL_OVER_TIME. - CreatureAttack#doAttack is correctly overriden in Attackable and Player cases. - Rename StatusType to ServerType. Rename related methods / variables. - Generate StatusType out of StatusUpdate packet. - Move _exp, _sp, _level to PlayableStatus. - Delete isChampion() concept. The whole custom is dropped. - Rework Formulas#calcCrit and calcMCrit. - Some Blow/Pdam cleanup. - Delete isBehindTarget() / isInFrontOfTarget(). The concept is wrong, since effected isn't specially actual getTarget(). - Move isBehind / isInFrontOf / isFacing from Creature to SpawnLocation. Any WorldObject can now call it. - Rework targetLost to handle more checks, rename it isTargetLost. - Siege#announceToPlayers is renamed Siege#announce and allow SiegeSide as parameters (making it possible to call it independently for ATTACKER and DEFENDER, or both). - Delete Player#isInSiege concept, since it's wrongly used (used as a mixed "isSiegeParticipant" and "isInSiegeZone" checks). - GMs are now affected by death penalty and by castle foreigner teleport. Bugfixes - 3200-3299.xml is partially fixed (reviewed 15+ item skills). - Add missing check regarding Baium Angelic Vortex. Ty Kitsos. - Fix SiegeGuard NPE during attack. Ty henrique for report. - Fix "Need to press ctrl to attack siege guards". Ty henrique for report. - Fix SiegeGuards respawn upon end of a Castle siege. Ty henrique for report. - Fix Guards can't be debuffed at any case. Ty shyr for report. - Add back interact possibility with FriendlyMonster. Ty shyr for report. - Fix Gatekeeper CANNOT_PORT_VILLAGE_IN_SIEGE condition. Ty Denzel for report. - Add missing Broadcasting Towers spawns. Ty henrique. - Introduce INTERACT for Summons. It basically is a MOVE_TO with shift possibility. - Fix a ClassCastException over PlayerAI interaction (boards use). - Fix a ClassCastException over RequestActionUse (throne use). Ty henrique for fix/report. - Summons react to shift command over attack. - Summons return back to owner if isTargetLost is triggered (interact, cast, attack). - Summons owner follow status is now broken while sent to attack/interact. - Add missing SUMMON_GAVE_DAMAGE_S1. Correct override. Ty StinkyMadness. - Summons can't be sent to attack dead targets. Ty StinkyMadness. - Fix "When you're running and click on npc to speak with it, your char only stops on client, but continues to run on server". Ty SlugeR for report. - Fix "Trying to cast skill + moving teleports you on client". Ty SlugeR for report. - Fix proper uses of tryToSit/tryToStand. You shouldn't "tryTo" when using a skill, but directly execute it. - Fix pick up animation timer. Ty SlugeR. - Add retail C5 implementation of Charm of Courage. - Fis death on siege properly decreases xp by 1/4. - Add proper check messages for siege summons attempts. - Fix siege process timer, based on AdvExt.

%% is a L2J tag used to say that content will be edited by core side. You can use L2PHX / a debug message to see exactly what is sent. If your bypass stays as %command%, then it's normal nothing happens. %command% is supposed to be replaced.

"mysql generate backup" on Google. And yes, it is kinda stupid to save during runtime since some data is stored only when server shutdowns, or when player shutdowns. If you save in middle of nowhere, then data integrity will be different than when server is currently closing. Properly close your server, then use mysqldump. It's the typical sort of code which "sounds cool", but is at best pointless, at worst dangerous (since you can save things in middle of something, and got no guarantee the actual engine properly ended). An "ok" move would be to generate it only when server actually shutdowned, after all server operations ended.