yeah ok

can you help adapt this code to l2j server Hi5..

 

I got one error on eclipse on getSkill()
 

Thank you.

Can't understand why you are attacking this guy, even if his code is shitty you cant stop him from learning/coding/sharing his work. 

 

give this guy a motivation to keep learning, and dont cut off his wings, all of you were on his coding level once upon.

OK time for motivation.

 

STOP SUCKING SO BADLY

HTMs are good because of HtmCache, which is caching htm info. Understand than once read at least once, it is cached and then content can be retrieved way faster. It also avoids to generate objects, cause atm you build one StringBuilder each time you access it (well at least you didn't use String concatenation, which is a really good point). Tbh as you use dynamic data you still have to build that StringBuilder anyway, so in that case the performance hit is probably low (you still avoid to append though).

 

HTM is also way easier to manage, a simple //reload htm is enough to see direct changes (as saif Elfo, flexibility/readability).

 

------------

• You should use "if / else if" instead of "if / if", because atm you are testing each condition, no matter if you already reached one successfully.
• The try catch blocks got no uses. The only thing to catch is basically the split && Integer.parseInt() of command.
• The override of onAction doesn't seem useful at all. You probably can use overidden showChat.

Except the points above, the code seems ok.

Edited April 24, 201511 yr by Tryskell

the flames is because he shared it