Help One Other Problem...

[Extreamer]

Sorted thank you !

Edited June 11, 2014 by ExtreameR

[Devlin]

SweeTs way is the best for this code & working for sure.

[Extreamer]

Well I want to know what is wrong with my way, its really annoying that I do not know.

[SweeTs]

Basically yup, I'd go with switch, but well.. You have your own way and that's cool :)

 

I tested you code, and guess what.. It's working fine. Dunno how you tested, but it's working only for the pvp case, not pk :P

 

So, if it's not working for you, you facked the placement of the code.

 

 

### Eclipse Workspace Patch 1.0
#P aCis_gameserver
Index: java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java
===================================================================
--- java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java    (revision 327)
+++ java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java    (working copy)
@@ -4012,6 +4012,9 @@
         if (isMounted())
             stopFeed();
         
+        comboDie(killer);
+        removeSkill(264);
+        
         synchronized (this)
         {
             if (isFakeDeath())
@@ -4226,6 +4229,9 @@
                 // Add PvP point to attacker.
                 setPvpKills(getPvpKills() + 1);
                 
+                // killing spree
+                checkCombo();
+                
                 // Send UserInfo packet to attacker with its Karma and PK Counter
                 sendPacket(new UserInfo(this));
             }
@@ -4245,6 +4251,56 @@
         }
     }
     
+    /** Fallen system */
+    private int combo = 0;
+    
+    private void checkCombo()
+    {
+        int i = 0;
+        combo++;
+        int combos = 0;
+                                
+        if(combo == 1)
+        {
+            i = 1;
+            addSkill(SkillTable.getInstance().getInfo(264, 1), false);
+            combos = 1;
+        }
+        else if(combo == 2)
+        {
+            i = 2;
+            addSkill(SkillTable.getInstance().getInfo(264, 110), false);
+            combos = 2;
+        }
+        else if(combo == 3)
+        {
+            i = 3;
+            addSkill(SkillTable.getInstance().getInfo(264, 120), false);
+            combos = 3;
+        }
+                  
+        if(i > 0)
+        {
+            sendMessage("You have been rewarded with a skill.");
+            Broadcast.announceToOnlinePlayers("Player "+getName() + " is in a Combo Mode with " +combos +" pvp kills in a row!");
+        }
+                  
+        i = 0;
+        combos = 0;
+    }
+                  
+    private void comboDie(L2Character killer)
+    {
+        if(combo > 1)
+            Broadcast.announceToOnlinePlayers("Player "+getName() +" has lost his combo of "+combo +" kills by "+killer.getName());
+
+        combo = 0;
+    }
+    
     public void updatePvPStatus()
     {
         if (isInsideZone(ZoneId.PVP))

Edited June 11, 2014 by SweeTs

[Extreamer]

ah i knew it for fuck sake. thanks sweets.

[Extreamer]

I tried to use your patch but my eclipse won't accept it, its giving me the sausage

[SweeTs]

aCis_gameserver

Edited June 11, 2014 by SweeTs

[Extreamer]

ah yeah shit sorry about that :D

 

 

EDIT: I fixed finally omfg, this time it wasn't you sweets but me being dumb as shit.

 

I misplaced the code, as fucking usual. Thank you anyway for the help !

Edited June 11, 2014 by ExtreameR

[SweeTs]

this time it wasn't you sweets

This time ? :dat:

[Extreamer]

yeah the other time you solved it :D

[Extreamer]

private void comboDie(L2Character killer)

   {

       if(combo < Config.COMBO1_KILLS)

removeSkill(Config.COMBO_SKILL_ID);

        Announcements.getInstance().announceToAll("Player "+getName() +" has lost his combo of "+combo +" kills by "+killer.getName());

 

is that correct ?

Edited June 11, 2014 by ExtreameR

[Extreamer]

yeah it doesnt delete the skill after death , kinda annoying.

[SweeTs]

It is, just put the comboDie at doDie method :P

 

Just noticed

if(combo < Config.COMBO1_KILLS)

Should be >= since it's not reseted yet.

Edited June 11, 2014 by SweeTs

[Nightw0lf]

dude who will copy this and you want to fix it for your self... its already old custom lol

and btw why else if while there is switch case?lol

[Extreamer]

dude who will copy this and you want to fix it for your self... its already old custom lol

and btw why else if while there is switch case?lol

 

Yes it was an old custom, Hence I mentioned I used an old code. However I rewrote mine to give different things at different stages, and the combo system has been overhauled, by adding protection.

[Nightw0lf]

you also said that you dont want help so nobody can see the code you're fixing thats where im refairing to, the code is bad and what can possibly be a protection on this one?'adding protection' this days its the same thing like you adding fence 5cm height on a chicken ....but anyway :you serious?: you rewrote yours

i will tell you again use switch case for less code and faster resaults and more editable easy to do

Edited June 12, 2014 by Nightw0lf