Tryskell

One dude on aCis forums needed transformations, and so moved aCis to Hellbound. You can eventually work with him to implement all packets. You can also downgrade actual latest H5 to HB.

Changeset 398 (2308) Admin commands - part II, Petition, TradeList, TargetHandler, Community Manager, Olympiads, Formulas, Bugfixes, Organization Admin commands - part II MovieMaker - Fully rewritten, merged under //movie and //sequence. Delete MovieMakerManager. - Sequences are stored under TreeMap for automatic sort based on index. - Work even if indexes aren't following each other. - Sequences parameters are set on individual columns for easier read. Delete AdminNpc, AdminCamera, AdminShop admincommandhandlers. - Delete //walker, merged with //show (walker). - Delete //gmshop, merged with //buy (no params needed). - Delete //show_shop, merged with //info (shop). - Delete //show_shoplist, replaced by simple //buy. - Delete old //camera (redundant with //movie, almost impossible to use) - Rename //cameramode > //camera. Fix 2 issues (knownlist is properly refreshed, the camera doesn't bounce back to initial position anymore). AdminPetition - Merge all admin commands related to petitions to //petition (show, unfollow, reject, join, reset, view). - Implement //add_peti_chat and //force_peti from ALT+G panel. - //setnoble is merged with //set (noble). - Add missing checks for //remove. Ty StinkyMadness for report. Petition - Overall cleanup (merge containers, Stream usage, Javadoc, multiple checks added, unhardcode HTMs, improve HTMs details). Rework ChatPetition to avoid to iterate upon sent message. - Allow petitions to be saved over server shutdown (lazy save), and properly loaded back (both responders and petitioner receive the Petition window with stored messages). - Implement the petition feedback system, and show it upon CLOSED state. - You can now add multiple users over a single petition (//add_peti_chat). If such added user "cancels" the petition, he can either cancel it if GM, or simply leaves it if regular user. - You can now enforce your target to petition with yourself (//force_peti). It will generate a perfectly regular Petition. - Add the possibility to switch from one Petition to another (active petition returns as PENDING if none active GMs are part of responders). - You can now move from one Petition to another simply joining another Petition - previous Petition will return as PENDING. - You can now unfollow current Petition without having to end it - it will return to PENDING if no left responders are GMs. - Set back the Petition as PENDING and remove associated responders if state is IN_PROCESS but no messages were sent. - Multiple integrity/sanity checks were added (avoid to reject if already REJECTED, etc). TradeList - Add Javadoc. - Add missing sysMsg ONCE_THE_TRADE_IS_CONFIRMED_THE_ITEM_CANNOT_BE_MOVED_AGAIN over self-locked TradeList. - Add missing sysMsg PRIVATE_STORE_UNDER_WAY over you/partner manage store mode. - Add missing sysMsg EXCHANGE_HAS_ENDED over unsuccessful trade - the most common unsuccessful trade being 2 empty validated TradeLists. - Fix an exploit moving distance check from trade request to validation. Ty StinkyMadness for report. - SendTradeDone packet now uses a static approach. TargetHandler - Add noicon over Recover Force. - Fix Signets symbols. - Delete TargetHandler PET. - Fix Treasure Keys. - Clear charges over Player death. - L2Skill addSummon/addCharacter methods aren't static anymore. - Rework canDoCast concept. Introduce ITargetHandler#meetCastConditions for Playable conditions, fixing numerous target issues over cast. Community Manager MailBBSManager - Move "Mail" class out of it. - Don't lazy load mails anymore, everything is done on startup - which avoid to db query to find last mail id. - Use PlayerInfoTable to retrieve isGm() instead of db query. FavoriteBBSManager - Introduce Favorites management (loading, saving, deleting being functional ; proper bypass saving being NOT due to the system chaos - mail coded in a way, memo in another, etc). Misc - Rename Manager > manager and bb > model packages. - Fix NPE over ClanBBSManager access upon clan creation. Ty Gigi85 for report. - Add the possibility to close Community Board using static approach (ShowBoard.STATIC_CLOSE). - Rename all related SQL tables to "bbs_". - Create ForumType, ForumAccess enums. Delete TopicType. - Rework the Forum/Topic/Post management and move it from "BBSManager"s to "CommunityBoard". Delete CPost concept. Structure isn't lazy loaded anymore, db connections are far, far lesser. Olympiads - Rename queries, tasks. - Remove synchronized, put _nobles as ConcurrentHashMap. - Drop _heroesToBe List (no use to retain it), compute it directly on HeroManager#computeNewHeroes. - loadNoblesRank() > processRankRewards(), use Entry to iterate data instead of keySet()/get(). - saveNobleData() "to_save" concept is removed, instead use INSERT ON DUPLICATE KEY. Also use addBatch/executeBatch instead of generating multiple PreparedStatement. - Merge few one-shot methods with their calls (scheduleWeeklyChange/addWeeklyPoints, init/updateCompStatus, olympiadEnd/updateMonthlyData). - Delete _nobles == null checks (impossible). - OlympiadStat doesn't call 4 times the same content anymore. Formulas - Hit accuracy calculation : Raise the lowcap from 20% to 30%. Modifiers are now directly applied over acc/eva diff rate (which x2 the impact). Base rate is 90, not 80. - Blow damage : fully rework the formula. - Blow rate : fully rework the formula. - Pdef calculation : Full Armors don't count LEGS bonus anymore. - Shield rate versus bows is now x3, out of 30%. Bugfixes - Fix pole attack over Players on peace zone. Ty StinkyMadness. - Fix CCE over Infinity Axe "Discord" effect. Ty Sahar for report. - Rework EffectConfuseMob > EffectDistrust. Only affect Monsters, add a radius check, called only once. - Fix 80+ Quests being broken prior to rev 396 Hasha refactor. Ty StinkyMadness for report. - Add few missing IdFactory cleanup (bbs_mail<>playerId, bbs_favorite<>playerId, bbs_post<>topicId, bbs_post<>playerId). - Don't spend SS over failed Blow. Don't show ATTACK_FAILED message aswell. Organization - Add Recovery Scrolls upon //buy "Scrolls" tab. Ty Somename. - Implement TeleportMode enum.

Most of customs are already shared, and the pack is free. Meaning they sell "wind", since they won't even "maintain" their offers (aka, provide fixes for either their customs or the initial pack). As I said to Trance, marketplace should stop to offer such spot for 2008 year behavior. Because yes, putting some dirty ninja-ed customs from some dark russian forums, adding your own HTMs (sometimes, not even yours) and putting it on any random base doesn't make it a "pack". My point isn't an ego point, it is a project leader point - a point than you can't understand, since you don't manage a publically used pack and you're part of the "car users" (to take back the "car manufacturer" image of xDem). The pack isn't 'fully' open source for specific reasons (and actually, the number of shares and aCis popularity gave me right about the made choice, back in 2010), the pack isn't able to sell for specific reasons (which I already explained - customers don't have any support from sellers, and will ultimately whine to me, my bug report section will be filled with either invalid or already fixed reports, there is no control over quality, there is no control over security, etc) - and once again, you can use any other fork or even basic L2JIL if you want to SELL your customs. I work almost for free, since 10 years. The minimum is to, at least, respect the few rules I put - which are far to be extreme.

Since sellers will never maintain the pack, I think that they shouldn't. Their sell is bound to aCis name, meaning if there is a backdoor, a shitty custom or an issue, they will come to me, not to the seller. That's the video I was referencing on my post :). Like if Zoey76 did all... :D

Lol, you would figure out what I have to reparse, you would reformulate immediately... Spawnlist, zones, skills, items, npc templates have to be reparsed and got their own issue tab on my gitlab... Without counting what I already did since few years. You got it all wrong, but that's np, you're a "car driver". From the moment wheels and engine are working, everything is good. All in one, it changes nothing to the concept - my point isn't to insult (or "forget") old retired L2J developers, who did what they could. At that time, there was no special leader, there was no special code rules and conventions (that's the real, only thing than Zoey76 did - for the team management, imho, he just destroyed L2J, forcing the split of L2JUnity, not accepting forks help for YEARS, etc). My point is to make my pack the most practical for ME and my COMMUNITY to MAINTAIN. I got few, basic, rules you are free to respect or not - which I believe improve aCis and will allow to maintain its legacy - and until now, it worked. My point is to deliver a IL pack for everyone. If you still didn't get it, I can't help you. I would want to make it private, I would simply make my own server, back in 2010, and only rely on players reports. I wouldn't care about javadoc, about methods rename, about splitting classes. But I know aCis is far more than "that" - some people litteraly LEARNT coding, reading my code. Some people PMed me, saying than my project gave them the desire to go in developer classroom - or simply thanked me for the "player memories". And if aCis is still used, it's only because it's coded in a serious way. There is a vision and there is a team leader, with defined goals. Which most of projects simply don't have. PS : packets aren't a big deal, once you got opcodes, and structure. And that's decompilable.

Believe me, I doubt L2JFrozen would survive a lot - Shyla/Nefer were doing hotfixes. You don't make a pack out of hotfixes. They had no special vision about what needed to be done. Remember than L2JFrozen isn't based on L2JIL, but on Scoria. Which means people already worked before them, and before them, it was probably some other russian dudes... Until L2J IL. L2JFrozen is only "good" because of the Scoria part... If they would begin on the same level than me, believe me, that would be another story. And if I can tell you that, it's because I was checking their timeline, during their whole lifetime, without ninja-ing anything useful. As I did with L2JHellas - nothing special to import.

I'm not sure how you calculate things, anyway, I can tell you than it's not a matter about how much was previously done - if everything done is wrong, then, everything has to be redone from zero. I can give you few exemples, such as skill effect system. It's as old as L2J, and it's the wrongest thing ever, leading to numerous issues. It's not even yet fixed on latest. Spawnlist is another wrong system (should be territory based). Knownlist is another (was scaling so bad than it could easily consume 2g RAM of your server with 3500 NPCs seeing each other). I can name few dozen and dozen of wrong things, than I reworked or am actually in the process to rework with my community. Most data (scripts, only to name those) has been or will be reparsed - that's a fact. It's not because it was existing before, or I reuse the existing structure, it makes my work "invisible". My work is a part of a bigger work. I'm not sure if you know exactly how bad L2J IL is, but It's an old decayed house than I refactor since 10y. And saying my (and my community) work equals 5% is, as I said, either ignorance or a lie.

Actually, I think L2J is at this bad shape only because of Zoey76. And Zoey76 isn't the one who coded initial L2J, just for your concern. He got nothing to do with L2J IL (if he was simply here at this time). There was a nice video made on L2JForum, back in time, with all contributors names - and I assure you than Zoey76 isn't the biggest one, in the concerned period of L2JIL, which is mine. ---- Locking a source don't avoid the leak, and it's not my point to lock things. And as says xdem, even if I could simply make few servers and fix things by myself and wait reports from players, it's "easier" and more "friendly" to build a community around a project. If you honor my words, you honor my work - that's all. If you don't feel like honoring my words, you got other, amateur or pro, L2J forks - simply use them.

Because you stucked at rev 190 - it's way higher than 5%. L2J IL don't even have IL skills, partymatching isn't implemented, cb aswell, scripts are in jython and rates aren't checked (when quests aren't simply exploitable), there are at least 6 fat exploits which can easy ruin your server... I got 600+ archived bug reports, that's without counting my own reworks which generally fix many things... I reworked countless things, I can speak about it and make a list but that would be long and annoying, if you don't want to see it that's fine, but you are at worst, simply lying, and at best, ignorant about the work done over the years.

I asked both to Zoey76 to maintain IL branch directly on L2J, and to L2JFrozen to merge with me - and both refused. Zoey76 refused because he was "supporting" L2JFrozen instead of my pack, back in time. I don't remember why Shyla/Nefer refused, most probably because of divergence about what needed to be done : Shyla considered than hotfixes are a way to fix, while me, instead, I'm the sort of people who uses dynamite to rebuild on a clean ground. I didn't understand you question, @Kara.

I already reported the following topic to moderators using the "Report" button, which breaks my own ToA. For an unknown reason, it was dropped then rehabilited. The ToA is public, and spread over my own Discord channel, forums, MxC subforums - so there is nothing like hidden content and no possibility of an error. https://maxcheaters.com/topic/238926-l2jacis-custom-pvp-server-ready-for-open/?tab=comments#comment-2768642 I request the drop of that topic. PS : I got nothing towards the author, all people have to follow the same rules. The main reasons for such a rule are, the author got no pretention to maintain his pack, meaning any issue his buyers would have will go directly to me, for no specific reasons (I'm not paid). Moreover, it will fill my own forums report section with invalid reports, mostly due to added customs or due to the fact the dude uses an older revision.

It's not to deMEV to reduce prices, it's to concurrents to exist. If someone thinks deMEV does a lot of money, he can open the geoeditor and work. That will generate battle price, happier customers, and (normally) a raise in quality. Windows for a very very long time had their shitty Internet Explorer with no concurrents, when there was finally concurrents they lost the market for solutions which were updated, more secured, and faster. If you think there is somewhere to make money, you're up to open a market yourself. It's not the fault to deMEV to be the only dude to develop geodata. If he is the only dude, then he can put whatever price he wants. I don't have any friendship towards deMEV, nor paid him for any work,... It's just my neutral PoV. :)

I invite you to read aCis Terms of Agreement - I reported the topic. Ty for your interest.

You can use stream for getUncategorizedUniversalDropItemsIds / monstersWithDropId for oneliners. monstersWithDropId should be properly named, and shouldn't create an empty List (but return Collections.emptyList() instead). IXmlReader use would cut your parser class by alot. equals can be replaced by == for enum comparison. Added to that, you can use NpcTemplate#isType for easy instance comparison (if you don't mind the enum.toString()). getUncategorizedUniversalDropById use should be null checked. You can/should use {} wildcard for LOGGER(s) parameters, cf. : LOGGER.info("Loaded {} crests.", _crests.size());

It's perfectly fine and I don't know why it's not the default behavior since always. My only downside would be about "public negociation", which will easily pollute the topic with things than none cares about. When I go on a topic, that's not to see if I can trade "my chicken to some peas and some pounds of butter". I believe "negociations" should stay in private circle - moreover it's really easy to bypass such rule by PMing the dude directly. But default price should definitively be shown for everyone (I personally even think, being part of the title). In another level, you must also forbid people "spamming" about "how high price is". It looks like a tradition when someone shows some price to spam about it. If people finds it expensive, simply don't bother with the topic and moves on. Up to people to buy or not to buy.

You have to generate a script with onKill event similar to GrandBosses, or a Manager which will basically be a RaidBossManager clone, because what you request is simply not existing - until I miss something and IL+ chronicles edited the system, it's normally only used for random teleport and alike NPCs, such as Master Toma, Mammons, etc. Also, using RaidBossManager by itself wouldn't be enough aswell, since it doesn't handle random locations. So all in one, you have to code it.

Well, it's always better to say it even if for you it's "obvious", because for many people - notably the ones you try to pick - it's not. I don't say it doesn't work - even a Ponzi scam such as bitconnect made real money to some of people - but for any pump, you will have actual pumpers which gonna be negative. It's really, simple maths and it's basically more "gambling" than "trading". That's cool you ma(k/d)e money that way, that basically means you click faster on "sell" than either greedy/lagging pumper. But you should also warn than it's risky and you can become negative really, really fast (notably if you enter too late and exit too late). For interested people you can check on TradingView the coin StreamR (DATA) which was pumped by the Discord group I joined in 2019 and left few weeks later (from memory it was the +150% one). It looks like this coin was pumped at least twice.

As a sidenote, you have to know some people have to "pay" the pump. It's not magical. If someone makes money, some other loses. And tbh, it's the Discord channel owner which makes the most of it (and his friends, since he gives the coin, he can easily exploit it and fill his own bags), not the regular users. I recommend any people interested by that method to "simulate" before even trying it. That will avoid you to stuck with some pumped shitcoins, due to either your own greediness or your faulty internet, since it's enough to stick 1 min too late to lose money (and not little one, but easily 25%+). I personally won't recommend anyone to use such method, until you use some paid subscriptions to get some advantages over the regular pleb. If you are the pleb, you will basically won't do any money out of those huge pumps (on my own test scenario, barely 15% out of a 100% bar - which is achieved in other, more secured, means). Also, and to be perfectly honest, you should say, @Frank, that you earn something if you recruit people (depending about the channel itself - money for every X members recruited, or/and paid subscriptions). Remember people - if someone wins, someone loses. Don't be the one losing :).

EventInterface.onHit(EventInterface.java:153)

I'm not a big client editor, but probably questname-e from your client system folder. Which is sure is, it's related to client and only to client.

If your point is to delete all conditions, easieast is to delete all VillageMaster children instances, and edit the used type from Npc template (on db or XML) from (let's say) "VillageMasterDwarf" to "VillageMaster". If your point is to edit conditions, edit checkVillageMasterRace and checkVillageMasterTeachType on whatever children instance. VillageMaster sends back by default "true" to both.

And what ? I'm supposed to copy-paste your answer ? Elmoreden's Gods...

Not my fault if the dude sharing such customized crap sucks, and if some poor dude are using it. You seem to know better about it. I answered to :

All your issues are related to custom databases, which got nothing to do with vanilla aCis.