Jump to content

Recommended Posts

Posted (edited)

Seriously ma bitch? :D 

 

public BossEvent()
+   {
+       if (Config.BOSS_EVENT_RAIDBOSS_ID != 0)
+           ThreadPool.scheduleAtFixedRate(this, 1000, 1000);
+   }
+  
+   @Override
+   public void run()
+   {
+       if (_state != State.INACTIVE)
+           return;
+      
+       final Calendar calendar = Calendar.getInstance();
+       final int hour = calendar.get(Calendar.HOUR_OF_DAY);
+       final int minute = calendar.get(Calendar.MINUTE);
+       for (String time : Config.BOSS_EVENT_SCHEDULER_TIMES)
+       {
+           final String[] splitTime = time.split(":");
+           if (Integer.parseInt(splitTime[0]) == hour && Integer.parseInt(splitTime[1]) == minute)
+           {
+               spawnRaidboss();
+               break;
+           }
+       }
+   }

Threadpool every 1 second to check if hour and minute matches the given config instead of calculate whats the closest time and set a thread for it specificialy?

+			spawn.setRespawnDelay(60000);
+           spawn.setRespawnState(false);

setRespawnDelay(6000); but then you setRespawnState false. So useless 60000 delay.

+			 _raidboss.setCurrentHp(_raidboss.getMaxHp());
+           _raidboss.setCurrentMp(_raidboss.getMaxMp());

Useless also. Any new npc is spawned with max HP/MP.

String[] BOSS_EVENT_SPAWN_LOCATION

Why don't you make it directly into a int[] to avoid later Integer.parse and make the code look shit?

It's 4 lines

String[] split = events.getProperty("BossEventSpawnLocation", "").split(",");

BOSS_EVENT_SPAWN_LOCATION = new int[split.lenght];

for (int i = 0; i < split.lenght; i++)
 BOSS_EVENT_SPAWN_LOCATION[i] = Integer.parseInt(split[i]);

 

Edited by Kara`
Posted

Hello again stinky, I'm trying to get your mod from acis 377 to 375 and I'm trying to make it difficult to read in XML, since your mod was done with IXMLReader and my source used XMLDocument, because of that I can not compile, I was looking for forms of convert the code to XMLDocument and would like to know if there are options to help me.
This document was not found. "The XMLDocument type can not be a superinterface of BossEventData; a superinterface must be an interface".

Translated by google translate.

[javac] C:\workspace\L2jMega_gameserver2\java\net\sf\l2j\gameserver\data\xml\BossEventData.java:18: error: cannot find symbol
    [javac] public class BossEventData implements IXmlReader
    [javac]                                       ^
    [javac]   symbol: class IXmlReader
    [javac] C:\workspace\L2jMega_gameserver2\java\net\sf\l2j\gameserver\data\xml\BossEventData.java:27: error: method does not override or implement a method from a supertype
    [javac]    @Override
    [javac]    ^
    [javac] C:\workspace\L2jMega_gameserver2\java\net\sf\l2j\gameserver\data\xml\BossEventData.java:30: error: cannot find symbol
    [javac]        parseFile("./data/xml/BossEvent.xml");
    [javac]        ^
    [javac]   symbol:   method parseFile(String)
    [javac]   location: class BossEventData
    [javac] C:\workspace\L2jMega_gameserver2\java\net\sf\l2j\gameserver\data\xml\BossEventData.java:33: error: method does not override or implement a method from a supertype
    [javac]    @Override
    [javac]    ^
    [javac] C:\workspace\L2jMega_gameserver2\java\net\sf\l2j\gameserver\data\xml\BossEventData.java:37: error: cannot find symbol
    [javac]        forEach(doc, "list", listNode -> forEach(listNode, "Boss", bossNode ->
    [javac]        ^
    [javac]   symbol:   method forEach(Document,String,(listNode)[...]); }))
    [javac]   location: class BossEventData
    [javac] C:\workspace\L2jMega_gameserver2\java\net\sf\l2j\gameserver\data\xml\BossEventData.java:44: error: cannot find symbol
    [javac]                set.set("posX", parseInteger(attrs, "x"));
    [javac]                                ^
    [javac]   symbol:   method parseInteger(NamedNodeMap,String)
    [javac]   location: class BossEventData
    [javac] C:\workspace\L2jMega_gameserver2\java\net\sf\l2j\gameserver\data\xml\BossEventData.java:45: error: cannot find symbol
    [javac]                set.set("posY", parseInteger(attrs, "y"));
    [javac]                                ^
    [javac]   symbol:   method parseInteger(NamedNodeMap,String)
    [javac]   location: class BossEventData
    [javac] C:\workspace\L2jMega_gameserver2\java\net\sf\l2j\gameserver\data\xml\BossEventData.java:46: error: cannot find symbol
    [javac]                set.set("posZ", parseInteger(attrs, "z"));
    [javac]                                ^
    [javac]   symbol:   method parseInteger(NamedNodeMap,String)
    [javac]   location: class BossEventData
    [javac] 8 errors

 

Posted

XMLDocument has different behaviour than IXMLReader. If you are a customer of acis and you got the new patches, change it. Otherwise check how other files are using the xmlreader and adapt it since you are not allowed to get the new version for free. 

  • Like 1
  • Thanks 1
Posted
5 hours ago, martuxas1 said:

good code but code not valid for acis can't find IXMLReader.java in google or some one can share IXMLReader.java for acis?

Its an class of newer aCis revisions, if you want it you have to become an customer on aCis.. else you have to write on your own or find it from any other project hat using IXmlReader.

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now


  • Posts

    • TG Support: https://t.me/buyingproxysup | Channel: https://t.me/buyingproxycom Discord support: #buyingproxy | Server: Join the BuyingProxy Discord Server!  Create your free account here
    • Dalam World — This is a new gaming project that brings together all the mechanics of your favorite games! I want to say right away that the game will run on all devices: Windows, Linux, macOS (Intel/Apple)! The Dalam World client features advanced graphics that will look great! The client also provides stable FPS even with a huge number of players! Dalam World is not a Salve or Chronicle client ported upward — it’s a completely remade game on its own proprietary game engine! Dalam World servers allow more than 100,000 people to exist in a single world without virtual instances, thanks to server technologies built with Elixir and Rust! Dalam World is the childhood game we love so much! From each of our favorite MMOs we took only the best elements! Low system requirements will let the game run on an old laptop! We redesigned the game so there are no bots or real-money traders! Game website: https://Dalam.World Game forum: https://Dalam.World/forums/ For arbitragers: https://careers.dalam.world/ Discord: https://discord.gg/vbQ347nuxd Telegram: https://t.me/+u1DNZPzscaRmNjYx Opening July 16, 2026 at 16:00 UTC!  
    • I'll give you my wallet if you want, haha
    • To make up for some of the waiting time we’re hosting a 3v3 Tournament on open Beta, and this time we’re raising the stakes with a $1,300 prize pool 💰   🏆 PRIZE POOL BREAKDOWN (Over 2000$ Worth of prices total)   🥇 1st Place — $700 🥈 2nd Place —$300 🥉 3rd Place — $200 🏅 4th Place — $100  5th -6th Place - $100 in Gold Coins each    All Participating Teams: $50 in Gold!   All Prices will be Paid out instantly after the tour, no waiting time and conditions. This is not simply a marketing move, we want to give back to the community.   📅 Date: Wednesday 06.05.2026 ⏰ Time: 20:00 Central European Timezone (Berlin) 📍Format: 3v3   ⚔️Why join? Cash Prices for top 4 and rewards for all participants Payments to winners sent out straight after the tournament - No waiting time or rules that you have to play live server to obtain the reward. Clean format, smooth matches, and solid prize pool and a chance to experience our brand new files   📝How to join: Form your 3-player team Group Leader Sign up here: ⁠📍・3v3-tour-registration (Include Name of Group, Name of Group Leader)   Be ready on match day!     A separate post with rules for the tournament and class setups will follow shortly.   Tag your teammates, lock in your roster, and get ready to compete. We'll be happy to see you on the OBT!   💬 Questions? Ask in ⁠🎫・ticket or send us a message   See you on L2Dark! 😏   Discord: https://discord.gg/FAJwnFpb8M
    • You should check if that condition is supported by your current sources. You can find this in  DocumentBase#parsePlayerCondition If it isnt there and you want to follow the same pattern of the other item conditions, create a custom condition to parse the classId (or multiple class ids) (there are examples to copy the code). Alternatively, you can create your own condition handler. Your condition should look like this: <cond msgId="1518"> <or> <player classId="ADVENTURER" /> <player classId="PALADIN" /> </or> </cond> or <cond msgId="1518"> <or> <player classId="93" /> <player classId="5" /> </or> </cond>  
  • Topics

×
×
  • Create New...

Important Information

This community uses essential cookies to function properly. Non-essential cookies and third-party services are used only with your consent. Read our Privacy Policy and We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue..