Broadcastpacket Is Worst Than Tryskell

[Afou To Patisa]

warning: CLICKBAIT title

 

Ok here's whats going on. player.broadcastUserInfo(); basically spreads  UserInfo(), charInfo() and extraInfo() onto knownlist players. 

So let's say we change title and then name color, we do broadcastTitle(); and broadcastUserInfo(); 

 

All players around get the new info BUT if a new player come in town of giran or teleport next to him, he see the old title + old name color cause simply he didn't receive

the packet (cause he wasnt in the knownlist region). 

 

Basically using player.decay(); player.spawn(); works fine after all but i cant really use this for 100 chars every 1 second example..

 

Is this knownlist problem? I guess no. But how to update properlya player without respawn him or without do a World.getInstance().getAllPlayers() -> sendPacket to all individual. ?

 

Tryskell ps. thanks for previous one.

Edited May 26, 2017 by Afou To Patisa

[Tryskell]

It's probably a knownlist problem, since L2J got a ghosts issue (which is nothing more than people didn't receive the DeleteObject packet when he left the region).

 

If you set something, and except if you edited it meanwhile (or was temporary enough to craft a packet but not saved anywhere), there is no reason you don't receive new informations. And if it worked once, it means the packet can handle the behavior, so it is correctly implemented. If you teleport, it normally refresh all packets.

 

PS : you could simply reuse your previous topic rather than writting clickbaiting topic.

Edited May 26, 2017 by Tryskell

[Afou To Patisa]

It's probably a knownlist problem, since L2J got a ghosts issue (which is nothing more than people didn't receive the DeleteObject packet when he left the region).

 

If you set something, and except if you edited it meanwhile, there is no reason you don't receive new informations. And if it worked once, it means the packet can handle the behavior, so it is correctly implemented. If you teleport, it normally refresh all packets.

No it doesnt, i tested it with normal gk teleport also didnt update. title either color. Any idea?

[Tryskell]

No it doesnt, i tested it with normal gk teleport also didnt update. title either color. Any idea?

 

Yup, shitty pack. :)

 

Test with regular settitle / setname admincommands, if it works you messed up somewhere.

Edited May 26, 2017 by Tryskell

[Afou To Patisa]

Yup, shitty pack. :)

 

Test with regular settitle / setname admincommands, if it works you messed up somewhere.

No you iddnt understand, thats the problem i've done it tho //settitle or anything relative to admin.. no custom mod or custom npc.. 

Any clue what should i check? I really got stuck, idk what to look for exaxtly, knownlist or what.. 

Edited May 26, 2017 by Afou To Patisa

[melron]

by your words knowlist seems working fine ... your problem could be in setRegion after teleport..

[Afou To Patisa]

by your words knowlist seems working fine ... your problem could be in setRegion after teleport..

Could u give me a clue? Really it's big problem to me and i can't find the source of problem, i dont want the solution i just want someone enlight me where the source of problem is.

[Afou To Patisa]

Come on someone give me a f . clue.. im checking updateRegion, knownList       PK broadcast works fine so i guess knownlist is fine.. whats wrong with broacastUserInfo()? ..

which method is working when a player walks to receive info from other players? where is that method? 

Edited May 26, 2017 by Afou To Patisa

[GameBlonD]

PcAppearance.java

 

	public final String getVisibleName()
	{
		if (_visibleName == null)
		{
-			_visibleName = getOwner().getName();
+			return getOwner().getName();
		}
		return _visibleName;
	}
	
	
 		if (_visibleTitle == null)

 		{

-			_visibleTitle = getOwner().getTitle();

+			return getOwner().getTitle();

 		}

 		return _visibleTitle;

 	}

[Afou To Patisa]

 

PcAppearance.java

 

 

	public final String getVisibleName()
	{
		if (_visibleName == null)
		{
-			_visibleName = getOwner().getName();
+			return getOwner().getName();
		}
		return _visibleName;
	}
	
	
 		if (_visibleTitle == null)

 		{

-			_visibleTitle = getOwner().getTitle();

+			return getOwner().getTitle();

 		}

 		return _visibleTitle;

 	}

wtf it worked with title.. but why this? whats the difference? And if so why in territory war also doesnt update the icon above of head? 

Thanks for respond tho.

[Afou To Patisa]

I did undo the changes back to _visibleTitle = getOwner().getTitle(); cause is a temporary solution for title only. i want find whats the problem and does same in territory war icon .. 

[Rootware]

I always told. All public info for UserInfo and CharInfo must be getting from PcAppearance template. So, PcAppearance must use custom info and info not was setted then get direct info from PcInstance. Current model are wrong. Something and somewhere missed always and add new checks everywhere. Too many code.

[Afou To Patisa]

I always told. All public info for UserInfo and CharInfo must be getting from PcAppearance template. So, PcAppearance must use custom info and info not was setted then get direct info from PcInstance. Current model are wrong. Something and somewhere missed always and add new checks everywhere. Too many code.

I really didnt understand what you said..  but tho this 

 

PcAppearance.java

https://pastebin.com/kaYP24Pc

 

UserInfo

https://pastebin.com/Bq5tGcKj

 

is pure l2j i dont think i've done something wrong. 

[Rootware]

I really didnt understand what you said..  but tho this 

 

PcAppearance.java

https://pastebin.com/kaYP24Pc

 

UserInfo

https://pastebin.com/Bq5tGcKj

 

is pure l2j i dont think i've done something wrong. 

 

Don't cares if you don't understanding L2J mechanics. You got the answer, but not see it.

Edited May 26, 2017 by Rootware

[Afou To Patisa]

Don't cares if you don't understanding L2J mechanics. You got the answer, but not see it.

So thats the best help i can get? an "ironic" comment.. ? 

Edited May 26, 2017 by Afou To Patisa

[Rootware]

So thats the best help i can get? an "ironic" comment.. ? 

 

Modify PcAppearance like from example in prev. post and change all plases where setting Name, Title, etc to this template except neccessary places (temporary use). Because current model for changing name and title uses PcAppearance and after by task all data stored to DB from this template (not direct from PcInstance). This is the big shit!

 

Don't forget change store method for using direct name and title.