Help What Does It Take To Create A Custom Chat For Pvpers

[mikemaster]

So i found a code which was supposed to enable a custom chat only for players that had reached a certain ammount of pvps

+++ java/net/sf/l2j/gameserver/network/clientpackets/Say2.java

+import net.sf.l2j.gameserver.model.L2World;
+import net.sf.l2j.gameserver.network.serverpackets.CreatureSay;


if(Config.ENABLE_PVP_CHAT)
+                                               {
+                                                       if(_text.startsWith("-"))
+                                                       {
+                                                               if(activeChar.getPvpKills() >= Config.PVP_CHAT_COUNT)
+                                                               {
+                                                       for(L2PcInstance p:L2World.getInstance().getAllPlayers().values())
+                                                          {
+                                                               p.sendPacket(new CreatureSay(0,16,activeChar.getName(),_text));                
+                                                               return;
+                                                              }       
+                                                               }
+                                                               else
+                                                                       activeChar.sendMessage("You don't have enough pvps in order to talk to this chat");
+                                                       }
+                                               }

I think there are still lots to be done cause it pops the message when someone doesn't have enough pvps but when he does nothing happens so..

Edited April 15, 2015 by mikemaster

[Tryskell]

You use return inside the for loop, making the whole method execution stops at the first player found. In a for loop you will almost never find return, it's either break or continue.

 

I let you search what each is doing...

 

Finally it's a nice habit to put all "invalid" states at the beginning, which avoid those nested if and make the code more readable.

if (Config.ENABLE_PVP_CHAT && _text.startsWith("-"))
{
    if (activeChar.getPvpKills() < Config.PVP_CHAT_COUNT)
    {
        activeChar.sendMessage("You don't have enough pvps in order to talk to this chat");
        return;
    }

    for (L2PcInstance p:L2World.getInstance().getAllPlayers().values())
        p.sendPacket(new CreatureSay(0,16,activeChar.getName(),_text)); 
}

If you want an internal check ot see if each receiver is able to read the chat, make the check

if (Config.ENABLE_PVP_CHAT && _text.startsWith("-"))
{
    if (activeChar.getPvpKills() < Config.PVP_CHAT_COUNT)
    {
        activeChar.sendMessage("You don't have enough pvps in order to talk to this chat");
        return;
    }

    for (L2PcInstance p:L2World.getInstance().getAllPlayers().values())
    {
        if (p.getPvpKills() < Config.PVP_CHAT_COUNT)
            continue;
    
        p.sendPacket(new CreatureSay(0,16,activeChar.getName(),_text));
    }
}

Edited April 15, 2015 by Tryskell

[mikemaster]

But Tryskell is this enought? i mean i wanted to make it with a colour like one of the other chats for instance Dark Purple

And also make it global

Cause right now when i added the code that you kindly provided me the message is shown twice and in  a way like normal chat :P

Edited April 15, 2015 by mikemaster

[SweeTs]

Yes, it's gonna be global, there is no region check in the code.

 

 

p.sendPacket(new CreatureSay(0,2,activeChar.getName(),_text));

[mikemaster]

but is there a way to stop the duplicate message? 
I mean when he doesn't have the number of pvps that are required  only to show the error message and not also the -(message he typed)

 

[Nightw0lf]

did you place both codes of tryskell show you?

[An4rchy]

 

     if (Config.ENABLE_PVP_CHAT && _text.startsWith("-"))
     {
         if (activeChar.getPvpKills() < Config.PVP_CHAT_COUNT)
         {
             activeChar.sendMessage("You don't have enough pvps in order to talk to this chat");
             return;
         }
 
         for (L2PcInstance p:L2World.getInstance().getAllPlayers().values())
         {
             if (p.getPvpKills() < Config.PVP_CHAT_COUNT)
                 continue;
         
             p.sendPacket(new CreatureSay(0,16,activeChar.getName(),_text));
         }
         
         return;
     }

[mikemaster]

okey no more duplicate message but  i would like the message to be seen by all players and not only those that have the ammount of pvp

 

Right now the message is Show globaly but only to those that have the pvp ammount

[SweeTs]

Remove the check from for loop..

[mikemaster]

Lock it works fine :D

[SweeTs]

Locked.