[Share]Trade bug fix

[Rizel]

Fix for this exploit:

 

http://www.maxcheaters.com/forum/index.php?topic=46638.0

 

Credit's to me

 

clientpackets.TradeRequest.java (about line 125)


+        if (partner.getAllowTrade() == false)
+       {
+        	player.sendMessage("Target is not allowed to receive more than one trade request at the same time.");
+        	return;
+        }
+        partner.setAllowTrade(false);
+        player.setAllowTrade(false);
	player.onTransactionRequest(partner);
	partner.sendPacket(new SendTradeRequest(player.getObjectId()));
	SystemMessage sm = new SystemMessage(SystemMessageId.REQUEST_S1_FOR_TRADE);
	sm.addString(partner.getName());
	player.sendPacket(sm);




-----------------------------------------------------------

clientpackets.AnswerTradeRequest.java (about line 69)


       L2PcInstance partner = player.getActiveRequester();
       if (partner == null || L2World.getInstance().findObject(partner.getObjectId()) == null)
       {
           // Trade partner not found, cancel trade
		player.sendPacket(new SendTradeDone(0));
           SystemMessage msg = new SystemMessage(SystemMessageId.TARGET_IS_NOT_FOUND_IN_THE_GAME);
           player.sendPacket(msg);
		player.setActiveRequester(null);
+			player.setAllowTrade(true);
+			partner.setAllowTrade(true);
		msg = null;
           return;
       }


-		if (_response == 1) player.startTrade(partner);



+		if (_response == 1)
+			{
+			player.startTrade(partner);
+			partner.setAllowTrade(true);
+			player.setAllowTrade(true);
+			}



	else
	{
		SystemMessage msg = new SystemMessage(SystemMessageId.S1_DENIED_TRADE_REQUEST);
		msg.addString(player.getName());
		partner.sendPacket(msg);
+			player.setAllowTrade(true);
		msg = null;
	}




------------------------------------------

L2PcInstance.java (about line 497)

   private int _apprentice = 0;
   private int _sponsor = 0;

+    public boolean _allowTrade = true;
   
private long _clanJoinExpiryTime;
private long _clanCreateExpiryTime;



L2PcInstance.java (about line 8121)


   public void setClanPrivileges(int n)
   {
       _clanPrivileges = n;
   }

+    public boolean getAllowTrade()
+    {
+    	return _allowTrade;
+    }
+    
+    public void setAllowTrade(boolean a)
+    {
+    	_allowTrade = a;
+    }

[Stefoulis15]

yup.

 

Totally AWESOME!

 

Gratz Mate.

 

+1 From me.

[Frank]

Nice share dude. I just hide it too.

[Versus]

Yes,that's working.Thanks.I would give you +1 but stefoulis already did.

[*~!ĈħâðيȘ۸μấيŧۼŔ™]

God DAMN LoL

 

I need 2 Years To Made This Posts And See The TEXT LoL  :-\

[Stefoulis15]

I would give you +1 but stefoulis already did.

muahahahaha Im The Fastest Gun of The West ! xD

 

Btw , XxRxX 300 Posts Are Too Much I Think.. :s

 

200 Would Be Ok :/

 

[Stealth]

OMG Top Share !

 

This will prevent scam tradings for sure! Maybe i will put this on my server :P

 

[Intrepid]

Really nice bug fix but you need to know one thing!its only for interlude because in gracia there are a protection for that:)

[WebM0nst3r]

Hidden Posts set to 200 ;)

 

Just awsome share owns! :)

[Versus]

I tested it before it was shared ;D

 

200 posts are not enough for this!(working everywhere!)

[stackman]

i cant see :@

[Intrepid]

i cant see :@

 

If you dont see dont post!

[DāЯқŜiĐє]

F@cking awesome...Added in favorites of course :P

[xXxExosoulerxXx]

i think that this trade bug does not work in l2jfree IL because in another topic i saw fafoyka telling that i am right?

soz for my bad english

[Kràtos]

Rizel another wonderful work on java , Thanks For This ;)!

 

Keep Working!