Skip to content

Small Npe And Something Else

Featured Replies

else if (parameters.contains("Cov"))
{
  if(player.getInventory().getItemByItemId(11010).getCount()>= 3)
  {
player.getInventory().destroyItemByItemId("Consume",11010, 3, player, null);
player.sendMessage("SYS: 3 of your Vote Tickets have been consumed.");
player.broadcastPacket(new InventoryUpdate());
MagicSkillUser mgc = new MagicSkillUser(player, player, 1363, 1, 1, 1);
SkillTable.getInstance().getInfo(1363, 1).getEffects(player,player);
player.broadcastPacket(mgc);
player.sendMessage("Your strength is improved due to Chant of Victory effects!"); 
   }
else
{ 
player.sendMessage("You don't have enough vote tickets.");
return;
}
 
}
 
java.lang.NullPointerException
at com.l2jfrozen.gameserver.powerpak.Buffer.BuffHandler.handleCommand(BuffHandler.java:338)
at com.l2jfrozen.gameserver.handler.custom.CustomBypassHandler.handleBypass(CustomBypassHandler.java:101)
at com.l2jfrozen.gameserver.network.clientpackets.RequestBypassToServer.runImpl(RequestBypassToServer.java:315)
at com.l2jfrozen.gameserver.network.clientpackets.L2GameClientPacket.run(L2GameClientPacket.java:77)
at com.l2jfrozen.gameserver.network.L2GameClient.run(L2GameClient.java:1213)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

i made this .. the item does not get destroyed visually.. it gets destroyed but visually i see the same number .. it needs char restart to show correctly..and i get also this NPE when i dont have the items to use the buff

 

 

Solved by melron


if (player.destroyItemByItemId("Buff", id, count, player, true))

{

SkillTable.getInstance().getInfo(buffid, bufflevel).getEffects(this, player);

player.broadcastPacket(new MagicSkillUse(this, player, buffid, 1, 0, 0));

Addk your msg to else and ready

Edited by Reborn12

  • Author
 if (player.destroyItemByItemId("Buff", id, count, player, true))
   {
    SkillTable.getInstance().getInfo(buffid, bufflevel).getEffects(this, player);
    player.broadcastPacket(new MagicSkillUse(this, player, buffid, 1, 0, 0));
Addk your msg to else and ready

 

next? :P haha was not that for sure

Just best choice removed 3 lines added 1 somethink better..

  • Author

Just best choice removed 3 lines added 1 somethink better..

i agree but problem unsolved xD

player.broadcastPacket(new InventoryUpdate());

Remove it

  • Author

still it does that.. 

 

player.broadcastPacket(new InventoryUpdate());
Remove it

  • Solution

working perfect 

                else if (parameters.contains("cov"))
                {			
                    if (player.destroyItemByItemId("Buff", 11010, 3, player, true))
			{
				player.getInventory().destroyItemByItemId("Consume",11010, 3, player, null);
				player.sendMessage("SYS: 3 of your Vote Tickets have been consumed.");
				player.broadcastPacket(new InventoryUpdate());
				MagicSkillUse mgc = new MagicSkillUse(player, player, 1363, 1, 1, 1);
				SkillTable.getInstance().getInfo(1363, 1).getEffects(player,player);
				player.broadcastPacket(mgc);
				player.sendMessage("Your strength is improved due to Chant of Victory effects!"); 
			}

			else
			{ 
			player.sendMessage("You don't have enough vote tickets.");
                        return;
			}
                }

Edited by ⏇Melron⏇℠Abs

  • Author

 

working perfect 

                else if (parameters.contains("cov"))
                {			
                    if (player.destroyItemByItemId("Buff", 11010, 3, player, true))
			{
				player.getInventory().destroyItemByItemId("Consume",11010, 3, player, null);
				player.sendMessage("SYS: 3 of your Vote Tickets have been consumed.");
				player.broadcastPacket(new InventoryUpdate());
				MagicSkillUse mgc = new MagicSkillUse(player, player, 1363, 1, 1, 1);
				SkillTable.getInstance().getInfo(1363, 1).getEffects(player,player);
				player.broadcastPacket(mgc);
				player.sendMessage("Your strength is improved due to Chant of Victory effects!"); 
			}

			else
			{ 
			player.sendMessage("You don't have enough vote tickets.");
                        return;
			}
                }

your item visually destroyed? cause mine doesnt it gets destroyed but visually not.. and when i dont have the items i get the npe

what to say... as i said its working perfect for me (acis)

  • Author

what to say... as i said its working perfect for me (acis)

ohh damn wait i will retest and feedback.. i have it opposite xD

ohh damn wait i will retest and feedback.. i have it opposite xD

:D

You only check for the item count while item doesn't exist - npe. Also lol at this inventory update packet. *Missing facepalm emoticone*  :gusta:

 

Simply..

 

 

if (!player.destroyItem(...
   return;
 
give buff crap

 

You only check for the item count while item doesn't exist - npe. Also lol at this inventory update packet. *Missing facepalm emoticone*  :gusta:

 

Simply..

if (!player.destroyItem(...
   return;
 
give buff crap

as he said he dont get the visually of the destroyed item and i guess thats why one more update added... 

about ur code ... cmon one code can be coded with 1k ways ... 

Guest
This topic is now closed to further replies.

Account

Navigation

Search

Search

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.