Official Ovenuç® Flame topic (L2J Professionals)

[Intrepid]

AHAHAHAH I WILL CRY NOW THEY PUT THAT CODE

 

ESI RE ELFO SE PARAKALW MIN PERNIS MEROS SE KOUBENTA PIGENE MA8E TI KANEI TO DOATTACK KAI TO DOCAST KAI META ELA NA BGALIS GNWMI.. AN LEW PSEMATA OTI TO ELEGES ROTAME KAI TRYSKEL..

 

OSO GIA AUTO TWRA MPIKE KAI PALI EINAI AXRISTO KAI DEN EINAI GIA TO L2PHX EINAI GIA TA MOBS!!!

 

So you say that you are better than everyone right? Okay sir.

 

L2jfree:

 

protected void doAttack(final L2Character target)

{

if (_log.isDebugEnabled())

_log.debug(getName() + " doAttack: target=" + target);

 

if (isAlikeDead() || target == null || (this instanceof L2Npc && target.isAlikeDead())

|| (this instanceof L2PcInstance && target.isDead() && !target.isFakeDeath()))

{

// If L2PcInstance is dead or the target is dead, the action is stoped

getAI().setIntention(CtrlIntention.AI_INTENTION_ACTIVE);

 

sendPacket(ActionFailed.STATIC_PACKET);

return;

}

 

And before you call l2jfree devs noobs, think about the fact that l2jfree in private is now a multiplatform, multichronicle supported, lindvior pack with things that l2j never seen before. Also they make the code you make(can be anything) faster and code it much better. So either you admit that your wrong and you crawl back to the hole you came from or we are just going to rip your ego apart. :)

[Guest Elfocrash]

if (!isAlikeDead() && target != null)

{

if (this instanceof L2Npc && target.isAlikeDead()

 

 

from what you linked. What are you trying to say?

 

 

Actualy you say remove null from doAttack and go cast prominence skills from sorcer class with out that cast.. :)

Yeah and i said what it does while you doattack at the same time. Nvm i wont stick on that.

[Ovenuç®]

It's there dude.

 

where is the null check?

 

 

do you know what is the code there?

 

if (!isAlikeDead() && target != null) 

 

so the null check is not for phx :)

[`NeverMore]

:happyforever:

[Intrepid]

where is the null check?

 

Im laughing so hard! Man please continue with this your making my day! :DDDDDDDDDDDDDDDDDDDDDDDDDDDD

[Guest Elfocrash]

where is the null check?

Are you blind?

 

// =========================================================

// Method - Private

/**

* Launch a physical attack against a target (Simple, Bow, Pole or Dual).<BR><BR>

*

* <B><U> Actions</U> :</B><BR><BR>

* <li>Get the active weapon (always equiped in the right hand) </li><BR><BR>

* <li>If weapon is a bow, check for arrows, MP and bow re-use delay (if necessary, equip the L2PcInstance with arrows in left hand)</li>

* <li>If weapon is a bow, consume MP and set the new period of bow non re-use </li><BR><BR>

* <li>Get the Attack Speed of the L2Character (delay (in milliseconds) before next attack) </li>

* <li>Select the type of attack to start (Simple, Bow, Pole or Dual) and verify if SoulShot are charged then start calculation</li>

* <li>If the Server->Client packet Attack contains at least 1 hit, send the Server->Client packet Attack to the L2Character AND to all L2PcInstance in the _KnownPlayers of the L2Character</li>

* <li>Notify AI with EVT_READY_TO_ACT</li><BR><BR>

*

* @param target The L2Character targeted

*

*/

protected void doAttack(L2Character target)

{

if (Config.DEBUG)

_log.fine(getName()+" doAttack: target="+target);

 

if (!isAlikeDead() && target != null)

{

if (this instanceof L2Npc && target.isAlikeDead()

|| !getKnownList().knowsObject(target))

{

getAI().setIntention(CtrlIntention.AI_INTENTION_ACTIVE);

sendPacket(ActionFailed.STATIC_PACKET);

return;

}

else if (this instanceof L2PcInstance)

{

if (target.isDead())

{

getAI().setIntention(CtrlIntention.AI_INTENTION_ACTIVE);

sendPacket(ActionFailed.STATIC_PACKET);

return;

}

 

L2PcInstance actor = (L2PcInstance)this;

/*

* Players riding wyvern or with special (flying) transformations can do melee attacks, only with skills

*/

if ((actor.isMounted() && actor.getMountNpcId() == 12621)

|| (actor.isTransformed() && !actor.getTransformation().canDoMeleeAttack()))

{

sendPacket(ActionFailed.STATIC_PACKET);

return;

}

}

}

 

if (isAttackingDisabled())

return;

 

 

God i though you were not so stupid...

[xdem]

where is the null check?

 

 

do you know what is the code there?

 

if (!isAlikeDead() && target != null) 

 

so the null check is not for phx :)

 

[Ovenuç®]

i listen here that null method is calling for l2phx and i wander somthing how is possible to attack to null target?

[Trance]

i listen here that null method is calling for l2phx and i wander somthing how is possible to attack to null target?

 

if it's null, it returns (it breaks it).

[xdem]

i listen here that null method is calling for l2phx and i wander somthing how is possible to attack to null target?

 

thats why the null check is there, to make it impossible to attack null target  :you serious?: :you serious?: :you serious?: :you serious?:

[Ovenuç®]

 

ahhaha you say that method is for phx elfo says that method is calling for skills (min me kaneis na balo sinomilia... nomizes oti to doattack elenxei kai ta skills)

 

and intrepid he says the same thing for l2phx

 

 

 

ok i will remove the null check  != null and i will test it now

[Intrepid]

i listen here that null method is calling for l2phx and i wander somthing how is possible to attack to null target?

 

[Guest Elfocrash]

i listen here that null method is calling for l2phx and i wander somthing how is possible to attack to null target?

Pfff let me explain it in even simpler words. This is not a Double check because the one is in the AttackRequest fine and the other is in the L2Character or whatever file. Yeah it passes through

both files so it might be a double check for L2phx BUT for java coding as a sum it is a MUST check to prevent NPEs which will cuz memory leaks and fuck up your stability. Dont think what

you do as a player and that this might look impossible. L2Char or PcInst are huge classes with 24/7 used methods. If these methods are not null checked then you are fucked.

 

 

I cant make it simpler.

[xdem]

ahhaha you say that method is for phx elfo says that method is calling for skills (min me kaneis na balo sinomilia... nomizes oti to doattack elenxei kai ta skills)

 

and intrepid he says the same thing for l2phx

 

ok i will remove the null check  != null and i will test it now

 

okay, change doAttack to throws

 

protected void doAttack(L2Character target) throws NullPointerException  :troll: :troll:

[Kràtos]

is that you?

 

http://www.l2jserver.com/forum/viewtopic.php?f=4&t=28086&p=167460&hilit=WHAT+IS+NULL#p167460

 

>:D