Changeset 13:

 

L2PcInstance renamed to L2PlayerInstance.

Removed dead code.

Turned some public functions to private.

Added null check to l2jpes command.

Made l2jpes logo in console more pretty.

 

https://xp-dev.com/trac/l2jpes/changeset/13/l2jpes

https://xp-dev.com/trac/l2jpes/changeset/13/l2jpes

Bad idea to commit the change of L2PcInstance with the rest. Anyway, good job.

Bad idea to commit the change of L2PcInstance with the rest. Anyway, good job.

 

Uh, that will just discourage some newbies.

Anyway the extra modifications, in case you want to know, have been done to:

 

gameserver/java/com/l2jpes/gameserver/handler/AdminCommandHandler.java

gameserver/java/com/l2jpes/gameserver/handler/ChatHandler.java

gameserver/java/com/l2jpes/gameserver/handler/ItemHandler.java

gameserver/java/com/l2jpes/gameserver/handler/SkillHandler.java

gameserver/java/com/l2jpes/gameserver/handler/UserCommandHandler.java

gameserver/java/com/l2jpes/gameserver/model/actor/instance/L2PlayerInstance.java

gameserver/java/com/l2jpes/gameserver/GameServer.java

gameserver/java/com/l2jpes/loginserver/L2LoginServer.java

gameserver/java/com/l2jpes/gameserver/handler/voicedcommandhandlers/L2JPesCmd.java

Bad idea to commit the change of L2PcInstance with the rest. Anyway, good job.

 

It's just a renaming.

What are the reasons behind the renaming  of objects except than ? Hey I my project looks different

What are the reasons behind the renaming  of objects except than ? Hey I my project looks different

Propably giving a better explanation of what the object represents from my point of view.

I coded a custom feature for l2jpes the other day, but I don't think I am going to commit something so gameplay-related any time, soon.

 

http://maxcheaters.com/forum/index.php?topic=280084.0

I'm gonna test this project, it is based on Acis right?

Btw, you can use this image for signature if you like it

I'm gonna test this project, it is based on Acis right?

Btw, you can use this image for signature if you like it

 

Yes, it is based on aCis.

 

Also, nice job.

Propably giving a better explanation of what the object represents from my point of view.

And PcInstance which meand Playable Character instance doesent work for you?

And PcInstance which meand Playable Character instance doesent work for you?

 

Its convinient to store "mother classes" in other place than the subclasses so renaming and moving them is just a "for convinience" thing.

And PcInstance which meand Playable Character instance doesent work for you?

Nope, it doesn't.

Changeset 14:

 

Moved handler implementors to a separated package.

 

https://xp-dev.com/trac/l2jpes/changeset/14/l2jpes

you should refactor everything at once so you dont end up having a gazillion refactoring changesets^^