Pauler Posted August 4, 2013 Author Share Posted August 4, 2013 Changeset 13: L2PcInstance renamed to L2PlayerInstance. Removed dead code. Turned some public functions to private. Added null check to l2jpes command. Made l2jpes logo in console more pretty. https://xp-dev.com/trac/l2jpes/changeset/13/l2jpes Link to comment Share on other sites More sharing options...
Devlin Posted August 4, 2013 Share Posted August 4, 2013 https://xp-dev.com/trac/l2jpes/changeset/13/l2jpes Bad idea to commit the change of L2PcInstance with the rest. Anyway, good job. Link to comment Share on other sites More sharing options...
Pauler Posted August 4, 2013 Author Share Posted August 4, 2013 Bad idea to commit the change of L2PcInstance with the rest. Anyway, good job. Uh, that will just discourage some newbies. Link to comment Share on other sites More sharing options...
Pauler Posted August 4, 2013 Author Share Posted August 4, 2013 Anyway the extra modifications, in case you want to know, have been done to: gameserver/java/com/l2jpes/gameserver/handler/AdminCommandHandler.java gameserver/java/com/l2jpes/gameserver/handler/ChatHandler.java gameserver/java/com/l2jpes/gameserver/handler/ItemHandler.java gameserver/java/com/l2jpes/gameserver/handler/SkillHandler.java gameserver/java/com/l2jpes/gameserver/handler/UserCommandHandler.java gameserver/java/com/l2jpes/gameserver/model/actor/instance/L2PlayerInstance.java gameserver/java/com/l2jpes/gameserver/GameServer.java gameserver/java/com/l2jpes/loginserver/L2LoginServer.java gameserver/java/com/l2jpes/gameserver/handler/voicedcommandhandlers/L2JPesCmd.java Link to comment Share on other sites More sharing options...
Trance Posted August 4, 2013 Share Posted August 4, 2013 Bad idea to commit the change of L2PcInstance with the rest. Anyway, good job. It's just a renaming. Link to comment Share on other sites More sharing options...
xdem Posted August 4, 2013 Share Posted August 4, 2013 What are the reasons behind the renaming of objects except than ? Hey I my project looks different Link to comment Share on other sites More sharing options...
Pauler Posted August 4, 2013 Author Share Posted August 4, 2013 What are the reasons behind the renaming of objects except than ? Hey I my project looks different Propably giving a better explanation of what the object represents from my point of view. Link to comment Share on other sites More sharing options...
Pauler Posted August 5, 2013 Author Share Posted August 5, 2013 I coded a custom feature for l2jpes the other day, but I don't think I am going to commit something so gameplay-related any time, soon. http://maxcheaters.com/forum/index.php?topic=280084.0 Link to comment Share on other sites More sharing options...
Strain Posted August 6, 2013 Share Posted August 6, 2013 I'm gonna test this project, it is based on Acis right? Btw, you can use this image for signature if you like it Link to comment Share on other sites More sharing options...
Pauler Posted August 6, 2013 Author Share Posted August 6, 2013 I'm gonna test this project, it is based on Acis right? Btw, you can use this image for signature if you like it Yes, it is based on aCis. Also, nice job. Link to comment Share on other sites More sharing options...
Guest Elfocrash Posted August 6, 2013 Share Posted August 6, 2013 Propably giving a better explanation of what the object represents from my point of view. And PcInstance which meand Playable Character instance doesent work for you? Link to comment Share on other sites More sharing options...
Intrepid Posted August 6, 2013 Share Posted August 6, 2013 And PcInstance which meand Playable Character instance doesent work for you? Its convinient to store "mother classes" in other place than the subclasses so renaming and moving them is just a "for convinience" thing. Link to comment Share on other sites More sharing options...
Pauler Posted August 6, 2013 Author Share Posted August 6, 2013 And PcInstance which meand Playable Character instance doesent work for you? Nope, it doesn't. Link to comment Share on other sites More sharing options...
Pauler Posted August 6, 2013 Author Share Posted August 6, 2013 Changeset 14: Moved handler implementors to a separated package. https://xp-dev.com/trac/l2jpes/changeset/14/l2jpes Link to comment Share on other sites More sharing options...
Intrepid Posted August 6, 2013 Share Posted August 6, 2013 you should refactor everything at once so you dont end up having a gazillion refactoring changesets^^ Link to comment Share on other sites More sharing options...
Recommended Posts