Jump to content
--> Place your ad text here <--
Get Free Banners - Giveaway MaxCheaters.com
We're Rebuilding – Join Our Staff Team

Uber Cancellation.

An4rchy
 Share

Recommended Posts

An4rchy Experienced

An4rchy

Posted
Posted

Hey all. It's been long since i was active here..

So i wanted so share sth i created for a server that i was working on, it's the custom cancel that the buffs return after x time..

 

CustomCancelTask.java

/*
* This program is free software: you can redistribute it and/or modify it under
* the terms of the GNU General Public License as published by the Free Software
* Foundation, either version 3 of the License, or (at your option) any later
* version.
* 
* This program is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
* FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
* details.
* 
* You should have received a copy of the GNU General Public License along with
* this program. If not, see <http://www.gnu.org/licenses/>.
*/
package net.sf.l2j.gameserver.model.entity.custom;

import java.util.Vector;

import net.sf.l2j.gameserver.model.L2Skill;
import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;

/**
* @author Anarchy
*
*/
public class CustomCancelTask implements Runnable
{
private L2PcInstance _player = null;
private Vector<L2Skill> _buffs = null;

public CustomCancelTask(L2PcInstance _player, Vector<L2Skill> _buffs)
{
	this._player = _player;
	this._buffs = _buffs;
}

@Override
public void run()
{
	if (_player == null || !_player.isOnline())
	{
		return;
	}
	for (L2Skill s : _buffs)
	{
		if (s == null)
		{
			continue;
		}

		s.getEffects(_player, _player);
	}
}
}

 

And on gameserver/handlers/skillhandlers/Cancel.java

 

Add:

Vector<L2Skill> cancelledBuffs = new Vector<>();

 

Above these variables:

 

int lastCanceledSkillId = 0;

int count = skill.getMaxNegatedEffects();

 

And add:

					if (!cancelledBuffs.contains(effect.getSkill()))
					{
						cancelledBuffs.add(effect.getSkill());
					}

 

Under this maybe:

 

// Stores the last canceled skill for further use.

lastCanceledSkillId = effect.getSkill().getId();

 

And finally add at the end of the method:

		if (cancelledBuffs.size() > 0)
		{
			ThreadPoolManager.getInstance().scheduleGeneral(new CustomCancelTask((L2PcInstance)target, cancelledBuffs), 5*1000);
		}

 

(Where 5 here is the seconds you want to delay until give the buffs back.)

 

However i would like to mention a few stuff:

- It was lazy coded, to be honest, since it gives the buff with full buff time.

- It can be used as bug, due to the above.

- It is coded on aCis.

- Sorry for not patch file but i committed that and the svn was deleted.

 

:) :)

 

Update:

 

These 2 patches should fix the code to work as it should. It was Justice's request.

 

-import java.util.Vector;
+import javolution.util.FastMap;

import net.sf.l2j.Config;
import net.sf.l2j.gameserver.ThreadPoolManager;
@@ -52,7 +52,7 @@
         // Get skill power (which is used as baseRate).
         final double skillPower = skill.getPower();
         
-        Vector<L2Skill> cancelledBuffs = new Vector<>();
+        FastMap<L2Skill, int[]> cancelledBuffs = new FastMap<>();
         
         for (L2Object obj : targets)
         {
@@ -108,9 +108,9 @@
                     // Stores the last canceled skill for further use.
                     lastCanceledSkillId = effect.getSkill().getId();
                     
-                    if (!cancelledBuffs.contains(effect.getSkill()))
+                    if (!cancelledBuffs.containsKey(effect.getSkill()))
                     {
-                        cancelledBuffs.add(effect.getSkill());
+                        cancelledBuffs.put(effect.getSkill(), new int[] { effect.getCount(), effect.getTime() });
                     }
                     
                     // Exit the effect.

 

package net.sf.l2j.gameserver.model.entity.custom;

-import java.util.Vector;
+import javolution.util.FastMap;

+import net.sf.l2j.gameserver.model.L2Effect;
import net.sf.l2j.gameserver.model.L2Skill;
import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
+import net.sf.l2j.gameserver.skills.Env;
+import net.sf.l2j.gameserver.skills.effects.EffectTemplate;

/**
  * @author Anarchy
@@ -26,9 +29,9 @@
public class CustomCancelTask implements Runnable
{
     private L2PcInstance _player = null;
-    private Vector<L2Skill> _buffs = null;
+    private FastMap<L2Skill, int[]> _buffs = null;
         
-    public CustomCancelTask(L2PcInstance _player, Vector<L2Skill> _buffs)
+    public CustomCancelTask(L2PcInstance _player, FastMap<L2Skill, int[]> _buffs)
     {
         this._player = _player;
         this._buffs = _buffs;
@@ -42,7 +45,7 @@
             return;
         }
             
-        for (L2Skill s : _buffs)
+        for (L2Skill s : _buffs.keySet())
         {
             if (s == null)
             {
@@ -49,7 +52,21 @@
                 continue;
             }
                 
-            s.getEffects(_player, _player);
+             Env env = new Env();
+             env.player = _player;
+             env.target = _player;
+             env.skill = s;
+             L2Effect ef;
+             for (EffectTemplate et : s.getEffectTemplates())
+             {
+                ef = et.getEffect(env);
+                 if (ef != null)
+                 {
+                     ef.setCount(_buffs.get(s)[0]);
+                     ef.setFirstTime(_buffs.get(s)[1]);
+                     ef.scheduleEffect();
+                 }
+             }
         }
     }
}
\ No newline at end of file

 

Btw, i have to say a big sorry for the blindness my old cancel code for l2elcardia caused to Elfocrash and Pauler  :alone:

Fanky Newbie

Fanky

Posted
Posted

this wasnt shared by rizzla?

Hey all. It's been long since i was active here..

So i wanted so share sth i created for a server that i was working on, it's the custom cancel that the buffs return after x time..

 

CustomCancelTask.java

/*
* This program is free software: you can redistribute it and/or modify it under
* the terms of the GNU General Public License as published by the Free Software
* Foundation, either version 3 of the License, or (at your option) any later
* version.
* 
* This program is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
* FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
* details.
* 
* You should have received a copy of the GNU General Public License along with
* this program. If not, see <http://www.gnu.org/licenses/>.
*/
package net.sf.l2j.gameserver.model.entity.custom;

import java.util.Vector;

import net.sf.l2j.gameserver.model.L2Skill;
import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;

/**
* @author Anarchy
*
*/
public class CustomCancelTask implements Runnable
{
private L2PcInstance _player = null;
private Vector<L2Skill> _buffs = null;

public CustomCancelTask(L2PcInstance _player, Vector<L2Skill> _buffs)
{
	this._player = _player;
	this._buffs = _buffs;
}

@Override
public void run()
{
	if (_player == null || !_player.isOnline())
	{
		return;
	}
	for (L2Skill s : _buffs)
	{
		if (s == null)
		{
			continue;
		}

		s.getEffects(_player, _player);
	}
}
}

 

And on gameserver/handlers/skillhandlers/Cancel.java

 

Add:

Vector<L2Skill> cancelledBuffs = new Vector<>();

 

Above these variables:

 

int lastCanceledSkillId = 0;

int count = skill.getMaxNegatedEffects();

 

And add:

					if (!cancelledBuffs.contains(effect.getSkill()))
					{
						cancelledBuffs.add(effect.getSkill());
					}

 

Under this maybe:

 

// Stores the last canceled skill for further use.

lastCanceledSkillId = effect.getSkill().getId();

 

And finally add at the end of the method:

		if (cancelledBuffs.size() > 0)
		{
			ThreadPoolManager.getInstance().scheduleGeneral(new CustomCancelTask((L2PcInstance)target, cancelledBuffs), 5*1000);
		}

 

(Where 5 here is the seconds you want to delay until give the buffs back.)

 

However i would like to mention a few stuff:

- It was lazy coded, to be honest, since it gives the buff with full buff time.

- It can be used as bug, due to the above.

- It is coded on aCis.

- Sorry for not patch file but i committed that and the svn was deleted.

 

:) :)

octapus,glad that you're back =]

sup?

 

nice idea anyway,thanks for sharing.

An4rchy Experienced

An4rchy

Posted
  • Author
Posted

octapus,glad that you're back =]

sup?

 

nice idea anyway,thanks for sharing.

Hehe ;) As always, can't really quit l2j or this forum generally ;p Even if lol took over my pc for several months :D

 

Thanks mate :)

 

this wasnt shared by rizzla?

Well sorry if that's the case, but i was inactive for several months, as i mentioned above.. It should be locked if it exists then..

Stewie Newbie

Stewie

Posted
Posted

The code is diff from the one that is already shared... as i see

Someone test and reply, i'm waiting...

Romeo one was with bugs, i hope this one is bugless and will restore all buffs + self buffs..

Stewie Newbie

Stewie

Posted
Posted

This cancellation as I recall is exploitable in dueling system and olympiad games, you might want to check it out.

 

with some edits it can be perfect... i accept that any developer can do the restrictions since they are easy

KderD64 Newbie

KderD64

Posted
Posted

with some edits it can be perfect... i accept that any developer can do the restrictions since they are easy

Indeed, that's why I was telling not to take only the raw code and apply it, it needs some adapting also.

xdem Proficient

xdem

Posted
Posted

Indeed, that's why I was telling not to take only the raw code and apply it, it needs some adapting also.

 

raw code?

raw code means FCA4 8CB8 48A8 4ACE 8488 9D48 94C9 464C

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing


  • Posts

    • ratchet
      Help and Interlude+

      By ratchet · Posted

      interlude: l2acis uber alles
    • DNClassic
      Dragon-Network: The Survey

      By DNClassic · Posted

      New Dragon-Network Server – Vote Now!   We’re launching a new Dragon-Network (Multiskill) server under a new domain, created by the original Classic-Interlude team. We no longer have access to the old domain, but this is the official continuation — not a scam, just a new home. The new domain will host: A main migrated server (nothing lost – all chars/items kept) Plus seasonal servers (voted by players) All seasonal progress will be merged into the main realm Help shape the new server – vote now: https://dragon-network.eu/   Let’s build the future of DN – together.
    • tomlondon12
      ✅ Mass DM Panel | Instagram, Twitter, Telegram and Discord!

      By tomlondon12 · Posted

      We are taking new orders. DM us on Telegram!
    • Lezzz
      Help and Interlude+

      By Lezzz · Posted

      Hello there, Im beyond confused and dont know what path to take. I want to start working on a L2 server, changing some stuff here and there and finally in the future if  im happy with the results, to launch the server, but... L2j or L2off? After all this years, is there a Interlude L2j close to off?   Ive spent some time lookin over this forum, searching what would be better and what files to take but I ain't near to a clear answer.  Most of the time everyone is trowing stones at everyone, "your filles are trash, my filles are good" and viceversa. Therefore, Im reaching out to a knowledge guy, hopefully from a neutral position to all this drama, that can pin point me in a direction.    To explain what I want for a base start is an Interlude with a classic interface (features), low rate. Mostly what this guy TravorJ is describing in his post TravorJ post , and to do some reworks on it, ex: mobs drop, rethink the augment system/interface, rethink learning skills/enchant skills, create some custom potions/buff effects, siege mechanics... Is that possible on off files? or is better to go with L2j? I also want to mention that I have little to none L2 dev experince (13-15yrs ago I had an L2j server running  for a month where I made some basics changes), but I have coding background so Im used to that and more than willing to learn.   So in conclusion, I dont want to get some free shared files without any support, that I need to wrap my head around and fix stuff for long time to make them work, stuff thats already fixed buy someone else. Instead im looking to buy something thats more updated and start working from there. Question is what and from whom? Kinda sux when you go and buy something and u dont know what the hell are you buying (need some guidance here)   Is L2j Orion a good choice? I saw that is regularly updated. Lucera2 I dont think is something that I want cuz they dont sell soruce, prefer to have control and not to be dependent on someone to much...   Big thanks in advance!   
    • protoftw
      Graphic/Html Designs - Protojah

      By protoftw · Posted

      L2 INSIDE - HTML DESIGN     Portfolio - protojahdesigns.com You can also join Protojah Designs Discord

  • Topics

×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock