error java

[loukas1978]

hi im new here and i would like some help i have puted the code to @Elfocrash on pack 272 to l2jacis 
when a player is going to send message to a bot it shows this error
and the message doesnt 
go ... can you help me to fix that 

 

code

+++ b/aCis_gameserver/java/net/sf/l2j/gameserver/handler/chathandlers/ChatTell.java
@@ -1,5 +1,7 @@
package net.sf.l2j.gameserver.handler.chathandlers;
 
+import com.elfocrash.roboto.FakePlayer;
+
 import net.sf.l2j.gameserver.handler.IChatHandler;
 import net.sf.l2j.gameserver.model.BlockList;
 import net.sf.l2j.gameserver.model.World;
@@ -21,7 +23,7 @@ public void handleChat(int type, Player activeChar, String target, String text)
 			return;
 		
 		final Player receiver = World.getInstance().getPlayer(target);
-		if (receiver == null || receiver.getClient().isDetached())
+		if (receiver == null || receiver.getClient().isDetached() && !(receiver instanceof FakePlayer))
 		{
 			activeChar.sendPacket(SystemMessageId.TARGET_IS_NOT_FOUND_IN_THE_GAME);
 			return;

erorr
Jan 20, 2020 10:19:03 AM net.sf.l2j.gameserver.network.clientpackets.L2GameClientPacket run
SEVERE: Client: [Character: leon - Account: admin - IP: 85.75.10.25] - Failed reading: [C] Say2 ; java.lang.NullPointerException
java.lang.NullPointerException
	at net.sf.l2j.gameserver.handler.chathandlers.ChatTell.handleChat(ChatTell.java:26)
	at net.sf.l2j.gameserver.network.clientpackets.Say2.runImpl(Say2.java:181)
	at net.sf.l2j.gameserver.network.clientpackets.L2GameClientPacket.run(L2GameClientPacket.java:50)
	at net.sf.l2j.gameserver.network.L2GameClient.run(L2GameClient.java:755)
	at net.sf.l2j.commons.concurrent.ThreadPool$TaskWrapper.run(ThreadPool.java:248)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

 

[Rootware]

1 hour ago, xFranky said:

I am not too sure if this is going to fix ur issue but try this:

if (receiver == null || receiver != null && receiver.getClient().isDetached() && !(receiver instanceof FakePlayer))

 

Pointless to add check for not null, because condition throw up TRUE after first null check if object null.

 

This will always throw up NullException for Fake Players.

 

receiver.getClient().isDetached()

The reason - client is null.

 

if (receiver == null || (receiver.getClient() != null && receiver.getClient().isDetached() && !(receiver instanceof FakePlayer)))

Something like this.

[Reynald0]

57 minutes ago, loukas1978 said:

hi im new here and i would like some help i have puted the code to @Elfocrash on pack 272 to l2jacis 
when a player is going to send message to a bot it shows this error
and the message doesnt 
go ... can you help me to fix that 

 

 

 

Are you using aCis 272? Why not update to 370? It is free also https://gitlab.com/Tryskell/acis_public

[loukas1978]

hi  

sorry my bad i use 372..

i have added to many codes at 372 and i cannot change it now 

can you help me to fix that error ?

 

[xFranky]

I am not too sure if this is going to fix ur issue but try this:

if (receiver == null || receiver != null && receiver.getClient().isDetached() && !(receiver instanceof FakePlayer))

[loukas1978]

if (receiver == null || (receiver.getClient() != null && receiver.getClient().isDetached() && !(receiver instanceof FakePlayer)))

i put the code below and it worked great thanks for your help!!!

[DenArt Designs]

7 hours ago, xFranky said:

I am not too sure if this is going to fix ur issue but try this:

if (receiver == null || receiver != null && receiver.getClient().isDetached() && !(receiver instanceof FakePlayer))

this is wrong in so many ways :D

equivalent to if (true or false && ...) mean is always true to 

return;

Edited January 25, 2020 by DenArt Designs

[xFranky]

9 hours ago, Rootware said:

 

Pointless to add check for not null, because condition throw up TRUE after first null check if object null.

 

This will always throw up NullException for Fake Players.

 

receiver.getClient().isDetached()

The reason - client is null.

 

if (receiver == null || (receiver.getClient() != null && receiver.getClient().isDetached() && !(receiver instanceof FakePlayer)))

Something like this.

I had way more than I could handle alcohol in my body last night. Now that I look at it, it was pointless. The worst I have come up with yet while I'm drunk in coding!

 

Locked

Edited January 25, 2020 by xFranky