Jump to content

Question

Posted (edited)

Hi guys. I am sharing an older code for Interlude with what i have a small issue. This is the Craft Manager what i recently managed to make it work. The code works fine, except for a little detail. This code loads up the items that are eligible for crystallization from D grade up to A grade. Problem is it loads up the items that are equipped aswell. How can i bypass it so it will ignore those items on the character so the user wont accidentally crystallize the equipped gear. My knowledge for this is mediocre at best, and i tried multiple aproches and have come up with nothing. Any help is appreciated. Thanks!

 

Here is the updated code for the Craft Manager for anyone who wants to use it. The only known issue so far, is the one on my 2nd post with the item selection crash after a certain amount.

 


package com.l2jmobius.gameserver.model.actor.instance;

import java.util.ArrayList;
import java.util.StringTokenizer;

import com.l2jmobius.Config;
import com.l2jmobius.commons.util.Rnd;
import com.l2jmobius.gameserver.datatables.csv.RecipeTable;
import com.l2jmobius.gameserver.datatables.sql.IconTable;
import com.l2jmobius.gameserver.datatables.xml.ItemTable;
import com.l2jmobius.gameserver.model.Inventory;
import com.l2jmobius.gameserver.model.L2RecipeList;
import com.l2jmobius.gameserver.model.multisell.L2Multisell;
import com.l2jmobius.gameserver.network.SystemMessageId;
import com.l2jmobius.gameserver.network.serverpackets.InventoryUpdate;
import com.l2jmobius.gameserver.network.serverpackets.NpcHtmlMessage;
import com.l2jmobius.gameserver.network.serverpackets.SystemMessage;
import com.l2jmobius.gameserver.templates.chars.L2NpcTemplate;
import com.l2jmobius.gameserver.templates.item.L2EtcItemType;
import com.l2jmobius.gameserver.templates.item.L2Item;

public class L2CraftManagerInstance extends L2MerchantInstance
{
	public static final int ADENA_ID = 57;
	public static final int ITEMS_PER_PAGE = 6; // items list size in craft and crystallize pages
	
	public L2CraftManagerInstance(int objectId, L2NpcTemplate template)
	{
		super(objectId, template);
	}
	
	@Override
	public void onBypassFeedback(L2PcInstance player, String command)
	{
		if (command.startsWith("multisell"))
		{
			L2Multisell.getInstance().generateMultiSell(Integer.parseInt(command.substring(9).trim()), player, false, this);
		}
		else if (command.startsWith("Crystallize")) // List player inventory items for crystallization
		{
			int _pageId;
			
			ArrayList<Integer> _itemsSelected = new ArrayList<>();
			
			Inventory _inventory = player.getInventory();
			
			StringTokenizer st = new StringTokenizer(command.substring(11).trim());
			
			try
			{
				if (st.countTokens() > 1)
				{
					_pageId = Integer.parseInt(st.nextToken());
					
					while (st.hasMoreTokens())
					{
						int _itemObjId = Integer.parseInt(st.nextToken());
						
						if ((_inventory.getItemByObjectId(_itemObjId) != null) && (!_itemsSelected.contains(_itemObjId)))
						{
							_itemsSelected.add(_itemObjId);
						}
					}
				}
				else
				{
					_pageId = Integer.parseInt(command.substring(11).trim());
				}
			}
			catch (NumberFormatException e)
			{
				_pageId = 0;
			}
			ArrayList<Integer> _items = new ArrayList<>();
			
			int _priceTotal = 0;
			
			ArrayList<Integer> _crystals = new ArrayList<>();
			
			_crystals.add(0, 0);
			_crystals.add(1, 0);
			_crystals.add(2, 0);
			_crystals.add(3, 0);
			_crystals.add(4, 0);
			_crystals.add(5, 0);
			
			for (L2ItemInstance _item : _inventory.getItems())
			{
				if (!_item.isStackable() && (_item.getLocation() != L2ItemInstance.ItemLocation.PAPERDOLL) && (_item.getItem().getCrystalType() != L2Item.CRYSTAL_NONE) && (_item.getItem().getCrystalCount() > 0))
				{
					_items.add(_item.getObjectId());
					
					if (_itemsSelected.contains(_item.getObjectId()))
					{
						int _count = _crystals.get(_item.getItem().getCrystalType()) + _item.getCrystalCount();
						_crystals.set(_item.getItem().getCrystalType(), _count);
						
						int _crystalId = 1457 + _item.getItem().getCrystalType();
						
						int _price = (int) ((Config.ALT_CRAFT_PRICE * _count * ItemTable.getInstance().getTemplate(_crystalId).getReferencePrice()) / 55);
						if (_price == 0)
						{
							_price = Config.ALT_CRAFT_DEFAULT_PRICE;
						}
						
						_priceTotal += _price;
					}
				}
			}
			if (_items.size() == 0)
			{
				sendOutOfItems(player, "at least one", "breakable item");
				return;
			}
			
			int _itemsOnPage = ITEMS_PER_PAGE;
			int _pages = _items.size() / _itemsOnPage;
			
			if (_items.size() > (_pages * _itemsOnPage))
			{
				_pages++;
			}
			if (_pageId > _pages)
			{
				_pageId = _pages;
			}
			
			int _itemStart = _pageId * _itemsOnPage;
			int _itemEnd = _items.size();
			
			if ((_itemEnd - _itemStart) > _itemsOnPage)
			{
				_itemEnd = _itemStart + _itemsOnPage;
			}
			
			String _elementsSelected = "";
			
			for (int i = 0; i < _itemsSelected.size(); i++)
			{
				_elementsSelected += " " + _itemsSelected.get(i);
			}
			NpcHtmlMessage npcReply = new NpcHtmlMessage(1);
			
			StringBuilder replyMSG = new StringBuilder("<html><body>");
			replyMSG.append("<center>Items to Crystallize</center>");
			replyMSG.append("<img src=\"L2UI.SquareWhite\" width=300 height=1> <img src=\"L2UI.SquareBlank\" width=1 height=3>");
			replyMSG.append("<table width=270><tr>");
			replyMSG.append("<td width=66><button value=\"Back\" action=\"bypass -h npc_" + getObjectId() + ((_pageId == 0) ? "_Chat 0" : "_Crystallize ") + (_pageId - 1) + _elementsSelected + "\" width=65 height=19 back=\"L2UI_ch3.smallbutton2_over\" fore=\"L2UI_ch3.smallbutton2\"></td>");
			replyMSG.append("<td width=138></td>");
			replyMSG.append("<td width=66>" + (((_pageId + 1) < _pages) ? "<button value=\"Next\" action=\"bypass -h npc_" + getObjectId() + "_Crystallize " + (_pageId + 1) + _elementsSelected + "\" width=65 height=19 back=\"L2UI_ch3.smallbutton2_over\" fore=\"L2UI_ch3.smallbutton2\">" : "") + "</td>");
			replyMSG.append("</tr></table>");
			replyMSG.append("<br>");
			replyMSG.append("<table width=270><tr>");
			if (Config.ALT_CRAFT_ALLOW_CRYSTALLIZE)
			{
				replyMSG.append("<td width=35><button value=\"\" action=\"bypass -h npc_" + getObjectId() + "_BreakItem" + _elementsSelected + "\" width=32 height=32 back=\"icon.skill0248\" fore=\"icon.skill0248\"></td>");
				replyMSG.append("<td width=135>");
				replyMSG.append("<table border=0 width=100%>");
				replyMSG.append("<tr><td><font color=\"B09878\">Crystallize</font></td></tr>");
				replyMSG.append("<tr><td><font color=\"B09878\">selected items " + (_itemsSelected.size() == 0 ? "" : "(" + _itemsSelected.size() + ")") + "</font></td></tr></table></td>");
				replyMSG.append("<td width=100>");
				replyMSG.append("<table border=0 width=100%>");
				replyMSG.append("<tr><td><font color=\"A2A0A2\">Total price:</font></td></tr>");
				replyMSG.append("<tr><td><font color=\"B09878\">" + _priceTotal + " Adena</font></td></tr></table></td>");
			}
			replyMSG.append("</tr></table><br>");
			
			for (int i = _itemStart; i < _itemEnd; i++)
			{
				L2ItemInstance _item = _inventory.getItemByObjectId(_items.get(i));
				
				if (_item == null)
				{
					continue;
				}
				
				int _crystalId = 1457 + _item.getItem().getCrystalType();
				
				String _crystal = _item.getItem().getCrystalType() == 1 ? "D" : _item.getItem().getCrystalType() == 2 ? "C" : _item.getItem().getCrystalType() == 3 ? "B" : _item.getItem().getCrystalType() == 4 ? "A" : _item.getItem().getCrystalType() == 5 ? "S" : "S";
				
				int _count = _item.getCrystalCount();
				
				int _price = (int) ((Config.ALT_CRAFT_PRICE * _count * ItemTable.getInstance().getTemplate(_crystalId).getReferencePrice()) / 55);
				
				if (_price == 0)
				{
					_price = Config.ALT_CRAFT_DEFAULT_PRICE;
				}
				replyMSG.append("<img src=\"L2UI.SquareWhite\" width=300 height=1> <img src=\"L2UI.SquareBlank\" width=1 height=1>");
				replyMSG.append("<table width=300 bgcolor=000000><tr>");
				replyMSG.append("<td width=44 height=41 align=center><table bgcolor=FFFFFF cellpadding=6 cellspacing=\"-5\"><tr><td><button width=32 height=32 back=" + IconTable.getIcon(_item.getItemId()) + " fore=" + IconTable.getIcon(_item.getItemId()) + "></td></tr></table></td>");
				replyMSG.append("<td width=240 height=20>");
				replyMSG.append("<table border=0 width=100%>");
				replyMSG.append("<tr><td><font color=\"A2A0A2\">" + ItemTable.getInstance().getTemplate(_item.getItemId()).getName() + (_item.getEnchantLevel() == 0 ? "" : " +" + _item.getEnchantLevel()) + "</font></td></tr>");
				replyMSG.append("<tr><td><font color=\"A2A0A2\">" + _crystal + " Crystals:</font> <font color=\"B09878\">" + _count + "</font></td></tr></table></td>");
				
				if (Config.ALT_CRAFT_ALLOW_CRYSTALLIZE)
				{
					if (_itemsSelected.contains(_items.get(i)))
					{
						replyMSG.append("<td valign=center width=20><button value=\"\" action=\"bypass -h npc_" + getObjectId() + "_Crystallize " + _pageId + _elementsSelected.replace(" " + _items.get(i).toString(), "") + "\" width=16 height=16 back=\"L2UI.CheckBox_checked\" fore=\"L2UI.CheckBox_checked\"></td>");
					}
					else
					{
						replyMSG.append("<td valign=center width=20><button value=\"\" action=\"bypass -h npc_" + getObjectId() + "_Crystallize " + _pageId + " " + _items.get(i).toString() + _elementsSelected + "\" width=16 height=16 back=\"L2UI.CheckBox\" fore=\"L2UI.CheckBox\"></td>");
					}
				}
				else
				{
					replyMSG.append("<td valign=center width=20></td>");
				}
				
				replyMSG.append("</tr></table>");
			}
			
			replyMSG.append("</body></html>");
			
			npcReply.setHtml(replyMSG.toString());
			player.sendPacket(npcReply);
		}
		else if (command.startsWith("BreakItem") && Config.ALT_CRAFT_ALLOW_CRYSTALLIZE)
		// Crystallize selected items
		{
			ArrayList<Integer> _itemsSelected = new ArrayList<>();
			Inventory _inventory = player.getInventory();
			
			StringTokenizer st = new StringTokenizer(command.substring(9).trim());
			
			try
			{
				while (st.hasMoreTokens())
				{
					int _itemObjId = Integer.parseInt(st.nextToken());
					
					if ((_inventory.getItemByObjectId(_itemObjId) != null) && (!_itemsSelected.contains(_itemObjId)))
					{
						_itemsSelected.add(_itemObjId);
					}
				}
			}
			catch (NumberFormatException e)
			{
			}
			
			if (_itemsSelected.size() == 0)
			{
				sendOutOfItems(player, "at least one", "breakable items");
				return;
			}
			
			int _priceTotal = 0;
			
			ArrayList<Integer> _crystals = new ArrayList<>();
			
			_crystals.add(0, 0);
			_crystals.add(1, 0);
			_crystals.add(2, 0);
			_crystals.add(3, 0);
			_crystals.add(4, 0);
			_crystals.add(5, 0);
			
			for (int i = 0; i < _itemsSelected.size(); i++)
			{
				
				L2ItemInstance _item = _inventory.getItemByObjectId(_itemsSelected.get(i));
				
				if ((_item != null) && (_item.getOwnerId() == player.getObjectId()) && !_item.isStackable() && (_item.getItem().getCrystalType() != L2Item.CRYSTAL_NONE) && (_item.getItem().getCrystalCount() > 0) && (i < _itemsSelected.size()))
				{
					int _count = _crystals.get(_item.getItem().getCrystalType()) + _item.getCrystalCount();
					
					_crystals.set(_item.getItem().getCrystalType(), _count);
					
					int _crystalId = 1457 + _item.getItem().getCrystalType();
					
					int _price = (int) ((Config.ALT_CRAFT_PRICE * _count * ItemTable.getInstance().getTemplate(_crystalId).getReferencePrice()) / 55);
					if (_price == 0)
					{
						_price = Config.ALT_CRAFT_DEFAULT_PRICE;
					}
					
					_priceTotal += _price;
				}
				else
				{
					_itemsSelected.remove(i);
				}
			}
			if (_inventory.getInventoryItemCount(ADENA_ID, 0) < _priceTotal)
			{
				sendOutOfItems(player, Integer.toString(_priceTotal), "Adena");
				return;
			}
			
			InventoryUpdate iu = new InventoryUpdate();
			
			player.destroyItemByItemId("CraftManager", ADENA_ID, _priceTotal, player, true);
			iu.addModifiedItem(player.getInventory().getItemByItemId(ADENA_ID));
			for (int i = 0; i < _itemsSelected.size(); i++)
			{
				L2ItemInstance _item = _inventory.getItemByObjectId(_itemsSelected.get(i));
				
				if ((_item != null) && (_item.getOwnerId() == player.getObjectId()) && !_item.isStackable() && (_item.getItem().getCrystalType() != L2Item.CRYSTAL_NONE) && (_item.getItem().getCrystalCount() > 0))
				{
					
					if (_item.isEquipped())
					{
						L2ItemInstance[] unequiped = player.getInventory().unEquipItemInSlotAndRecord(_item.getEquipSlot());
						
						if (_item.isEquipped())
						{
							for (L2ItemInstance element : unequiped)
							{
								iu.addModifiedItem(element);
							}
						}
					}
					
					player.destroyItem("CraftManager", _itemsSelected.get(i), 1, player, true);
					iu.addModifiedItem(player.getInventory().getItemByObjectId(_itemsSelected.get(i)));
				}
			}
			
			for (int i = 0; i < _crystals.size(); i++)
			{
				if (_crystals.get(i) > 0)
				{
					int _crystalId = 1457 + i;
					
					SystemMessage sm = null;
					sm = new SystemMessage(SystemMessageId.EARNED_S2_S1_S);
					sm.addItemName(_crystalId);
					sm.addNumber(_crystals.get(i));
					player.sendPacket(sm);
					
					_inventory.addItem("CraftManager", _crystalId, _crystals.get(i), player, player.getTarget());
					
					iu.addModifiedItem(player.getInventory().getItemByItemId(_crystalId));
				}
			}
			player.sendPacket(iu);
			player.broadcastUserInfo();
		}
		else if (command.startsWith("Manufacture"))
		// List recipes from player inventory
		
		{
			int _pageId;
			
			try
			{
				_pageId = Integer.parseInt(command.substring(11).trim());
			}
			catch (NumberFormatException e)
			{
				_pageId = 0;
			}
			
			Inventory _inventory = player.getInventory();
			
			ArrayList<Integer> _recipes = new ArrayList<>();
			for (L2ItemInstance _item : _inventory.getItems())
			{
				if (_item.getItemType() == L2EtcItemType.RECEIPE)
				{
					L2RecipeList _recipe = RecipeTable.getInstance().getRecipeByItemId(_item.getItemId());
					
					if (_recipe != null)
					{
						_recipes.add(_item.getObjectId());
					}
				}
			}
			
			if (_recipes.size() == 0)
			{
				sendOutOfItems(player, "at least one", "recipe");
				return;
			}
			
			int _itemsOnPage = ITEMS_PER_PAGE;
			int _pages = _recipes.size() / _itemsOnPage;
			
			if (_recipes.size() > (_pages * _itemsOnPage))
			{
				_pages++;
			}
			if (_pageId > _pages)
			{
				_pageId = _pages;
			}
			
			int _itemStart = _pageId * _itemsOnPage;
			int _itemEnd = _recipes.size();
			if ((_itemEnd - _itemStart) > _itemsOnPage)
			{
				_itemEnd = _itemStart + _itemsOnPage;
			}
			
			NpcHtmlMessage npcReply = new NpcHtmlMessage(1);
			
			StringBuilder replyMSG = new StringBuilder("<html><body>");
			
			replyMSG.append("<center>List of Recipes</center>");
			replyMSG.append("<img src=\"L2UI.SquareWhite\" width=300 height=1> <img src=\"L2UI.SquareBlank\" width=1 height=3>");
			replyMSG.append("<br1>");
			replyMSG.append("<center><font color=\"FFFF00\">To craft multiple items first press </center></font>");
			replyMSG.append("<br1>");
			replyMSG.append("<center><font color=\"FFFF00\">CALCULATE to see if you have the required amount!</center></font>");
			replyMSG.append("<table width=270><tr>");
			replyMSG.append("<td width=66><button value=\"Back\" action=\"bypass -h npc_" + getObjectId() + ((_pageId == 0) ? "_Chat 0" : "_Manufacture ") + (_pageId - 1) + "\" width=65 height=19 back=\"L2UI_ch3.smallbutton2_over\" fore=\"L2UI_ch3.smallbutton2\"></td>");
			replyMSG.append("<td width=138></td>");
			replyMSG.append("<td width=66>" + (((_pageId + 1) < _pages) ? "<button value=\"Next\" action=\"bypass -h npc_" + getObjectId() + "_Manufacture " + (_pageId + 1) + "\" width=65 height=19 back=\"L2UI_ch3.smallbutton2_over\" fore=\"L2UI_ch3.smallbutton2\">" : "") + "</td>");
			replyMSG.append("</tr></table>");
			replyMSG.append("<br>");
			replyMSG.append("<img src=\"L2UI.SquareWhite\" width=300 height=1> <img src=\"L2UI.SquareBlank\" width=1 height=1>");
			for (int i = _itemStart; i < _itemEnd; i++)
			{
				L2ItemInstance _recipe = _inventory.getItemByObjectId(_recipes.get(i));
				if (_recipe == null)
				{
					continue;
				}
				
				L2RecipeList _recipeList = RecipeTable.getInstance().getRecipeByItemId(_recipe.getItemId());
				if (_recipeList == null)
				{
					continue;
				}
				
				boolean _isConsumable = ItemTable.getInstance().getTemplate(_recipeList.getItemId()).isConsumable();
				int _price = (int) ((((Config.RATE_CRAFT_COST * _recipeList.getSuccessRate()) / 100) * ItemTable.getInstance().getTemplate(_recipeList.getItemId()).getReferencePrice()) / 55);
				if (_price == 0)
				{
					_price = Config.ALT_CRAFT_DEFAULT_PRICE;
				}
				
				L2Item item = ItemTable.getInstance().getTemplate(_recipe.getItemId());
				String name = item.getName();
				
				if (name.startsWith("Recipe: "))
				{
					name = "R: " + name.substring(8);
				}
				String _recipeIcon = IconTable.getIcon(item.getItemId());
				replyMSG.append("<table width=300 bgcolor=000000><tr>");
				replyMSG.append("<td valign=top width=35><button value=\"\" action=\"bypass -h npc_" + getObjectId() + "_CraftInfo " + _recipes.get(i) + " 1 " + _pageId + "\" width=32 height=32 back=\"" + _recipeIcon + "\" fore=\"" + _recipeIcon + "\"></td>");
				replyMSG.append("<td valign=top width=235>");
				replyMSG.append("<td valign=center width=320 height=20>");
				replyMSG.append("<table border=0 width=100%>");
				replyMSG.append("<tr><td><font color=\"FFFF00\">" + name + "</font></td></tr>");
				replyMSG.append("<tr><td><font color=\"A2A0A2\">Product:</font> <font color=\"B09878\">" + (_isConsumable ? _recipeList.getCount() + " " : "") + ItemTable.getInstance().getTemplate(_recipeList.getItemId()).getName() + "</font></td></tr></table></td>");
				replyMSG.append("</tr></table>");
				replyMSG.append("<img src=\"L2UI.SquareWhite\" width=300 height=1> <img src=\"L2UI.SquareBlank\" width=1 height=1>");
				replyMSG.append("<br1>");
			}
			
			replyMSG.append("</body></html>");
			
			npcReply.setHtml(replyMSG.toString());
			
			player.sendPacket(npcReply);
		}
		else if (command.startsWith("CraftInfo"))
		// Show information about choosen recipe
		{
			int _recipeObjId = 0;
			int _pageId = 0;
			int _quantity = 1;
			
			StringTokenizer st = new StringTokenizer(command.substring(9).trim());
			
			try
			{
				if (st.countTokens() > 2)
				{
					_recipeObjId = Integer.parseInt(st.nextToken());
					_quantity = Integer.parseInt(st.nextToken());
				}
				else
				{
					_recipeObjId = Integer.parseInt(st.nextToken());
				}
				
				_pageId = Integer.parseInt(st.nextToken());
			}
			catch (NumberFormatException e)
			{
			}
			
			Inventory _inventory = player.getInventory();
			
			L2ItemInstance _recipe = _inventory.getItemByObjectId(_recipeObjId);
			L2RecipeList _recipeList = RecipeTable.getInstance().getRecipeByItemId(_recipe.getItemId());
			
			boolean _isConsumable = ItemTable.getInstance().getTemplate(_recipeList.getItemId()).isConsumable();
			
			if ((_recipe.getOwnerId() == player.getObjectId()) && (_recipe.getItemType() == L2EtcItemType.RECEIPE))
			{
				int _price = (int) ((((Config.RATE_CRAFT_COST * _recipeList.getSuccessRate()) / 100) * _quantity * (_isConsumable ? _recipeList.getCount() : 1) * ItemTable.getInstance().getTemplate(_recipeList.getItemId()).getReferencePrice()) / 55);
				if (_price == 0)
				{
					_price = Config.ALT_CRAFT_DEFAULT_PRICE;
				}
				
				L2Item item = ItemTable.getInstance().getTemplate(_recipe.getItemId());
				String name = item.getName();
				
				if (name.startsWith("Recipe: "))
				{
					name = "R: " + name.substring(8);
				}
				
				NpcHtmlMessage npcReply = new NpcHtmlMessage(1);
				
				StringBuilder replyMSG = new StringBuilder("<html><body>");
				
				replyMSG.append("<center>Craft Info</center>");
				replyMSG.append("<img src=\"L2UI.SquareWhite\" width=300 height=1> <img src=\"L2UI.SquareBlank\" width=1 height=3>");
				replyMSG.append("<table width=270><tr>");
				replyMSG.append("<td width=66><button value=\"Back\" action=\"bypass -h npc_" + getObjectId() + "_Manufacture " + _pageId + "\" width=65 height=19 back=\"L2UI_ch3.smallbutton2_over\" fore=\"L2UI_ch3.smallbutton2\"></td>");
				replyMSG.append("<td width=138></td>");
				replyMSG.append("<td width=66></td>");
				replyMSG.append("</tr></table>");
				replyMSG.append("<br>");
				replyMSG.append("<table width=270><tr>");
				
				if ((_recipeList.isDwarvenRecipe() && Config.ALT_CRAFT_ALLOW_CRAFT) || (!_recipeList.isDwarvenRecipe() && Config.ALT_CRAFT_ALLOW_COMMON))
				{
					replyMSG.append("<td valign=top width=35><button value=\"\" action=\"bypass -h npc_" + getObjectId() + "_CraftItem " + _recipeObjId + " " + _quantity + "\" width=32 height=32 back=\"icon.skill0172\" fore=\"icon.skill0172\"></td>");
				}
				else
				{
					replyMSG.append("<td valign=top width=35><img src=icon.skill0172 width=32 height=32 align=left></td>");
				}
				
				replyMSG.append("<td valign=top width=235>");
				replyMSG.append("<table border=0 width=100%>");
				replyMSG.append("<tr><td><font color=\"FFFF00\">" + name + "</font></td></tr>");
				replyMSG.append("<tr><td><font color=\"A2A0A2\">Product:</font> <font color=\"B09878\">" + (_isConsumable ? (_recipeList.getCount() * _quantity) + " * " : _quantity > 1 ? _quantity : "") + " " + ItemTable.getInstance().getTemplate(_recipeList.getItemId()).getName() + "</font></td></tr>");
				
				if ((_recipeList.isDwarvenRecipe() && Config.ALT_CRAFT_ALLOW_CRAFT) || (!_recipeList.isDwarvenRecipe() && Config.ALT_CRAFT_ALLOW_COMMON))
				{
					replyMSG.append("<tr><td><font color=\"A2A0A2\">Price:</font> <font color=\"B09878\">" + _price + " Adena</font></td></tr></table></td>");
				}
				else
				{
					replyMSG.append("<tr><td></td></tr></table></td>");
				}
				
				replyMSG.append("</tr></table>");
				replyMSG.append("<br>");
				replyMSG.append("<center>");
				replyMSG.append("<table width=210>");
				replyMSG.append("<tr><td valign=top width=70><font color=\"B09878\">Enter quantity:</font></td><td></td></tr>");
				replyMSG.append("<tr><td valign=top width=70><edit var=\"quantity\" width=70></td>");
				replyMSG.append("<td valign=top width=70><button value=\"Calculate\" action=\"bypass -h npc_" + getObjectId() + "_CraftInfo " + _recipeObjId + " $quantity " + _pageId + "\" width=65 height=19 back=\"L2UI_ch3.smallbutton2_over\" fore=\"L2UI_ch3.smallbutton2\"></td>");
				replyMSG.append("</tr></table>");
				replyMSG.append("</center>");
				replyMSG.append("<br>");
				replyMSG.append("<br>");
				replyMSG.append("<table width=270><tr>");
				replyMSG.append("<td width=220><button value=\"Ingredients\" width=60 height=21 back=\"botaoes1.s04_over\" fore=\"botaoes1.s04_over\"</td>"); // width=120 height=21 back=\"botaoes1.s03_over\" fore=\"botaoes1.s03\">"
				replyMSG.append("<td width=50><button value=\"Quantity\" width=60 height=21 back=\"botaoes1.s04_over\" fore=\"botaoes1.s04_over\"</td></tr>");
				
				L2RecipeInstance[] _recipeItems = _recipeList.getRecipes();
				
				for (L2RecipeInstance _recipeItem : _recipeItems)
				{
					L2ItemInstance _item = _inventory.getItemByItemId(_recipeItem.getItemId());
					
					String _quantityState = "<font color=\"55FF55\">" + (_quantity * _recipeItem.getQuantity()) + "</font>";
					
					if ((_item == null) || (_item.getCount() < (_quantity * _recipeItem.getQuantity())))
					{
						_quantityState = "<font color=\"FF5555\">" + (int) (_quantity * _recipeItem.getQuantity() * Config.ALT_RATE_CRAFT_COST) + "</font>";
					}
					
					replyMSG.append("<tr><td width=220>" + ItemTable.getInstance().getTemplate(_recipeItem.getItemId()).getName() + "</td>");
					replyMSG.append("<td width=50>" + _quantityState + "</td></tr>");
				}
				
				replyMSG.append("</table>");
				replyMSG.append("</body></html>");
				
				npcReply.setHtml(replyMSG.toString());
				player.sendPacket(npcReply);
			}
		}
		else if (command.startsWith("CraftItem") && (Config.ALT_CRAFT_ALLOW_CRAFT || Config.ALT_CRAFT_ALLOW_COMMON))
		// Craft amount of items using selected recipe
		{
			int _recipeObjId = 0;
			int _quantity = 1;
			StringTokenizer st = new StringTokenizer(command.substring(9).trim());
			
			if (st.countTokens() != 2)
			{
				return;
			}
			
			try
			{
				_recipeObjId = Integer.parseInt(st.nextToken());
				_quantity = Integer.parseInt(st.nextToken());
			}
			catch (NumberFormatException e)
			{
			}
			Inventory _inventory = player.getInventory();
			
			L2ItemInstance _recipe = _inventory.getItemByObjectId(_recipeObjId);
			L2RecipeList _recipeList = RecipeTable.getInstance().getRecipeByItemId(_recipe.getItemId());
			
			boolean _isConsumable = ItemTable.getInstance().getTemplate(_recipeList.getItemId()).isConsumable();
			if ((_recipe.getOwnerId() == player.getObjectId()) && (_recipe.getItemType() == L2EtcItemType.RECEIPE) && ((_recipeList.isDwarvenRecipe() && Config.ALT_CRAFT_ALLOW_CRAFT) || (!_recipeList.isDwarvenRecipe() && Config.ALT_CRAFT_ALLOW_COMMON)))
			{
				L2RecipeInstance[] _recipeItems = _recipeList.getRecipes();
				
				boolean _enoughtMaterials = true;
				
				for (L2RecipeInstance _recipeItem : _recipeItems)
				{
					L2ItemInstance _item = _inventory.getItemByItemId(_recipeItem.getItemId());
					if ((_item == null) || (_item.getCount() < (int) (_quantity * _recipeItem.getQuantity() * Config.ALT_RATE_CRAFT_COST)))
					{
						_enoughtMaterials = false;
					}
				}
				
				int _price = (int) ((((Config.RATE_CRAFT_COST * _recipeList.getSuccessRate()) / 100) * _quantity * _recipeList.getCount() * ItemTable.getInstance().getTemplate(_recipeList.getItemId()).getReferencePrice()) / 55);
				if (_price == 0)
				{
					_price = Config.ALT_CRAFT_DEFAULT_PRICE;
				}
				
				if (_inventory.getInventoryItemCount(ADENA_ID, 0) < _price)
				{
					sendOutOfItems(player, Integer.toString(_price), "Adena");
					return;
				}
				
				if (!_enoughtMaterials)
				{
					sendOutOfItems(player, "proper amount", "materials");
					return;
				}
				
				int _quantitySuccess = 0;
				
				for (int i = 0; i < _quantity; i++)
				{
					if (Rnd.get(100) < _recipeList.getSuccessRate())
					{
						_quantitySuccess++;
					}
				}
				
				InventoryUpdate iu = new InventoryUpdate();
				
				for (L2RecipeInstance _recipeItem : _recipeItems)
				{
					player.destroyItemByItemId("CraftManager", _recipeItem.getItemId(), (int) (_quantity * _recipeItem.getQuantity() * Config.ALT_RATE_CRAFT_COST), player, true);
					iu.addModifiedItem(player.getInventory().getItemByItemId(_recipeItem.getItemId()));
				}
				
				player.destroyItemByItemId("CraftManager", ADENA_ID, _price, player, true);
				iu.addModifiedItem(player.getInventory().getItemByItemId(ADENA_ID));
				
				if (_quantitySuccess > 0)
				{
					
					SystemMessage sm = null;
					sm = new SystemMessage(SystemMessageId.EARNED_S2_S1_S);
					sm.addItemName(_recipeList.getItemId());
					sm.addNumber(_quantitySuccess * _recipeList.getCount());
					player.sendPacket(sm);
					sm = null;
					
					iu.addModifiedItem(player.getInventory().getItemByItemId(_recipeList.getItemId()));
					_inventory.addItem("CraftManager", _recipeList.getItemId(), _quantitySuccess * (_isConsumable ? _recipeList.getCount() : 1), player, player.getTarget());
				}
				
				player.sendPacket(iu);
				iu = null;
				
				player.broadcastUserInfo();
				sendCraftedItems(player, _quantitySuccess * (_isConsumable ? _recipeList.getCount() : 1), (_quantity - _quantitySuccess) * (_isConsumable ? _recipeList.getCount() : 1), ItemTable.getInstance().getTemplate(_recipeList.getItemId()).getName());
			}
		}
		else
		{
			super.onBypassFeedback(player, command);
		}
	}
	
	public String getRecipeIcon(int grade)
	{
		return "icon.etc_recipe_" + (grade == 1 ? "blue" : grade == 2 ? "yellow" : grade == 3 ? "red" : grade == 4 ? "violet" : grade == 5 ? "black" : "white") + "_i00";
	}
	
	public String getCrystalIcon(int grade)
	{
		return "icon.etc_crystal_" + (grade == 1 ? "blue" : grade == 2 ? "green" : grade == 3 ? "red" : grade == 4 ? "silver" : grade == 5 ? "gold" : "white") + "_i00";
	}
	
	public void sendOutOfItems(L2PcInstance player, String count, String itemname)
	{
		NpcHtmlMessage npcReply = new NpcHtmlMessage(1);
		
		StringBuilder replyMSG = new StringBuilder("<html><body>");
		
		replyMSG.append(getName() + ":<br>");
		replyMSG.append("Come back later, when you will have  <font color=\"LEVEL\">" + count + "</font>  of " + itemname + ".");
		replyMSG.append("</body></html>");
		
		npcReply.setHtml(replyMSG.toString());
		
		player.sendPacket(npcReply);
	}
	
	public void sendCraftedItems(L2PcInstance player, int success, int failed, String itemname)
	{
		NpcHtmlMessage npcReply = new NpcHtmlMessage(1);
		
		StringBuilder replyMSG = new StringBuilder("<html><body>");
		
		replyMSG.append(getName() + ":<br>");
		
		if (success == 0)
		{
			replyMSG.append("I am sorry, " + player.getName() + ", but all attempts to create <font color=\"LEVEL\">" + itemname + "</font> failed. All your materials have been lost.");
		}
		else if (failed == 0)
		{
			replyMSG.append("Congratulations, " + player.getName() + ", I created " + success + " <font color=\"LEVEL\">" + itemname + "</font> for you!");
		}
		else
		{
			replyMSG.append("Here you go, " + player.getName() + ", " + success + " <font color=\"LEVEL\">" + itemname + "</font> successfully created, but " + failed + " broken while craft.");
		}
		
		replyMSG.append("</body></html>");
		
		npcReply.setHtml(replyMSG.toString());
		
		player.sendPacket(npcReply);
	}
	
	@Override
	public String getHtmlPath(int npcId, int val)
	{
		String pom = "";
		if (val == 0)
		{
			pom = "" + npcId;
		}
		else
		{
			pom = npcId + "-" + val;
		}
		
		return "data/html/default/" + pom + ".htm";
	}
}

 

Edited by stalker66
Updated code

9 answers to this question

Recommended Posts

  • 0
Posted
On 7/14/2019 at 1:06 PM, SweeTs said:

... && !_item.isEquipped()

 

That's all you have to add to your check(s).

Thanks SweeTs! Im sorry for the late response, I just didn't have time to test it! But I did now and its works! Thanks a bunch! On the other hand, I encountered a problem with this code. As it seems if a player selects more than 21 items to crystallise, the game client crashes with the following error.

Quote

History: FMallocWindows::Free <- FMallocWindows::Realloc <- 00000034 0 FArray <- FArray::Realloc <- 0*4 <- NCHtmlViewer::ReleaseHtml <- NCHtmlViewer::LoadHtmlFormString <- NCNPCHtmlViewer::LoadHtml <- NConsoleWnd::ReceiveHtmlMessage <- UGameEngine::OnNpcHtmlMessage <- UNetworkHandler::Tick <- Function Name=NpcHtmlMessageP <- UGameEngine::Tick <- UpdateWorld <- MainLoop

 

My guess is it has to do with the limitations of the html files but im not sure.

My question, is there a way I can limit the number of items the player can select? If its possible, I would appreciate any help.

 

Here is a link to the Craft Manager in works:

Crystallize.gif

Crafting.gif

  • 0
Posted

Yea, pagination (pages) are required. I guess you won't handle it alone, but you can try. You can take a look at acis sources, admin command handler, memos file for example.

 

Eventually, easier, you can limit items show view to 20. Under a foor loop, you have to add some counter and break loop if reached.

  • 0
Posted
1 minute ago, SweeTs said:

Yea, pagination (pages) are required. I guess you won't handle it alone, but you can try. You can take a look at acis sources, admin command handler, memos file for example.

Yes, but I have the pages set, a max of 6 items/ page, problem is when you check the items and go over the 21 checkboxes ticked, then it crashes. But I will check out the acis, thanks for the hint.

  • 0
Posted

Restrict it to 10 items checked max. You already got a counter, so it's easy to implement.

 

If you don't want to impose a limit to the user, you have to paginate as SweeTs says. //bk admincommand on aCis would give you some hints about how to do it and keep it readable.

 

https://github.com/Tryskell/acis_public/blob/master/aCis_gameserver/java/net/sf/l2j/gameserver/handler/admincommandhandlers/AdminBookmark.java

 

Your own code got a pagination system, already, normally.

 

int _itemsOnPage = ITEMS_PER_PAGE;
			int _pages = _items.size() / _itemsOnPage;
			
			if (_items.size() > (_pages * _itemsOnPage))
			{
				_pages++;
			}
			if (_pageId > _pages)
			{
				_pageId = _pages;
			}
			
			int _itemStart = _pageId * _itemsOnPage;
			int _itemEnd = _items.size();
			
			if ((_itemEnd - _itemStart) > _itemsOnPage)
			{
				_itemEnd = _itemStart + _itemsOnPage;
			}

 

  • 0
Posted

So apparently this is the error it throws now... even though it worked. Now for some reason, it wont return any item from the players inventory at all. 

Bad RequestBypassToServer: java.lang.NullPointerException
java.lang.NumberFormatException: For input string: ""
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:68)
	at java.base/java.lang.Integer.parseInt(Integer.java:662)
	at java.base/java.lang.Integer.parseInt(Integer.java:770)
	at org.l2jmobius.gameserver.model.actor.instance.L2CraftManagerInstance.onBypassFeedback(L2CraftManagerInstance.java:69)
	at org.l2jmobius.gameserver.network.clientpackets.RequestBypassToServer.runImpl(RequestBypassToServer.java:526)
	at org.l2jmobius.gameserver.network.clientpackets.GameClientPacket.run(GameClientPacket.java:55)
	at org.l2jmobius.gameserver.network.GameClient.run(GameClient.java:837)
	at org.l2jmobius.commons.concurrent.RunnableWrapper.run(RunnableWrapper.java:38)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
	at java.base/java.lang.Thread.run(Thread.java:832)

 

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now


  • Posts

    • ## [1.4.0] - 2026-01-28   ### ✨ New Features - **Vote System**: Lineage 2 servers can now use our vote–reward system. Players vote on the website and claim rewards in-game (1 vote = 1 claim) - **Vote Page**: On each server’s page (`/servers/<server>`), a **“Vote for Server”** button opens a dedicated vote page with cooldown info and optional Turnstile verification - **By Votes View**: The **“By Votes”** tab on the main page shows **actual vote counts** per server - **API Documentation**: New **API Docs** page at `/docs` (and footer link) with HMAC auth, endpoints, and examples for game server integration - **Vote API (My Servers)**: Server owners can open **“Vote API”** in My Servers to manage credentials, cooldown, allowed IPs, and open the docs   ### 🔄 Improvements - **Server Pages**: Single-server data is cached and loads faster; server pages can be opened by ID or by name (e.g. `/servers/my-server-name`) - **API Root**: Visiting the API root redirects to the docs URL configured in admin (default: site docs page) - **Admin Panel**: New **“Vote System”** tab for global settings (Turnstile, API security, default cooldown, docs URL)   ### 🔐 Security & Reliability - Turnstile (CAPTCHA) support for vote submissions to reduce abuse - HMAC-protected game server API for secure vote check/claim and stats
    • "I recently purchased the account panel from this developer and wanted to leave a positive review.   The transaction was smooth, and the developer demonstrated exceptional professionalism throughout the process.   What truly sets them apart is their outstanding post-sale support. They are responsive, patient, and genuinely helpful when addressing questions or issues. It's clear they care about their customers' experience beyond just the initial sale.   I am thoroughly satisfied and grateful for the service. This is a trustworthy seller who provides real value through both a quality product and reliable support. 100% recommended."
    • Server owners, Top.MaxCheaters.com is now live and accepting Lineage 2 server listings. There is no voting, no rankings manipulation, and no paid advantages. Visibility is clean and equal, and early listings naturally appear at the top while the platform grows. If your server is active, it should already be listed. Submit here https://Top.MaxCheaters.com This platform is part of the MaxCheaters.com network and is being built as a long-term reference point for the Lineage 2 community. — MaxCheaters.com Team
    • ⚙️ General Changed “No Carrier” title to “Disconnected” to avoid confusion after abnormal DC. On-screen Clan War kill notifications will no longer appear during Sieges, Epics, or Events. Bladedancer or SwordSinger classes can now log in even when Max Clients (2) is reached, you cannot have both at the same time. The max is 3 clients. Duels will now be aborted if a monster aggros players during a duel (retail-like behavior). Players can no longer send party requests to blocked players (retail-like). Fixed Researcher Euclie NPC dialogue HTML error. Changed Clan leave/kick penalty from 12 hours to 3 hours. 🧙 Skills Adjusted Decrease Atk. Spd. & Decrease Speed land rates in Varka & FoG. Fixed augmented weapons not getting cooldown when entering Olympiad. 🎉 Events New Team vs Team map added. New Save the King map added (old TvT map). Mounts disabled during Events. Letter Collector Event enabled Monsters drop letters until Feb. 13th Louie the Cat in Giran until Feb. 16th Inventory slots +10 during event period 📜 Quests Fixed “Possessor of a Precious Soul Part 1” rare stuck issue when exceeding max quest items. Fixed Seven Signs applying Strife buff/debuff every Monday until restart. 🏆 Milestones New milestone: “Defeat 700 Monsters in Varka” 🎁 Rewards: 200 Varka’s Mane + Daily Coin 🌍 NEW EXP Bonus Zones Hot Springs added Varka Silenos added (hidden spots excluded) As always, thank you for your support! L2Elixir keeps evolving, improving, and growing every day 💙   Website: https://l2elixir.org/ Discord: https://discord.gg/5ydPHvhbxs
  • Topics

×
×
  • Create New...

Important Information

This community uses essential cookies to function properly. Non-essential cookies and third-party services are used only with your consent. Read our Privacy Policy and We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue..