Help Target null

[N0K3]

Hello friends, I have a problem about sending party to a fakeplayer, I am sending it and java recognizes the fake as target null "if (target == null)".
However, fake receives trade normally, and the trade uses the same party code, I will make available the party and trade code below.

 

I used the "+" to show where the code stops, identifying the target as nullo, however it should go to the end and send the invite to fake equal the trade.

 

RequestJoinParty.java (acis374)

  Reveal hidden contents

package net.sf.l2j.gameserver.network.clientpackets;

import net.sf.l2j.gameserver.events.teamvsteam.TvTEvent;
import net.sf.l2j.gameserver.model.BlockList;
import net.sf.l2j.gameserver.model.World;
import net.sf.l2j.gameserver.model.actor.instance.Player;
import net.sf.l2j.gameserver.model.group.Party;
import net.sf.l2j.gameserver.model.group.Party.LootRule;
import net.sf.l2j.gameserver.model.zone.ZoneId;
import net.sf.l2j.gameserver.network.SystemMessageId;
import net.sf.l2j.gameserver.network.serverpackets.AskJoinParty;
import net.sf.l2j.gameserver.network.serverpackets.SystemMessage;

public final class RequestJoinParty extends L2GameClientPacket
{
	private String _name;
	private int _itemDistribution;

	@Override
	protected void readImpl()
	{
		_name = readS();
		_itemDistribution = readD();
	}

	@Override
	protected void runImpl()
	{
		final Player requestor = getClient().getActiveChar();
		if (requestor == null)
			return;
		
		final Player target = World.getInstance().getPlayer(_name);
+		if (target == null || !requestor.getKnownType(Player.class).contains(target) || target.equals(requestor))
+		{
+			requestor.sendMessage("This is incorrect target or is in refusal mode.");
+			return;
+		}

		if (BlockList.isBlocked(target, requestor))
		{
			requestor.sendMessage("This is incorrect target or is in refusal mode.");
			return;
		}
		
		if ((target.equals(requestor)) || (target.isCursedWeaponEquipped()) || (requestor.isCursedWeaponEquipped()) || ((target.getAppearance().getInvisible()) && (!target.isInsideZone(ZoneId.TOURNAMENT)) && (!target.isGM())))
		{
			requestor.sendPacket(SystemMessageId.YOU_HAVE_INVITED_THE_WRONG_TARGET);
			return;
		}

		if (target.isPartyInRefuse())
		{
			requestor.sendMessage("This is incorrect target or is in refusal mode.");
			return;
		}

		if (target.isInParty())
		{
			requestor.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.S1_IS_ALREADY_IN_PARTY).addCharName(target));
			return;
		}
		
		if (TvTEvent.isPlayerParticipant(target.getObjectId()))
		{
			requestor.sendPacket(SystemMessageId.YOU_HAVE_INVITED_THE_WRONG_TARGET);
			return;
		}

		if (target.getClient().isDetached())
		{
			requestor.sendMessage("The player you tried to invite is in offline mode.");
			return;
		}

		if (target.isInJail() || requestor.isInJail())
		{
			requestor.sendMessage("The player you tried to invite is currently jailed.");
			return;
		}

		if (target.isInOlympiadMode() || requestor.isInOlympiadMode())
			return;

		if (requestor.isProcessingRequest())
		{
			requestor.sendPacket(SystemMessageId.WAITING_FOR_ANOTHER_REPLY);
			return;
		}

		if (target.isProcessingRequest())
		{
			requestor.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.S1_IS_BUSY_TRY_LATER).addCharName(target));
			return;
		}

		final Party party = requestor.getParty();
		if (party != null)
		{
			if (!party.isLeader(requestor))
			{
				requestor.sendPacket(SystemMessageId.ONLY_LEADER_CAN_INVITE);
				return;
			}

			if (party.getMembersCount() >= 9)
			{
				requestor.sendPacket(SystemMessageId.PARTY_FULL);
				return;
			}

			if (party.getPendingInvitation() && !party.isInvitationRequestExpired())
			{
				requestor.sendPacket(SystemMessageId.WAITING_FOR_ANOTHER_REPLY);
				return;
			}

			party.setPendingInvitation(true);
		}
		else
			requestor.setLootRule(LootRule.VALUES[_itemDistribution]);

		requestor.onTransactionRequest(target);
		requestor.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.YOU_INVITED_S1_TO_PARTY).addCharName(target));

		target.sendPacket(new AskJoinParty(requestor.getName(), (party != null) ? party.getLootRule().ordinal() : _itemDistribution));
	}
}

 

 

 

TradeRequest.java(acis 374)

  Reveal hidden contents

package net.sf.l2j.gameserver.network.clientpackets;

import net.sf.l2j.commons.math.MathUtil;

import net.sf.l2j.Config;
import net.sf.l2j.gameserver.model.BlockList;
import net.sf.l2j.gameserver.model.World;
import net.sf.l2j.gameserver.model.actor.Npc;
import net.sf.l2j.gameserver.model.actor.instance.Player;
import net.sf.l2j.gameserver.network.SystemMessageId;
import net.sf.l2j.gameserver.network.serverpackets.SendTradeRequest;
import net.sf.l2j.gameserver.network.serverpackets.SystemMessage;

public final class TradeRequest extends L2GameClientPacket
{
	private int _objectId;

	@Override
	protected void readImpl()
	{
		_objectId = readD();
	}

	@Override
	protected void runImpl()
	{
		final Player player = getClient().getActiveChar();
		if (player == null)
			return;

		if (!player.getAccessLevel().allowTransaction())
		{
			player.sendPacket(SystemMessageId.YOU_ARE_NOT_AUTHORIZED_TO_DO_THAT);
			return;
		}

		final Player target = World.getInstance().getPlayer(_objectId);
+		if (target == null || !player.getKnownType(Player.class).contains(target) || target.equals(player))
+		{
+			player.sendPacket(SystemMessageId.TARGET_IS_INCORRECT);
+			return;
+		}

		if (player.isSubmitingPin())
		{
			player.sendMessage("Unable to do any action while PIN is not submitted");
			return;
		}

		if (target.isInOlympiadMode() || player.isInOlympiadMode())
		{
			player.sendMessage("You or your target cannot trade during Olympiad.");
			return;
		}

		if (target.isInCombat() || player.isInCombat())
		{
			player.sendMessage("You or your target can't trade in Combat.");
			return;
		}

		if (target.isInCombat() || player.isInCombat())
		{
			player.sendMessage("You or your target can't trade in Combat.");
			return;
		}

		// Alt game - Karma punishment
		if (!Config.KARMA_PLAYER_CAN_TRADE && (player.getKarma() > 0 || target.getKarma() > 0))
		{
			player.sendMessage("You cannot trade in a chaotic state.");
			return;
		}

		if (player.isInStoreMode() || target.isInStoreMode())
		{
			player.sendPacket(SystemMessageId.CANNOT_TRADE_DISCARD_DROP_ITEM_WHILE_IN_SHOPMODE);
			return;
		}

		if (player.isProcessingTransaction())
		{
			player.sendPacket(SystemMessageId.ALREADY_TRADING);
			return;
		}

		if (target.isProcessingRequest() || target.isProcessingTransaction())
		{
			SystemMessage sm = SystemMessage.getSystemMessage(SystemMessageId.S1_IS_BUSY_TRY_LATER).addCharName(target);
			player.sendPacket(sm);
			return;
		}

		if (target.getTradeRefusal())
		{
			player.sendMessage("This is incorrect target or is in refusal mode.");
			return;
		}

		if (BlockList.isBlocked(target, player))
		{
			SystemMessage sm = SystemMessage.getSystemMessage(SystemMessageId.S1_HAS_ADDED_YOU_TO_IGNORE_LIST).addCharName(target);
			player.sendPacket(sm);
			return;
		}

		if (MathUtil.calculateDistance(player, target, true) > Npc.INTERACTION_DISTANCE)
		{
			player.sendPacket(SystemMessageId.TARGET_TOO_FAR);
			return;
		}

		player.onTransactionRequest(target);
		target.sendPacket(new SendTradeRequest(player.getObjectId()));
		player.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.REQUEST_S1_FOR_TRADE).addCharName(target));
	}
}

 

Text generated by google translate.

[Kara]

  On 10/8/2018 at 6:49 PM, N0K3 said:

Hello friends, I have a problem about sending party to a fakeplayer, I am sending it and java recognizes the fake as target null "if (target == null)".
However, fake receives trade normally, and the trade uses the same party code, I will make available the party and trade code below.

 

I used the "+" to show where the code stops, identifying the target as nullo, however it should go to the end and send the invite to fake equal the trade.

 

RequestJoinParty.java (acis374)

  Reveal hidden contents

 

 

 

TradeRequest.java(acis 374)

  Reveal hidden contents

package net.sf.l2j.gameserver.network.clientpackets;

import net.sf.l2j.commons.math.MathUtil;

import net.sf.l2j.Config;
import net.sf.l2j.gameserver.model.BlockList;
import net.sf.l2j.gameserver.model.World;
import net.sf.l2j.gameserver.model.actor.Npc;
import net.sf.l2j.gameserver.model.actor.instance.Player;
import net.sf.l2j.gameserver.network.SystemMessageId;
import net.sf.l2j.gameserver.network.serverpackets.SendTradeRequest;
import net.sf.l2j.gameserver.network.serverpackets.SystemMessage;

public final class TradeRequest extends L2GameClientPacket
{
	private int _objectId;

	@Override
	protected void readImpl()
	{
		_objectId = readD();
	}

	@Override
	protected void runImpl()
	{
		final Player player = getClient().getActiveChar();
		if (player == null)
			return;

		if (!player.getAccessLevel().allowTransaction())
		{
			player.sendPacket(SystemMessageId.YOU_ARE_NOT_AUTHORIZED_TO_DO_THAT);
			return;
		}

		final Player target = World.getInstance().getPlayer(_objectId);
+		if (target == null || !player.getKnownType(Player.class).contains(target) || target.equals(player))
+		{
+			player.sendPacket(SystemMessageId.TARGET_IS_INCORRECT);
+			return;
+		}

		if (player.isSubmitingPin())
		{
			player.sendMessage("Unable to do any action while PIN is not submitted");
			return;
		}

		if (target.isInOlympiadMode() || player.isInOlympiadMode())
		{
			player.sendMessage("You or your target cannot trade during Olympiad.");
			return;
		}

		if (target.isInCombat() || player.isInCombat())
		{
			player.sendMessage("You or your target can't trade in Combat.");
			return;
		}

		if (target.isInCombat() || player.isInCombat())
		{
			player.sendMessage("You or your target can't trade in Combat.");
			return;
		}

		// Alt game - Karma punishment
		if (!Config.KARMA_PLAYER_CAN_TRADE && (player.getKarma() > 0 || target.getKarma() > 0))
		{
			player.sendMessage("You cannot trade in a chaotic state.");
			return;
		}

		if (player.isInStoreMode() || target.isInStoreMode())
		{
			player.sendPacket(SystemMessageId.CANNOT_TRADE_DISCARD_DROP_ITEM_WHILE_IN_SHOPMODE);
			return;
		}

		if (player.isProcessingTransaction())
		{
			player.sendPacket(SystemMessageId.ALREADY_TRADING);
			return;
		}

		if (target.isProcessingRequest() || target.isProcessingTransaction())
		{
			SystemMessage sm = SystemMessage.getSystemMessage(SystemMessageId.S1_IS_BUSY_TRY_LATER).addCharName(target);
			player.sendPacket(sm);
			return;
		}

		if (target.getTradeRefusal())
		{
			player.sendMessage("This is incorrect target or is in refusal mode.");
			return;
		}

		if (BlockList.isBlocked(target, player))
		{
			SystemMessage sm = SystemMessage.getSystemMessage(SystemMessageId.S1_HAS_ADDED_YOU_TO_IGNORE_LIST).addCharName(target);
			player.sendPacket(sm);
			return;
		}

		if (MathUtil.calculateDistance(player, target, true) > Npc.INTERACTION_DISTANCE)
		{
			player.sendPacket(SystemMessageId.TARGET_TOO_FAR);
			return;
		}

		player.onTransactionRequest(target);
		target.sendPacket(new SendTradeRequest(player.getObjectId()));
		player.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.REQUEST_S1_FOR_TRADE).addCharName(target));
	}
}

 

Text generated by google translate.

Expand  

If you get an error in console the only "null" that can cause it is the getKnownType which might return a null list.

Check your getKnownType method to see why it return null list.

Edited October 8, 2018 by Kara`

[N0K3]

  On 10/8/2018 at 10:08 PM, Kara` said:

If you get an error in console the only "null" that can cause it is the getKnownType which might return a null list.

Check your getKnownType method to see why it return null list.

Expand  

It returns the message that is intended "requestor.sendMessage (" This is incorrect target or is in refusal mode. "); however, I'd like it to go to the end of the code and send the party invite, I do not get null on the console.

[Tryskell]

My politic is to avoid null when I can, getKnownType / getKnownTypeInRadius never show null. The list is at best a static List or a new ArrayList, but in the end there is a List, so any action on this List is ok. An iteration on it, without any check, is fully ok.

 

The idea is more about if a Fake player is supposed to be a Player or if there is a specific instance for it (ake, if it's a FakePlayer, you have to check this instance type).

 

You got a specific admin command to check your current knownlist and associated types around you, //knownlist, for that purpose.