Jump to content

Recommended Posts

Posted (edited)

Recently I've been reading about lots of trashtalking about acis. I've been using aCis about 5 years, my favorite server L2AEPvP I based it into an ancient aCis rev, 110 I think?

I know each line of this project by hand line by line with eyes closed, I've recently ported this ancient 110 rev acis L2AEPvP into the H5 client with MINIMAL effort, (packets, datapack)...
Not saying that its flawless but its a great and very clean project with a bad reputation from a shitty community and small devs.

 

 

Basically this topic is a big fuck you

 

DescriptiveCleanErne-max-1mb.gif

 

to all the trashers that use this pack with zero knowledge and no contribution, ruining the small community more and more.

 

 

My 2 cents wannabies

Edited by xxdem
Posted
18 minutes ago, vampir said:

So how much time totally did you spend on improving the pack?

 

Lots, but I cant have an opinion on that because i am fully custom

 

4 minutes ago, .Elfocrash said:

It's a fine project with mediocre code. 

The best way I can sum it up is: "It's code looks like what a hobbyist would think clean code is."

 

Still a more than fine project (and the only one) to use for interlude.

 

Your sum up belongs to the trash can, everyone has his own opinion about clean code because it's a matter of coding style with the given trade-offs for each case (performance, expandability, readability, development speed, etc)

Posted
9 minutes ago, xxdem said:

Absolutely no reason to argue with you. *You are right*

I don't want you to tell me I'm right. I'd rather have you tell me with arguments why I'm wrong, but ofc you can't do that.

Posted
9 hours ago, xxdem said:

Recently I've been reading about lots of trashtalking about acis. I've been using aCis about 5 years, my favorite server L2AEPvP I based it into an ancient aCis rev, 110 I think?

I know each line of this project by hand line by line with eyes closed, I've recently ported this ancient 110 rev acis L2AEPvP into the H5 client with MINIMAL effort, (packets, datapack)...
Not saying that its flawless but its a great and very clean project with a bad reputation from a shitty community and small devs.

 

 

Basically this topic is a big fuck you

 

DescriptiveCleanErne-max-1mb.gif

 

to all the trashers that use this pack with zero knowledge and no contribution, ruining the small community more and more.

 

 

My 2 cents wannabies

I have 2 questions:

1. How many players hold your server? How long was online? Rates?

2. How long did you play on the retail?

 

Posted
1 minute ago, Quark said:

I have 2 questions:

1. How many players hold your server? How long was online? Rates?

2. How long did you play on the retail?

 

 

I find these totally irrelevant

Posted

aCis 110 revision not better solution. Use L2J Frozen then. *Obama Not Bad*

 

P.S. I surprises, that there was the person, who praises the project which it was yet totally L2J Server Freya (only cutted yet). aCis, as unique fork, became much later.

Posted
10 hours ago, xxdem said:

The topic "what is lean code" is abstract and completely offtopic

On topic then. Even if you put 5 years to some shared c1 pack then you can make it be great. The thing is currently there arent any good IL pack that could run low/mid server. If you want to work on acis you need to implement all missing things and also make at least some modifications to skills and geoengine or your server will fail very shortly.

When it comes to clean code, acis is not much different from russian packs. If you would remove all customs from lucera or fandc then you will notice that those 2 types of packs(eu and ru) are very similar, are both of them are very far away from so called clean code. The difference is that russian packs have all acis missing things implemented and a lot of bugs fixed.

 

Try to open mid rate on clean acis files, then we can talk if this pack is great or not.

  • Like 1
Posted
3 hours ago, vampir said:

If you want to work on acis you need to implement all missing things and also make at least some modifications to skills and geoengine or your server will fail very shortly.

Missing things - if you need them, otherwise it's not a problem. 

Skills - what's actually wrong with them?

Geoengine - sure, that nasty 'chasing' issue is present, but not a BIG issue. Look at sahar server, he did not fix it yet people didn't report it. Even worse, the same crap happens on l2rpg or whatever the server it was (could twist the name), yet people play it and don't complain.

 

People rarely use brain, so such situation is like a gold fish. You know it does exists, but you never seen her. 

Posted
1 hour ago, SweeTs said:

Look at sahar server,

Is'nt this "sahar server" custom thing, something like side vs side with closed areas, mobs have no drop and etc...?

Or I'm wrong?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.




  • Posts

    • hello, i want to wtt my charracter in l2elmorelab 1x harbor for 1.5kkk adena in l2reborn 10x new. Or if you interested tell me your offer. :)) Clean Mail 30 lvl Cleric Naked   Updated.
    • package ai.npc.NFWalker; import java.util.ArrayList; import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.Random; import l2r.gameserver.enums.CtrlIntention; import l2r.gameserver.model.Location; import l2r.gameserver.model.actor.L2Npc; import l2r.gameserver.model.quest.Quest; import l2r.gameserver.network.clientpackets.Say2; import l2r.gameserver.network.serverpackets.NpcSay; public class NFWalkerAI extends Quest { private static final int WALKER_NPC_ID = 20116; private final Map<String, Route> routes = new HashMap<>(); private final Map<Integer, Integer> npcIndexes = new HashMap<>(); private final Map<Integer, Boolean> npcReverse = new HashMap<>(); private final Map<Integer, String> npcCurrentRoute = new HashMap<>(); public NFWalkerAI() { super(-1, NFWalkerAI.class.getSimpleName(), "ai/npc/NFWalker"); loadRoutes(); addSpawnId(WALKER_NPC_ID); } private void loadRoutes() { // Route 1 Data Route route1 = new Route("route1"); route1.addPoint(new RoutePoint(0, 149363, 172341, -941, 0, false, "")); route1.addPoint(new RoutePoint(1, 148568, 172328, -980, 5, true, "Puff")); route1.addPoint(new RoutePoint(2, 148536, 172792, -980, 0, false, "")); // Route 2 Data Route route2 = new Route("route2"); route2.addPoint(new RoutePoint(0, 149363, 172341, -941, 0, false, "")); route2.addPoint(new RoutePoint(1, 150248, 172328, -980, 5, true, "Rise my children! Bring me the servants of the god! Let them be offered to our god Bifrons!")); route2.addPoint(new RoutePoint(2, 150248, 172776, -980, 0, false, "")); // Add routes to the map routes.put("route1", route1); routes.put("route2", route2); } @Override public String onSpawn(L2Npc npc) { if (npc.getId() == WALKER_NPC_ID) { selectInitialRouteForNpc(npc); } return super.onSpawn(npc); } @Override public String onAdvEvent(String event, L2Npc npc, l2r.gameserver.model.actor.instance.L2PcInstance player) { if (event.equalsIgnoreCase("move")) { moveNpc(npc); } else if (event.equalsIgnoreCase("check_reached")) { checkIfReached(npc); } return null; } private void moveNpc(L2Npc npc) { String routeName = npcCurrentRoute.get(npc.getObjectId()); Route route = routes.get(routeName); Integer pointIndex = npcIndexes.get(npc.getObjectId()); if (route != null && pointIndex != null) { RoutePoint point = route.getPoints().get(pointIndex); if (point.isRun()) { npc.setRunning(); } else { npc.setWalking(); } if (!point.getChat().isEmpty()) { npc.broadcastPacket(new NpcSay(npc.getObjectId(), Say2.NPC_ALL, npc.getId(), point.getChat())); } npc.getAI().setIntention(CtrlIntention.AI_INTENTION_MOVE_TO, new Location(point.getX(), point.getY(), point.getZ())); // Log movement intention System.out.println("NPC " + npc.getObjectId() + " moving to " + point.getX() + ", " + point.getY() + ", " + point.getZ()); // Schedule a check to see if the NPC has reached its destination startQuestTimer("check_reached", 1000, npc, null); } } private void checkIfReached(L2Npc npc) { String routeName = npcCurrentRoute.get(npc.getObjectId()); Route route = routes.get(routeName); Integer pointIndex = npcIndexes.get(npc.getObjectId()); if (route != null && pointIndex != null) { RoutePoint point = route.getPoints().get(pointIndex); Location currentLocation = npc.getLocation(); Location targetLocation = new Location(point.getX(), point.getY(), point.getZ()); // Check if the NPC has reached the target location if (currentLocation.equals(targetLocation)) { // Log that the NPC has reached the target System.out.println("NPC " + npc.getObjectId() + " reached target " + targetLocation); // Schedule the next movement startQuestTimer("move", point.getDelay() * 1000, npc, null); if (!npcReverse.get(npc.getObjectId())) { pointIndex++; if (pointIndex >= route.getPoints().size()) { npcReverse.put(npc.getObjectId(), true); pointIndex = route.getPoints().size() - 1; } } else { pointIndex--; if (pointIndex < 0) { npcReverse.put(npc.getObjectId(), false); pointIndex = 0; // Choose a new route after completing the current one in both directions switchRouteForNpc(npc); return; } } npcIndexes.put(npc.getObjectId(), pointIndex); } else { // Check again after 1 second startQuestTimer("check_reached", 1000, npc, null); } } } private void selectInitialRouteForNpc(L2Npc npc) { // Randomly select either route1 or route2 String selectedRouteName = "route" + (new Random().nextInt(2) + 1); npcCurrentRoute.put(npc.getObjectId(), selectedRouteName); npcIndexes.put(npc.getObjectId(), 0); npcReverse.put(npc.getObjectId(), false); startQuestTimer("move", 5000, npc, null); // Log initial route selection System.out.println("NPC " + npc.getObjectId() + " selected initial route " + selectedRouteName); } private void switchRouteForNpc(L2Npc npc) { String currentRoute = npcCurrentRoute.get(npc.getObjectId()); String newRoute = currentRoute.equals("route1") ? "route2" : "route1"; npcCurrentRoute.put(npc.getObjectId(), newRoute); npcIndexes.put(npc.getObjectId(), 0); npcReverse.put(npc.getObjectId(), false); startQuestTimer("move", 5000, npc, null); // Log route switching System.out.println("NPC " + npc.getObjectId() + " switched to route " + newRoute); } private static class Route { private List<RoutePoint> points = new ArrayList<>(); public Route(String name) { } public void addPoint(RoutePoint point) { points.add(point); } public List<RoutePoint> getPoints() { return points; } } private static class RoutePoint { private int id; private int x, y, z, delay; private boolean run; private String chat; public RoutePoint(int id, int x, int y, int z, int delay, boolean run, String chat) { this.id = id; this.x = x; this.y = y; this.z = z; this.delay = delay; this.run = run; this.chat = chat; } public int getId() { return id; } public int getX() { return x; } public int getY() { return y; } public int getZ() { return z; } public int getDelay() { return delay; } public boolean isRun() { return run; } public String getChat() { return chat; } } } I looking for help, with this, the npc not start to move. Im trying to create, an NPC wich have multiple walk routes basic logic is  random pick a route complite the route  like Route 1 start form zero (0 -> 1 -> 2(or more) -> 1 -> 0) When the npc return to 0, the script should pic the other route and start again.  And if there is a message like point 1 here     "route1.addPoint(new RoutePoint(1, 148568, 172328, -980, 5, true, "Puff"));" The npc should display the chat message. Currently my problem is the npc not moving, but if I manage it to start moving its randomly move between the route 1 and 2 set of coordinates. Currently for me its  a nightmare. I hope anyone can help somhow.
    • We are certainly not an ambulance, but we will definitely cure you of blacklists and empty pockets. Live freely with SX! Each of you will receive a trial version of SX to familiarize yourself with the product, all you have to do is post in this thread
    • qual e o valor pra atualizar o java da soucer ?
    • qual e o valor pra atualizar o java ?
  • Topics

×
×
  • Create New...