Code Custom Enchant Skill List

[melron]

Hello guys,

I wanna share with you my custom enchant skill list. What this list contains?

 

1. 100% safe enchant till enchant reach the config value
2. If the enchant is higher than this value you have the retail chance
3. if you fail to enchant and character is nobl ( nobl condition was for testing you have to change this with your condition ) the skill enchant will become -1 of the current enchant
4. Its working for both conditions ( < 130 , < 170 ex. power,cost )
5. 2 configs ( no need more )

Coded in acis 364

video

 

 

diff

 

### Eclipse Workspace Patch 1.0
#P aCis_gameserver
Index: java/net/sf/l2j/gameserver/network/clientpackets/RequestExEnchantSkillInfo.java
===================================================================
--- java/net/sf/l2j/gameserver/network/clientpackets/RequestExEnchantSkillInfo.java	(revision 7)
+++ java/net/sf/l2j/gameserver/network/clientpackets/RequestExEnchantSkillInfo.java	(working copy)
@@ -84,7 +84,9 @@
 					return;
 				
 				// Send ExEnchantSkillInfo packet.
-				ExEnchantSkillInfo esi = new ExEnchantSkillInfo(_skillId, _skillLevel, data.getCostSp(), data.getCostExp(), data.getRate(activeChar.getLevel()));
+				int fElem = 100 + Config.SAFE_ENCHANT;
+				int sElem = 140 + Config.SAFE_ENCHANT;
+				ExEnchantSkillInfo esi = new ExEnchantSkillInfo(_skillId, _skillLevel, data.getCostSp(), data.getCostExp(), (activeChar.isNoble() && ((_skillLevel > 130 && _skillLevel <= sElem) || (_skillLevel <= fElem))) ? 100 : data.getRate(activeChar.getLevel()));
 				if (Config.ES_SP_BOOK_NEEDED)
 					if (data.getItemId() != 0 && data.getItemCount() != 0)
 						esi.addRequirement(4, data.getItemId(), data.getItemCount(), 0);
Index: java/net/sf/l2j/Config.java
===================================================================
--- java/net/sf/l2j/Config.java	(revision 7)
+++ java/net/sf/l2j/Config.java	(working copy)
@@ -52,6 +52,7 @@
 	public static final String SIEGE_FILE = "./config/siege.properties";
 	public static final String PARTY_EVENT_FILE = "./config/PartyEvent.properties";
 	public static final String VOTE_MANAGER_FILE = "./config/VoteManager.properties";
+	public static final String ENCHANT_SKILL_FILE = "./config/CustomEnchantSkills.properties";
 	
 	
 	/** VoteManager Settings */
@@ -107,6 +108,10 @@
 	public static boolean ALT_MEMBERS_CAN_WITHDRAW_FROM_CLANWH;
 	public static boolean REMOVE_CASTLE_CIRCLETS;
 	
+	/** Enchant Skills */
+	 public static int SAFE_ENCHANT;
+	 public static boolean REDUCE_BY_ONE;
+	 
 	/** Manor */
 	public static int ALT_MANOR_REFRESH_TIME;
 	public static int ALT_MANOR_REFRESH_MIN;
@@ -1056,6 +1061,12 @@
 		RED_RAID_MSG = ptEvent.getProperty("RedRaidMessage","And remember!! Your enemies are noobs! Go Go Go!");
 
 	}
+	private static final void loadEnchantSkills()
+	{
+		final ExProperties eSkills = initProperties(ENCHANT_SKILL_FILE);
+		SAFE_ENCHANT = eSkills.getProperty("SkillSafeEnchantMax", 15);
+		REDUCE_BY_ONE = eSkills.getProperty("ReduceEnchant", false);
+	}
 	/**
 	 * Loads NPC settings.<br>
 	 * Such as champion monsters, NPC buffer, class master, wyvern, raid bosses and grand bosses, AI.
@@ -1512,6 +1523,9 @@
 		
 		// server settings
 		loadServer();
+		
+		// Enchant Skills
+		loadEnchantSkills();
 	}
 	
 	public static final void loadLoginServer()
Index: java/net/sf/l2j/gameserver/network/clientpackets/RequestExEnchantSkill.java
===================================================================
--- java/net/sf/l2j/gameserver/network/clientpackets/RequestExEnchantSkill.java	(revision 7)
+++ java/net/sf/l2j/gameserver/network/clientpackets/RequestExEnchantSkill.java	(working copy)
@@ -121,7 +121,9 @@
 		activeChar.removeExpAndSp(data.getCostExp(), data.getCostSp());
 		
 		// Try to enchant skill.
-		if (Rnd.get(100) <= data.getRate(activeChar.getLevel()))
+		int fElem = 100 + Config.SAFE_ENCHANT;
+		int sElem = 140 + Config.SAFE_ENCHANT;
+		if ((activeChar.isNoble() && ((_skillLevel > 130 && _skillLevel <= sElem) || (_skillLevel <= fElem))) ? true : Rnd.get(100) <= data.getRate(activeChar.getLevel()))
 		{
 			activeChar.addSkill(skill, true);
 			activeChar.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.YOU_HAVE_SUCCEEDED_IN_ENCHANTING_THE_SKILL_S1).addSkillName(_skillId, _skillLevel));
@@ -131,7 +133,13 @@
 			activeChar.sendPacket(SystemMessage.getSystemMessage(SystemMessageId.YOU_HAVE_FAILED_TO_ENCHANT_THE_SKILL_S1).addSkillName(_skillId, _skillLevel));
 			if (_skillLevel > 100)
 			{
-				_skillLevel = baseLvl;
+				if (Config.REDUCE_BY_ONE && activeChar.isNoble())
+				{
+					if (_skillLevel > 140 || _skillLevel < 130)
+						_skillLevel-=2;		
+				}
+				else
+					_skillLevel = baseLvl;
 				activeChar.addSkill(SkillTable.getInstance().getInfo(_skillId, _skillLevel), true);
 			}
 		}
 

 

 

CustomEnchantSkills.properties

 

# ================================================================
#                          Enchant Skills setting
# ================================================================

#If the char meet the conditions will enchant with 100% success rate
#Till the this value
#default 15
SkillSafeEnchantMax = 10

#If this is true and the enchant will fail , the skill enchantment will lost 1 enchant
ReduceEnchant = true 

 

Edited January 12, 2017 by melron

[protoftw]

I think it should be better to require 1 book of giant everytime skill enchant fails .(for the noblesse part)

  Because without requiring one he can go all the way to max enchant with just 1 bog  ^-^

[melron]

I think it should be better to require 1 book of giant everytime skill enchant fails .(for the noblesse part)

  Because without requiring one he can go all the way to max enchant with just 1 bog  ^-^

Nop, you supposed to use this code for a special case (like nobl in this case) so , its better as it is :P

Edited January 12, 2017 by melron

[protoftw]

Nop, you supposed to use this code for a special case (like nobl in this case) so , its better as it is :P

You know better :)

[StinkyMadness]

I think it should be better to require 1 book of giant everytime skill enchant fails .(for the noblesse part)

  Because without requiring one he can go all the way to max enchant with just 1 bog  ^-^

 +1 to this setting ( You can add it as config )

Thanks for sharing

[protoftw]

 +1 to this setting ( You can add it as config )

Thanks for sharing

thank you :)

If he can make it that way it would be a pretty nice npc :P

[Red-Hair-Shanks]

very nice code.
it can be use for donators xD :P

tnx for share :)

[melron]

 +1 to this setting ( You can add it as config )

Thanks for sharing

 

ill not add something like this because..

 

it can be use for donators xD :P

 

also if i add this setting that means i have to add require item and the check must be before the character will click enchant... like normal one

Edited January 13, 2017 by melron

[Accountant]

Nice code mate.Keep up great work.

[Tryskell]

If the success rate is 100%, better reward directly last segment, and compute the SP cost for looping +1 to +30.

 

That will avoid you 30 clicks per skill.

[melron]

If the success rate is 100%, better reward directly last segment, and compute the SP cost for looping +1 to +30.

 

That will avoid you 30 clicks per skill.

the rate is 100 only till the value u set .. next enchants chance is retail one from xmls.. i made this one for low values like +10 .. now if someone wants +30 he can do it like this in +30 case :P

 

btw i already did that (instantly +30) :-beep- yeah:

 

Edited January 14, 2017 by melron

[Reborn12]

the rate is 100 only till the value u set .. next enchants chance is retail one from xmls.. i made this one for low values like +10 .. now if someone wants +30 he can do it like this in +30 case :P

 

btw i already did that (instantly +30) :-beep- yeah:

 

https://www.youtube.com/watch?v=KK7Y-QxYfF8&feature=youtu.be

I like this way seems better than the first one

[AccessDenied]

Awww my little melron made a share. Normally i'm bad with everyone but you're exception.

I will give you tomorrow the +1 cause im sleepy.

 

Also tryskell stop being lazy bananawhore who eat cookies from other's kitchen and watch family series you b*itch 

[melron]

Awww my little melron made a share. Normally i'm bad with everyone but you're exception.

I will give you tomorrow the +1 cause im sleepy.

 

Also tryskell stop being lazy bananawhore who eat cookies from other's kitchen and watch family series you b*itch 

Hehe thanks baby :D

[ozeritozz]

Adapt for Frozen maybe?