Jump to content

Recommended Posts

Posted

Hello I want to share code Auto Announce online p.  + fake p. + crit. announce for L2PS

Its based on L2PS source ( https://www.facebook.com/pages/L2jPS-Hi5/410729485662486 )

 

 

Config file:

- insert to custom mods in events folder

# ---------------------------------------------------------------------------
# Auto Announce player with Fake players
# ---------------------------------------------------------------------------
AnnouncePlayers = False
FakePlayers = 256
OnlineInterval = 10
CriticalAnnounce = False

 

Core side:

- inset this code to ...gameserver/

/*
* This program is free software: you can redistribute it and/or modify it under
* the terms of the GNU General Public License as published by the Free Software
* Foundation, either version 3 of the License, or (at your option) any later
* version.
*
* This program is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
* FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
* details.
*
* You should have received a copy of the GNU General Public License along with
* this program. If not, see <http://www.gnu.org/licenses/>.
*/
package com.l2jserver.gameserver;

import com.l2jserver.Config;
import com.l2jserver.gameserver.Announcements;
import com.l2jserver.gameserver.ThreadPoolManager;
import com.l2jserver.gameserver.model.L2World;

/**
* @author RobíkBobík - L2PS Team
*/
public class AnnounceOnline
{
static int _fakeOnlinePlayer = Config.FAKE_PLAYERS;

protected static void StartAnnounce()
{
	int OnlinePlayers = L2World.getInstance().getAllPlayersCount();

	if (OnlinePlayers >= 1)
	{
		if (Config.CRITICAL_ONLINE_ANNOUNCE)
		{
			Announcements.getInstance().announceToAll(OnlinePlayers + _fakeOnlinePlayer + " players are online. Have a nice day.", true);
		}
		else
		{
			Announcements.getInstance().announceToAll(OnlinePlayers + _fakeOnlinePlayer + " players are online. Have a nice day.");
		}
	}
}

public static void getInstance()
{
	ThreadPoolManager.getInstance().scheduleGeneralAtFixedRate(new Runnable()
	{
		@Override
		public void run()
		{
			StartAnnounce();
		}
	}, 0, Config.ANNOUNCE_ONLINE_PLAYERS_DELAY * 1000);
}
}

 

Config.java

- edit Config.java

public static int ANNOUNCE_ONLINE_PLAYERS_DELAY;
public static int FAKE_PLAYERS;
public static boolean ALLOW_ANNOUNCE_ONLINE_PLAYERS;
public static boolean CRITICAL_ONLINE_ANNOUNCE;
......
ALLOW_ANNOUNCE_ONLINE_PLAYERS = Boolean.parseBoolean(L2PSModSettings.getProperty("AnnouncePlayers", "False"));
FAKE_PLAYERS = Integer.parseInt(L2PSModSettings.getProperty("FakePlayers", "324"));
ANNOUNCE_ONLINE_PLAYERS_DELAY = Integer.parseInt(L2PSModSettings.getProperty("OnlineInterval", "600"));
CRITICAL_ONLINE_ANNOUNCE = Boolean.parseBoolean(L2PSModSettings.getProperty("CriticalAnnounce", "False"));

  • 2 weeks later...
Posted

1. seriously, why the hell these online shits needed? players nowdays rather watching the online counters than the game content because of these 13 years old kids admins running servers with codes like this... - . - so idiotic logic..

2. if you share something take care these things:

a. coding logic

b. code quality

c. coding standards

 

Just to think a bit.. if you gonna add "Fake Player Amount" don't you mind if one player is on your server and it always prints 101 it will be TOO obviously? You never heard about Rnd.get ?

NEVER EVER start method/variable names with BiggerCase, only CLASS names starting with BiggerCase...

and getInstance() designed to hold Singletons, not ThreadPoolManager... - . -

and well, we usually name method with prefix "start" when we want to start a task or something like it... in your case your getInstance() method should be named as startAnnounce() or startAnnounceTask() and your StartAnnounce() method should be named as simply announce()...

 

Guest
This topic is now closed to further replies.
  • Posts

    • new synchronized movement with neoengine obstacle correction I reported bugs to you and you completely ignored me because of my nationality. Yes, you were arrogant towards me. I sent you many questions on your forum and you didn't even thank me or say anything about it. I stopped using your updates a long time ago and focused on fixing my own aCis because you intentionally break the code. Just buy versions 401 to 409; you intentionally broke a lot of things for "IDIOTS" to buy from you. Anyway, our conversation ends here. Good luck with renaming and organizing; that probably makes you more money than fixing the basics. With this debug I created valid notes for monsters and NPCs, fixing the maxZ that you broke, and also corrected fly/water movements, making them more efficient. I only spent 2 months and I'm using Geoengine l2.j   NOTE: I'm not selling my GeoEngine, don't waste your time sending messages!
    • I'm on that same situation, but hey after almost 3600 commits it's almost playable! 😛
    • Probably due to poor choice of container handling items, you should test other types.   If it's not due to container, it can be whatever method impacting inventory, such as sort/filter/integrity checks. Bad synchronization can also grealty impact performance.   Another thing to check is about packet sending, you should use L2PHX to explore what is actually sent.
    • how do I make it so that you only deal damage to a mob if you have the right items equipped, like jewels, belt, underwear, bracelet, so if you don't have one of those items equipped, you don't deal any damage to the mob thanks
    • I always welcome bug reports and never ban ppl - until proven leaker - not sure where the "arrogant" part comes from, I would like to know what exactly let you think that (quote me please, and not 12y old quotes as the other frog meme dude). I request bug reports to be properly detailed, otherwise it's a waste of time. Other than that, I don't see where I have been arrogant. I got proper discussions with many ppl, not sure why you wouldn't be one of them.   I got 76 bug reports in my list (21 on forums, 55 on gitlab).   I have a single bug report regarding lvl 4 clan quest, which has to be tested since it's not even clear about what is supposed to be broken. Seven Signs was never reworked and is basically L2J based (we got a rework branch to test/commit with reworked AIs). Geoengine got no specific issues (at my knowledge), pathfinding was reworked lately to be way more performant, and I still try to improve performance using some pool system. Movement was partially fixed in latest 410, and probably will get another rework soon (notably reverting to the task wallclock).   "I" surely didn't spend 12y over geoengine - Hasha cared about geoengine during rev 334 / 354 / 390 / 395 and 397. It is solely his work, and always tagged as it. He was rewarded with money for his work, and almost a decade of aCis access.   aCis is a community work, things tagged with Tryskell is my work, the leftover is someone else work. 22 ppl worked as developers in this project over 14 years.   I would gladly accept whatever list of fixes/reports you have to share. You will even be rewarded (you probably know about cookie system), as anyone else sharing bug report or fixes.   My main concerns lately is the lack of decent L2OFF IL data, it is my main bottleneck actually. If you're aware about decent L2OFF data to parse, let me know.   Eventually reach me over Discord to speak, I don't want to continue the offtopic over that help request.
  • Topics

×
×
  • Create New...

Important Information

This community uses essential cookies to function properly. Non-essential cookies and third-party services are used only with your consent. Read our Privacy Policy and We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue..

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock