Jump to content

Recommended Posts

Posted

Hello I want to share code Auto Announce online p.  + fake p. + crit. announce for L2PS

Its based on L2PS source ( https://www.facebook.com/pages/L2jPS-Hi5/410729485662486 )

 

 

Config file:

- insert to custom mods in events folder

# ---------------------------------------------------------------------------
# Auto Announce player with Fake players
# ---------------------------------------------------------------------------
AnnouncePlayers = False
FakePlayers = 256
OnlineInterval = 10
CriticalAnnounce = False

 

Core side:

- inset this code to ...gameserver/

/*
* This program is free software: you can redistribute it and/or modify it under
* the terms of the GNU General Public License as published by the Free Software
* Foundation, either version 3 of the License, or (at your option) any later
* version.
*
* This program is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
* FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
* details.
*
* You should have received a copy of the GNU General Public License along with
* this program. If not, see <http://www.gnu.org/licenses/>.
*/
package com.l2jserver.gameserver;

import com.l2jserver.Config;
import com.l2jserver.gameserver.Announcements;
import com.l2jserver.gameserver.ThreadPoolManager;
import com.l2jserver.gameserver.model.L2World;

/**
* @author RobíkBobík - L2PS Team
*/
public class AnnounceOnline
{
static int _fakeOnlinePlayer = Config.FAKE_PLAYERS;

protected static void StartAnnounce()
{
	int OnlinePlayers = L2World.getInstance().getAllPlayersCount();

	if (OnlinePlayers >= 1)
	{
		if (Config.CRITICAL_ONLINE_ANNOUNCE)
		{
			Announcements.getInstance().announceToAll(OnlinePlayers + _fakeOnlinePlayer + " players are online. Have a nice day.", true);
		}
		else
		{
			Announcements.getInstance().announceToAll(OnlinePlayers + _fakeOnlinePlayer + " players are online. Have a nice day.");
		}
	}
}

public static void getInstance()
{
	ThreadPoolManager.getInstance().scheduleGeneralAtFixedRate(new Runnable()
	{
		@Override
		public void run()
		{
			StartAnnounce();
		}
	}, 0, Config.ANNOUNCE_ONLINE_PLAYERS_DELAY * 1000);
}
}

 

Config.java

- edit Config.java

public static int ANNOUNCE_ONLINE_PLAYERS_DELAY;
public static int FAKE_PLAYERS;
public static boolean ALLOW_ANNOUNCE_ONLINE_PLAYERS;
public static boolean CRITICAL_ONLINE_ANNOUNCE;
......
ALLOW_ANNOUNCE_ONLINE_PLAYERS = Boolean.parseBoolean(L2PSModSettings.getProperty("AnnouncePlayers", "False"));
FAKE_PLAYERS = Integer.parseInt(L2PSModSettings.getProperty("FakePlayers", "324"));
ANNOUNCE_ONLINE_PLAYERS_DELAY = Integer.parseInt(L2PSModSettings.getProperty("OnlineInterval", "600"));
CRITICAL_ONLINE_ANNOUNCE = Boolean.parseBoolean(L2PSModSettings.getProperty("CriticalAnnounce", "False"));

  • 2 weeks later...
Posted

1. seriously, why the hell these online shits needed? players nowdays rather watching the online counters than the game content because of these 13 years old kids admins running servers with codes like this... - . - so idiotic logic..

2. if you share something take care these things:

a. coding logic

b. code quality

c. coding standards

 

Just to think a bit.. if you gonna add "Fake Player Amount" don't you mind if one player is on your server and it always prints 101 it will be TOO obviously? You never heard about Rnd.get ?

NEVER EVER start method/variable names with BiggerCase, only CLASS names starting with BiggerCase...

and getInstance() designed to hold Singletons, not ThreadPoolManager... - . -

and well, we usually name method with prefix "start" when we want to start a task or something like it... in your case your getInstance() method should be named as startAnnounce() or startAnnounceTask() and your StartAnnounce() method should be named as simply announce()...

 

Guest
This topic is now closed to further replies.
×
×
  • Create New...