Code TeamVsTeam for aCis 374

[l2jkain]

Hello, this event I was creating, but I do not know what else to do, I took a lot of it out and there is a lot to be removed, I can not finish it any more, so anyone who wants to finish is a good event...

 

https://pastebin.com/raw/x9GwZugx

Edited April 20, 2018 by l2jkain

[Nightw0lf]

this code is bad in many ways... to many codes written inside, old codes that can be done in one line and its heavy, since you designed it for acis you could at least follow the patterns they provide with the treads and the connections, I didnt see all the code but its if else if else if else if no switch case senarios and bad excersise to for->teams->get players-thread it could be done for players->getTeam-> actions 1 time on a thread if nessasary if you wanted it so much that way

[l2jkain]

5 hours ago, Nightw0lf said:

this code is bad in many ways... to many codes written inside, old codes that can be done in one line and its heavy, since you designed it for acis you could at least follow the patterns they provide with the treads and the connections, I didnt see all the code but its if else if else if else if no switch case senarios and bad excersise to for->teams->get players-thread it could be done for players->getTeam-> actions 1 time on a thread if nessasary if you wanted it so much that way

 

Help me improve, because the only way I found it was that improvement I did not see any useless method it is well written

[Nightw0lf]

2 hours ago, l2jkain said:

 

Help me improve, because the only way I found it was that improvement I did not see any useless method it is well written

start by posting your code in pastebin.com second you can use only 1 thread to run the entire event (or an engine that runs events) you can stop it you can restart it when you want and the rest can be done with simple checks, I would recomment to learn how the treads work and make some test codes to start them stop them see how they work and when they give errors and you might start a small engine out of nothing :)

[l2jkain]

1 hour ago, Nightw0lf said:

start by posting your code in pastebin.com second you can use only 1 thread to run the entire event (or an engine that runs events) you can stop it you can restart it when you want and the rest can be done with simple checks, I would recomment to learn how the treads work and make some test codes to start them stop them see how they work and when they give errors and you might start a small engine out of nothing :)

 

 

yes to much what improves more the location should save correct right in my code there is nothing that of conflict and show this message

 

[Nightw0lf]

3 hours ago, l2jkain said:

 

 

yes to much what improves more the location should save correct right in my code there is nothing that of conflict and show this message

 

try to trace the message to the source check client message ID then trace back into messages and delete it, all red errors is where the message appears thats how you find such errors at least it works for me :D

second you can delete parts of your code and check if error is fixed.

 

Edited April 20, 2018 by Nightw0lf

[l2jkain]

1 hour ago, Nightw0lf said:

try to trace the message to the source check client message ID then trace back into messages and delete it, all red errors is where the message appears thats how you find such errors at least it works for me :D

second you can delete parts of your code and check if error is fixed.

 

 

I managed to fix it I will patch and update the topic.

[l2jkain]

4 hours ago, Nightw0lf said:

try to trace the message to the source check client message ID then trace back into messages and delete it, all red errors is where the message appears thats how you find such errors at least it works for me :D

second you can delete parts of your code and check if error is fixed.

 

 

player.java

 

error generates here

 

@Override
     public void onAction(Player player)
     {
+        // Check if this Player is in an event
+        if (!TeamVsTeam.onAction(player.getName(), getName())) 
+        {
+            player.sendPacket(ActionFailed.STATIC_PACKET);
+            return;
+        }
+        

 

[Nightw0lf]

when player click on a player? is that target protection for friendly fire?

[l2jkain]

9 hours ago, Nightw0lf said:

when player click on a player? is that target protection for friendly fire?

the participants can not attack if it generates this message, more if a nonparticipating player works, not to being able to fix this

 

I'm going to create my engine with this base event of any kind so I'll create ctf and DM based on this

 

https://pastebin.com/raw/ESxADxRV

Edited April 21, 2018 by l2jkain

[melron]

if you could search about the message as nightw0lf said, you could find that the player is in observer mode somehow..

 

if (activeChar.isInObserverMode())
{
	activeChar.sendPacket(SystemMessageId.OBSERVERS_CANNOT_PARTICIPATE);
	activeChar.sendPacket(ActionFailed.STATIC_PACKET);
	return;
}

 

public boolean isInObserverMode()
{
	return !_isInOlympiadMode && !_savedLocation.equals(Location.DUMMY_LOC);
}

 

Try this one:

 

 	public boolean isInObserverMode()
 	{
-		return !_isInOlympiadMode && !_savedLocation.equals(Location.DUMMY_LOC);
+		return !_isInOlympiadMode && !_savedLocation.equals(Location.DUMMY_LOC) && !isInTvTEvent();
 	}
 	
 	public int getTeleMode()

 

Create this new method in order to get the necessary data and check if the player is registered 

 

[Nightw0lf]

it would be best if this work to make it && !isInFunEvent() if you're going to use this to create other events.

[l2jkain]

I'm going to test this

6 hours ago, melron said:

if you could search about the message as nightw0lf said, you could find that the player is in observer mode somehow..

 

if (activeChar.isInObserverMode())
{
	activeChar.sendPacket(SystemMessageId.OBSERVERS_CANNOT_PARTICIPATE);
	activeChar.sendPacket(ActionFailed.STATIC_PACKET);
	return;
}

 

public boolean isInObserverMode()
{
	return !_isInOlympiadMode && !_savedLocation.equals(Location.DUMMY_LOC);
}

 

Try this one:

 

 	public boolean isInObserverMode()
 	{
-		return !_isInOlympiadMode && !_savedLocation.equals(Location.DUMMY_LOC);
+		return !_isInOlympiadMode && !_savedLocation.equals(Location.DUMMY_LOC) && !isInTvTEvent();
 	}
 	
 	public int getTeleMode()

 

Create this new method in order to get the necessary data and check if the player is registered 

 

 

 

Look what I'm creating is getting better and better.

 

https://pastebin.com/xP7NFJv5

 

5 hours ago, Nightw0lf said:

it would be best if this work to make it && !isInFunEvent() if you're going to use this to create other events.

 

Edited April 22, 2018 by l2jkain

[SweeTs]

Pointless to create methods to hide title and add restrictions. Simply don't show / show fake title if player is registered, a short, simple check over charinfo, userinfo is enough.

Didn't read even half of the code, but for sure can be optimized a lot. After all it's an old code with thread sleep. 

[Nightw0lf]

2 hours ago, SweeTs said:

Pointless to create methods to hide title and add restrictions. Simply don't show / show fake title if player is registered, a short, simple check over charinfo, userinfo is enough.

Didn't read even half of the code, but for sure can be optimized a lot. After all it's an old code with thread sleep. 

the efford is what counts, kain userinfo and charinfo are packets you can check them :) and i did too notice that thread sleep xD