Jump to content

TeamVsTeam for aCis 374


Recommended Posts

Hello, this event I was creating, but I do not know what else to do, I took a lot of it out and there is a lot to be removed, I can not finish it any more, so anyone who wants to finish is a good event...

 

https://pastebin.com/raw/x9GwZugx

Edited by l2jkain
Link to comment
Share on other sites

this code is bad in many ways... to many codes written inside, old codes that can be done in one line and its heavy, since you designed it for acis you could at least follow the patterns they provide with the treads and the connections, I didnt see all the code but its if else if else if else if no switch case senarios and bad excersise to for->teams->get players-thread it could be done for players->getTeam-> actions 1 time on a thread if nessasary if you wanted it so much that way

Link to comment
Share on other sites

5 hours ago, Nightw0lf said:

this code is bad in many ways... to many codes written inside, old codes that can be done in one line and its heavy, since you designed it for acis you could at least follow the patterns they provide with the treads and the connections, I didnt see all the code but its if else if else if else if no switch case senarios and bad excersise to for->teams->get players-thread it could be done for players->getTeam-> actions 1 time on a thread if nessasary if you wanted it so much that way

 

Help me improve, because the only way I found it was that improvement I did not see any useless method it is well written

Link to comment
Share on other sites

2 hours ago, l2jkain said:

 

Help me improve, because the only way I found it was that improvement I did not see any useless method it is well written

start by posting your code in pastebin.com second you can use only 1 thread to run the entire event (or an engine that runs events) you can stop it you can restart it when you want and the rest can be done with simple checks, I would recomment to learn how the treads work and make some test codes to start them stop them see how they work and when they give errors and you might start a small engine out of nothing :)

Link to comment
Share on other sites

1 hour ago, Nightw0lf said:

start by posting your code in pastebin.com second you can use only 1 thread to run the entire event (or an engine that runs events) you can stop it you can restart it when you want and the rest can be done with simple checks, I would recomment to learn how the treads work and make some test codes to start them stop them see how they work and when they give errors and you might start a small engine out of nothing :)

 

 

yes to much what improves more the location should save correct right in my code there is nothing that of conflict and show this message

 

plMrr1E.png

Link to comment
Share on other sites

3 hours ago, l2jkain said:

 

 

yes to much what improves more the location should save correct right in my code there is nothing that of conflict and show this message

 

plMrr1E.png

try to trace the message to the source check client message ID then trace back into messages and delete it, all red errors is where the message appears thats how you find such errors at least it works for me :D

second you can delete parts of your code and check if error is fixed.

 

Edited by Nightw0lf
  • Thanks 1
Link to comment
Share on other sites

1 hour ago, Nightw0lf said:

try to trace the message to the source check client message ID then trace back into messages and delete it, all red errors is where the message appears thats how you find such errors at least it works for me :D

second you can delete parts of your code and check if error is fixed.

 

 

I managed to fix it I will patch and update the topic.

Link to comment
Share on other sites

4 hours ago, Nightw0lf said:

try to trace the message to the source check client message ID then trace back into messages and delete it, all red errors is where the message appears thats how you find such errors at least it works for me :D

second you can delete parts of your code and check if error is fixed.

 

 

player.java

 

error generates here

 

@Override
     public void onAction(Player player)
     {
+        // Check if this Player is in an event
+        if (!TeamVsTeam.onAction(player.getName(), getName())) 
+        {
+            player.sendPacket(ActionFailed.STATIC_PACKET);
+            return;
+        }
+        

 

Link to comment
Share on other sites

9 hours ago, Nightw0lf said:

when player click on a player? is that target protection for friendly fire?

the participants can not attack if it generates this message, more if a nonparticipating player works, not to being able to fix this

 

I'm going to create my engine with this base event of any kind so I'll create ctf and DM based on this

 

https://pastebin.com/raw/ESxADxRV

Edited by l2jkain
Link to comment
Share on other sites

if you could search about the message as nightw0lf said, you could find that the player is in observer mode somehow..

 

if (activeChar.isInObserverMode())
{
	activeChar.sendPacket(SystemMessageId.OBSERVERS_CANNOT_PARTICIPATE);
	activeChar.sendPacket(ActionFailed.STATIC_PACKET);
	return;
}

 

public boolean isInObserverMode()
{
	return !_isInOlympiadMode && !_savedLocation.equals(Location.DUMMY_LOC);
}

 

Try this one:

 

 	public boolean isInObserverMode()
 	{
-		return !_isInOlympiadMode && !_savedLocation.equals(Location.DUMMY_LOC);
+		return !_isInOlympiadMode && !_savedLocation.equals(Location.DUMMY_LOC) && !isInTvTEvent();
 	}
 	
 	public int getTeleMode()

 

Create this new method in order to get the necessary data and check if the player is registered 

 

Link to comment
Share on other sites

I'm going to test this

6 hours ago, melron said:

if you could search about the message as nightw0lf said, you could find that the player is in observer mode somehow..

 


if (activeChar.isInObserverMode())
{
	activeChar.sendPacket(SystemMessageId.OBSERVERS_CANNOT_PARTICIPATE);
	activeChar.sendPacket(ActionFailed.STATIC_PACKET);
	return;
}

 


public boolean isInObserverMode()
{
	return !_isInOlympiadMode && !_savedLocation.equals(Location.DUMMY_LOC);
}

 

Try this one:

 


 	public boolean isInObserverMode()
 	{
-		return !_isInOlympiadMode && !_savedLocation.equals(Location.DUMMY_LOC);
+		return !_isInOlympiadMode && !_savedLocation.equals(Location.DUMMY_LOC) && !isInTvTEvent();
 	}
 	
 	public int getTeleMode()

 

Create this new method in order to get the necessary data and check if the player is registered 

 

 

 

Look what I'm creating is getting better and better.

 

https://pastebin.com/xP7NFJv5

 

5 hours ago, Nightw0lf said:

it would be best if this work to make it && !isInFunEvent() if you're going to use this to create other events.

 

Edited by l2jkain
Link to comment
Share on other sites

Pointless to create methods to hide title and add restrictions. Simply don't show / show fake title if player is registered, a short, simple check over charinfo, userinfo is enough.

Didn't read even half of the code, but for sure can be optimized a lot. After all it's an old code with thread sleep. 

  • Sad 1
Link to comment
Share on other sites

2 hours ago, SweeTs said:

Pointless to create methods to hide title and add restrictions. Simply don't show / show fake title if player is registered, a short, simple check over charinfo, userinfo is enough.

Didn't read even half of the code, but for sure can be optimized a lot. After all it's an old code with thread sleep. 

the efford is what counts, kain userinfo and charinfo are packets you can check them :) and i did too notice that thread sleep xD

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Posts

    • Their innovative approach combines cutting-edge technology with expert insights to create resumes that truly stand out. As I explored their website https://skillroads.com/ , I was impressed by the user-friendly interface and the seamless process of using their AI Resume Writer tool. With just a few clicks, I was able to generate a professional resume tailored to my skills and experiences. Skillroads' commitment to excellence and their utilization of AI technology make them a standout choice for anyone looking to enhance their career prospects with a compelling resume.
    • We are giving out promo codes for 3GBs for testing Asocks proxy. All you need to do is post a reply in this thread.
    • Slim X Keto Gummies Slim X Keto Gummies Weight loss is everyone’s hassle those days. Many humans combat with themselves to reduce off their greater weight however couldn’t get a result. This demotivates a number of them and they will lose preference of dropping weight. Overweight reasons many health-associated issues that might create troubles for your ordinary life. If you observed that your every day exercise or a few tablets can also furthermore need to make you shed pounds in a brief fraction of time. Then this isn't always flow that will help you solely. You want to perform a piece detail that is useful for you frame as well. You want to begin following keto fast as possible. It is the super form of  however it can restriction your flavor buds however doesn’t restriction your eating. It allows you to consume however limits to a few form of food. But to cope with keto flu and to offer hundreds of power there’s a supplement.   https://atozsupplement.com/slim-x-keto-gummies/ https://www.facebook.com/slimxketogummies/ https://slimxketogummies.wixsite.com/slim-x-keto-gummies/ https://slim-x-keto-gummies.hp.peraichi.com/ https://slim-x-keto-gummies.jimdosite.com/ https://slim-x-keto-gummies.yolasite.com/ https://slim-x-keto-gummies.company.site/ https://slim-x-keto-gummies.webflow.io/ https://github.com/slim-x-keto-gummies https://slim-x-keto-gummies.tilda.ws/
    • GRAND OPENING  19.04.2024 OPEN BETA TEST  15.04.2024 - 18.04.2024     RATES XP/SP - x3 Adena Drop Chance - x2 Adena Drop Amount - x1 Drop Chance - x2 Drop Amount - x1 Spoil Chance - x2 Spoil Amount - x1 Raidboss Drop Chance - x5 Raidboss Drop Amount - x1 Quest Chance - x1 Quest Reward - x1   FEATURES 1. Added NPC Buffer with basic buffs (duration 60m). 2. Added Mana Drugs and Greater Mana Drugs, which work like Healing Potions. 3. Added skills "Summon Mana Drug" & "Summon Greater Mana Drug" to Elven and Shillen Elders. 4. Basic Mana Drugs can be bought in Grocery Store. 5. Blade Dancer and Sword Singer have both, Dances and Songs from Second Profession. 6. No need duals for dances from Second Profession 7. Increase Weight Limit +30% 8. Increase Inventory Slots from 80 to 120 9. Set Raidboss's respawn 24h +/- 30 minutes. 10. Remake monsters spawns. 11. Olympiad Period - 2 weeks. 12. Change Queen Ant, Core, Orfen, Zaken lvl to 75. 13. Increase Epic Jewelery Bonus. -Ring of Core +2 INT/WIT/MEN -Earring of Orfen +2 STR/DEX/CON     website - https://www.primeinterlude.com  facebook - https://www.facebook.com/profile.php?id=61550083156269 discord - https://discord.gg/2T7nTTz2Gt   Promo Video
  • Topics

×
×
  • Create New...