Help Skills Bug Fixes

[tiguz]

Hello! I would like to get some help on how to fix some skills like Sonic Buster and Force Burst. If I target myself and press crtl, I can hit myself directly to HP, avoiding CP. With Force Burst Tyrants can use this bug to Pre-zealot in Olympiad. 

 

Im not sure what should be changed and where!

 

Thank you in advance!

 

Edit: I use L2JFrozen 1118

Edited April 20, 2017 by tiguz

[tiguz]

Something like that will be more stable 

if (this instanceof L2PcInstance)
{
	L2PcInstance player = (L2PcInstance) this;
	if (player.getTarget() != null && player.getTarget() == player)
	if (skill.getSkillType() == SkillType.CHARGEDAM)
	{
		player.sendMessage("message");
		return;
	}	
}

but if you just wanted these 2 then nvm its working ;)

Im testing other skills as well. Any help is very welcome. What you mean by more stable? If I needed to fix various skills this method will be better? 

I will compile your version and test, and return here. Im not sure if all CHARGEDAM skills should be blocked from self target.  For example, Force Barrier ( celestial shield) is "autobuff", So I can use it even if I have other char target. Also, Its not blocked from usage if I have my own target. It this skill is CHARGEDAM the player wont be alloed to use it if he has his own target, which might be a problem when in PVP.

 

Anyway, I will compile your code and test it. brb!

[Solomun]

If you are afraid of a NullPointerException in trgt variable, (i didn't add the statement because without target, cast doesn't even start) you can edit it..

 

 

 

if (this instanceof L2PcInstance) {
   L2PcInstance pl = (L2PcInstance) this;
if (pl.getTarget() != null){
  if (pl.getTarget() instanceof L2PcInstance) {
   L2PcInstance trgt = (L2PcInstance) pl.getTarget();
   if (trgt == pl) //Player targets himself
   {
    int skill_id = skill.getId();
    switch (skill_id) {
    case 9://Sonic Buster
    case 17://Force Burst
     sendPacket(ActionFailed.STATIC_PACKET);
     return false;
    default:
     break;
    }
   }
  }
}
  }

 

 

[melron]

Im testing other skills as well. Any help is very welcome. What you mean by more stable? If I needed to fix various skills this method will be better? 

I will compile your version and test, and return here. Im not sure if all CHARGEDAM skills should be blocked from self target.  For example, Force Barrier ( celestial shield) is "autobuff", So I can use it even if I have other char target. Also, Its not blocked from usage if I have my own target. It this skill is CHARGEDAM the player wont be alloed to use it if he has his own target, which might be a problem when in PVP.

 

Anyway, I will compile your code and test it. brb!

CHARGEDAM its skilltype. You can take a look in your skills xml . search for this

<set name="skillType" val="CHARGEDAM"/>

celestial shield etc, its BUFF type so you will not have problems... To be honest i didnt checked all the skills with type CHARGEDAM but i believe there isnt any issue in this case..

TSS DSS etc skills have this type so u will be fine. 

But again , if u just want only 2 skills dont add my code use solomuns

[tiguz]

Thank you guys! Both codes worked! =D