Jump to content

Question

Posted (edited)

Edit : I add one new vote Autovotereward and i have some errors.  L2jserver high five last version 

errors : http://prnt.sc/afihhb

 

Code : 

package com.l2jserver.gameserver.instancemanager;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.net.URL;
import java.net.URLConnection;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.logging.Level;
import java.util.logging.Logger;

import com.l2jserver.Config;
import com.l2jserver.L2DatabaseFactory;
import com.l2jserver.gameserver.ThreadPoolManager;
import com.l2jserver.gameserver.model.L2World;
import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;
import com.l2jserver.gameserver.model.items.instance.L2ItemInstance;
import com.l2jserver.gameserver.network.clientpackets.Say2;
import com.l2jserver.gameserver.network.serverpackets.CreatureSay;
import com.l2jserver.gameserver.util.Broadcast;

public class AutoVoteRewardHandler
{
   private static Logger _log = Logger.getLogger(AutoVoteRewardHandler.class.getName());
   
   private static final int initialCheck = 1 * 1000;
   private static final int delayForCheck = Config.DELAY_FOR_NEXT_REWARD * 1000;
   
   private static int lastVoteCount = 0;
   
   @SuppressWarnings("synthetic-access")
   private AutoVoteRewardHandler()
   {
      _log.info("Vote Reward System: Vote reward system initiated.");
      if (Config.VOTE_REWARD_ENABLE)
      {
         load();
      }
      ThreadPoolManager.getInstance().scheduleGeneralAtFixedRate(new AutoReward(), initialCheck, delayForCheck);
   }
   
   private class AutoReward implements Runnable
   {
      @SuppressWarnings(
      {
         "null",
         "synthetic-access"
      })
      @Override
      public void run()
      {
         int votes = getVotes(Config.VOTE_HTML_PATCH);
         System.out.println("Server Votes: " + votes);
         if ((votes != 0) && (getLastVoteCount() != 0) && (votes >= (getLastVoteCount() + Config.VOTES_FOR_REWARD)))
         {
            Connection con = null;
            try
            {
               con = L2DatabaseFactory.getInstance().getConnection();
               PreparedStatement statement = con.prepareStatement("SELECT c.charId, c.char_name FROM characters AS c LEFT JOIN loginserver.accounts AS a ON c.account_name = a.login WHERE c.online > 0 GROUP BY a.lastIP ORDER BY c.level DESC");
               ResultSet rset = statement.executeQuery();
               L2PcInstance player = null;
               L2ItemInstance item = null;
               L2ItemInstance item2 = null;
               while (rset.next())
               {
                  player = L2World.getInstance().getPlayer(rset.getInt("charId"));
                  if ((player != null) && !player.getClient().isDetached())
                  {
                     item = player.getInventory().getItemByItemId(Config.VOTE_REWARD1_ID);
                     if ((item == null) || (item.getCount() < Config.MAX_REWARD_COUNT_FOR_STACK_ITEM1))
                     {
                        player.addItem("reward", Config.VOTE_REWARD1_ID, Config.VOTE_REWARD1_COUNT, player, true);
                     }
                     item2 = player.getInventory().getItemByItemId(Config.VOTE_REWARD1_ID);
                     
                     if ((item2 == null) || (item2.getCount() < Config.MAX_REWARD_COUNT_FOR_STACK_ITEM1))
                     {
                        player.addItem("reward", Config.VOTE_REWARD2_ID, Config.VOTE_REWARD2_COUNT, player, true);
                     }
                  }
               }
               setLastVoteCount(getLastVoteCount() + Config.VOTES_FOR_REWARD);
               statement.close();
               _log.info("Vote Reward System: Reward for votes now!");
               Broadcast.toAllOnlinePlayers(new CreatureSay(1, Say2.CRITICAL_ANNOUNCE, "", "Vote Manager: Reward for players! Thanks for Vote."));
            }
            catch (SQLException e)
            {
               e.printStackTrace();
            }
            finally
            {
               try
               {
                  con.close();
               }
               catch (SQLException e)
               {
                  // TODO Auto-generated catch block
                  e.printStackTrace();
               }
            }
            
            setLastVoteCount(getLastVoteCount() + Config.VOTES_FOR_REWARD);
         }
         Broadcast.toAllOnlinePlayers(new CreatureSay(1, Say2.CRITICAL_ANNOUNCE, "", "Vote Manager: Server votes: " + votes + " | Next Reward on " + (getLastVoteCount() + Config.VOTES_FOR_REWARD) + " Votes."));
         if (getLastVoteCount() == 0)
         {
            setLastVoteCount(votes);
         }
      }
   }
   
   @SuppressWarnings("null")
   private int getVotes(String urlString)
   {
      URL url = null;
      InputStreamReader isr = null;
      BufferedReader in = null;
      try
      {
         url = new URL(urlString);
         URLConnection connection = url.openConnection();
         connection.setRequestProperty("User-Agent", "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20100101 Firefox/10.0.2");
         connection.connect();
         InputStream response = connection.getInputStream();
         isr = new InputStreamReader(response);
         in = new BufferedReader(isr);
         String inputLine;
         while ((inputLine = in.readLine()) != null)
         {
            if (Config.VOTE_REWARD_TOPZONE_ENABLE)
            {
               // for TopZone
               if (inputLine.contains("<div class=\"rank\"><div class=\"votes2\">Votes:<br>"))
               {
                  return Integer.valueOf(inputLine.split(">")[5].replace("</font", ""));
               }
            }
            if (Config.VOTE_REWARD_HOPZONE_ENABLE)
            {
               // for HopZone
               if (inputLine.contains("no steal make love") || inputLine.contains("no votes here") || inputLine.contains("bang, you don't have votes") || inputLine.contains("la vita e bella"))
               {
                  @SuppressWarnings("unused")
                  int Sub = 12;
                  switch (inputLine.length())
                  {
                     case 116:
                        Sub = 13;
                        break;
                     case 117:
                        Sub = 14;
                        break;
                     case 118:
                        Sub = 15;
                        break;
                     case 119:
                        Sub = 16;
                        break;
                  }
                  return Integer.valueOf(inputLine.split(">")[2].replace("</span", ""));
               }
            }
         }
      }
      catch (IOException e)
      {
         _log.warning("Vote Reward System: " + e);
      }
      finally
      {
         try
         {
            in.close();
         }
         catch (IOException e)
         {
         }
         try
         {
            isr.close();
         }
         catch (IOException e)
         {
         }
      }
      return 0;
   }
   
   private void setLastVoteCount(int voteCount)
   {
      lastVoteCount = voteCount;
   }
   
   private int getLastVoteCount()
   {
      return lastVoteCount;
   }
   
   @SuppressWarnings("null")
   private void load()
   {
      int votes = 0;
      Connection con = null;
      try
      {
         con = L2DatabaseFactory.getInstance().getConnection();
         PreparedStatement statement = con.prepareStatement("SELECT vote FROM votes LIMIT 1");
         ResultSet rset = statement.executeQuery();
         
         while (rset.next())
         {
            votes = rset.getInt("vote");
         }
         rset.close();
         statement.close();
      }
      catch (Exception e)
      {
         _log.log(Level.WARNING, "data error on vote: ", e);
      }
      finally
      {
         try
         {
            con.close();
         }
         catch (SQLException e)
         {
            // TODO Auto-generated catch block
            e.printStackTrace();
         }
      }
      
      setLastVoteCount(votes);
   }
   
   @SuppressWarnings("null")
   public void save()
   {
      Connection con = null;
      try
      {
         con = L2DatabaseFactory.getInstance().getConnection();
         PreparedStatement statement = con.prepareStatement("UPDATE votes SET vote = ? WHERE id=1");
         statement.setInt(1, getLastVoteCount());
         statement.execute();
         statement.close();
      }
      catch (Exception e)
      {
         _log.log(Level.WARNING, "data error on vote: ", e);
      }
      finally
      {
         try
         {
            con.close();
         }
         catch (SQLException e)
         {
            // TODO Auto-generated catch block
            e.printStackTrace();
         }
      }
   }
   
   public static AutoVoteRewardHandler getInstance()
   {
      return SingletonHolder._instance;
   }
   
   @SuppressWarnings("synthetic-access")
   private static class SingletonHolder
   {
      protected static final AutoVoteRewardHandler _instance = new AutoVoteRewardHandler();
   }
}
Edited by kris131

Recommended Posts

  • 0
Posted (edited)

Welcome to null-land.

@SuppressWarnings("null")

Drop this code, entirely. Find something bettter.

Edited by SweeTs
  • 0
Posted

Fix errors then. Basically you can even use frozen code for that. At least you will not see null crap.

  • 0
Posted

L2jfrozen hard to adapt to high five too mutch files missing need to improvising and why null is bad where is the problem? (just for know)

  • 0
Posted (edited)

Nothing is missing, just few methods are another/renamed. null - to suppress warnings relative to null analysis. You hide issues related to your code. Remove them and fix errors/warnings.

Edited by SweeTs
  • 0
Posted

L2jfrozen hard to adapt to high five too mutch files missing need to improvising and why null is bad where is the problem? (just for know)

 

Null is bad because it creates issues, notably NPE like you show on your screen... Leading to code not working properly, as it stops to run when a NPE is found and not catched.

 

It's like if you asked why an headache is bad for your head...

  • 0
Posted (edited)

Edit : Look i remove the @SuppressWarnings("null") and i see error on in.close con.close isr.close

i fix but i dont know if again is the same.

Old :
finally{
try
{
con.close();
}
 
New : 
finally
{
try
{
if (con != null)
{
con.close();
}
Edited by kris131
  • 0
Posted (edited)

Use try-with-ressources to avoid any memory leak. It avoids those ugly finally statements, and you don't have to care about closing the ressource too. Your project must support JDK 1.7 from memory.

 

https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html

Edited by Tryskell
  • 0
Posted (edited)

Hmm check it its fine ? bcs have some errors for fix 

package com.l2jserver.gameserver.instancemanager;
    
import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.net.URL;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.logging.Level;
import java.util.logging.Logger;

import com.l2jserver.Config;
import com.l2jserver.L2DatabaseFactory;
import com.l2jserver.gameserver.ThreadPoolManager;
import com.l2jserver.gameserver.model.L2World;
import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;
import com.l2jserver.gameserver.model.items.instance.L2ItemInstance;
import com.l2jserver.gameserver.network.clientpackets.Say2;
import com.l2jserver.gameserver.network.serverpackets.CreatureSay;
import com.l2jserver.gameserver.util.Broadcast;
    
public class AutoVoteRewardHandler
{
  private static Logger _log = Logger.getLogger(AutoVoteRewardHandler.class.getName());
  
  private static final int initialCheck  = 1 * 1000;
  private static final int delayForCheck = Config.DELAY_FOR_NEXT_REWARD * 1000;

  private static int lastVoteCount = 0;
      
  private AutoVoteRewardHandler()
  {
      _log.info("Vote Reward System: Vote reward system initiated.");
      if (Config.VOTE_REWARD_ENABLE)
          load();
      ThreadPoolManager.getInstance().scheduleGeneralAtFixedRate(new AutoReward(), initialCheck, delayForCheck);
  }
      
  private class AutoReward implements Runnable
	{
		@Override
		public void run()
		{
			int votes = getVotes(Config.VOTE_HTML_PATCH);
			System.out.println("Server Votes: " + votes);
			if (votes != 0 && getLastVoteCount() != 0 && votes >= getLastVoteCount() + Config.VOTES_FOR_REWARD)
			{
				Connection con = null;
				try
				{
					con = L2DatabaseFactory.getInstance().getConnection();
					PreparedStatement statement = con.prepareStatement("SELECT c.charId, c.char_name FROM characters AS c LEFT JOIN accounts AS a ON c.account_name = a.login WHERE c.online > 0 GROUP BY a.lastIP ORDER BY c.level DESC");
					ResultSet rset = statement.executeQuery();
					L2PcInstance player = null;
					L2ItemInstance item = null;
					L2ItemInstance item2 = null;
					while (rset.next())
					{
						player = L2World.getInstance().getPlayer(rset.getInt("charId"));
						if (player != null && !player.getClient().isDetached())
						{
								item = player.getInventory().getItemByItemId(Config.VOTE_REWARD1_ID);
								if (item == null || item.getCount() < Config.MAX_REWARD_COUNT_FOR_STACK_ITEM1)
									player.addItem("reward", Config.VOTE_REWARD1_ID, Config.VOTE_REWARD1_COUNT, player, true);
								item2 = player.getInventory().getItemByItemId(Config.VOTE_REWARD1_ID);
						
								if (item2 == null || item2.getCount() < Config.MAX_REWARD_COUNT_FOR_STACK_ITEM1)
									player.addItem("reward", Config.VOTE_REWARD2_ID, Config.VOTE_REWARD2_COUNT, player, true);
						}
					}
					setLastVoteCount(getLastVoteCount() + Config.VOTES_FOR_REWARD);
					statement.close();
					_log.info("Vote Reward System: Reward for votes now!");
	            Broadcast.toAllOnlinePlayers(new CreatureSay(1, Say2.CRITICAL_ANNOUNCE, "", "Vote Manager: Reward for players! Thanks for Vote."));
	}
		catch (SQLException e)
			{
				e.printStackTrace();
				}
				finally
				{
					L2DatabaseFactory.close(con);
				}
				
				setLastVoteCount(getLastVoteCount() + Config.VOTES_FOR_REWARD);
			}
			Broadcast.toAllOnlinePlayers(new CreatureSay(1, Say2.CRITICAL_ANNOUNCE, "", "Vote Manager: Server votes: " + votes + " | Next Reward on " + (getLastVoteCount() + Config.VOTES_FOR_REWARD) + " Votes."));
		if (getLastVoteCount() == 0)
				setLastVoteCount(votes);
		}
	}
      
  private int getVotes(String urlString)
  {
      URL url = null;
      InputStreamReader isr = null;
      BufferedReader in = null;
      try
      {
          url = new URL(urlString);
          isr = new InputStreamReader(url.openStream());
          in = new BufferedReader(isr);
          String inputLine;
          while ((inputLine = in.readLine()) != null)
          {
        	  if (Config.VOTE_REWARD_TOPZONE_ENABLE)
        	  {
        		  // for TopZone
        		  if (inputLine.contains("<tr><td><div align=\"center\"><b><font style=\"font-size:14px;color:#018BC1;\""))
        		  {
       			  return Integer.valueOf(inputLine.split(">")[5].replace("</font", ""));
        		  }
        	  }
        	  if (Config.VOTE_REWARD_HOPZONE_ENABLE)
        	  {
        		  // for HopZone
        		  if (inputLine.contains("rank anonymous tooltip"))
        		  {
        			  @SuppressWarnings("unused")
        			  int Sub = 12;
        			  switch (inputLine.length())
        			  {
        				  case 116:
        					  Sub = 13; 
        					  break;
        				  case 117:
        					  Sub = 14; 
        					  break;
        				  case 118:
        					  Sub = 15;
        					  break;
        				  case 119:
        					  Sub = 16; 
        					  break;
        			  }
        			  return Integer.valueOf(inputLine.split(">")[2].replace("</span", ""));
        		  }
              }
          }
      }
      catch (IOException e)
      {
          _log.warning("Vote Reward System: "+e);
      }
      finally
     {
          try
          {
              in.close();
          }
          catch (IOException e)
          {}
          try
          {
              isr.close();
          }
          catch (IOException e)
          {}
      }
      return 0;
  }
      
  private void setLastVoteCount(int voteCount)
  {
      lastVoteCount = voteCount;
  }
      
  private int getLastVoteCount()
  {
      return lastVoteCount;
  }
  
  private void load()
  {
      int votes = 0;
      Connection con = null;
      try
      {
          con = L2DatabaseFactory.getInstance().getConnection();
          PreparedStatement statement = con.prepareStatement("SELECT vote FROM votes LIMIT 1");
          ResultSet rset = statement.executeQuery();

          while (rset.next())
          {
              votes = rset.getInt("vote");
          }
          rset.close();
          statement.close();
      }
      catch (Exception e)
      {
          _log.log(Level.WARNING, "data error on vote: ", e);
      }
      finally
      {
          L2DatabaseFactory.close(con);
      }
      
      setLastVoteCount(votes);
  }
  
  public void save()
  {
      Connection con = null;
      try
      {
          con = L2DatabaseFactory.getInstance().getConnection();
          PreparedStatement statement = con.prepareStatement("UPDATE votes SET vote = ? WHERE id=1");
          statement.setInt(1, getLastVoteCount());
          statement.execute();
          statement.close();
      }
      catch (Exception e)
      {
          _log.log(Level.WARNING, "data error on vote: ", e);
      }
      finally
      {
          L2DatabaseFactory.close(con);
      }
  }
  
  public static AutoVoteRewardHandler getInstance()
  {
      return SingletonHolder._instance;
  }
      
  @SuppressWarnings("synthetic-access")
  private static class SingletonHolder
  {
      protected static final AutoVoteRewardHandler _instance = new AutoVoteRewardHandler();
  }
}
Edited by kris131
  • 0
Posted (edited)

Lock it error fixed

 

Dont try that code who i asked for help its just fail ;) Find one acis and fix error 

Edited by kris131
Guest
This topic is now closed to further replies.


  • Posts

    • Server is Online – 1,000+ Active Players! We’re excited to announce the addition of a Europe Proxy to improve connectivity for our EU players! Clans can now benefit from VIP Access to help you catch up faster. 🎯 If you're a clan leader with at least 9 active members, join our Discord and open a ticket to claim your VIP rewards!  
    • The Telegram team is rolling out a new batch of Stars-only gifts you’ll be able to mint as NFTs. Don’t miss your chance to join the next Telegram trend and earn from it! Buy Telegram Stars cheap and KYC-free 1 Star from $0.0149 (min. 50 Stars, bulk discounts available) Promo code STARS5 — 5 % off Pay any way you like: bank cards · crypto · other popular methods How to purchase: ➡Online Store — Click ➡ Telegram bot — Click Other services: ➡ SMM panel — Click Regular buyers get extra discounts and promo codes. Support: ➡ Telegram: https://t.me/solomon_bog ➡ Telegram channel: https://t.me/accsforyou_shop ➡ Discord: https://discord.gg/y9AStFFsrh ➡ WhatsApp: https://wa.me/79051904467 ➡ Email: solomonbog@socnet.store Use these contacts to discuss wholesale orders, partnerships (current list: https://socnet.bgng.io/partners) or to become a supplier. SocNet — your shop for digital goods and premium subscriptions
    • The Telegram team is rolling out a new batch of Stars-only gifts you’ll be able to mint as NFTs. Don’t miss your chance to join the next Telegram trend and earn from it! Buy Telegram Stars cheap and KYC-free 1 Star from $0.0149 (min. 50 Stars, bulk discounts available) Promo code STARS5 — 5 % off Pay any way you like: bank cards · crypto · other popular methods How to purchase: ➡Online Store — Click ➡ Telegram bot — Click Other services: ➡ SMM panel — Click Regular buyers get extra discounts and promo codes. Support: ➡ Telegram: https://t.me/solomon_bog ➡ Telegram channel: https://t.me/accsforyou_shop ➡ Discord: https://discord.gg/y9AStFFsrh ➡ WhatsApp: https://wa.me/79051904467 ➡ Email: solomonbog@socnet.store Use these contacts to discuss wholesale orders, partnerships (current list: https://socnet.bgng.io/partners) or to become a supplier. SocNet — your shop for digital goods and premium subscriptions
    • 📜 • Mass PVP – Craft – Progressive Server (ITEMS, ARMOR, WEAPONS, ETC) 🕹️ • Chronicles: Lineage 2 - Interlude (C6) 🛠️ • Retail status 🕒 • Server Time: GMT -3 🏙️ • Main Town: Giran ✨ • Teleportation for all Towns, Gk Global 🛡️ • NPC BUFFER - GMSHOP B-GRADE - DONATION SHOP - AUCTION MANAGER 🐉 • Epic Bosses: Chaotic Zones 🔁 • Protection respawn: 15 seconds ⏰ • Restart Server: 05:00 AM Today 💸 • RTM allowed between players (ask Staff if in doubt) 📊 SERVER RATES: • EXP: x8 • SP: x10 • Adena: x3 • Seal Stone: x3 • Drop: x3 • Spoil: x5 • Raid EXP/SP/Drop: x3 • Premium Rates: x2 🌐 Website: https://www.l2roosters.com 💬 Discord: https://discord.gg/cUyYXrfy 🔥 Join us now and forge your legacy at Roosters Gaming!
    • Hello, lovely people, how are you? I just finished compiling the L2jFrozen project Rev: 1132 (very old). I don't mind it being too old, since the project is for me and my children. (LAN/Offline) it's not meant to be put online. I want to learn and give my children more comfort when playing. And for my part, I also experiment with the game. My problem is that I don't know much about the subject. I was able to make some basic configurations to my liking and that of my children, but it never compiles or anything like that... I would really need help from you, the community... I simply want to remove all subclass restrictions, remove the restriction on "Overlord, Warsmith, and Dark Elf subclasses with White Elves and vice versa." Thank you very much in advance! Greetings, community.
  • Topics

×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock