he actually must admit(but he wont) that he's wrong, I am right (there are alot of examples on google with better handle) and aCis lucks of a good SQL connection management actually its half code done in try-with-resources and plus a better DatabaseFactory management can be achieved as I prementioned with changing c3p0 jar, the aCis guys can make their tests and see what I am talking about.

I won't edit c3p0 for a custom crap while you got other efficient db poolers running around (boneCP, hikariCP, etc).

 

The point is no one will try and test those poolers because no one knows how to properly test it. See L2JFrozen tried to move to boneCP, it ended by a total revert as they couldn't figure which values to set.

 

Gimme good values for X, XX and XXX and XXXX players and I will commit it without doubt (with a performance test before/after) ;p.

 

I got other things to rework before trying to crash the db due to new system. But up to you to test and share results of your experiments.

 

Regarding PreparedStatement, it's still using close but as I don't rely on an external method, class or even Jar (like that CloseUtil.) I didn't see the use to edit it. Finally some queries still got "crafted" PreparedStatement, I prefered to keep a single writing style over the whole project.

 

-----------

 

Regarding the OP question, the shutdown process has to be reworked. If it's not that, it's one of the queries used by the Shutdown process methods.

Edited May 11, 201511 yr by Tryskell

close this topic please only spam here 0 help

Ofc, if you expect reworked code then yeah, it is a spam. Locked.