Help Help With This Piece Of Code Please

[b0rto]

hello maxcheaters i added a piece of code that i found here:  http://www.maxcheaters.com/topic/171501-helprandom-spawns/ for random respawns after death, all seems work fine but when i tested in my server only get the first random spawn config, if someone can give me a hand I will be grateful, because i have death my mind xD

 

here the code requestrestartpoint.java:

			case 27: // to jail
				if (!activeChar.isInJail()) return;
				loc = new Location(-114356, -249645, -2984);
				break;
				
			default:
				
				if(activeChar.isInsideZone((byte) 23) && Config.CUSTOM_RANDOM_RESPAWN_AFTER_DEATH)
					
				    loc = new Location(getRandomArray()[0], getRandomArray()[1], getRandomArray()[2]);
					else
					loc = MapRegionManager.getInstance().getTeleToLocation(activeChar, MapRegionManager.TeleportWhereType.Town);
				break;
		}
		// Teleport and revive
		activeChar.setInstanceId(instanceId);
		activeChar.setIsIn7sDungeon(false);
		activeChar.setIsPendingRevive(true);
		activeChar.teleToLocation(loc, true);

	}
	private static int[][] RANDOM_LOCATIONS =
	{
		{Config.LOCATIONX,Config.LOCATIONY,Config.LOCATIONZ},
		{Config.LOCATION2X,Config.LOCATION2Y,Config.LOCATION2Z},
		{Config.LOCATION3X,Config.LOCATION3Y,Config.LOCATION3Z},
		{Config.LOCATION4X,Config.LOCATION4Y,Config.LOCATION4Z},
		{Config.LOCATION5X,Config.LOCATION5Y,Config.LOCATION5Z},
		{Config.LOCATION6X,Config.LOCATION6Y,Config.LOCATION6Z}
	};
	
	public static int[] getRandomArray()
	{

		return RANDOM_LOCATIONS[Rnd.get(RANDOM_LOCATIONS.length)];

	}

i try to fix it with this line but my eclipse says unreachable code and no solutions availables:

return RANDOM_LOCATIONS[Rnd.get(1, 6)];

thanks in advance.

Edited February 20, 2015 by b0rto

[Klay]

return RANDOM_LOCATIONS[Rnd.get(6)];

 

try this

[StealthyS4m]

I believe this line

return RANDOM_LOCATIONS[Rnd.get(1, 6)]

doesn't work because you are generating random from 1 to 6(1,2,3,4,5,6) and while array is counted from zero (0,1,2,3,4,5  --  6Elements).

[b0rto]

hello thanks for answer me this line dont work for my eclipse, says unreachable code:

 

return RANDOM_LOCATIONS[Rnd.get(6)];

 

also i try with this line and eclipse accept it but anyway random respawns dont work :/

 

return RANDOM_LOCATIONS[Rnd.get(0, 5)];

 

if someone know where is the problem..because always get the first random respawn filled in configs, thanks in advance.

 

 

[Tryskell]

Instead of int[][], use Location[]. It will save you time, will shortcut the code and actually will fix an issue you got with your current code (atm you are randomizing THREE TIMES to get one location, one time for X, another for Y and last for Z).

private static Location[] RANDOM_LOCATIONS =
{
	new Location(Config.LOCATIONX,Config.LOCATIONY,Config.LOCATIONZ),
	blablabla
};
	
public static Location getRandomLocation()
{
	return RANDOM_LOCATIONS[Rnd.get(RANDOM_LOCATIONS.length)];
} 

And finally

loc = getRandomLocation();