Jump to content
MaxCheaters Official Group at Discord
--> Place your ad text here <--

No Heal and Buffs at Monsters and Raids

xdem

By xdem
in Server Shares & Files [L2J]

 Share

Recommended Posts

xdem Proficient

xdem

Posted
Posted

This simple code will stop players from healing or buffing monsters and raids

Go at network/clientpackets/RequestMagicSkillUse

	// Check the validity of the skill
	if (skill != null)
	{
		+if (activeChar.getTarget() instanceof L2MonsterInstance)
		+{
		+	switch (skill.getSkillType())
		+	{
		+		case HEAL:
		+		case HEAL_PERCENT:
		+		case BUFF:
		+		{
		+			if (skill.getTargetType()==L2TargetType.TARGET_ONE)
		+			{
		+				return;
		+			}
		+		}
		+	}
		+}
		if ((activeChar.isTransformed() || activeChar.isInStance()) && !activeChar.containsAllowedTransformSkill(skill.getId()))

 

Credits me, thanks for your reports guys, all fixed!

for those with the previus version I recomend change asap

Link to comment
Share on other sites
Setekh Apprentice

Setekh

Posted
Posted

small note.

 

You don't do this:

		+		case HEAL:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case HEAL_PERCENT:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case CHAIN_HEAL:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case BUFF:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;

 

You do

		+		case HEAL:
		+		case HEAL_PERCENT:
		+		case CHAIN_HEAL:
		+		case BUFF:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;

Cases collapse and run till u tell them to break;

Also it would of been best/safer, if you did it in the Heal skill handler.

Link to comment
Share on other sites
xdem Proficient

xdem

Posted
  • Author
Posted

small note.

 

You don't do this:

		+		case HEAL:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case HEAL_PERCENT:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case CHAIN_HEAL:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case BUFF:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;

 

You do

		+		case HEAL:
		+		case HEAL_PERCENT:
		+		case CHAIN_HEAL:
		+		case BUFF:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;

Cases collapse and run till u tell them to break;

Also it would of been best/safer, if you did it in the Heal skill handler.

thanks for the info, updated

Link to comment
Share on other sites
Napster321 Newbie

Napster321

Posted
Posted

small note.

 

You don't do this:

		+		case HEAL:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case HEAL_PERCENT:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case CHAIN_HEAL:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;
		+		case BUFF:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;

 

You do

		+		case HEAL:
		+		case HEAL_PERCENT:
		+		case CHAIN_HEAL:
		+		case BUFF:
		+			activeChar.sendPacket(ActionFailed.STATIC_PACKET);
		+			return;

Cases collapse and run till u tell them to break;

Also it would of been best/safer, if you did it in the Heal skill handler.

as you had told me to add these exceptions in skillhandlers didn't work...so it's pointless to add that to skillhandlers :)
Link to comment
Share on other sites
vampir Apprentice

vampir

Posted
Posted

also

from this:

if (activeChar.getTarget() instanceof L2RaidBossInstance || activeChar.getTarget() instanceof L2GrandBossInstance || activeChar.getTarget() instanceof L2MonsterInstance)

you can do this:

if (activeChar.getTarget() instanceof L2MonsterInstance)

because as far as i know, L2RaidBossInstance and L2GrandBossInstance are extending L2MonsterInstance

Link to comment
Share on other sites
xdem Proficient

xdem

Posted
  • Author
Posted

also

from this:

if (activeChar.getTarget() instanceof L2RaidBossInstance || activeChar.getTarget() instanceof L2GrandBossInstance || activeChar.getTarget() instanceof L2MonsterInstance)

you can do this:

if (activeChar.getTarget() instanceof L2MonsterInstance)

because as far as i know, L2RaidBossInstance and L2GrandBossInstance are extending L2MonsterInstance

 

I thougth it too, but never tested it, because L2MonsterInstance Extends L2Npc I think, its a little complicated, I will test

Link to comment
Share on other sites
lame69 Newbie

lame69

Posted
Posted

I thougth it too, but never tested it, because L2MonsterInstance Extends L2Npc I think, its a little complicated, I will test

After alot of tests today(becouse i like your idea)

When u get target raidboss/grandraid/monster:

u cant use group heal/chain heal/prayer/servitor heal/AI and alot of buffs which are self...

if you drop chain heal/Buff and MonsterInstance this system will be perfect for raids/epics,big deal that someone will buff him with might or shield,and only group heal and few other skills on target will not work normal.(this is my opinion ofc)

Link to comment
Share on other sites
xdem Proficient

xdem

Posted
  • Author
Posted

After alot of tests today(becouse i like your idea)

When u get target raidboss/grandraid/monster:

u cant use group heal/chain heal/prayer/servitor heal/AI and alot of buffs which are self...

if you drop chain heal/Buff and MonsterInstance this system will be perfect for raids/epics,big deal that someone will buff him with might or shield,and only group heal and few other skills on target will not work normal.(this is my opinion ofc)

 

Your report is usefull for me and now I will go fix it, im pretty sure I will solve this bug too, the servitor heal yes its a bug on witch im gonna work on now, but the healer(who is there to use heal and mass heals) is not the one who is supposed to target the monster, but still yes this makes the code faulty and buggy so Im gonna spend more time on this

 

PS I will only fix: SelfBuffs, SelfHeals and any other skill that casts without target

Link to comment
Share on other sites
Trance Experienced

Trance

Posted
Posted

After alot of tests today(becouse i like your idea)

When u get target raidboss/grandraid/monster:

u cant use group heal/chain heal/prayer/servitor heal/AI and alot of buffs which are self...

if you drop chain heal/Buff and MonsterInstance this system will be perfect for raids/epics,big deal that someone will buff him with might or shield,and only group heal and few other skills on target will not work normal.(this is my opinion ofc)

 

Index: java/net/sf/l2j/gameserver/network/clientpackets/RequestMagicSkillUse.java
===================================================================
--- java/net/sf/l2j/gameserver/network/clientpackets/RequestMagicSkillUse.java	(revision 2)
+++ java/net/sf/l2j/gameserver/network/clientpackets/RequestMagicSkillUse.java	(working copy)
@@ -17,7 +17,10 @@
import net.sf.l2j.gameserver.datatables.SkillTable;
import net.sf.l2j.gameserver.model.L2Skill;
+import net.sf.l2j.gameserver.model.actor.instance.L2MonsterInstance;
import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
import net.sf.l2j.gameserver.network.serverpackets.ActionFailed;
@@ -69,6 +72,19 @@
			if (skill.isToggle() && activeChar.isMounted())
				return;

+			if (activeChar.getTarget() instanceof L2MonsterInstance)
+			{
+				switch (skill.getSkillType())
+				{
+					case BUFF:
+						return;
+					case HEAL:
+						return;
+					case HEAL_PERCENT:
+						return;
+				}
+			}
+			
			activeChar.useMagic(skill, _ctrlPressed, _shiftPressed);
		}
		else

Link to comment
Share on other sites
xdem Proficient

xdem

Posted
  • Author
Posted 

Index: java/net/sf/l2j/gameserver/network/clientpackets/RequestMagicSkillUse.java
===================================================================
--- java/net/sf/l2j/gameserver/network/clientpackets/RequestMagicSkillUse.java	(revision 2)
+++ java/net/sf/l2j/gameserver/network/clientpackets/RequestMagicSkillUse.java	(working copy)
@@ -17,7 +17,10 @@
import net.sf.l2j.gameserver.datatables.SkillTable;
import net.sf.l2j.gameserver.model.L2Skill;
+import net.sf.l2j.gameserver.model.actor.instance.L2MonsterInstance;
import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
import net.sf.l2j.gameserver.network.serverpackets.ActionFailed;
@@ -69,6 +72,19 @@
			if (skill.isToggle() && activeChar.is-beep-ted())
				return;

+			if (activeChar.getTarget() instanceof L2MonsterInstance)
+			{
+				switch (skill.getSkillType())
+				{
+					case BUFF:
+						return;
+					case HEAL:
+						return;
+					case HEAL_PERCENT:
+						return;
+				}
+			}
+			
			activeChar.useMagic(skill, _ctrlPressed, _shiftPressed);
		}
		else

I cant see any diffrence tho

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing


  • Posts

    • bomarket
      ⭐️BUYING CSGO SKINS⭐️INSTANT CRYPTO / BANK

      By bomarket · Posted

      Bump
    • milozare
      ⭐ LIST OF FORUMS FOR YOUR NEEDS ⭐ [OVER 100 RUSSIAN FORUMS]

      By milozare · Posted

      Relevant! List of forums on sale! Contact us!
    • Asocks
      PREMIUM RESIDENTIAL AND MOBILE PROXY | GET 3 GBS FOR FREE

      By Asocks · Posted

      New locations pool! Try it and make your effency greater with Asocks.com!
    • jnvv
      [L2J] L2Noxis

      By jnvv · Posted

      Greetings, Adventurers! 🎉 Announcement: L2 Noxis OBT Server Launch! 🎉 Adventurers of Aden, the moment you’ve been waiting for is here! We are thrilled to announce the official launch of the L2 Noxis Open Beta Test (OBT) Server! Gear up and get ready to embark on an epic journey in the world of Lineage 2 with a plethora of new and exciting features: 🔥 Features of L2 Noxis: Path of Rogue server: Modern Auto-Hunting System: Enjoy a seamless and modern auto-hunting experience, just like in the Essence chronicle. Free To Play Structure: Earn Einhasad's Golden Coins and Tarot cards through various in-game activities, making your adventure rewarding and enjoyable. Long-Term Project: Join us in a long-term commitment to provide a stable, exciting, and evolving gaming environment. Robust Anti-Cheat System: Play with confidence knowing that we have implemented a top-notch anti-cheat system to ensure a fair and balanced gaming experience. Newest Chronicle - Lineage 2: Path of Rogue: Experience the latest chronicle with new content, challenges, and adventures. New Classes: Unleash the power of the Death Knight and the mystical abilities of the Shinemaker. Discover new skills, abilities, and strategies with these exciting classes. Enhanced Rates: Enjoy 2x experience points and 2x adena drop rate, making your progression faster and more rewarding. Join us on this incredible journey and be among the first to experience the wonders of the L2 Noxis server. Gather your friends, form alliances, and conquer the lands of Aden!   📅 Launch Date: [July 10, 2024]   Stay tuned for more updates and get ready to explore, battle, and thrive in the world of L2 Noxis! For more information and instructions how to join the OBT, visit our official website: L2Noxis.com See you in Aden, warriors! 🌟     L2 Noxis Team  
    • protoftw
      Graphic/Html Designs - Protojah

      By protoftw · Posted

      L2 GOLD - HTML BORDER

  • Topics

×
×
  • Create New...