Jump to content

[Share]Over Enchant Trade Bug Fix


Recommended Posts

### Eclipse Workspace Patch 1.0
#P L2J-Archid-Game
Index: src/main/java/com/l2jarchid/gameserver/network/clientpackets/RequestEnchantItem.java
===================================================================
--- src/main/java/com/l2jarchid/gameserver/network/clientpackets/RequestEnchantItem.java	(revision 1060)
+++ src/main/java/com/l2jarchid/gameserver/network/clientpackets/RequestEnchantItem.java	(working copy)
@@ -26,6 +26,7 @@
import com.l2jarchid.gameserver.model.actor.instance.L2PcInstance;
import com.l2jarchid.gameserver.network.SystemMessageId;
import com.l2jarchid.gameserver.network.basepackets.L2GameClientPacket;
+import com.l2jarchid.gameserver.network.serverpackets.ActionFailed;
import com.l2jarchid.gameserver.network.serverpackets.EnchantResult;
import com.l2jarchid.gameserver.network.serverpackets.InventoryUpdate;
import com.l2jarchid.gameserver.network.serverpackets.ItemList;
@@ -78,6 +79,14 @@
     	    return;
     	}
     	
+    	
+    	if (activeChar.getActiveTradeList() != null)
+    	{
+    	activeChar.sendPacket(ActionFailed.STATIC_PACKET);
+    	activeChar.sendMessage("You Cannot Enchant While Trading!");
+    	return;
+    	}
+    	
         if(item.isWear())
         {
             Util.handleIllegalPlayerAction(activeChar,"Player "+activeChar.getName()+" tried to enchant a weared Item", IllegalPlayerAction.PUNISH_KICK);

This Is My First Step In Java

I Know That This Code Simple But Its My First One

I Want Say A Big Thanks To Stefoulis For Help (Thnx Bro)

 

Fix For This http://www.maxcheaters.com/forum/index.php?topic=84103.0

Not Tested

And This If You Want trade Close

### Eclipse Workspace Patch 1.0
#P L2J-Archid-Game
Index: src/main/java/com/l2jarchid/gameserver/network/clientpackets/RequestEnchantItem.java
===================================================================
--- src/main/java/com/l2jarchid/gameserver/network/clientpackets/RequestEnchantItem.java	(revision 1060)
+++ src/main/java/com/l2jarchid/gameserver/network/clientpackets/RequestEnchantItem.java	(working copy)
@@ -26,6 +26,7 @@
import com.l2jarchid.gameserver.model.actor.instance.L2PcInstance;
import com.l2jarchid.gameserver.network.SystemMessageId;
import com.l2jarchid.gameserver.network.basepackets.L2GameClientPacket;
-import com.l2jarchid.gameserver.network.serverpackets.ActionFailed;
import com.l2jarchid.gameserver.network.serverpackets.EnchantResult;
import com.l2jarchid.gameserver.network.serverpackets.InventoryUpdate;
import com.l2jarchid.gameserver.network.serverpackets.ItemList;
@@ -78,6 +79,14 @@
     	    return;
     	}
     	
+    	
+    	if (activeChar.getActiveTradeList() != null)
+    	{
+    	activeChar.canselActiveTrade();
+    	activeChar.sendMessage("Your trade canseled");
+    	return;
+    	}
+    	
         if(item.isWear())
         {
             Util.handleIllegalPlayerAction(activeChar,"Player "+activeChar.getName()+" tried to enchant a weared Item", IllegalPlayerAction.PUNISH_KICK);

Link to comment
Share on other sites

This Is My First Step In Java

I Know That This Code Simple But Its My First One

I Want Say A Big Thanks To Stefoulis For Help (Thnx Bro)

 

Fix For This http://www.maxcheaters.com/forum/index.php?topic=84103.0

Thanks god after lain posted it everyone used it on l2jarchid. im waiting for the new archid updates to install it

 

 

Link to comment
Share on other sites

Thanks god after lain posted it everyone used it on l2jarchid. im waiting for the new archid updates to install it

 

 

 

So this works?

Link to comment
Share on other sites

All this can be fixed in char info updating ....

 

i mean to run a script

 

if the weapon enchanting > than config.maxweaponenchant config

QQ

so characters informaton updating every few sec :)

 

yeah and than your CPU on 100 your network on 100 and full lagg congratz for the post :D

if you want to make it better dont send message to the activeChar send just a _log.warning(); :)

Link to comment
Share on other sites

should not be first sendMessage only then acion failed? b/c whit this code i haved errors till i changed places...

The order doesn't matter.

It just sends an empty packet first so that the client wont be waiting for the response packet forever.

Link to comment
Share on other sites

You could also cancel the trade. That's what i've done on deathwhisper.

 

just add this

activeChar.cancelActiveTrade(); 

Link to comment
Share on other sites

You could also cancel the trade. That's what i've done on deathwhisper.

 

just add this

activeChar.cancelActiveTrade(); 

Yup but sending an empty packet is always a great choice (Even if you cancel the trade) to prevent exploits ^^

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Posts

    • hELLO, DOES THIS WORK FOR ELMORELAB SERVER X3??
    • 4 DAYS for NEW WORLD 5000x https://x5000.l2focus.com/    JOIN BEST PVP COMUNITY DISCORD FOR INFORMATIONS: https://discord.com/invite/L2Focus
    • The project is no longer for sale. Please lock the topic. Thanks 😊 
    • Hello Dear Friends of Maxchets. I come to announce to you the Faction project that I have been working on for some time and due to some unforeseen circumstances Guys, I ended up pausing and maybe stopping the project. Would you like some information about the project and details on how to get in touch via Discord: crazyrx2564 Acis Project Basis: These Acis are already solid files so decide to create the faction based on more solid files. Is the entire Faction System Ready, are all Faction x Faction events working and which Events do they have so far? CaptureFlag Death March Faction Hero -> Replaces the onlympiad system, as the faction fights to get the hero of each class. the fights too happen between members of different factions. Faction System. the traditional event where you have to capture the territory until the end of time. Strength KillBoss: a faction that deals the most damage earns a reward and secondly another reward, all configurable. Last man TVT. All of the above events have been reworked to work with the faction system. events are radom. With a pause in the project, some changes remained pending. some mods that were in the plans were not added. The EloRank event was halfway through. If you purchase the Project and do not have experience in Java, you will have to hire a Dev to complete, add or correct any errors that may appear. I make it very clear that the Project is 90% to my liking, what is missing are my ideas that have no impact whatsoever on opening a server. the project also comes with a very complete Skin Pack. It also has a Balnce Faction system, to balance the number of players from each faction to your liking. The Project also has several other mods that can be used. Start NFT bang toppvp reward. etc. It's a very complete project, but it's up to you to use, add, or change it. but they are files that are completely ready to be configured to your liking and open a server faction.  
  • Topics

×
×
  • Create New...