Help Top Enchant Npc

[Eleven]

Hello McX!

Im using aCis 401 and i tryed to adapt a Top Enchant Manager from an older revision. thats my code.

 

In order to make it work i had to make some changes in ItemData.java. Check bellow

 

 

Is that the correct way? Everything seems to work fine but i want to make sure that is not affected anything else. 

 

Thanks in advance.

[Katara512]

what you did right now is to move weapon map outside your main method, why to do that?

[Zake]

Well, let's just ignore almost everything and stick to your only change. You don't have to loop through all the weapons in order to get the item name. You also don't have to change your weapons map from temporary variable to a constant (public static). Since your only concern is the item name you can just make it like

final Item itemTemplate = ItemData.getInstance().getTemplate(id here);

final String itemName = itemTemplate.getName();

[Tryskell]

If the point is only to retrieve item name to put it in a NpcHtmlMessage, you can use the client option "&#"+itemId + ";". Obviously it only works if you properly edited client to reflect what names are on the server, but it's by far the cheapest option.

 

So you only

 

String weaponName = "&#" + rs.getInt("itemId") + ";";

or even better, you integrate it directly into your ret String and you put your different rs.get methods directly into String (you can then delete the first 7 lines, for loop included, and keep only ret +=).

Edited September 18, 2022 by Tryskell