Code Merchant Say

[Williams]

This system is just to give merchants a life. To avoid floods create a config for this I left "FloodProtector.SOCIAL" as an example only. code

 

+<?xml version="1.0" encoding="UTF-8"?>
+<list>
+<!--  SayType
+
+	ALL,
+	SHOUT, // !
+	TELL, // "
+	PARTY, // #
+	CLAN, // @
+	GM,
+	PETITION_PLAYER,
+	PETITION_GM,
+	TRADE, // +
+	ALLIANCE, // $
+	ANNOUNCEMENT,
+	BOAT,
+	L2FRIEND,
+	MSNCHAT,
+	PARTYMATCH_ROOM,
+	PARTYROOM_COMMANDER, // (Yellow)
+	PARTYROOM_ALL, // (Red)
+	HERO_VOICE,
+	CRITICAL_ANNOUNCE;
+ -->
+	<settings npcId="30001" text="Hello what do you want ?" sayType="SHOUT" effect="true" />
+</list>

 

 

code optimization

Update

Edited April 23, 2021 by Williams

[Kara]

1. If you're working with Java 15+ this

 

public class MerchantSay
+{
+	private final int _npcId;
+	private final String _text;
+	private final SayType _type;
+	private final boolean _effect;
+	
+	public MerchantSay(int npcId, String text, SayType type, boolean effect)
+	{
+		_npcId = npcId;
+		_text = text;
+		_type = type;
+		_effect = effect;
+	}
+	
+	public int getNpcId()
+	{
+		return _npcId;
+	}
+	
+	public String getText()
+	{
+		return _text;
+	}
+	
+	public SayType getType()
+	{
+		return _type;
+	}
+	
+	public boolean isEffects()
+	{
+		return _effect;
+	}
+}

 

Can be simply in 1 line like this:

 

+ public record MerchantSay(int npcId, String text, SayType type, boolean effect){}

 

2. Your code broadcast to all players the text and the effect. If 3-4 players click at the same time it will be a mess. Send packet only to the player who clicked. 

 

3. Why return if the data is null ?

 

final MerchantSay says = MerchantSayData.getInstance().getNpc(getNpcId());
+		if (says == null)
+			return "";

 

Doesn't this mean that the other NPC that are not registered as MerchantSay won't display a proper html path? 

 

4. Kinda pointless to use all Say2 channels. Nobody is going to use for example L2FRIEND, MSNCHAT or CRITICAL_ANNOUNCE. Especially the way you wrote your code if any Admin does it will spam the whole place surrounded by players (can also be a gate to flood), simply use All chat. 

 

In addition if you made the video it's very annoying to have 8 seconds of dubstep intro while the video is 19. 50% of the video is the intro.

Edited April 23, 2021 by Kara

[Williams]

2 hours ago, Kara said:

1. If you're working with Java 15+ this

 

public class MerchantSay
+{
+	private final int _npcId;
+	private final String _text;
+	private final SayType _type;
+	private final boolean _effect;
+	
+	public MerchantSay(int npcId, String text, SayType type, boolean effect)
+	{
+		_npcId = npcId;
+		_text = text;
+		_type = type;
+		_effect = effect;
+	}
+	
+	public int getNpcId()
+	{
+		return _npcId;
+	}
+	
+	public String getText()
+	{
+		return _text;
+	}
+	
+	public SayType getType()
+	{
+		return _type;
+	}
+	
+	public boolean isEffects()
+	{
+		return _effect;
+	}
+}

 

Can be simply in 1 line like this:

 

+ public record MerchantSay(int npcId, String text, SayType type, boolean effect){}

 

2. Your code broadcast to all players the text and the effect. If 3-4 players click at the same time it will be a mess. Send packet only to the player who clicked. 

 

3. Why return if the data is null ?

 

final MerchantSay says = MerchantSayData.getInstance().getNpc(getNpcId());
+		if (says == null)
+			return "";

 

Doesn't this mean that the other NPC that are not registered as MerchantSay won't display a proper html path? 

 

4. Kinda pointless to use all Say2 channels. Nobody is going to use for example L2FRIEND, MSNCHAT or CRITICAL_ANNOUNCE. Especially the way you wrote your code if any Admin does it will spam the whole place surrounded by players (can also be a gate to flood), simply use All chat. 

 

In addition if you made the video it's very annoying to have 8 seconds of dubstep intro while the video is 19. 50% of the video is the intro.

Really xD I use java 11 and not 15, I cleaned the code. Didn't you like my intro?

 

Update

Edited April 23, 2021 by Williams

[Xtellia]

1 phrase cmon man. Make a pool of phrases which are chosen randomly upon talk with an npc. U can also check npc's sex and use that to deliver different phrases.

Then if player used more 1kk upon buying something the trader should comment that in general chat.

Or a big drop was sold so npc says that he received some nice goods etc.

If you start to hit  the merchant he should call the guards and they're spawning outside the shop and rush in to attack player ;)))

Edited April 24, 2021 by Xtellia