Help How To Make It Forbidden

[milosvamp]

Can somebody give me a little bit of help ?

I wanna make one NPC not available for all classes. I want to make for example that only healers can use it. But I am very new at this... Could anybody just try to give me some advices ? (:

For now the code looks like this:

 

/*
 * Copyright (C) 2004-2016 L2J DataPack
 * 
 * This file is part of L2J DataPack.
 * 
 * L2J DataPack is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 * 
 * L2J DataPack is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 * General Public License for more details.
 * 
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
package custom.pots.pots;

import com.l2jserver.gameserver.model.actor.L2Npc;
import com.l2jserver.gameserver.enums.PlayerAction;
import com.l2jserver.gameserver.enums.Race;
import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;
import com.l2jserver.gameserver.model.base.ClassId;
import com.l2jserver.gameserver.network.serverpackets.NpcHtmlMessage;
import com.l2jserver.gameserver.model.actor.instance.L2MerchantInstance;

import ai.npc.AbstractNpcAI;
import village_master.KamaelChange2.KamaelChange2;

public final class pots extends AbstractNpcAI
{
	/**
	 * @param name
	 * @param descr
	 */
	public pots(String name, String descr)
	{
		super(name, descr);
	}
	
	// NPC
	private static int[] NPCS =
	{
		30165, // Ralford
	};
	
	public void showChatWindow(PlayerAction player, int val)

final int npcId = getNpcId();
 
if (npcId == 30165)
{
final NpcHtmlMessage html = new NpcHtmlMessage();
if (PlayerAction.getclassid == 97)
html.setFile("data/html/merchant/30165-50.htm", _descr);
else
html.setFile("data/html/merchant/30165-3.htm", _descr);
 
html.replace("%objectId%", getObjectId());
player.sendPacket(html);
return; 
}
}

	/**
	 * @return
	 */
	private Object getObjectId()
	{
		return null;
	}
}

Thanks in advance...

[melron]

Well you have 2 options.

 

1. You will add the next check in showChatWindow() method in super class (L2Npc?) by checking the npc id
2. You will override the method showChatWindow() in your npc instance

 

inside of your method before you send the html add a check like this:

	List<Integer> classes = Arrays.asList(1,2,3,4,5,6);
	
	if (classes.contains(player.getClassId().getId()))
		return;

Fill the list with all healers class ids

Edited July 19, 2017 by melron

[Sdw]

My god,

 

First check the proper method, what you want to use would be onTalk, onFirstTalk or maybe onAdvEvent. Pick the one that suits you.

 

Also category were made in retail to avoid such ugly list. There is an existing category for healer, check the name in categoryData.xml and use player.isInCategory(Category type.NAME_HERE)

 

you can even make yours if you like.

[melron]

Use sdw's example.

 

I thought it was for aCis. I didnt even see the imports l2jserver :P

[milosvamp]

On 7/19/2017 at 7:14 AM, Sdw said:

My god,

 

First check the proper method, what you want to use would be onTalk, onFirstTalk or maybe onAdvEvent. Pick the one that suits you.

 

Also category were made in retail to avoid such ugly list. There is an existing category for healer, check the name in categoryData.xml and use player.isInCategory(Category type.NAME_HERE)

 

you can even make yours if you like.

/*
 * Copyright (C) 2004-2016 L2J DataPack
 * 
 * This file is part of L2J DataPack.
 * 
 * L2J DataPack is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 * 
 * L2J DataPack is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 * General Public License for more details.
 * 
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
package custom.potions;

import com.l2jserver.gameserver.model.actor.L2Npc;
import com.l2jserver.gameserver.enums.PlayerAction;
import com.l2jserver.gameserver.enums.Race;
import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;
import com.l2jserver.gameserver.model.base.ClassId;
import com.l2jserver.gameserver.network.serverpackets.NpcHtmlMessage;
import com.l2jserver.gameserver.model.actor.instance.L2MerchantInstance;

import ai.npc.AbstractNpcAI;

public final class potions extends AbstractNpcAI
{
	/**
	 * @param name
	 * @param descr
	 */
	public potions(String name, String descr)
	{
		super(name, descr);
	}
	
	// NPC
	private static int[] NPCS =
	{
		30165, // Ralford
	};
	
	@Override
	public String onTalk(L2Npc npc, L2PcInstance player,int)
	{
		String htmltext = null;
	
final int npcId = getId();
 
if (npcId == 30165)
{
final NpcHtmlMessage html = new NpcHtmlMessage();
if (player.getClassId() == 97)
html.setFile("data/html/merchant/30165-50.htm", _descr);
else
html.setFile("data/html/merchant/30165-3.htm", _descr);
}
else
html.replace("%objectId%", getObjectId());
player.sendPacket(html);
return; 
}
	
	/**
	 * @return
	 */
	private Object getObjectId()
	{
		return null;
	}
}

:X  .... can u fix it :D 

[milosvamp]

Could anybody try to make it for me pls ? I know it is few lines of a code ;X

[Tryskell]

• Delete your pointless getObjectId() and use instead npc.getObjectId().
• Use onFirstTalk instead of onTalk, and register the npc to the correct event too.

Finally the whole class structure sucks, check how other scripts using onFirstTalk event are written, it's not hard.

Edited September 15, 2017 by Tryskell

[milosvamp]

2 hours ago, Tryskell said:

• Delete your pointless getObjectId() and use instead npc.getObjectId().
• Use onFirstTalk instead of onTalk, and register the npc to the correct event too.

Finally the whole class structure sucks, check how other scripts using onFirstTalk event are written, it's not hard.

/*
 * Copyright (C) 2004-2016 L2J DataPack
 *
 * This file is part of L2J DataPack.
 *
 * L2J DataPack is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * L2J DataPack is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
package custom.potionns;

import com.l2jserver.gameserver.model.actor.L2Npc;
import com.l2jserver.gameserver.enums.PlayerAction;
import com.l2jserver.gameserver.enums.Race;
import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;
import com.l2jserver.gameserver.model.base.ClassId;
import com.l2jserver.gameserver.network.serverpackets.NpcHtmlMessage;
import com.l2jserver.gameserver.model.actor.instance.L2MerchantInstance;

import ai.npc.AbstractNpcAI;
import village_master.DwarfWarehouseChange1.DwarfWarehouseChange1;

public final class potionns extends AbstractNpcAI
{
	/**
     * @param name
     * @param descr
     */
    public potionns(String name, String descr)
    {
        super(name, descr);
    }
	
	// NPC
	private static int[] NPCS =
	{
		30165, // Ralford
	};
	
	@Override
    public String addTalkId(L2Npc npc, L2PcInstance player,int)
    {
        String htmltext = null;
   
final int npcId = getId();
 
if (npcId == 30165)
{
final NpcHtmlMessage html = new NpcHtmlMessage();
if (player.getClassId() == 97)
html.setFile("data/html/merchant/30165-50.htm", _descr);
else
html.setFile("data/html/merchant/30165-3.htm", _descr);
}
else
html.replace("%objectId%", getObjectId());
player.sendPacket(html);
return;

	
	/**
	 * @return
	 */
	private Object npc.getObjectId()
	{
		return null;
	}
}

There are still some problems :X

[Tryskell]

Did you open an existing file with the event I talked about before reposting this ?

Edited September 16, 2017 by Tryskell

[milosvamp]

6 minutes ago, Tryskell said:

Did you open an existing file with the event I talked about before reposting this ?

I don't understand what it is and what should i open... there are thousands of files and idk what is constructor and what is event and where to put. I simply don't understand it. Sorry

[Tryskell]

16 hours ago, milosvamp said:

I don't understand what it is and what should i open... there are thousands of files and idk what is constructor and what is event and where to put. I simply don't understand it. Sorry

Reconsider developing if you don't know how to use Eclipse search tool.

[milosvamp]

2 hours ago, Tryskell said:

Reconsider developing if you don't know how to use Eclipse search tool.

What should i search ? Just tell me from which file should i copy that if  u know....

[Tryskell]

onFirstTalk on the whole script folder. Or whatever your pack uses as "first talk event" on script system.

[milosvamp]

12 minutes ago, Tryskell said:

onFirstTalk on the whole script folder. Or whatever your pack uses as "first talk event" on script system.

ok i got this now but idk what to say if player is class or what..... :x i just copied what i found onFirstTalk... look

 

/*
 * Copyright (C) 2004-2016 L2J DataPack
 *
 * This file is part of L2J DataPack.
 *
 * L2J DataPack is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * L2J DataPack is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
package custom.potionns;

import com.l2jserver.gameserver.model.ClanPrivilege;
import com.l2jserver.gameserver.model.actor.L2Npc;
import com.l2jserver.gameserver.enums.PlayerAction;
import com.l2jserver.gameserver.enums.Race;
import com.l2jserver.gameserver.model.actor.instance.L2PcInstance;
import com.l2jserver.gameserver.model.base.ClassId;
import com.l2jserver.gameserver.network.serverpackets.NpcHtmlMessage;
import com.l2jserver.gameserver.model.actor.instance.L2MerchantInstance;

import ai.npc.AbstractNpcAI;
import village_master.DwarfWarehouseChange1.DwarfWarehouseChange1;

public final class potionns extends AbstractNpcAI
{
	/**
	 * @param name
	 * @param descr
	 */
	public potionns(String name, String descr)
	{
		super(name, descr);
	}
	
	// NPC
	private static int[] NPCS =
	{
		30165, // Ralford
	};
	
	@Override
	public String onFirstTalk(L2Npc npc, L2PcInstance player)
	{
		if (player.isClanLeader() || player.hasClanPrivilege(ClanPrivilege.CL_TROOPS_FAME))
		{
			return npc.getId() + ".html";
		}
		return npc.getId() + "-01.html";
	}
   
final int npcId = getId()
;{
 
if (npcId == 30165)
{
final NpcHtmlMessage html = new NpcHtmlMessage();
if (player.getClassId() == 97)
html.setFile("data/html/merchant/30165-50.htm", _descr);
else
html.setFile("data/html/merchant/30165-3.htm", _descr);
}
else
html.replace("%objectId%", getObjectId());
player.sendPacket(html);
return;

	
	/**
	 * @return
	 */
	private Object npc.
	
	getObjectId()
	{
		return null;
	}
}

 

[wongerlt]

You just copy/paste.... :D

	@Override
	public String onFirstTalk(L2Npc npc, L2PcInstance player)
	{
		if (player.getClassId() == 97)
		return "data/html/merchant/30165-50.htm";
		else
		return "data/html/merchant/30165-3.htm";
	}

and u need regiser onfirsttalk to 30165 npc.

 

[milosvamp]

9 hours ago, wongerlt said:

You just copy/paste.... :D

	@Override
	public String onFirstTalk(L2Npc npc, L2PcInstance player)
	{
		if (player.getClassId() == 97)
		return "data/html/merchant/30165-50.htm";
		else
		return "data/html/merchant/30165-3.htm";
	}

and u need regiser onfirsttalk to 30165 npc.

 

yeah, haha idk how to make it ......................:x shit