Jump to content

Recommended Posts

  • 3 weeks later...
Posted (edited)

There isn't that much to improve, replace ConcurrentHashMap occurences by regular HashMap (no need of concurrency here, slow the code for nothing) and as a basic core, if you got no bugs, it's almost good to go.

Edited by Tryskell
Posted

There isn't that much to improve, replace ConcurrentHashMap occurences by regular HashMap (no need of concurrency here, slow the code for nothing) and as a basic core, if you got no bugs, it's almost good to go.

 

it can be coded way better. Theres no need of external data structures at all to make this work. This is a shitcode

Posted

it can be coded way better. Theres no need of external data structures at all to make this work. This is a shitcode

 

You don't need external data structure for anything, if you think like this. Almost everything can be hardcoded on enum. 40k spawns on int array, you will like it.

Posted

You don't need external data structure for anything, if you think like this. Almost everything can be hardcoded on enum. 40k spawns on int array, you will like it.

 

bs. I am talking about this particular case, you don't need hashmaps to store players on their factions at all

Posted (edited)

The hashmap is used either for Faction type storing, or as a temporary container. There is no additional storing HashMap otherwise, so I don't really see what you mean. getFactionPlayers( isn't even used and could be deleted (or replaced by a stream, which still produce garbage).

 

And as I said higher anyway, factions could benefit from enum as there isn't a lot of data and it won't be edited.

http://www.maxcheaters.com/topic/211856-acis-faction-system-unlimited-factions/?p=2614452

Edited by Tryskell
Guest
This topic is now closed to further replies.



  • Posts

    • this will explain better than words  
    • I would like to emphasize that I am selling the tool used to generate geodata for the client you are developing, not the geodata itself; therefore, I consider the price reasonable. As for your view that the price is high and shows a lack of respect for the customer—that is your own opinion. Thank you. I have also purchased his products, and—just as you said—he is skilled and provides very enthusiastic support. If you feel he is deserving, then you should continue buying from him.
    • Ημουν μικρος οταν τον επαιξα, οριακα δεν ηξερα τι ειναι το Lineage, θυμαμαι πηγαιναμε στα νετ με τους φιλους και προσπαθουσαμε να κανουμε log-in αλλα πολλες φορες δεν μπορουσαμε γιατι ο server ηταν heavy σε load και πολλες φορες προλαβαιναμε να παιξουμε μονο κανα τεταρτακι η εικοσαλεπτο απ την μια ωρα που βαζαμε για να ανοιξουμε pc, ωστοσο εχω πολλες αναμνησεις να βλεπω τους μεγαλυτερους τοτε να παιζουν και εγω να καθομαι διπλα και να χαζευω gameplay, Λιγα πραγματα που ξερω (δεν ξερω αν ισχυουν) ειναι οτι τον σερβερ τον ειχε ανοιξει η αλυσιδα TheWeb, επισης οτι ηταν δυο οι σερβερ, ενας rpg low rate και ενας pvp με higher rates, περα απο αυτο δεν μπορεσα να βρω καμια αλλη χρησιμη πληροφορια, ουτε στα forum του theweb.gr ουτε στo l2.thegame.gr (waybackmachine) οποτε ερχομαι εδω που ειμαι σιγουρος οτι θα υπαρχουν σιγουρα καποιοι που επαιξαν εκει και δεν ηταν οσο πιτσιρικας οσο ημουν εγω που δεν καταλαβαινε τι γινοταν.   Γενικοτερα οποιος ξερει οτιδηποτε για τον thegame ας το πει, ακομη κι ας ειναι μια μικρη ιστορια που ακουσε πριν πολλα χρονια, ακομη κι αν ειναι μια μικρη πληροφορια για κατι που θυμαται μεσα στο παιχνιδι, οπως πως λεγανε τους admins, κανα σκηνικο ιντερνετ καφε και μπουνιδια, οοοοοτι μα οτιδηποτε κι αν ειναι αυτο αρκει να εχει να κανει με τον TheGame   (εννοειται εαν εχετε φωτογραφιες η βιντεο να τα linkαρετε)   μερικες δικες μου αποριες ειναι: απο τι chronicle αρχισε και μεχρι που εφτασε? ποια χρονια ηταν το peak του και σε ποιο chronicle? επισης μεχρι πιο chronicle εξελιχθηκε? γιατι εκλεισε αφου τοτε ηταν στο peak το να πηγαινει ο κοσμος στα ιντερνετ καφε και να παιζει λ2, τι features ειχε σαν σερβερ? επι ποσο ηταν? custom πραγματα κτλπ? η ηταν ενας bone stock server?    να'στε καλα!
    • Yeah... the price for the project at this stage is the kind of disrespect to the customer I was talking about.     As for deMEV, he’s overpriced too, but he’s one of the very few people in the L2 market who is available almost 24/7.
    • Thank you all for your interest in my post. I confirm that I did indeed use L2MapConv to develop my tool, adding my own customizations. If you are already a customer of deMEV, please continue to support him; I believe his products are excellent—I have purchased from him myself, and he is truly talented. Below is the Giran 22_22 geodata file generated using my tool; feel free to take a look. Thanks again to everyone for your comments. https://drive.google.com/file/d/1owpXCGEAhAO6TjjBJTYuVFqeUDu9RNoI/view?usp=drive_link
  • Topics

×
×
  • Create New...

Important Information

This community uses essential cookies to function properly. Non-essential cookies and third-party services are used only with your consent. Read our Privacy Policy and We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue..