Small Npe And Something Else

[Kelrzher]

else if (parameters.contains("Cov"))
{
  if(player.getInventory().getItemByItemId(11010).getCount()>= 3)
  {
player.getInventory().destroyItemByItemId("Consume",11010, 3, player, null);
player.sendMessage("SYS: 3 of your Vote Tickets have been consumed.");
player.broadcastPacket(new InventoryUpdate());
MagicSkillUser mgc = new MagicSkillUser(player, player, 1363, 1, 1, 1);
SkillTable.getInstance().getInfo(1363, 1).getEffects(player,player);
player.broadcastPacket(mgc);
player.sendMessage("Your strength is improved due to Chant of Victory effects!"); 
   }
else
{ 
player.sendMessage("You don't have enough vote tickets.");
return;
}
 
}

 

java.lang.NullPointerException
at com.l2jfrozen.gameserver.powerpak.Buffer.BuffHandler.handleCommand(BuffHandler.java:338)
at com.l2jfrozen.gameserver.handler.custom.CustomBypassHandler.handleBypass(CustomBypassHandler.java:101)
at com.l2jfrozen.gameserver.network.clientpackets.RequestBypassToServer.runImpl(RequestBypassToServer.java:315)
at com.l2jfrozen.gameserver.network.clientpackets.L2GameClientPacket.run(L2GameClientPacket.java:77)
at com.l2jfrozen.gameserver.network.L2GameClient.run(L2GameClient.java:1213)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

i made this .. the item does not get destroyed visually.. it gets destroyed but visually i see the same number .. it needs char restart to show correctly..and i get also this NPE when i dont have the items to use the buff

 

 

[melron]

working perfect 

                else if (parameters.contains("cov"))
                {			
                    if (player.destroyItemByItemId("Buff", 11010, 3, player, true))
			{
				player.getInventory().destroyItemByItemId("Consume",11010, 3, player, null);
				player.sendMessage("SYS: 3 of your Vote Tickets have been consumed.");
				player.broadcastPacket(new InventoryUpdate());
				MagicSkillUse mgc = new MagicSkillUse(player, player, 1363, 1, 1, 1);
				SkillTable.getInstance().getInfo(1363, 1).getEffects(player,player);
				player.broadcastPacket(mgc);
				player.sendMessage("Your strength is improved due to Chant of Victory effects!"); 
			}

			else
			{ 
			player.sendMessage("You don't have enough vote tickets.");
                        return;
			}
                }

Edited October 6, 2016 by ⏇Melron⏇℠Abs

[Reborn12]

if (player.destroyItemByItemId("Buff", id, count, player, true))

{

SkillTable.getInstance().getInfo(buffid, bufflevel).getEffects(this, player);

player.broadcastPacket(new MagicSkillUse(this, player, buffid, 1, 0, 0));

Addk your msg to else and ready

Edited October 6, 2016 by Reborn12

[Kelrzher]

 if (player.destroyItemByItemId("Buff", id, count, player, true))
   {
    SkillTable.getInstance().getInfo(buffid, bufflevel).getEffects(this, player);
    player.broadcastPacket(new MagicSkillUse(this, player, buffid, 1, 0, 0));

Addk your msg to else and ready

 

next? :P haha was not that for sure

[Reborn12]

Just best choice removed 3 lines added 1 somethink better..

[Kelrzher]

Just best choice removed 3 lines added 1 somethink better..

i agree but problem unsolved xD

[Reborn12]

player.broadcastPacket(new InventoryUpdate());

Remove it

[Kelrzher]

still it does that.. 

 

player.broadcastPacket(new InventoryUpdate());
Remove it

[Sdw]

Ahahahah

[Kelrzher]

 

working perfect 

                else if (parameters.contains("cov"))
                {			
                    if (player.destroyItemByItemId("Buff", 11010, 3, player, true))
			{
				player.getInventory().destroyItemByItemId("Consume",11010, 3, player, null);
				player.sendMessage("SYS: 3 of your Vote Tickets have been consumed.");
				player.broadcastPacket(new InventoryUpdate());
				MagicSkillUse mgc = new MagicSkillUse(player, player, 1363, 1, 1, 1);
				SkillTable.getInstance().getInfo(1363, 1).getEffects(player,player);
				player.broadcastPacket(mgc);
				player.sendMessage("Your strength is improved due to Chant of Victory effects!"); 
			}

			else
			{ 
			player.sendMessage("You don't have enough vote tickets.");
                        return;
			}
                }

your item visually destroyed? cause mine doesnt it gets destroyed but visually not.. and when i dont have the items i get the npe

[melron]

what to say... as i said its working perfect for me (acis)

[Kelrzher]

what to say... as i said its working perfect for me (acis)

ohh damn wait i will retest and feedback.. i have it opposite xD

[melron]

ohh damn wait i will retest and feedback.. i have it opposite xD

:D

[SweeTs]

You only check for the item count while item doesn't exist - npe. Also lol at this inventory update packet. *Missing facepalm emoticone*  :gusta:

 

Simply..

 

 

if (!player.destroyItem(...
   return;
 
give buff crap

[melron]

 

You only check for the item count while item doesn't exist - npe. Also lol at this inventory update packet. *Missing facepalm emoticone*  :gusta:

 

Simply..

if (!player.destroyItem(...
   return;
 
give buff crap

as he said he dont get the visually of the destroyed item and i guess thats why one more update added... 

about ur code ... cmon one code can be coded with 1k ways ... 

[Kelrzher]

 

You only check for the item count while item doesn't exist - npe. Also lol at this inventory update packet. *Missing facepalm emoticone*  :gusta:

 

Simply..

if (!player.destroyItem(...
   return;
 
give buff crap

visually bug , thought it was for test porpuse xD