Jump to content

Recommended Posts

Posted (edited)

You should keep javadoc and forums in english, I doubt there is THAT MUCH spanishes using L2J (like if I would write all aCis javadoc in french while I maybe met... 4 other frenchies in L2J world). I don't have troube with spanish, but not everyone made it as second langage at school.

 

If you can create multiple instances in same time, you should edit following for concurrent version (CopyOn...) :

private static final List<InstanceWorld> _instancesWorlds = new ArrayList<>();

Otherwise good job, it's clean.

Edited by Tryskell
Posted (edited)

You should keep javadoc and forums in english, I doubt there is THAT MUCH spanishes using L2J (like if I would write all aCis javadoc in french while I maybe met... 4 other frenchies in L2J world). I don't have troube with spanish, but not everyone made it as second langage at school.

 

If you can create multiple instances in same time, you should edit following for concurrent version (CopyOn...) :

private static final List<InstanceWorld> _instancesWorlds = new ArrayList<>();

Otherwise good job, it's clean.

I agree about the lang.

 

About the suggestion, i don't know why we have a list if the engine only supports one event at the same time (for now). Whatever, thank you.

Edited by Zephyr92
  • 2 weeks later...
Posted

luego de unas vacaciones vuelvo para intentar mejorar y terminar este hermoso motor de eventos.

---------------------------------------------------------------

then a holiday I go back to try to improve and complete this beautiful event engine.

 

 

Tryskell, on 03 Jul 2015 - 07:16 AM, said:
You should keep javadoc and forums in english, I doubt there is THAT MUCH spanishes using L2J (like if I would write all aCis javadoc in french while I maybe met... 4 other frenchies in L2J world). I don't have troube with spanish, but not everyone made it as second langage at school.

If you can create multiple instances in same time, you should edit following for concurrent version (CopyOn...) :
private static final List<InstanceWorld> _instancesWorlds = new ArrayList<>();
Otherwise good job, it's clean.

 

Gracias por tu comentario, valoró mucho tu opinión.

---------------------------------------------------------------

Thanks for your comment, appreciated very much your opinion. 

Posted (edited)

You should keep javadoc and forums in english, I doubt there is THAT MUCH spanishes using L2J (like if I would write all aCis javadoc in french while I maybe met... 4 other frenchies in L2J world). I don't have troube with spanish, but not everyone made it as second langage at school.

 

If you can create multiple instances in same time, you should edit following for concurrent version (CopyOn...) :

private static final List<InstanceWorld> _instancesWorlds = new ArrayList<>();

Otherwise good job, it's clean.

Sweet Tryskell you need to read more for java and stop spam all time ...... see your job and stop speak for another job

l2jaCis 345 SpawnTable 

private final Set<L2Spawn> _spawntable = new CopyOnWriteArraySet<>();

are you sure for that ? 

plz and don't tell ... ( i create it at last update ) why you wait months for fix it ?
you create fail for more revision 
this is shit job bro :)
and i tell you again stop spam and i don't tell more for your job :)
 
and ty for share again :)
Edited by pirama
Posted (edited)

 

Shit and more shit...

 

Dude, I don't speak with someone which takes the job of another team, use it for its own shit and say after it's shitty. Just shut the fuck out.

 

_spawntable is ok like it was, what do you want to fix about it ?

 

Latest aCis is 

private final Set<L2Spawn> _spawntable = ConcurrentHashMap.newKeySet();

but you probably will say I'm a copy-paster, because L2J did it and I did it after I verified there was a performance boost ? Finally, why are you speaking about SpawnManager, while it gonna soon dissapear ? And prove me I'm wrong about both that _spawntable and my answer to that topic.

 

You explain nothing. You only know how to bark ?

 

Finally rev 345 is leaked, so basically you say you are using a leaked project for your own Pirama crap ? You're worst than a dog, dude.

Edited by Tryskell
Posted
/*
 * This program is free software: you can redistribute it and/or modify it under
 * the terms of the GNU General Public License as published by the Free Software
 * Foundation, either version 3 of the License, or (at your option) any later
 * version.
 * 
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 * 
 * You should have received a copy of the GNU General Public License along with
 * this program. If not, see <http://www.gnu.org/licenses/>.
 */
package net.sf.l2j.gameserver.l2event.mainevents;

import net.sf.l2j.gameserver.l2event.AbstractEvent;
import net.sf.l2j.gameserver.l2event.EventSchemas;
import net.sf.l2j.gameserver.l2event.EventSchemas.TeamTemplate;
import net.sf.l2j.gameserver.l2event.EventTeam;
import net.sf.l2j.gameserver.model.Location;
import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;

/**
 * @author Drake2wow
 */
public class TeamVsTeam extends AbstractEvent
{
	public TeamVsTeam()
	{	super("TvT Event(TvT)", "TvT", EventSchemas.tvtLoc[0], EventSchemas.tvtLoc[1], EventSchemas.tvtLoc[2]);
		for (TeamTemplate teamTemplate : EventSchemas.getRandomTvTSchema().getTeamTemplates())
			addTeam(new EventTeam(teamTemplate));
	}
	
	@Override
	public void run()
	{	ScheduleAfterMinutes(() -> initEvent(),  EventSchemas.tvtRegTask[0]);
		startRegistrationTask( EventSchemas.tvtRegTask);
	}
	
	@Override
	public void startEventTask()
	{	ScheduleAfterSeconds(() -> startMainAndFinishTask(EventSchemas.tvtRunTask), 25);
		ScheduleAfterMinutes(() -> end(), EventSchemas.tvtRunTask[0]);
	}
	
	@Override
	public void end()
	{	broadCastTopPlayers(5);
		calculateWinnerTeams();
		super.end();
	}
	
	@Override
	public boolean isSameTeam(final L2PcInstance player, final L2PcInstance target)
	{	return player != target && getTeam(player) != null && getTeam(player) == getTeam(target);
	}
	
	@Override
	public boolean isInSpawnProtection(final L2PcInstance player)
	{	if (!isEventParticipant(player))
			return false;
		final EventTeam team = getTeam(player);
		if (team == null)
			return false;
		final Location loc = team.getSpawnLocation();
		return player.isInsideRadius(loc.getX(), loc.getY(), loc.getZ(), 400, false, false);
	}
	
	@Override
	public void onDie(final L2PcInstance killer, final L2PcInstance victim)
	{	final EventTeam killerTeam = getTeam(killer), victimTeam = getTeam(victim);
		if (killerTeam != null && victimTeam != null && killerTeam != victimTeam)
			killerTeam.increaseScore();
		super.onDie(killer, victim);
	}
	
	@Override
	public void respawn(final L2PcInstance player)
	{	if (state == State.FINISHED || state == State.INACTIVE)
			player.teleToLocation(leaveLoc, 250);
		else
		{	final EventTeam team = getTeam(player);
			if (team != null)
			player.teleToLocation(team.getSpawnLocation(), 100);
		}
		super.respawn(player);
	}
}

Cleanest TvT 2015-2016, supports N teams N locations  :-[

  • 2 weeks later...
Posted (edited)

I'm working on a system to define the properties from the amount of equipment you prefer, but show us the work is not much since much different from ours.

The project greatly improved ah and continue working in order to achieve a system in which everyone can trust.

Edited by fissban
  • 3 weeks later...
  • 2 weeks later...
  • 3 weeks later...
Posted

Lock this, he hasnt update the source 1 month now, is dead... and 100000 bugs.. dont use it even events doesnt work..

the most easy event (ctf) has 3 bugs

 

ctf is a complex event as far as you want good, clean and efficient code

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.




×
×
  • Create New...