Jump to content

Recommended Posts

Posted (edited)

You miss brackets in some places and 1st msg about adena umm..

 

Ofc it is working, cuz you do meet the requirements, so the check msg was not activated.

Give a try here.. But like that i have 1 error on last line of the code.

/*
 * This program is free software: you can redistribute it and/or modify it under
 * the terms of the GNU General Public License as published by the Free Software
 * Foundation, either version 3 of the License, or (at your option) any later
 * version.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program. If not, see <http://www.gnu.org/licenses/>.
 */
package com.l2jfrozen.gameserver.handler;
 
import com.l2jfrozen.Config;
import com.l2jfrozen.gameserver.handler.IVoicedCommandHandler;
import com.l2jfrozen.gameserver.model.actor.instance.L2PcInstance;
import com.l2jfrozen.gameserver.network.serverpackets.ItemList;
 
public class ClassItems implements IVoicedCommandHandler
{
        private static String[] _voicedCommands =
        {
                        "daggeritems", "bowitems", "tankitems", "mageitems"
        };
 
        /**
         * @see com.l2jfrozen.gameserver.handler.IVoicedCommandHandler(java.lang.String,
         *      com.l2jfrozen.gameserver.model.actor.instance.L2PcInstance, java.lang.String)
         */
        @Override
        public boolean useVoicedCommand(String command, L2PcInstance activeChar, String target)
        {
            {
                activeChar.sendMessage("You do not have enough Adena");
        }
        if(activeChar.isInOlympiadMode())
        {
                activeChar.sendMessage("Sorry,you are in the Olympiad now.");
                return false;
        }
        else if(activeChar.isInDuel())
        {
                activeChar.sendMessage("Sorry,you are in a duel!");
                return false;
        }
        else if(activeChar.atEvent)
        {
                activeChar.sendMessage("Sorry,you are on event now.");
                return false;
        }
        else if(!Config.ALT_GAME_KARMA_PLAYER_CAN_USE_GK && activeChar.getKarma() > 0)
        {
                activeChar.sendMessage("Sorry,PK player can't use this.");
                return false;
        }
        else if(activeChar.isDead())
        {
                activeChar.sendMessage("Sorry,Dead player can't take items.");                 
                return false;
        }
        else if(activeChar.isFakeDeath())
        {
                activeChar.sendMessage("Sorry,on fake death mode can't use this.");
                return false;
        }
                if(command.equalsIgnoreCase("daggeritems"))
                {
                        if(activeChar.getInventory().getInventoryItemCount(57, 0) >= Config.FIGHTER_ITEMS_PRICE)
                        {
                                activeChar.getInventory().reduceAdena("Adena", Config.FIGHTER_ITEMS_PRICE, activeChar, null);
                                activeChar.getInventory().addItem("Angel Slayer", 6367, 1, activeChar, activeChar);
                                activeChar.getInventory().addItem("Dragonic Light", 6379, 1, activeChar, activeChar );
                                activeChar.getInventory().addItem("Dragonic Boots", 6380, 1, activeChar, activeChar);
                                activeChar.getInventory().addItem("Dragonic Gloves", 6381, 1, activeChar, activeChar );
                                activeChar.getInventory().addItem("Dragonic Helmet", 6382, 1, activeChar, activeChar);
                                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar );
                                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                                activeChar.sendMessage("Now You Have Dagger Items On Your Invetory. Take a Look!.");
                }
                if(command.equalsIgnoreCase("bowitems"))
                {
                        if(activeChar.getInventory().getInventoryItemCount(57, 0) >= Config.FIGHTER_ITEMS_PRICE)
                        {
                                activeChar.getInventory().reduceAdena("Adena", Config.FIGHTER_ITEMS_PRICE, activeChar, null);
                                activeChar.getInventory().addItem("Draconic Bow", 7577, 1, activeChar, activeChar);
                                activeChar.getInventory().addItem("Draconic Light", 6379, 1, activeChar, activeChar );
                                activeChar.getInventory().addItem("Draconic Boots", 6380, 1, activeChar, activeChar);
                                activeChar.getInventory().addItem("Draconic Gloves", 6381, 1, activeChar, activeChar );
                                activeChar.getInventory().addItem("Draconic Helmet", 6382, 1, activeChar, activeChar);
                                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar );
                                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                                activeChar.sendMessage("Now You Have Bow Items On Your Invetory. Take a Look!.");

                }
                if(command.equalsIgnoreCase("tankitems"))
                {
                        if(activeChar.getInventory().getInventoryItemCount(57, 0) >= Config.FIGHTER_ITEMS_PRICE)
                        {
                                activeChar.getInventory().reduceAdena("Adena", Config.FIGHTER_ITEMS_PRICE, activeChar, null);
                                activeChar.getInventory().addItem("Forgotten Blade", 6582, 1, activeChar, activeChar);
                                activeChar.getInventory().addItem("Imperial Armor", 6373, 1, activeChar, activeChar );
                                activeChar.getInventory().addItem("Imperial ArmorP2", 6374, 1, activeChar, activeChar);
                                activeChar.getInventory().addItem("Imperial Gloves", 6375, 1, activeChar, activeChar );
                                activeChar.getInventory().addItem("Imperial Boots", 6376, 1, activeChar, activeChar);
                                activeChar.getInventory().addItem("Imperial Helmet", 6378, 1, activeChar, activeChar );
                                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar);
                                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                                activeChar.sendMessage("Now You Have Tank Items On Your Invetory. Take a Look!.");
                }
                else if(command.equalsIgnoreCase("mageitems"))
                {
                        if(activeChar.getInventory().getInventoryItemCount(57, 0) >= Config.MAGE_ITEMS_PRICE)
                        {
                                activeChar.getInventory().destroyItemByItemId("Adena", 57, Config.MAGE_ITEMS_PRICE, activeChar, null);
                                activeChar.getInventory().addItem("Arcana Mace Acumen", 6608, 1, activeChar, activeChar);
                                activeChar.getInventory().addItem("DC Robe", 2407, 1, activeChar, activeChar );
                                activeChar.getInventory().addItem("DC Gloves", 5767, 1, activeChar, activeChar);
                                activeChar.getInventory().addItem("DC Boots", 5779, 1, activeChar, activeChar );
                                activeChar.getInventory().addItem("DC Helmet", 512, 1, activeChar, activeChar);
                                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar );
                                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                                activeChar.sendMessage("Now You Have Mage Items On Your Invetory. Take a Look!");
        /**
         * @see com.l2jfrozen.gameserver.handler.IVoicedCommandHandler#getVoicedCommandList()
         */
        @Override
        public String[] getVoicedCommandList()
        {
                return _voicedCommands;
        }
}
Edited by 'Baggos'
Posted

 

            {
                activeChar.sendMessage("You do not have enough Adena");

 

To be removed. Also, in all commands you miss the close bracket of if }

Posted (edited)

Also the useVoicedCommand is a boolean, so it should return true somewhere ^_^

Edited by Tessa
Posted

And 100000 time to be shared the credits is MINE from the past. (2012).

2st, this code worked on Original L2Network project perfect. Work to me before share. and 3st, what is reput? reput is for kids. i share for help no for "reput".

I come back here on maxcheaters and i want to remmember all that i know.

This code give items with commands.

If you start a new player, you need to go in main town/Gm Shop and will buy this items. why you consider useless this topic? in one second you have all items you want for start your farm. mage or fighter or tank or bow, and jewels.

If is not work to you give me your error here...

Sorry for my english...

no need apologize for your english lol :D i just i find this useless cause already shared many times i didnt say its not yours

Posted

Also the useVoicedCommand is a boolean, so it should return true somewhere ^_^

Too many error if i change something in code.

I'll not change something. It's work like that. I can't find a way to work without all this check.

 

If someone can to make this code work without all this check, then give here to help. I have 2 year to see a code.

in the past on L2Network Project, this code helped a lot.

Posted (edited)

Too many error if i change something in code.

I'll not change something. It's work like that. I can't find a way to work without all this check.

 

If someone can to make this code work without all this check, then give here to help. I have 2 year to see a code.

in the past on L2Network Project, this code helped a lot.

You should put these checks only once and you will have a clean code.

/*
 * This program is free software: you can redistribute it and/or modify it under
 * the terms of the GNU General Public License as published by the Free Software
 * Foundation, either version 3 of the License, or (at your option) any later
 * version.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program. If not, see <http://www.gnu.org/licenses/>.
 */
package com.l2jfrozen.gameserver.handler.voicedcommandhandlers;
 
import com.l2jfrozen.Config;
import com.l2jfrozen.gameserver.handler.IVoicedCommandHandler;
import com.l2jfrozen.gameserver.model.actor.instance.L2PcInstance;
import com.l2jfrozen.gameserver.network.serverpackets.ItemList;
 
public class ClassItems implements IVoicedCommandHandler
{
        private static String[] _voicedCommands =
        {
                        "daggeritems", "bowitems", "tankitems", "mageitems"
        };
 
        /**
         * @see com.l2jfrozen.gameserver.handler.IVoicedCommandHandler(java.lang.String,
         *      com.l2jfrozen.gameserver.model.actor.instance.L2PcInstance, java.lang.String)
         */
        @Override
        public boolean useVoicedCommand(String command, L2PcInstance activeChar, String target)
        {
            if(activeChar.getInventory().getInventoryItemCount(57, 0) < Config.FIGHTER_ITEMS_PRICE)
            {
                        activeChar.sendMessage("You do not have enough Adena");
                        return false;
            }

            if (activeChar.isInOlympiadMode())
            {
                        activeChar.sendMessage("Sorry,you are in the Olympiad now.");
                        return false;
            }
            else if (activeChar.isInDuel())
            {
                        activeChar.sendMessage("Sorry,you are in a duel!");
                        return false;
            }
            else if (activeChar.atEvent)
            {
                        activeChar.sendMessage("Sorry,you are on event now.");
                        return false;
            }
            else if (!Config.ALT_GAME_KARMA_PLAYER_CAN_USE_GK && activeChar.getKarma() > 0)
            {
                        activeChar.sendMessage("Sorry,PK player can't use this.");
                        return false;
            }
            else if (activeChar.isDead())
            {
                        activeChar.sendMessage("Sorry,Dead player can't take items.");                 
                        return false;
            }
            else if (activeChar.isFakeDeath())
            {
                        activeChar.sendMessage("Sorry,on fake death mode can't use this.");
                        return false;
            }
            if(command.equalsIgnoreCase("daggeritems"))
            {
                activeChar.getInventory().reduceAdena("Adena", Config.FIGHTER_ITEMS_PRICE, activeChar, null);
                activeChar.getInventory().addItem("Angel Slayer", 6367, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Dragonic Light", 6379, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Dragonic Boots", 6380, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Dragonic Gloves", 6381, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Dragonic Helmet", 6382, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                activeChar.sendMessage("Now You Have Dagger Items On Your Invetory. Take a Look!.");
            }
            else if (command.equalsIgnoreCase("bowitems"))
            {
                activeChar.getInventory().reduceAdena("Adena", Config.FIGHTER_ITEMS_PRICE, activeChar, null);
                activeChar.getInventory().addItem("Draconic Bow", 7577, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Draconic Light", 6379, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Draconic Boots", 6380, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Draconic Gloves", 6381, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Draconic Helmet", 6382, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                activeChar.sendMessage("Now You Have Bow Items On Your Invetory. Take a Look!.");
            }
            else if (command.equalsIgnoreCase("tankitems"))
            {
                activeChar.getInventory().reduceAdena("Adena", Config.FIGHTER_ITEMS_PRICE, activeChar, null);
                activeChar.getInventory().addItem("Forgotten Blade", 6582, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Imperial Armor", 6373, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Imperial ArmorP2", 6374, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Imperial Gloves", 6375, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Imperial Boots", 6376, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Imperial Helmet", 6378, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                activeChar.sendMessage("Now You Have Tank Items On Your Invetory. Take a Look!.");
            }
            else if (command.equalsIgnoreCase("mageitems"))
            {
                activeChar.getInventory().destroyItemByItemId("Adena", 57, Config.MAGE_ITEMS_PRICE, activeChar, null);
                activeChar.getInventory().addItem("Arcana Mace Acumen", 6608, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("DC Robe", 2407, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("DC Gloves", 5767, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("DC Boots", 5779, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("DC Helmet", 512, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                activeChar.sendMessage("Now You Have Mage Items On Your Invetory. Take a Look!");
            }
            return true;
        }
 
        /**
         * @see com.l2jfrozen.gameserver.handler.IVoicedCommandHandler#getVoicedCommandList()
         */
        @Override
        public String[] getVoicedCommandList()
        {
                return _voicedCommands;
        }
}
Edited by Tessa
Posted (edited)

 

You should put these checks only once and you will have a clean code.

/*
 * This program is free software: you can redistribute it and/or modify it under
 * the terms of the GNU General Public License as published by the Free Software
 * Foundation, either version 3 of the License, or (at your option) any later
 * version.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program. If not, see <http://www.gnu.org/licenses/>.
 */
package com.l2jfrozen.gameserver.handler.voicedcommandhandlers;
 
import com.l2jfrozen.Config;
import com.l2jfrozen.gameserver.handler.IVoicedCommandHandler;
import com.l2jfrozen.gameserver.model.actor.instance.L2PcInstance;
import com.l2jfrozen.gameserver.network.serverpackets.ItemList;
 
public class ClassItems implements IVoicedCommandHandler
{
        private static String[] _voicedCommands =
        {
                        "daggeritems", "bowitems", "tankitems", "mageitems"
        };
 
        /**
         * @see com.l2jfrozen.gameserver.handler.IVoicedCommandHandler(java.lang.String,
         *      com.l2jfrozen.gameserver.model.actor.instance.L2PcInstance, java.lang.String)
         */
        @Override
        public boolean useVoicedCommand(String command, L2PcInstance activeChar, String target)
        {
            if(activeChar.getInventory().getInventoryItemCount(57, 0) >= Config.FIGHTER_ITEMS_PRICE)
            {
                        activeChar.sendMessage("You do not have enough Adena");
                        return false;
            }
            if(activeChar.isInOlympiadMode())
            {
                        activeChar.sendMessage("Sorry,you are in the Olympiad now.");
                        return false;
            }
            if(activeChar.isInDuel())
            {
                        activeChar.sendMessage("Sorry,you are in a duel!");
                        return false;
            }
            if(activeChar.atEvent)
            {
                        activeChar.sendMessage("Sorry,you are on event now.");
                        return false;
            }
            if(!Config.ALT_GAME_KARMA_PLAYER_CAN_USE_GK && activeChar.getKarma() > 0)
            {
                        activeChar.sendMessage("Sorry,PK player can't use this.");
                        return false;
            }
            if(activeChar.isDead())
            {
                        activeChar.sendMessage("Sorry,Dead player can't take items.");                 
                        return false;
            }
            if(activeChar.isFakeDeath())
            {
                        activeChar.sendMessage("Sorry,on fake death mode can't use this.");
                        return false;
            }
            if(command.equalsIgnoreCase("daggeritems"))
            {
                activeChar.getInventory().reduceAdena("Adena", Config.FIGHTER_ITEMS_PRICE, activeChar, null);
                activeChar.getInventory().addItem("Angel Slayer", 6367, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Dragonic Light", 6379, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Dragonic Boots", 6380, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Dragonic Gloves", 6381, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Dragonic Helmet", 6382, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                activeChar.sendMessage("Now You Have Dagger Items On Your Invetory. Take a Look!.");
            }
            else if (command.equalsIgnoreCase("bowitems"))
            {
                activeChar.getInventory().reduceAdena("Adena", Config.FIGHTER_ITEMS_PRICE, activeChar, null);
                activeChar.getInventory().addItem("Draconic Bow", 7577, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Draconic Light", 6379, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Draconic Boots", 6380, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Draconic Gloves", 6381, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Draconic Helmet", 6382, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                activeChar.sendMessage("Now You Have Bow Items On Your Invetory. Take a Look!.");
            }
            else if (command.equalsIgnoreCase("tankitems"))
            {
                activeChar.getInventory().reduceAdena("Adena", Config.FIGHTER_ITEMS_PRICE, activeChar, null);
                activeChar.getInventory().addItem("Forgotten Blade", 6582, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Imperial Armor", 6373, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Imperial ArmorP2", 6374, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Imperial Gloves", 6375, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Imperial Boots", 6376, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Imperial Helmet", 6378, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                activeChar.sendMessage("Now You Have Tank Items On Your Invetory. Take a Look!.");
            }
            else if (command.equalsIgnoreCase("mageitems"))
            {
                activeChar.getInventory().destroyItemByItemId("Adena", 57, Config.MAGE_ITEMS_PRICE, activeChar, null);
                activeChar.getInventory().addItem("Arcana Mace Acumen", 6608, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("DC Robe", 2407, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("DC Gloves", 5767, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("DC Boots", 5779, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("DC Helmet", 512, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                activeChar.sendMessage("Now You Have Mage Items On Your Invetory. Take a Look!");
            }
            return true;
        }
 
        /**
         * @see com.l2jfrozen.gameserver.handler.IVoicedCommandHandler#getVoicedCommandList()
         */
        @Override
        public String[] getVoicedCommandList()
        {
                return _voicedCommands;
        }
}

I have try with this and before, and i take error on the last line before "return true".

But i have problem with my eclipse... maybe here is the problem...

Edited by 'Baggos'
Posted

I have try with this and before, and i take error on the last line before "return true".

But i have problem with my eclipse... maybe here is the problem...

Yes Tessa... Is right. Thank you. I realized my mistake.

Posted (edited)
if(activeChar.getInventory().getInventoryItemCount(57, 0) >= Config.FIGHTER_ITEMS_PRICE)
{
activeChar.sendMessage("You do not have enough Adena");
return false;
}

Tessa... Seriously '>=' ? :happyforever:

 

Also, those checks should be if, else if. There is no need to check them all ++ you will get few messages.

Edited by SweeTs
Posted (edited)
if(activeChar.getInventory().getInventoryItemCount(57, 0) >= Config.FIGHTER_ITEMS_PRICE)
{
activeChar.sendMessage("You do not have enough Adena");
return false;
}

Tessa... Seriously '>=' ? :happyforever:

 

Also, those checks should be if, else if. There is no need to check them all ++ you will get few messages.

 

I've copied one of the checks in the pastebin version :lol:

I've no idea what happened to the else if because they was ok in the editor :|

 

EDIT: Fixed ^_^

Edited by Tessa
Posted
if(activeChar.getInventory().getInventoryItemCount(57, 0) >= Config.FIGHTER_ITEMS_PRICE)
{
activeChar.sendMessage("You do not have enough Adena");
return false;
}

Tessa... Seriously '>=' ? :happyforever:

 

Also, those checks should be if, else if. There is no need to check them all ++ you will get few messages.

 

I have change something here.. Is still wrong like that?

 

/*
 * This program is free software: you can redistribute it and/or modify it under
 * the terms of the GNU General Public License as published by the Free Software
 * Foundation, either version 3 of the License, or (at your option) any later
 * version.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
 * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
 * details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program. If not, see <http://www.gnu.org/licenses/>.
 */
package com.l2jfrozen.gameserver.handler.voicedcommandhandlers;
 
import com.l2jfrozen.Config;
import com.l2jfrozen.gameserver.handler.IVoicedCommandHandler;
import com.l2jfrozen.gameserver.model.actor.instance.L2PcInstance;
 
public class ClassItems implements IVoicedCommandHandler
{
        private static String[] _voicedCommands =
        {
                        "daggeritems", "bowitems", "tankitems", "mageitems"
        };
 
        /**
         * @see com.l2jfrozen.gameserver.handler.IVoicedCommandHandler(java.lang.String,
         *      com.l2jfrozen.gameserver.model.actor.instance.L2PcInstance, java.lang.String)
         */
        @SuppressWarnings("javadoc")
        @Override
        public boolean useVoicedCommand(String command, L2PcInstance activeChar, String target)
        {
            if(activeChar.isInOlympiadMode())
            {
                        activeChar.sendMessage("Sorry,you are in the Olympiad now.");
                        return false;
            }
            if(activeChar.isInDuel())
            {
                        activeChar.sendMessage("Sorry,you are in a duel!");
                        return false;
            }
            if(activeChar.atEvent)
            {
                        activeChar.sendMessage("Sorry,you are on event now.");
                        return false;
            }
            if(!Config.ALT_GAME_KARMA_PLAYER_CAN_USE_GK && activeChar.getKarma() > 0)
            {
                        activeChar.sendMessage("Sorry,PK player can't use this.");
                        return false;
            }
            if(activeChar.isDead())
            {
                        activeChar.sendMessage("Sorry,Dead player can't take items.");                 
                        return false;
            }
            if(activeChar.isFakeDeath())
            {
                        activeChar.sendMessage("Sorry,on fake death mode can't use this.");
                        return false;
            }
            if(command.equalsIgnoreCase("daggeritems"))
            {
            }
                if(activeChar.getInventory().getInventoryItemCount(57, 0) >= Config.FIGHTER_ITEMS_PRICE)
                {    
                activeChar.getInventory().reduceAdena("Adena", Config.FIGHTER_ITEMS_PRICE, activeChar, null);
                activeChar.getInventory().addItem("Angel Slayer", 6367, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Dragonic Light", 6379, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Dragonic Boots", 6380, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Dragonic Gloves", 6381, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Dragonic Helmet", 6382, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                activeChar.sendMessage("Now You Have Dagger Items On Your Invetory. Take a Look!.");
            }
            else if (command.equalsIgnoreCase("bowitems"))
            {
                activeChar.getInventory().reduceAdena("Adena", Config.FIGHTER_ITEMS_PRICE, activeChar, null);
                activeChar.getInventory().addItem("Draconic Bow", 7577, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Draconic Light", 6379, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Draconic Boots", 6380, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Draconic Gloves", 6381, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Draconic Helmet", 6382, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                activeChar.sendMessage("Now You Have Bow Items On Your Invetory. Take a Look!.");
            }
            else if (command.equalsIgnoreCase("tankitems"))
            {
                activeChar.getInventory().reduceAdena("Adena", Config.FIGHTER_ITEMS_PRICE, activeChar, null);
                activeChar.getInventory().addItem("Forgotten Blade", 6582, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Imperial Armor", 6373, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Imperial ArmorP2", 6374, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Imperial Gloves", 6375, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Imperial Boots", 6376, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Imperial Helmet", 6378, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                activeChar.sendMessage("Now You Have Tank Items On Your Invetory. Take a Look!.");
            }
            else if (command.equalsIgnoreCase("mageitems"))
            {
                if(activeChar.getInventory().getInventoryItemCount(57, 0) >= Config.MAGE_ITEMS_PRICE)
            {
                activeChar.getInventory().destroyItemByItemId("Adena", 57, Config.MAGE_ITEMS_PRICE, activeChar, null);
                activeChar.getInventory().addItem("Arcana Mace Acumen", 6608, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("DC Robe", 2407, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("DC Gloves", 5767, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("DC Boots", 5779, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("DC Helmet", 512, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                activeChar.sendMessage("Now You Have Mage Items On Your Invetory. Take a Look!");
                activeChar.sendMessage("You do not have enough Adena");
                return false;
            }
            return true;
        }
                return false;
        }
 
        /**
         * @see com.l2jfrozen.gameserver.handler.IVoicedCommandHandler#getVoicedCommandList()
         */
        @Override
        public String[] getVoicedCommandList()
        {
                return _voicedCommands;
        }
}
Posted (edited)

Yes, it's wrong .. :happyforever: Also, this check is kinda.. poor to don't be rude

 

 

if (!Config.ALT_GAME_KARMA_PLAYER_CAN_USE_GK && activeChar.getKarma() > 0)

 

Delete the config check

Edited by SweeTs
Posted

Yes, it's wrong .. :happyforever: Also, this check is kinda.. poor to don't be rude

if (!Config.ALT_GAME_KARMA_PLAYER_CAN_USE_GK && activeChar.getKarma() > 0)

Delete the config check

What is right for you?

i have pass check for adena Mage and fighter items.

I don't say about this line "if (!Config.ALT_GAME_KARMA_PLAYER_CAN_USE_GK && activeChar.getKarma() > 0)".

only for check in adena, why is wrong?

Posted

That's plain wrong and few more. Enable errors on Eclipse and you will see it :)

 

 

        @SuppressWarnings("javadoc")
 
------------------
 
            if(command.equalsIgnoreCase("daggeritems"))
            {
            }
                if(activeChar.getInventory().getInventoryItemCount(57, 0) >= Config.FIGHTER_ITEMS_PRICE)
                {    
                activeChar.getInventory().reduceAdena("Adena", Config.FIGHTER_ITEMS_PRICE, activeChar, null);
                activeChar.getInventory().addItem("Angel Slayer", 6367, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Dragonic Light", 6379, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Dragonic Boots", 6380, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("Dragonic Gloves", 6381, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("Dragonic Helmet", 6382, 1, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Necklace", 920, 1, activeChar, activeChar );
                activeChar.getInventory().addItem("TEO Earring", 858, 2, activeChar, activeChar);
                activeChar.getInventory().addItem("TEO Ring", 889, 2, activeChar, activeChar );
                activeChar.sendMessage("Now You Have Dagger Items On Your Invetory. Take a Look!.");
            }
 
-----
 
        }
                return false;

 

Basically, I should junk the topic, cuz of the code, but.. Out of respect for you, I won't.

 

Check Tessa version, it's good. Only checks should be if / else if.

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now



  • Posts

    • @Darafamboos let him know that this is already shared
    • Selling for 35 us umodel that opens any ukx , utx and static meshes from samurai updat 542 protocol . Leave me a pm if needed. 
    • TG Support: https://t.me/buyingproxysup | Channel: https://t.me/buyingproxycom Discord support: #buyingproxy | Server: Join the BuyingProxy Discord Server!  Create your free account here
    • NEW HIDDENSTASH KEY SYSTEM INTRODUCED TO THE SITE   **Earn While You Spend - Introducing HS Cashback!**   Every purchase on our site now rewards you with **HS Keys cashback**   EVERY ONE WHO REGISTERS IN SITE UNTILL 15TH OF MAY GETS 2000 HS KEYS IN HES BALANE   Here's how it works:       **1 USD = 1000 HS Keys**   **Get 3% cashback** on every purchase   **Use your HS Keys to **save on your next order**   ---   ### ⚡ Why this is awesome   * Every order gives you value back   * Stack it with promos & HS usage   * Turn your spending into future discounts   ---   ### Example   Spend **$10** → Get **300 HS Keys** back   Spend **$50** → Get **1500 HS Keys** back   ---   ### Smart system (built for fairness)   * Cashback is rounded to keep things balanced   * Prevents abuse from tiny orders   * Rewards real buyers   ---   ### Start earning now   Every purchase = progress toward your next discount   Shop now and build your HS balance!   #cashback #gamingdeals #d2r #rewards #loyalty   Stay safe out there, heroes - and happy hunting! www.d2rhiddenstash.com     We just launched our new Affiliate Program — and it’s the easiest way to earn HS Keys.   Invite your friends using your personal link.   Example: If your friend spends $10 → you get 300 HS Keys No limits. No effort. Just share your link.   Get your referral link here: www.d2rhiddenstash.com/profile     Start earning today
    • It’s time for something new to rise. In a world filled with short-lived projects and empty promises, Emerge was created with a different vision — a vision built on experience, precision, and long-term commitment. This is not just another server launch. This is the beginning of something that is meant to last. 🌑 Eclipse x10 – A New Beginning Eclipse x10 is designed for players who seek more than just fast progression. It is built for those who value competition, balance, and a real Lineage II experience. From the very first day, every system has been carefully adjusted to provide a smooth and fair journey — where both solo players and clans can thrive. No shortcuts. No chaos. Only a structured and competitive world. ⚔️ What Awaits You • A balanced mid-rate environment (x10 core progression) • Stable and optimized gameplay • Fair systems with focus on long-term play • Competitive PvP and rewarding PvE • Active and dedicated administration • A project built with vision, not temporary hype 📊 Server Rates Basic: EXP/SP: x10 Adena: x5 Drop: x5 Spoil: x5 Secondary: Quests: x1 Seal Stones: x5 Life Stone Drop: x1 Enchant Scroll Drop: x1 Bosses: Raid Boss EXP/SP: x1 Raid Boss Drop: x1 Epic Boss EXP/SP: x1 Epic Boss Drop: x1 Enchant: Safe: +3 Max: +16 📅 Launch Information Grand Opening: 5 June 2026 The countdown has already begun. Clans are forming. Strategies are being prepared. The question is — will you be ready? 🔗 Join the Community Every strong server begins with a strong community. Be part of it from the very start. 💬 Discord: https://discord.gg/l2emerge 🌐 Website: https://www.l2emerge.com  
  • Topics

×
×
  • Create New...

Important Information

This community uses essential cookies to function properly. Non-essential cookies and third-party services are used only with your consent. Read our Privacy Policy and We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue..