Jump to content

Recommended Posts

Posted

well... not bad share at all. Good HTMLs, etc.. But if my eyes doesn't tricks me inside DropInfo.java you made totally same code X3 repeated and the only difference is the "htmlFile" move it to one method like..

 

private void showDropInfo(final String path) {
try {
   html.setFile(activeChar.getHtmlPrefix(), path);

 

than use it like...

if (command.startsWith("drop"))
   showDropInfo("data/html/custom/mobdrop.htm");
if (command.startsWith("spoil"))
   showDropInfo("data/html/custom/mobspoil.htm");

 

and the last thing... even if you use int, or enum, (or even String but just up to Java 7) when you have possibility ALWAYS use switch... like this:

 

switch (item.getCrystalType()) {
   case 0:
     smind = "<img src=\"L2UI_CH3.joypad_shortcut\" width=16 height=16>";
   break;
   case 1:
    smind = "<img src=\"L2UI_CT1.Icon_DF_ItemGrade_D\" width=16 height=16>";
    break;
.... etc
}

  • 2 weeks later...
Posted

When you target Knoriks in the lair of antharas and you wanna look into his droplist client get crashed.

And when you target Guide Solins from the MOs then have the Weapons a drop chance from 0%

Please fix this thx

 

 

same problem, i cannot find fix for this, crash in allgrandboss, allmobs dragon valley (h5)

  • 1 month later...
  • 1 month later...
  • 2 weeks later...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.




×
×
  • Create New...