Gurment Posted January 29, 2013 Posted January 29, 2013 Great share thanks, but I believe you should create a patch. It will be more easier if someone want to change something in it. Quote
lord_rex Posted January 29, 2013 Posted January 29, 2013 well... not bad share at all. Good HTMLs, etc.. But if my eyes doesn't tricks me inside DropInfo.java you made totally same code X3 repeated and the only difference is the "htmlFile" move it to one method like.. private void showDropInfo(final String path) { try { html.setFile(activeChar.getHtmlPrefix(), path); than use it like... if (command.startsWith("drop")) showDropInfo("data/html/custom/mobdrop.htm"); if (command.startsWith("spoil")) showDropInfo("data/html/custom/mobspoil.htm"); and the last thing... even if you use int, or enum, (or even String but just up to Java 7) when you have possibility ALWAYS use switch... like this: switch (item.getCrystalType()) { case 0: smind = "<img src=\"L2UI_CH3.joypad_shortcut\" width=16 height=16>"; break; case 1: smind = "<img src=\"L2UI_CT1.Icon_DF_ItemGrade_D\" width=16 height=16>"; break; .... etc } Quote
VeNoM™ Posted January 29, 2013 Posted January 29, 2013 Amazing share man thanks :) i will use it :P Some errors on html but i fix it :P Good Luck Quote
yakuza Posted January 29, 2013 Posted January 29, 2013 Thx for share is goud i test it on h5 work perfectly some modification in Html Mobinfo Quote
StarSCreams Posted February 10, 2013 Posted February 10, 2013 When you target Knoriks in the lair of antharas and you wanna look into his droplist client get crashed. And when you target Guide Solins from the MOs then have the Weapons a drop chance from 0% Please fix this thx same problem, i cannot find fix for this, crash in allgrandboss, allmobs dragon valley (h5) Quote
Stereotype Posted February 10, 2013 Posted February 10, 2013 Some errors in html... and the crashes ... appears to me the same! Quote
Napster321 Posted February 10, 2013 Posted February 10, 2013 Some errors in html... and the crashes ... appears to me the same! try to use clan/ally/quest functions on hich priests :) Quote
PartyAnimaL88 Posted February 17, 2013 Posted February 17, 2013 Great thnx for your time and share Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.