Jump to content

Recommended Posts

Posted

well... not bad share at all. Good HTMLs, etc.. But if my eyes doesn't tricks me inside DropInfo.java you made totally same code X3 repeated and the only difference is the "htmlFile" move it to one method like..

 

private void showDropInfo(final String path) {
try {
   html.setFile(activeChar.getHtmlPrefix(), path);

 

than use it like...

if (command.startsWith("drop"))
   showDropInfo("data/html/custom/mobdrop.htm");
if (command.startsWith("spoil"))
   showDropInfo("data/html/custom/mobspoil.htm");

 

and the last thing... even if you use int, or enum, (or even String but just up to Java 7) when you have possibility ALWAYS use switch... like this:

 

switch (item.getCrystalType()) {
   case 0:
     smind = "<img src=\"L2UI_CH3.joypad_shortcut\" width=16 height=16>";
   break;
   case 1:
    smind = "<img src=\"L2UI_CT1.Icon_DF_ItemGrade_D\" width=16 height=16>";
    break;
.... etc
}

  • 2 weeks later...
Posted

When you target Knoriks in the lair of antharas and you wanna look into his droplist client get crashed.

And when you target Guide Solins from the MOs then have the Weapons a drop chance from 0%

Please fix this thx

 

 

same problem, i cannot find fix for this, crash in allgrandboss, allmobs dragon valley (h5)

  • 1 month later...
  • 1 month later...
  • 2 weeks later...

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now



×
×
  • Create New...

AdBlock Extension Detected!

Our website is made possible by displaying online advertisements to our members.

Please disable AdBlock browser extension first, to be able to use our community.

I've Disabled AdBlock