Code Rank Pvp System 3.8.9 [Il - H5]

[O_o]

BTW. It was not DC it was Client Crash ;) This crash can happened when htm file have missing tag or error.

I will check again all htm files, for sure ;)

RankPvpSystemConfig eclipse error latest l2j h5 beta hast change in config.java http://trac.l2jserver.com/changeset/6194#file1

[snacks]

RankPvpSystemBBSManager

if(command.startsWith("_bbsrps:")

Index.html

<button value="PvP Ranking" action="bypass _bbsrps;0" width=260 height=32>

[<< Masterio >>]

1. I repeat, it is ONLY for H5 Chrinicles, I will fit it to lower chronicles after beta tests.

2. New revision:

 

Download

 

 

v3.7.3 [26.09.2013]:

  + Reworked ImageConverter classes. Now is faster and cleaner  [probably no more problems with import to all chronicles].
  + Fixed index.htm example for community board (thanks snacks).
  + Reworked RankPvpSystemConfig, changed L2Properties to Properties (thanks O_o).

Edited September 26, 2013 by matthewmaster04

[O_o]

there is one error left in eclipse at rankpvpsystem.java -> getClanId

Edited September 26, 2013 by O_o

[<< Masterio >>]

quick fix for clan checkers:

 

Download

[valanths1990]

you still working on that and for free! thanks for your share,what i can say keep up the amazing work!

[<< Masterio >>]

I just skill java for fun ;)

[<< Masterio >>]

RPS 3.7.4 for H5, H5 Beta, Freya, Frozen, aCis.

 

Thx for using ;) 

[numl0ckas]

Omg, thanks man!!!

[andon19]

You should check at l2jfrozen version EnterWorld.java is it right?

[<< Masterio >>]

		// Rank PvP System by Masterio:
		if(RankPvpSystemConfig.NICK_COLOR_ENABLED || RankPvpSystemConfig.TITLE_COLOR_ENABLED)
		{
			KillerPvpStats activeCharPvpStats = PvpTable.getInstance().getKillerPvpStats(activeChar.getObjectId());
			
			if(RankPvpSystemConfig.NICK_COLOR_ENABLED)
			{
				activeChar.getAppearance().setNameColor(activeCharPvpStats.getRank().getNickColor());
			}
			
			if(RankPvpSystemConfig.TITLE_COLOR_ENABLED)
			{
				activeChar.getAppearance().setTitleColor(activeCharPvpStats.getRank().getTitleColor());
			}
		}

i removed some lines you can paste it there.

 

If you have objections, write here.

[andon19]

Thank you for everything.. :) Well you have done an excellent job and if i had the opportunity i will had donate on  you. You deserve it :)

 

but i had this problem on compiling :

 

  [javac] C:\Documents and Settings\Owner\workspace\L2Server\gameserver\head-src\com\l2jfrozen\gameserver\network\clientpackets\EnterWorld.java:722: error: cannot find symbol

    [javac] KillerPvpStats activeCharPvpStats = PvpTable.getInstance().getKillerPvpStats(activeChar.getObjectId());

    [javac] ^

    [javac]   symbol:   class KillerPvpStats

    [javac]   location: class EnterWorld

    [javac] 1 error

    [javac] 1 warning

Edited October 2, 2013 by andon19

[<< Masterio >>]

KillerPvpStats <- this is the claas from my package, just correct imports check if u have this line in imports:

import com.l2jfrozen.gameserver.masteriopack.rankpvpsystem.KillerPvpStats;
import com.l2jfrozen.gameserver.masteriopack.rankpvpsystem.PvpTable;
import com.l2jfrozen.gameserver.masteriopack.rankpvpsystem.RankPvpSystemConfig;

[andon19]

GG Done it! :) thank you once more 

[UnAfraid]

Nice idea!

 

BUT the implementation is not that nice..

Why didn't u wrote that as a DP sided script..

Also u're using thread-safe classes where u don't need to, and not thread-safe where u had to..

Using public variables to access from outside and methods to access inner vars is not so nice either.

Btw we use to add '_' (underscore) prefix to global variables not to local ones so you don't have to use explicit 'this.var = var'

Also we stopped using e.printStackTrace() because in windows it doesn't gets logged on log files, we use Logger for that (Same goes for System.out.println())

(new Thread(new RankPvpSystemPvpTask(player, target))).start();

 Why don't u simply use that instead.

ThreadPoolManager.getInstance().executeTask(new RankPvpSystemPvpTask(player, target));

It also executes the task in another thread without having to create new thread because there is already created a pool of threads used by the whole server.

 

Actually the code is really messed up (That's what we call spaghetti  code) that's why u have 20 pages of typo reports, i think u should start writing a bit more cleaner & safe.

Here i attach similar script i started some time ago, it doesn't supports most of the things u did but count it as an example of how i write things.

Note: This is an alpha version, totally not ready for use version, it may work but it still needs work to be done to consider it as a final version.

PvP.zip

Edited October 9, 2013 by UnAfraid