Jump to content

Professional L2J Developer Services


Recommended Posts

Posted

Let me tell you a story about codes of Elfocrash:

Few months ago i had to return a favor to a friend who did something for me, his request was simple he wanted an 'ingame player stats balancer' when i asked him what exactly he wants he placed an link pointing to this thread.

I've open it i've seen what it is and started codding it, suddenly my friend somehow found the sources of l2jesios or wtf it was, and sent them on my skype.

I wasn't really need them but he said look how it works and so i did.

I was shocked looking at the code at the first look, i mean i've never really expected an approach like the one i found!

Seriously i've never seen such way of codding things..

Dude with this way of codding things you can open an opensource project and you can be sure noone is going to touch your shit other then deleting it.

I've never seen so bad code in my life, and that's professional l2j developer really?

Few months ago i've even seen 'Oracle Certificated Developer' award on his profile, i trough he is real coder what a shame.. thanks god it was removed.

You're really lucky you know? if your customers was giving a shit how the code works, but not only if it works you wouldn't sold more then 2 shits.

 

I've shown this code to some real developers https://gist.github.com/UnAfraid/ef5e7d1173033a4220dc and they said: WTF Man how this could even work, its even larger then l2j itself!

 

Looking at comments like this just makes me sad, how clueless people are..

 

Actually I believe you don't see the real beauty here:

Really short import list (3 or 4 imports per class), huge improvement when you try to compile code.

Proper management of connection close: if (con != null) if (localThrowable2 != null) try { con.close(); } catch (Throwable x2) { localThrowable2.addSuppressed(x2); } else con.close();

All static data saved in database for easy modifications.

Duplicated code that improves readability and maintenance.

Declaration of mutators, but no use for them all fields are public.

No use of complex code, interfaces, abstract classes, polymorphism, iterations, nothing but assign and variable declarations pretty much.

All is static, no time for instantiation.

Posted

Actually I believe you don't see the real beauty here:

Really short import list (3 or 4 imports per class), huge improvement when you try to compile code.

Proper management of connection close: if (con != null) if (localThrowable2 != null) try { con.close(); } catch (Throwable x2) { localThrowable2.addSuppressed(x2); } else con.close();

All static data saved in database for easy modifications.

Duplicated code that improves readability and maintenance.

Declaration of mutators, but no use for them all fields are public.

No use of complex code, interfaces, abstract classes, polymorphism, iterations, nothing but assign and variable declarations pretty much.

All is static, no time for instantiation.

Yeah sorry i couldn't see any beauty between so much shit inside.

I like your sarcasm btw!

Posted

Let me tell you a story about codes of Elfocrash:

Few months ago i had to return a favor to a friend who did something for me, his request was simple he wanted an 'ingame player stats balancer' when i asked him what exactly he wants he placed an link pointing to this thread.

I've open it i've seen what it is and started codding it, suddenly my friend somehow found the sources of l2jesios or wtf it was, and sent them on my skype.

I wasn't really need them but he said look how it works and so i did.

I was shocked looking at the code at the first look, i mean i've never really expected an approach like the one i found!

Seriously i've never seen such way of codding things..

Dude with this way of codding things you can open an opensource project and you can be sure noone is going to touch your shit other then deleting it.

I've never seen so bad code in my life, and that's professional l2j developer really?

Few months ago i've even seen 'Oracle Certificated Developer' award on his profile, i trough he is real coder what a shame.. thanks god it was removed.

You're really lucky you know? if your customers was giving a shit how the code works, but not only if it works you wouldn't sold more then 2 shits.

 

I've shown this code to some real developers https://gist.github.com/UnAfraid/ef5e7d1173033a4220dc and they said: WTF Man how this could even work, its even larger then l2j itself!

 

Looking at comments like this just makes me sad, how clueless people are..

 

because he made a bad code doesnt prove anything at all, still I believe that the whole idea of ingame balancer is bad

Guest Elfocrash
Posted

if you check the commit comment i said myself that the code is pure SHIT and it was there for a reason. I can show you guys the current version of my balancer and part of the code (not that you cant do it yourselves lol, but UnAfraid and Zoey are great devs, but when you do something for free you dont really give the 100% of your work. Look at L2jServer as it is now. People really thing it is opensource (lol yeah and China has democracy) but the truth is that the actual devs of it have private servers with way better files than the ones that l2jserver provides now. So why should i give out such a kickass feature with a perfect code? However my clients never had something to say for paid work. Thats from me. Cheers for the interest btw.

Posted

if you check the commit comment i said myself that the code is pure SHIT and it was there for a reason. I can show you guys the current version of my balancer and part of the code (not that you cant do it yourselves lol, but UnAfraid and Zoey are great devs, but when you do something for free you dont really give the 100% of your work. Look at L2jServer as it is now. People really thing it is opensource (lol yeah and China has democracy) but the truth is that the actual devs of it have private servers with way better files than the ones that l2jserver provides now. So why should i give out such a kickass feature with a perfect code? However my clients never had something to say for paid work. Thats from me. Cheers for the interest btw.

 

Well you are totally wrong, I give everything I do for free and don't keep anything, I don't have a server and I don't work for servers.

There is no secret code shared between developers, there is no secret svns, all we do is for free, for all.

 

If you can't see that L2J is a real open source project, then you should expend some time in our forums, maybe you can learn a thing or two.

 

I not only work at L2J as main project, but also help projects with good open source spirit such as L2JFrozen.

 

I don't expect you to check trac but you will see we added hundred of missing features retail like.

 

And when I'm joking about your code, I also know you help others.

 

It's just that seeing "professional" in the title was too much for others who expend time trying to improve their skills and give the best for free.

 

Finally, I'm glad that you say that you are better now, you didn't set the bar too high :D

Posted

Well you are totally wrong, I give everything I do for free and don't keep anything, I don't have a server and I don't work for servers.

There is no secret code shared between developers, there is no secret svns, all we do is for free, for all.

 

If you can't see that L2J is a real open source project, then you should expend some time in our forums, maybe you can learn a thing or two.

 

I not only work at L2J as main project, but also help projects with good open source spirit such as L2JFrozen.

 

I don't expect you to check trac but you will see we added hundred of missing features retail like.

 

And when I'm joking about your code, I also know you help others.

 

It's just that seeing "professional" in the title was too much for others who expend time trying to improve their skills and give the best for free.

 

Finally, I'm glad that you say that you are better now, you didn't set the bar too high :D

 

I was with the idea, that if a guy who makes a bunch of codes is a developer or a proffessional developer (general speaking), then what the fack are those who coded l2j from scratch? gods?

Posted

I was with the idea, that if a guy who makes a bunch of codes is a developer or a proffessional developer (general speaking), then what the fack are those who coded l2j from scratch? gods?

L2J was coded by many devs with the time.

if you check the commit comment i said myself that the code is pure SHIT and it was there for a reason. I can show you guys the current version of my balancer and part of the code (not that you cant do it yourselves lol, but UnAfraid and Zoey are great devs, but when you do something for free you dont really give the 100% of your work. Look at L2jServer as it is now. People really thing it is opensource (lol yeah and China has democracy) but the truth is that the actual devs of it have private servers with way better files than the ones that l2jserver provides now. So why should i give out such a kickass feature with a perfect code? However my clients never had something to say for paid work. Thats from me. Cheers for the interest btw.

Of course we give our best there.

We may have servers but our servers are different only because of some custom codes which we haven't committed in l2j.

But isn't that the point of l2j to provide stable server and everyone to customize it as he likes? :)

I checked some other codes i really don't think that they are any closer to 'Professional'.

Posted

L2J was coded by many devs with the time.Of course we give our best there.

We may have servers but our servers are different only because of some custom codes which we haven't committed in l2j.

But isn't that the point of l2j to provide stable server and everyone to customize it as he likes? :)

I checked some other codes i really don't think that they are any closer to 'Professional'.

 

still dc shits on u, I didnt see anywhere saying that l2j sucks etc etc (just saying)

Guest Elfocrash
Posted

What i said wasn't on Zoey or UnAfraid but tell me about nBd or Nik and these are just 2 examples.

So yeah what i said is totally correct. Zoey and UnAfraid might really try for something better but don't say i am wrong on that i said.

Also about the professional thingy, you really know shit about marketing and promotion don't you? (No offense)

Posted

What i said wasn't on Zoey or UnAfraid but tell me about nBd or Nik and these are just 2 examples.

So yeah what i said is totally correct. Zoey and UnAfraid might really try for something better but don't say i am wrong on that i said.

Also about the professional thingy, you really know shit about marketing and promotion don't you? (No offense)

 

Well, it seems that your marketing works. Everyone is saying "The Best developer ever"

Small world

Posted

What i said wasn't on Zoey or UnAfraid but tell me about nBd or Nik and these are just 2 examples.

So yeah what i said is totally correct. Zoey and UnAfraid might really try for something better but don't say i am wrong on that i said.

Also about the professional thingy, you really know shit about marketing and promotion don't you? (No offense)

This is not an excuse to code like that..

You've spend even more time to make all that in such a wrong way.

The real-time balancer i had to do thing took me around 15-20 mins (Including tests) in such simple way allowing to change ANY possible Stats that exists.

Here's it https://gist.github.com/UnAfraid/6cbb728c3210fb6ad178

 

My point is when you claiming that you're selling 'Professional' development services, your code should looks like at least good.

  • 2 weeks later...
Posted

This is not an excuse to code like that..

You've spend even more time to make all that in such a wrong way.

The real-time balancer i had to do thing took me around 15-20 mins (Including tests) in such simple way allowing to change ANY possible Stats that exists.

Here's it https://gist.github.com/UnAfraid/6cbb728c3210fb6ad178

 

My point is when you claiming that you're selling 'Professional' development services, your code should looks like at least good.

 

Indeed, I reviewed his code and I was like What the f u c k ? 6k lines of code! Just creating functions and local variables and stuff but no object-orientated programing...UnAfraid is right, doesn't matter if you are paid for it or not, the way you code it reflects your experience and knowledge.

Posted

We should see more recent codes to judge. Everyone has a learning curve

Although, promoting himself as professional when he couldn't even get to a medium programmer is nasty. Marketing or not

Still, we just don't know what is his current status

Guest
This topic is now closed to further replies.



×
×
  • Create New...