[Help]Augments

[Bobi]

any ideas where can be the problem chance augment to do not work i mean they never active

i check in other project to synhronizate DP settings but still same they are never active

[Zake]

  On 4/21/2012 at 10:12 PM, Bobi said:

any ideas where can be the problem chance augment to do not work i mean they never active

i check in other project to synhronizate DP settings but still same they are never active

explain this clearer please

[Tryskell]

It's clearly not DP.

 

The different codes are in many places, such as being hitted, hitting, avoiding an hit.

 

Im lazy to open Eclipse, if no one gave you exact name I will give you tomorrow.

[Bobi]

  On 4/21/2012 at 10:18 PM, Zake said:

explain this clearer please

i mean for example augment skill id: 3086 its have chance to hold enemy but this chance never started i do same DP settings like other project where the same augment work , i dont have any errors in GS console when load or something else

[Bobi]

  On 4/21/2012 at 10:27 PM, Tryskell said:

It's clearly not DP.

 

The different codes are in many places, such as being hitted, hitting, avoiding an hit.

 

Im lazy to open Eclipse, if no one gave you exact name I will give you tomorrow.

tnx dude i will wait you tomorrow :P if on one cant help me

[Bleadd]

There is so many things that are in the equation.. Resist debuff, level of the skill ls, mdef(not sure?)

 

Anyway, all skills chance are coded like on official. So they are coded for not overbuffs players i guess..

[Bobi]

  On 4/22/2012 at 8:31 AM, Bleadd said:

There is so many things that are in the equation.. Resist debuff, level of the skill ls, mdef(not sure?)

 

Anyway, all skills chance are coded like on official. So they are coded for not overbuffs players i guess..

yes i know because i was test it on char without items,buff....... but they are never started , same test in other project is successful

 

Because i thin the problem is in Java because my DP settings are same like second project

but im not good on java and because i ask for help here

[Bobi]

bump

[Tryskell]

Correct your pack about ChanceCondition, ChanceSkillList to fit with current L2J.

 

Can be either methods uses (missing method use during an "event") or methods themselves (bad coded so event never occurs even if method is correctly launched).

[Bobi]

  On 4/23/2012 at 10:42 AM, Tryskell said:

Correct your pack about ChanceCondition, ChanceSkillList to fit with current L2J.

 

Can be either methods uses (missing method use during an "event") or methods themselves (bad coded so event never occurs even if method is correctly launched).

can you help me little more?

this is my file ChanceSkillList , can you tell me what is wrong and how to fix because im not good on java :(

 

public class ChanceSkillList extends FastMap<L2Skill, ChanceCondition>
{
private static final long	serialVersionUID	= -2542073222059976854L;
private L2Character			_owner;

public ChanceSkillList(L2Character owner)
{
	super();
	setShared(true);
	_owner = owner;
}

public L2Character getOwner()
{
	return _owner;
}

public void setOwner(L2Character owner)
{
	_owner = owner;
}

public void onHit(L2Character target, boolean ownerWasHit, boolean wasCrit)
{
	int event;
	if (ownerWasHit)
	{
		event = ChanceCondition.EVT_ATTACKED | ChanceCondition.EVT_ATTACKED_HIT;
		if (wasCrit)
			event |= ChanceCondition.EVT_ATTACKED_CRIT;
	}
	else
	{
		event = ChanceCondition.EVT_HIT;
		if (wasCrit)
			event |= ChanceCondition.EVT_CRIT;
	}

	onEvent(event, target);
}

public void onSkillHit(L2Character target, boolean ownerWasHit, boolean wasMagic, boolean wasOffensive)
{
	int event;
	if (ownerWasHit)
	{
		event = ChanceCondition.EVT_HIT_BY_SKILL;
		if (wasOffensive)
		{
			event |= ChanceCondition.EVT_HIT_BY_OFFENSIVE_SKILL;
			event |= ChanceCondition.EVT_ATTACKED;
		}
		else
		{
			event |= ChanceCondition.EVT_HIT_BY_GOOD_MAGIC;
		}
	}
	else
	{
		event = ChanceCondition.EVT_CAST;
		event |= wasMagic ? ChanceCondition.EVT_MAGIC : ChanceCondition.EVT_PHYSICAL;
		event |= wasOffensive ? ChanceCondition.EVT_MAGIC_OFFENSIVE : ChanceCondition.EVT_MAGIC_GOOD;
	}

	onEvent(event, target);
}

public void onEvent(int event, L2Character target)
{
	for (FastMap.Entry<L2Skill, ChanceCondition> e = head(), end = tail(); (e = e.getNext()) != end;)
	{
		if (e.getValue() != null && e.getValue().trigger(event))
		{
			makeCast(e.getKey(), target);
		}
	}
}

private void makeCast(L2Skill skill, L2Character target)
{
	try
	{
		L2Object[] targets = skill.getTargetList(_owner, false);
		if (targets != null && targets.length > 0)
		{
			_owner.broadcastPacket(new MagicSkillLaunched(_owner, skill.getDisplayId(), skill.getLevel(), targets));
			_owner.broadcastPacket(new MagicSkillUser(_owner, (L2Character)targets[0], skill.getDisplayId(), skill.getLevel(), 0, 0));

			// Launch the magic skill and calculate its effects
			ISkillHandler handler = SkillHandler.getInstance().getSkillHandler(skill.getSkillType());
			// Launch the magic skill and calculate its effects
			if (handler != null)
				handler.useSkill(_owner, skill, targets);
			else
				skill.useSkill(_owner, targets);
		}
	}
	catch (Exception e)
	{
		e.printStackTrace();
	}
}
}

[Tryskell]

  Quote

can you help me little more?

Nope. I don't have to make your job.

[Bobi]

  On 4/24/2012 at 8:47 AM, Tryskell said:

Nope. I don't have to make your job.

i dont want to make my job i try to make my files like l2j current but i get few errors

[Bleadd]

  Quote

i dont want to make my job

 

So don't make a server.

[Tryskell]

Ask the pack owner to correct it ?