[HELP] Java row kill system

[djpliku]

Hi guys, well i have Coyote's faction engine , the row killing system dont apply on Faction members.

On normal players work great. Can anyone help me to make it work to faction member aswell?

 

 

 

here it is

[djpliku]

BUMP

[Erol]

i don't have eclipse from where i am but give me the code for normal members to take a look.

You just have to adapt it for faction.

[djpliku]

i don't have eclipse from where i am but give me the code for normal members to take a look.

You just have to adapt it for faction.

http://www.4shared.com/document/tFzEaknB/L2PcInstance.html

here you are,

[djpliku]

BUMP

[EdenEternal]

BUMP

i never use that system please explain maybe i help you

[djpliku]

i never use that system please explain maybe i help you

Well actually when i kill sombody , a mesge apprea on announcement and a skill cast on player,

but this work perfect on normal player(check video), after i chose faction  dont work .

+ i can show you on my server

[EdenEternal]

show the patch of this kill system

[djpliku]

show the patch of this kill system

the upper link open it and find the ROW kill 

 

http://www.4shared.com/document/tFzEaknB/L2PcInstance.html

 

 

I need to make it to work onKill not on Pvp or PK

[djpliku]

BUMP

[djpliku]

BUMP

[ConArtist™]

Hi guys, well i have Coyote's faction engine , the row killing system dont apply on Faction members.

On normal players work great. Can anyone help me to make it work to faction member aswell?

 

 

 

here it is

 

this song for this code is perfect! the code is failed :S

[djpliku]

this song for this code is perfect! the code is failed :S

code fail?

 

Why ppl comment about things that they dont even know.... make better code with numbers animations etc, and after comment.

[xAddytzu]

this song for this code is perfect! the code is failed :S

what exactly is failed ?

[Tryskell]

For upper posts, don't feed trolls.

 

The SpreeKills have been added twice in 2 differents methods, wtf ? Do a search with "switch(SpreeKills)", you will see what I talk.

 

- Just create a method "SpreeKillsCall", and call it when you need it... Normally once is enough.

- Your SpreeKills isn't reseted at death... Only at delog lol. On the "doDie" method, put a "SpreeKills = 0;"

 

-----

 

Second, and this should answer your question, the 2 uses of SpreeKills are in "increasePvpKills" and "increasePkKillsAndKarma" methods.

 

"increasePkKillsAndKarma" got a faction restriction (and it's normal, to avoid to get karma). The whole method is just ignored.

 

For "increasePvpKills" method, it is surely not used in your faction system.

 

Try to verify first if you get a pvp point from an enemy.

 

If you haven't, add "increasePvpKills;" where it is needed.

If you have, you're unlucky and need more searches.

 

As I'm very cute (:>)

you will surely have to edit "onKillUpdatePvPKarma".

And as I'm INSANELY cute

it's after "// Check if it's pvp" commentary.

Normally a faction system haven't a pvpflag, so this pvp checker is failed, and works for normal players, but not for faction.

 

End of the spoiler.

 

----

 

Finally, and as old intensive player of faction servers, and developer of my own, I think the idea is a fail in the sense some guys can reach easily 400 pvps in a row (and it has really happen on a well known server), so what ? You code 400 different sprees ? Even if the render is very graphical and candy-eye looking, it's bad idea finally. Idea is good, but in gamers' reality... Well you got my point.

 

Was my 2,1 cent.

 

----

 

Try that :

 

After // Check if it's pvp, you got

 

		if (
			(
					checkIfPvP(target) &&            //   Can pvp and
					targetPlayer.getPvpFlag() != 0   //   Target player has pvp flag set
			) ||                                     // or
			(
					isInsideZone(ZONE_PVP) &&         		 //   Player is inside pvp zone and
					targetPlayer.isInsideZone(ZONE_PVP) 	 //   Target player is inside pvp zone
			)
	)
		increasePvpKills(target);
	else
	// Target player doesn't have pvp flag set
	{
		// check about wars
		if (targetPlayer.getClan() != null && getClan() != null
				&& getClan().isAtWarWith(targetPlayer.getClanId())
				&& targetPlayer.getClan().isAtWarWith(getClanId())
				&& targetPlayer.getPledgeType() != L2Clan.SUBUNIT_ACADEMY
				&& getPledgeType() != L2Clan.SUBUNIT_ACADEMY)
		{
			// 'Both way war' -> 'PvP Kill'
			increasePvpKills(target);
			return;
		}

           // 'No war' or 'One way war' -> 'Normal PK'
		if (targetPlayer.getKarma() > 0)                                        // Target player has karma
		{
			if (Config.KARMA_AWARD_PK_KILL)
                   increasePvpKills(target);
		}
		else if (targetPlayer.getPvpFlag() == 0)                                                                    // Target player doesn't have karma
		{
			increasePkKillsAndKarma(target);
			//Unequip adventurer items
			checkItemRestriction();
		}
	}

 

You have to add a code to say "hiho, i'm in a faction server, all those checks are useless and make my code buggy". For that we will use a variable, like that you can ON/OFF the system. This variable seems to be already used by your faction engine, on configs .txt part.

 

The code I wroten must be taken between that :

 

if (!Config.ENABLE_FACTION_ENGINE)
{
     code I linked
}
else
    increasePvpKills(target);

 

What it does exactly ? It bypasses all checks if the variable is set to "True", and go directly to the "increasePvpKills" method, which supposed to add you 1 pvpkill and do your abracadabra system.

 

Don't forget to remove the uselesss code you added in "increasePkKillsAndKarma". It's not needed for your faction system, except for normal players.

[djpliku]

just THX