Jump to content

Recommended Posts

Posted

I will start from credits: L2Oneo

This checks illegal skills on enter, useful especially on pvp servers you write the skills you allow on configs.

 

Patch:

Index: /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java (revision 153)
+++ /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java (revision 178)
@@ -315,4 +315,8 @@
         TvTEvent.onLogin(activeChar);
         CrownManager.getInstance().checkCrowns(activeChar);
+        if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+        {
+        	activeChar.checkIlegalSkills();
+        }
	}

Index: /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java (revision 88)
+++ /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java (revision 178)
@@ -71,5 +71,5 @@
     {
         String[] commandStr = command.split(" ");
-        String actualCommand = commandStr[0]; // Get actual command
+        String actualCommand = commandStr[0];

         String cmdParams = "";
@@ -256,4 +256,9 @@
                     content.append("Change Subclass:<br>Which of the following sub classes would you like to change?<br>");
                     int classIndex = 1;
+
+                    if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+                    {
+                    	player.checkIlegalSkills();
+                    }

                     for (Iterator<SubClass> subList = iterSubClasses(player); subList.hasNext();)
@@ -375,4 +380,9 @@
                         + CharTemplateTable.getClassNameById(player.getActiveClass()) + "</font>.");

+                    if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+                    {
+                    	player.checkIlegalSkills();
+                    }
+
                     player.sendPacket(new SystemMessage(SystemMessageId.SUBCLASS_TRANSFER_COMPLETED)); // Transfer completed.
                     break;
@@ -410,4 +420,9 @@

                         player.sendPacket(new SystemMessage(SystemMessageId.ADD_NEW_SUBCLASS)); // Subclass added.
+
+                        if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+                        {
+                        	player.checkIlegalSkills();
+                        }
                     }
                     else
Index: /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java (revision 161)
+++ /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java (revision 178)
@@ -10163,3 +10163,69 @@
		return _currentSkillWorldPosition;
	}
+
+	public void checkIlegalSkills()
+	{
+		boolean LegalSkill = false;
+
+		if (!isGM())
+		{
+			Collection<L2SkillLearn> skillTree = SkillTreeTable.getInstance().getAllowedSkills(getClassId());
+
+			for (L2Skill skill : getAllSkills())
+			{
+				int skillid = skill.getId();
+
+				LegalSkill = false;
+
+				for (L2SkillLearn temp : skillTree)
+				{
+					if (temp.getId() == skillid)
+						LegalSkill = true;
+				}
+
+				if (isCursedWeaponEquiped() && skillid == CursedWeaponsManager.getInstance().getCursedWeapon(_cursedWeaponEquipedId).getSkillId())
+				{
+					LegalSkill = true;
+				}
+
+				if (getClan() != null && (skillid >= 370 && skillid <= 391))
+				{
+					LegalSkill = true;
+				}
+
+				if (getClan() != null && (skillid == 246 || skillid == 247))
+				{
+					if (getClan().getLeaderId() == getObjectId())
+						LegalSkill = true;
+				}
+
+				if (skillid >= 1312 && skillid <= 1322)
+				{
+					LegalSkill = true;
+				}
+
+				if (skillid >= 1368 && skillid <= 1373)
+				{
+					LegalSkill = true;
+				}
+
+				if (skillid >= 3000 && skillid < 7000)
+				{
+					LegalSkill = true;
+				}
+
+				if (Config.ALLOWED_SKILLS_LIST.contains(skillid))
+				{
+					LegalSkill = true;
+				}
+
+				if (!LegalSkill)
+				{
+					removeSkill(skill);
+					sendMessage("[sVR]: Ilegal skill detected: "+skill.getName()+".");
+					sendMessage("[sVR]: The ilegal skill has been removed.");
+				}
+			}
+		}
+	}
}
Index: /trunk/Game/java/net/sf/l2j/Config.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/Config.java (revision 136)
+++ /trunk/Game/java/net/sf/l2j/Config.java (revision 178)
@@ -589,4 +589,7 @@
     public static int                  CHAMPION_REWARD_ID;
     public static int                  CHAMPION_REWARD_QTY;
+    public static boolean              CHECK_SKILLS_ON_ENTER;
+    public static String               ALLOWED_SKILLS;
+    public static FastList<Integer>    ALLOWED_SKILLS_LIST = new FastList<Integer>();
     
     /** Events */
@@ -616,12 +619,12 @@
     public static String               GAME_VERSION;
     public static String               BUILD_DATE;
-    
+
     /** Data Version */
     public static String               DATA_VERSION;

     /** HexID */
-    public static int                 SERVER_ID;
-    public static byte[]              HEX_ID;
-    
+    public static int                  SERVER_ID;
+    public static byte[]               HEX_ID;
+
     /** Custom */
     // Comming Soon !
@@ -1324,4 +1327,11 @@
                 CHAMPION_REWARD_ID                           = Integer.parseInt(Mods.getProperty("ChampionRewardItemID", "6393"));
                 CHAMPION_REWARD_QTY                          = Integer.parseInt(Mods.getProperty("ChampionRewardItemQty", "1"));
+                CHECK_SKILLS_ON_ENTER                        = Boolean.parseBoolean(Mods.getProperty("CheckSkillsOnEnter", "False"));
+                ALLOWED_SKILLS                               = Mods.getProperty("AllowedSkills", "541,542,543,544,545,546,547,548,549,550,551,552,553,554,555,556,557,558,617,618,619");
+                ALLOWED_SKILLS_LIST                          = new FastList<Integer>();
+                for (String id : ALLOWED_SKILLS.trim().split(","))
+                {
+                	ALLOWED_SKILLS_LIST.add(Integer.parseInt(id.trim()));
+                }
             }
             catch (Exception e)
@@ -1493,6 +1503,6 @@
                 Custom.load(is);
                 is.close();
-                
-                // Comming Soon
+
+                // Commgin Soon !
             }
             catch (Exception e)

I know shares that are not mine doesn't count a lot for the contest but someone might find it useful thanks thanks thanks.

Posted

this setting isnt already exist from the ready packs...?oO

Yes L2Oneo is very old pack

 

Whats the need, when the multiskill hack was fixed instead.

whar are you speaking about ?

Posted

whar are you speaking about ?

 

im talking about the stupidity of making codes to prevent "possible" hacks.. when its logical to fix the problem at its source? it means that instead of making a check on enter world or whatever.. you fix the villagemasterinstance and prevent the skill hack in the first place.

 

anyway, i guess this code is usefull if you dont know how and you wanna make something custom..

  • 7 months later...
Posted

Can create one command for this example . //checkskills and the source code checking automatic for skill and automatic delete the anonymous skills?

 

Sorry for my english ...thanks

  • 7 months later...
Posted

I will start from credits: L2Oneo

This checks illegal skills on enter, useful especially on pvp servers you write the skills you allow on configs.

 

Patch:

Index: /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java (revision 153)
+++ /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java (revision 178)
@@ -315,4 +315,8 @@
         TvTEvent.onLogin(activeChar);
         CrownManager.getInstance().checkCrowns(activeChar);
+        if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+        {
+        	activeChar.checkIlegalSkills();
+        }
	}

Index: /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java (revision 88)
+++ /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java (revision 178)
@@ -71,5 +71,5 @@
     {
         String[] commandStr = command.split(" ");
-        String actualCommand = commandStr[0]; // Get actual command
+        String actualCommand = commandStr[0];

         String cmdParams = "";
@@ -256,4 +256,9 @@
                     content.append("Change Subclass:<br>Which of the following sub classes would you like to change?<br>");
                     int classIndex = 1;
+
+                    if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+                    {
+                    	player.checkIlegalSkills();
+                    }

                     for (Iterator<SubClass> subList = iterSubClasses(player); subList.hasNext();)
@@ -375,4 +380,9 @@
                         + CharTemplateTable.getClassNameById(player.getActiveClass()) + "</font>.");

+                    if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+                    {
+                    	player.checkIlegalSkills();
+                    }
+
                     player.sendPacket(new SystemMessage(SystemMessageId.SUBCLASS_TRANSFER_COMPLETED)); // Transfer completed.
                     break;
@@ -410,4 +420,9 @@

                         player.sendPacket(new SystemMessage(SystemMessageId.ADD_NEW_SUBCLASS)); // Subclass added.
+
+                        if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+                        {
+                        	player.checkIlegalSkills();
+                        }
                     }
                     else
Index: /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java (revision 161)
+++ /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java (revision 178)
@@ -10163,3 +10163,69 @@
		return _currentSkillWorldPosition;
	}
+
+	public void checkIlegalSkills()
+	{
+		boolean LegalSkill = false;
+
+		if (!isGM())
+		{
+			Collection<L2SkillLearn> skillTree = SkillTreeTable.getInstance().getAllowedSkills(getClassId());
+
+			for (L2Skill skill : getAllSkills())
+			{
+				int skillid = skill.getId();
+
+				LegalSkill = false;
+
+				for (L2SkillLearn temp : skillTree)
+				{
+					if (temp.getId() == skillid)
+						LegalSkill = true;
+				}
+
+				if (isCursedWeaponEquiped() && skillid == CursedWeaponsManager.getInstance().getCursedWeapon(_cursedWeaponEquipedId).getSkillId())
+				{
+					LegalSkill = true;
+				}
+
+				if (getClan() != null && (skillid >= 370 && skillid <= 391))
+				{
+					LegalSkill = true;
+				}
+
+				if (getClan() != null && (skillid == 246 || skillid == 247))
+				{
+					if (getClan().getLeaderId() == getObjectId())
+						LegalSkill = true;
+				}
+
+				if (skillid >= 1312 && skillid <= 1322)
+				{
+					LegalSkill = true;
+				}
+
+				if (skillid >= 1368 && skillid <= 1373)
+				{
+					LegalSkill = true;
+				}
+
+				if (skillid >= 3000 && skillid < 7000)
+				{
+					LegalSkill = true;
+				}
+
+				if (Config.ALLOWED_SKILLS_LIST.contains(skillid))
+				{
+					LegalSkill = true;
+				}
+
+				if (!LegalSkill)
+				{
+					removeSkill(skill);
+					sendMessage("[sVR]: Ilegal skill detected: "+skill.getName()+".");
+					sendMessage("[sVR]: The ilegal skill has been removed.");
+				}
+			}
+		}
+	}
}
Index: /trunk/Game/java/net/sf/l2j/Config.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/Config.java (revision 136)
+++ /trunk/Game/java/net/sf/l2j/Config.java (revision 178)
@@ -589,4 +589,7 @@
     public static int                  CHAMPION_REWARD_ID;
     public static int                  CHAMPION_REWARD_QTY;
+    public static boolean              CHECK_SKILLS_ON_ENTER;
+    public static String               ALLOWED_SKILLS;
+    public static FastList<Integer>    ALLOWED_SKILLS_LIST = new FastList<Integer>();
     
     /** Events */
@@ -616,12 +619,12 @@
     public static String               GAME_VERSION;
     public static String               BUILD_DATE;
-    
+
     /** Data Version */
     public static String               DATA_VERSION;

     /** HexID */
-    public static int                 SERVER_ID;
-    public static byte[]              HEX_ID;
-    
+    public static int                  SERVER_ID;
+    public static byte[]               HEX_ID;
+
     /** Custom */
     // Comming Soon !
@@ -1324,4 +1327,11 @@
                 CHAMPION_REWARD_ID                           = Integer.parseInt(Mods.getProperty("ChampionRewardItemID", "6393"));
                 CHAMPION_REWARD_QTY                          = Integer.parseInt(Mods.getProperty("ChampionRewardItemQty", "1"));
+                CHECK_SKILLS_ON_ENTER                        = Boolean.parseBoolean(Mods.getProperty("CheckSkillsOnEnter", "False"));
+                ALLOWED_SKILLS                               = Mods.getProperty("AllowedSkills", "541,542,543,544,545,546,547,548,549,550,551,552,553,554,555,556,557,558,617,618,619");
+                ALLOWED_SKILLS_LIST                          = new FastList<Integer>();
+                for (String id : ALLOWED_SKILLS.trim().split(","))
+                {
+                	ALLOWED_SKILLS_LIST.add(Integer.parseInt(id.trim()));
+                }
             }
             catch (Exception e)
@@ -1493,6 +1503,6 @@
                 Custom.load(is);
                 is.close();
-                
-                // Comming Soon
+
+                // Commgin Soon !
             }
             catch (Exception e)

I know shares that are not mine doesn't count a lot for the contest but someone might find it useful thanks thanks thanks.

 

Bad skill check already excists in l2j configs, idk for old packs but the latest freya has it on configs

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now


  • Posts

    • I’m coming to you with a small update — internal testing is currently underway. We’re working on catching minor issues and resolving them before the server launch 😉 In the near future, we’re planning public tests, which you’ll all be invited to. At the same time, I’ll be sharing a few Quality of Life changes coming to L2 Genesis.   Even if you’re not interested in playing right now, but you are a long-time Lineage 2 player, feel free to join our community. We would greatly appreciate your experience and feedback to help us improve and develop our project. Join the growing L2Genesis community: https://discord.gg/mcuHsQzNCm Also check our website: https://l2genesis.com/   Offline Shop System — run your shop without being online.   Buff Shop System — playing as a buffer? When you’re not in the game, sell buffs! Reworked classic interface, adapted to Interlude — shown here with the inventory menu as an example. New custom mob drop and spoil preview. DualBox Verification System — each player can only use one active account at a time. Genesis Wiki — a collection of all essential information about items, NPCs, drops, spoils, and quests.
    • https://gitlab.com/Tryskell/acis_public nai swsta, exeis kati pio updated na mas protineis? 
    • 🔥 L2Gold Enma – High Rate PvP Interlude 🔥 Interlude Chronicle • C6 Skills • Pure PvP Experience Welcome to L2Gold Enma, a high-rate PvP server designed for players who want instant action, balanced gameplay and nonstop PvP, without pointless grinding. ⚔️ Server Rates XP / SP: x1000 Adena / Drops: x10 Chronicle: Interlude Skills: C6 balanced skills Buff duration: 2 hours No weight limit 🎮 Gameplay Philosophy Fast leveling, instant PvP Clean Interlude experience No pay-to-win mechanics Focus on skill-based PvP 🛡️ Core Features Global Gatekeeper Offline shops Auto events (TvT, DM, CTF, etc.) Retail-like Olympiad with custom balance Active Raid Bosses Easy access to PvP gear 🏰 PvP & Competition Mass PvP & clan wars Meaningful castle sieges Olympiad focused on player skill Balanced classes for both solo & group PvP ⚡ Why L2Gold Enma? Interlude nostalgia with C6 skills High rates, low grind Stable server & active development Community-focused updates 💥 Join L2Gold Enma and dominate the battlefield! This is not a farm server. This is PvP   https://l2gold-enma.com/ https://discord.com/invite/Ba9cHj3HUJ
    • Hi I'm still online for this but making backup of everything in that time I didn't organize well so let me create a pack and upload to archive.org maybe. Thanks ! we can enrich togethers this if everyone add more and more old files.
  • Topics

×
×
  • Create New...

Important Information

This community uses essential cookies to function properly. Non-essential cookies and third-party services are used only with your consent. Read our Privacy Policy and We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue..