Jump to content

Recommended Posts

Posted

I will start from credits: L2Oneo

This checks illegal skills on enter, useful especially on pvp servers you write the skills you allow on configs.

 

Patch:

Index: /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java (revision 153)
+++ /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java (revision 178)
@@ -315,4 +315,8 @@
         TvTEvent.onLogin(activeChar);
         CrownManager.getInstance().checkCrowns(activeChar);
+        if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+        {
+        	activeChar.checkIlegalSkills();
+        }
	}

Index: /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java (revision 88)
+++ /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java (revision 178)
@@ -71,5 +71,5 @@
     {
         String[] commandStr = command.split(" ");
-        String actualCommand = commandStr[0]; // Get actual command
+        String actualCommand = commandStr[0];

         String cmdParams = "";
@@ -256,4 +256,9 @@
                     content.append("Change Subclass:<br>Which of the following sub classes would you like to change?<br>");
                     int classIndex = 1;
+
+                    if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+                    {
+                    	player.checkIlegalSkills();
+                    }

                     for (Iterator<SubClass> subList = iterSubClasses(player); subList.hasNext();)
@@ -375,4 +380,9 @@
                         + CharTemplateTable.getClassNameById(player.getActiveClass()) + "</font>.");

+                    if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+                    {
+                    	player.checkIlegalSkills();
+                    }
+
                     player.sendPacket(new SystemMessage(SystemMessageId.SUBCLASS_TRANSFER_COMPLETED)); // Transfer completed.
                     break;
@@ -410,4 +420,9 @@

                         player.sendPacket(new SystemMessage(SystemMessageId.ADD_NEW_SUBCLASS)); // Subclass added.
+
+                        if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+                        {
+                        	player.checkIlegalSkills();
+                        }
                     }
                     else
Index: /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java (revision 161)
+++ /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java (revision 178)
@@ -10163,3 +10163,69 @@
		return _currentSkillWorldPosition;
	}
+
+	public void checkIlegalSkills()
+	{
+		boolean LegalSkill = false;
+
+		if (!isGM())
+		{
+			Collection<L2SkillLearn> skillTree = SkillTreeTable.getInstance().getAllowedSkills(getClassId());
+
+			for (L2Skill skill : getAllSkills())
+			{
+				int skillid = skill.getId();
+
+				LegalSkill = false;
+
+				for (L2SkillLearn temp : skillTree)
+				{
+					if (temp.getId() == skillid)
+						LegalSkill = true;
+				}
+
+				if (isCursedWeaponEquiped() && skillid == CursedWeaponsManager.getInstance().getCursedWeapon(_cursedWeaponEquipedId).getSkillId())
+				{
+					LegalSkill = true;
+				}
+
+				if (getClan() != null && (skillid >= 370 && skillid <= 391))
+				{
+					LegalSkill = true;
+				}
+
+				if (getClan() != null && (skillid == 246 || skillid == 247))
+				{
+					if (getClan().getLeaderId() == getObjectId())
+						LegalSkill = true;
+				}
+
+				if (skillid >= 1312 && skillid <= 1322)
+				{
+					LegalSkill = true;
+				}
+
+				if (skillid >= 1368 && skillid <= 1373)
+				{
+					LegalSkill = true;
+				}
+
+				if (skillid >= 3000 && skillid < 7000)
+				{
+					LegalSkill = true;
+				}
+
+				if (Config.ALLOWED_SKILLS_LIST.contains(skillid))
+				{
+					LegalSkill = true;
+				}
+
+				if (!LegalSkill)
+				{
+					removeSkill(skill);
+					sendMessage("[sVR]: Ilegal skill detected: "+skill.getName()+".");
+					sendMessage("[sVR]: The ilegal skill has been removed.");
+				}
+			}
+		}
+	}
}
Index: /trunk/Game/java/net/sf/l2j/Config.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/Config.java (revision 136)
+++ /trunk/Game/java/net/sf/l2j/Config.java (revision 178)
@@ -589,4 +589,7 @@
     public static int                  CHAMPION_REWARD_ID;
     public static int                  CHAMPION_REWARD_QTY;
+    public static boolean              CHECK_SKILLS_ON_ENTER;
+    public static String               ALLOWED_SKILLS;
+    public static FastList<Integer>    ALLOWED_SKILLS_LIST = new FastList<Integer>();
     
     /** Events */
@@ -616,12 +619,12 @@
     public static String               GAME_VERSION;
     public static String               BUILD_DATE;
-    
+
     /** Data Version */
     public static String               DATA_VERSION;

     /** HexID */
-    public static int                 SERVER_ID;
-    public static byte[]              HEX_ID;
-    
+    public static int                  SERVER_ID;
+    public static byte[]               HEX_ID;
+
     /** Custom */
     // Comming Soon !
@@ -1324,4 +1327,11 @@
                 CHAMPION_REWARD_ID                           = Integer.parseInt(Mods.getProperty("ChampionRewardItemID", "6393"));
                 CHAMPION_REWARD_QTY                          = Integer.parseInt(Mods.getProperty("ChampionRewardItemQty", "1"));
+                CHECK_SKILLS_ON_ENTER                        = Boolean.parseBoolean(Mods.getProperty("CheckSkillsOnEnter", "False"));
+                ALLOWED_SKILLS                               = Mods.getProperty("AllowedSkills", "541,542,543,544,545,546,547,548,549,550,551,552,553,554,555,556,557,558,617,618,619");
+                ALLOWED_SKILLS_LIST                          = new FastList<Integer>();
+                for (String id : ALLOWED_SKILLS.trim().split(","))
+                {
+                	ALLOWED_SKILLS_LIST.add(Integer.parseInt(id.trim()));
+                }
             }
             catch (Exception e)
@@ -1493,6 +1503,6 @@
                 Custom.load(is);
                 is.close();
-                
-                // Comming Soon
+
+                // Commgin Soon !
             }
             catch (Exception e)

I know shares that are not mine doesn't count a lot for the contest but someone might find it useful thanks thanks thanks.

Posted

this setting isnt already exist from the ready packs...?oO

Yes L2Oneo is very old pack

 

Whats the need, when the multiskill hack was fixed instead.

whar are you speaking about ?

Posted

whar are you speaking about ?

 

im talking about the stupidity of making codes to prevent "possible" hacks.. when its logical to fix the problem at its source? it means that instead of making a check on enter world or whatever.. you fix the villagemasterinstance and prevent the skill hack in the first place.

 

anyway, i guess this code is usefull if you dont know how and you wanna make something custom..

  • 7 months later...
Posted

Can create one command for this example . //checkskills and the source code checking automatic for skill and automatic delete the anonymous skills?

 

Sorry for my english ...thanks

  • 7 months later...
Posted

I will start from credits: L2Oneo

This checks illegal skills on enter, useful especially on pvp servers you write the skills you allow on configs.

 

Patch:

Index: /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java (revision 153)
+++ /trunk/Game/java/net/sf/l2j/gameserver/clientpackets/EnterWorld.java (revision 178)
@@ -315,4 +315,8 @@
         TvTEvent.onLogin(activeChar);
         CrownManager.getInstance().checkCrowns(activeChar);
+        if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+        {
+        	activeChar.checkIlegalSkills();
+        }
	}

Index: /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java (revision 88)
+++ /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2VillageMasterInstance.java (revision 178)
@@ -71,5 +71,5 @@
     {
         String[] commandStr = command.split(" ");
-        String actualCommand = commandStr[0]; // Get actual command
+        String actualCommand = commandStr[0];

         String cmdParams = "";
@@ -256,4 +256,9 @@
                     content.append("Change Subclass:<br>Which of the following sub classes would you like to change?<br>");
                     int classIndex = 1;
+
+                    if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+                    {
+                    	player.checkIlegalSkills();
+                    }

                     for (Iterator<SubClass> subList = iterSubClasses(player); subList.hasNext();)
@@ -375,4 +380,9 @@
                         + CharTemplateTable.getClassNameById(player.getActiveClass()) + "</font>.");

+                    if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+                    {
+                    	player.checkIlegalSkills();
+                    }
+
                     player.sendPacket(new SystemMessage(SystemMessageId.SUBCLASS_TRANSFER_COMPLETED)); // Transfer completed.
                     break;
@@ -410,4 +420,9 @@

                         player.sendPacket(new SystemMessage(SystemMessageId.ADD_NEW_SUBCLASS)); // Subclass added.
+
+                        if (Config.CHECK_SKILLS_ON_ENTER && !Config.SKILL_LEARN)
+                        {
+                        	player.checkIlegalSkills();
+                        }
                     }
                     else
Index: /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java (revision 161)
+++ /trunk/Game/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java (revision 178)
@@ -10163,3 +10163,69 @@
		return _currentSkillWorldPosition;
	}
+
+	public void checkIlegalSkills()
+	{
+		boolean LegalSkill = false;
+
+		if (!isGM())
+		{
+			Collection<L2SkillLearn> skillTree = SkillTreeTable.getInstance().getAllowedSkills(getClassId());
+
+			for (L2Skill skill : getAllSkills())
+			{
+				int skillid = skill.getId();
+
+				LegalSkill = false;
+
+				for (L2SkillLearn temp : skillTree)
+				{
+					if (temp.getId() == skillid)
+						LegalSkill = true;
+				}
+
+				if (isCursedWeaponEquiped() && skillid == CursedWeaponsManager.getInstance().getCursedWeapon(_cursedWeaponEquipedId).getSkillId())
+				{
+					LegalSkill = true;
+				}
+
+				if (getClan() != null && (skillid >= 370 && skillid <= 391))
+				{
+					LegalSkill = true;
+				}
+
+				if (getClan() != null && (skillid == 246 || skillid == 247))
+				{
+					if (getClan().getLeaderId() == getObjectId())
+						LegalSkill = true;
+				}
+
+				if (skillid >= 1312 && skillid <= 1322)
+				{
+					LegalSkill = true;
+				}
+
+				if (skillid >= 1368 && skillid <= 1373)
+				{
+					LegalSkill = true;
+				}
+
+				if (skillid >= 3000 && skillid < 7000)
+				{
+					LegalSkill = true;
+				}
+
+				if (Config.ALLOWED_SKILLS_LIST.contains(skillid))
+				{
+					LegalSkill = true;
+				}
+
+				if (!LegalSkill)
+				{
+					removeSkill(skill);
+					sendMessage("[sVR]: Ilegal skill detected: "+skill.getName()+".");
+					sendMessage("[sVR]: The ilegal skill has been removed.");
+				}
+			}
+		}
+	}
}
Index: /trunk/Game/java/net/sf/l2j/Config.java
===================================================================
--- /trunk/Game/java/net/sf/l2j/Config.java (revision 136)
+++ /trunk/Game/java/net/sf/l2j/Config.java (revision 178)
@@ -589,4 +589,7 @@
     public static int                  CHAMPION_REWARD_ID;
     public static int                  CHAMPION_REWARD_QTY;
+    public static boolean              CHECK_SKILLS_ON_ENTER;
+    public static String               ALLOWED_SKILLS;
+    public static FastList<Integer>    ALLOWED_SKILLS_LIST = new FastList<Integer>();
     
     /** Events */
@@ -616,12 +619,12 @@
     public static String               GAME_VERSION;
     public static String               BUILD_DATE;
-    
+
     /** Data Version */
     public static String               DATA_VERSION;

     /** HexID */
-    public static int                 SERVER_ID;
-    public static byte[]              HEX_ID;
-    
+    public static int                  SERVER_ID;
+    public static byte[]               HEX_ID;
+
     /** Custom */
     // Comming Soon !
@@ -1324,4 +1327,11 @@
                 CHAMPION_REWARD_ID                           = Integer.parseInt(Mods.getProperty("ChampionRewardItemID", "6393"));
                 CHAMPION_REWARD_QTY                          = Integer.parseInt(Mods.getProperty("ChampionRewardItemQty", "1"));
+                CHECK_SKILLS_ON_ENTER                        = Boolean.parseBoolean(Mods.getProperty("CheckSkillsOnEnter", "False"));
+                ALLOWED_SKILLS                               = Mods.getProperty("AllowedSkills", "541,542,543,544,545,546,547,548,549,550,551,552,553,554,555,556,557,558,617,618,619");
+                ALLOWED_SKILLS_LIST                          = new FastList<Integer>();
+                for (String id : ALLOWED_SKILLS.trim().split(","))
+                {
+                	ALLOWED_SKILLS_LIST.add(Integer.parseInt(id.trim()));
+                }
             }
             catch (Exception e)
@@ -1493,6 +1503,6 @@
                 Custom.load(is);
                 is.close();
-                
-                // Comming Soon
+
+                // Commgin Soon !
             }
             catch (Exception e)

I know shares that are not mine doesn't count a lot for the contest but someone might find it useful thanks thanks thanks.

 

Bad skill check already excists in l2j configs, idk for old packs but the latest freya has it on configs

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now


  • Posts

    • TG Support: https://t.me/buyingproxysup | Channel: https://t.me/buyingproxycom Discord support: #buyingproxy | Server: Join the BuyingProxy Discord Server! Create your free account here  
    • I've purchased the Samurai interface. Everything went smoothly, and the interface is excellent. Highly recommended!
    • For quick reference, I’ve been using the D12 dice roller when testing dice mechanics—clean design and instant results help a lot. It might give you a solid visual template to work from as you build your own games.
    • 🪙 GoldRush — High Five x20 🪙   A fresh High Five server focused on active progression, fair competition, and a healthy player-driven economy.   GoldRush is built for players who want a fresh spin on our beloved game that is connected to today's world via Web3 marketplace.    🏅 Gold Bar & Marketplace • Gold Bars are part of the server's custom economy — they can be used in Marketplace or Cosmetics shop. • Tokens are optional and used only for server Marketplace features.   ⚙️ Server Rates • EXP: 20x • SP: 20x • Adena: 10x • Normal Drop Chance: 8x • Spoil Chance: 12x • Raid Drop Chance: 3x • Quest Item Drop Amount: 5x • Quest EXP/SP Reward: 10x • Quest Adena Reward: 5x   ✨ Enchant Rates • Max Enchant: Weapons +16 / Armors +12 • +0 to +3 armor / weapon = 100% safe • +0 to +4 full body armor = 100% safe • +4 to +6 = 66% • +7 to +9 = 60% • +10 to +12 = 54% • +13 to +14 = 48% • +15 to +16 = 42%   🛒 Alt+B Services GoldRush includes useful Alt+B services: • GM Shop up to Dynasty • Buffer 1h • Teleports • Drop Search • Rankings   🎒 Auto-Loot • Normal mob drops: auto-loot • Adena: auto-loot • Raid drops: stay on the ground • Herbs: stay on the ground   🧙 Class Progression • 1st and 2nd professions are free with shadow weapon reward. • 3rd profession: 5kk • Auto Learn Skills • Subclass - No Quest • Noblesse - Full Quest     ⚔️ Olympiad • Hero period: 1 week • Olympiad time: 18:00–00:00 server time • Match duration: 5 minutes • Max enchant in Olympiad: +6   🏰 Sieges Castle sieges take place on Sundays at 16:00 and 20:00 GMT+3. The first siege will happen 2 weeks after launch.   🐉 Grand Boss Respawn Queen Ant: 24h + 2h random Core: 30h + 2h random Orfen: 48h + 2h random Baium: 120h + 3h random Antharas: 120h + 24h random Valakas: 120h + 24h random Beleth: 120h + 24h random   ⚔️ Fair Play Bots are strictly forbidden and will result in a ban without warning. Dualbox is limited to 1 box. GoldRush is built around a healthy player-to-player economy. Website : https://www.goldrushpvp.xyz/ Discord : https://discord.com/invite/v3zRZVV6ka Guide of how to make an account on our web3 server!  
    • Patch notes of update v1.0 is done regarding some feedbacks. Added Special Buffs category to the buffer. Queen Cat, Seraphim and Dwarf equipment buffs are now available. Special buffs last 1 hour and can be saved in schemes. Players can now Shift+Click monsters to check drops and spoil directly in-game.
  • Topics

×
×
  • Create New...

Important Information

This community uses essential cookies to function properly. Non-essential cookies and third-party services are used only with your consent. Read our Privacy Policy and We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue..