[Share]Rework Gracia Final FloodProtector to IL + Some Actions

[Vkouk]

So,i was trying to put 's FloodProtector Rework and i had problems,so i decided to rework it by myself.

For any problem,let me know it

 

FloodProtector Rework

http://pastebin.com/6bNw0teS

 

FloodProtector Actions

http://pastebin.com/s16WtRNn

 

FloodProtector Actions 2

http://pastebin.com/rgUy3eAz

 

 

[Versus]

There's no difference between the old & new floodprotector, so why should someone rework it?

[Vkouk]

There's no difference between the old & new floodprotector, so why should someone rework it?

Gracia FloodProtector i guess is more effective

[Versus]

Gracia FloodProtector i guess is more effective

No it's not, they do exactly the same thing.

[Coyote™]

No it's not, they do exactly the same thing.

 

No they aren't Versus, they are more efficient and easier to use..

There certainly was a reason to change them.

[Versus]

No they aren't Versus, they are more efficient and easier to use..

There certainly was a reason to change them.

Just tell me how they can be more 'efficient', i won't disagree, they might be easier to be used but in which way exactly they are more efficient?

[Coyote™]

Just tell me how they can be more 'efficient', i won't disagree, they might be easier to be used but in which way exactly they are more efficient?

 

Okay, let's make a comparison between the Interlude and the Gracia ones.

Interlude FloodProtection:

[*]Innefficient Performance.

[*]They are accessed in a REALLY BAD way.

[*]Of course the configurations, that are not as good as the gracia ones.

 

Epilogue FloodProtection:

[*]Safer & way easier to be accessed.

[*]It's really efficient.

[*]Very well configured and easy to use, especially for newbies.

[*]Really easy to be extended.

 

Let me explain:

-The configures thingy is obvious, I suppose.

 

-Efficiency: Performance Side (you'll check below).

 

-Access: In the old flood protection system, it has to search for a whole map with player IDs for the player, but in this way there are useless checks made. In the newer one there is just a cast to L2PcInstance, so you just have a simple check for the player's action. Not to mention the use of the array that makes it even slower. And the result of the old floodprotection's use is extra CPU "cycles" on every single received packet, which is obviously protected by a floodprotector.

[Versus]

Okay, let's make a comparison between the Interlude and the Gracia ones.

Interlude FloodProtection:

[*]Innefficient Performance.

[*]They are accessed in a REALLY BAD way.

[*]Of course the configurations, that are not as good as the gracia ones.

 

Epilogue FloodProtection:

[*]Safer & way easier to be accessed.

[*]It's really efficient.

[*]Very well configured and easy to use, especially for newbies.

[*]Really easy to be extended.

 

Let me explain:

-The configures thingy is obvious, I suppose.

 

-Efficiency: Performance Side (you'll check below).

 

-Access: In the old flood protection system, it has to search for a whole map with player IDs for the player, but in this way there are useless checks made. In the newer one there is just a cast to L2PcInstance, so you just have a simple check for the player's action. Not to mention the use of the array that makes it even slower. And the result of the old floodprotection's use is extra CPU "cycles" on every single received packet, which is obviously protected by a floodprotector.

So you think the new floodprotector can give you permormance boost? Come on.. even if it gives you it's so small that can't be noticed.

 

Safer & way easier to be accessed. - Safer? Sorry, but even if there's a security 'leak' at the floodprotectors, how you are supposed to exploit it? Kick yourself faster?

[Coyote™]

So you think the new floodprotector can give you permormance boost? Come on.. even if it gives you it's so small that can't be noticed.

 

Safer & way easier to be accessed. - Safer? Sorry, but even if there's a security 'leak' at the floodprotectors, how you are supposed to exploit it? Kick yourself faster?

 

1) So small? Well, you see L2jServer has been f*cked up @ performance side because of those "small" performance thingies. And that's why NB4L1 has succeeded making L2jFree the best G Final Project. And still, it's pure logic. What it's better: To use something light that will run smoothly, or something old and less efficient?

 

2) The safety thing is the new AtomicInteger. The old floodprotection is using a simple int for that kind of "tick", whereas the newer one is using the atomicinteger, which is a value updated automatically and is of course a faster and safer way, for a counter like that (where you need to count in milis). Compared to a simple integer, it's about 50% faster, so let's take an example:

On the normal Integer the value is 18 mili, whereas on the atomic one, the same value is about 11.

[Versus]

Two things i noticed with a quick look.

 

- You don't need to write 'player' or 'activeChar' before the sendPacket at clientpackets.

- All the actions (even floodprotector) should follow after the null check.

[[DEV]DjSt3rios]

Thanks, i hope it works. I will test it and i will tell you! By the way, does anyone tested this?

[Vkouk]

Thanks, i hope it works. I will test it and i will tell you! By the way, does anyone tested this?

me

[DnR]

So,i was trying to put 's FloodProtector Rework and i had problems,so i decided to rework it by myself.

For any problem,let me know it

 

FloodProtector Rework

http://pastebin.com/6bNw0teS

 

FloodProtector Actions

http://pastebin.com/s16WtRNn

 

FloodProtector Actions 2

http://pastebin.com/rgUy3eAz

 

 

Reworked what?2 lines?

You gotta give credits to l2jserver for this.

 

Okay, let's make a comparison between the Interlude and the Gracia ones.

Interlude FloodProtection:

[*]Innefficient Performance.

[*]They are accessed in a REALLY BAD way.

[*]Of course the configurations, that are not as good as the gracia ones.

 

Epilogue FloodProtection:

[*]Safer & way easier to be accessed.

[*]It's really efficient.

[*]Very well configured and easy to use, especially for newbies.

[*]Really easy to be extended.

 

Let me explain:

-The configures thingy is obvious, I suppose.

 

-Efficiency: Performance Side (you'll check below).

 

-Access: In the old flood protection system, it has to search for a whole map with player IDs for the player, but in this way there are useless checks made. In the newer one there is just a cast to L2PcInstance, so you just have a simple check for the player's action. Not to mention the use of the array that makes it even slower. And the result of the old floodprotection's use is extra CPU "cycles" on every single received packet, which is obviously protected by a floodprotector.

 

plus Gracia FP got the punishment system,phx could flood using floodprotector itself so thats a great solution to this problem.

[Trance]

What changes are exactly >.> ?

 

Anyway i downloaded maybe i will see alone.

[Vkouk]

2 lines?

parizaki you should see what i change and then speak