Help Olympiad problem erorr plz help

[optimousprime]

ERROR Error saving Olympiadds.
java.util.ConcurrentModificationException
        at java.util.HashMap$HashIterator.nextNode(HashMap.java:1445)
        at java.util.HashMap$KeyIterator.next(HashMap.java:1469)
        at com.l2jfrozen.gameserver.model.entity.olympiad.Olympiad.saveNobleData(Olympiad.java:1098)
        at com.l2jfrozen.gameserver.model.entity.olympiad.Olympiad.saveOlympiadStatus(Olympiad.java:1201)
        at com.l2jfrozen.gameserver.Shutdown.saveData(Shutdown.java:499)
        at com.l2jfrozen.gameserver.Shutdown.closeServer(Shutdown.java:357)
        at com.l2jfrozen.gameserver.Shutdown.run(Shutdown.java:182)

[Zake]

Did you put any custom code that affects olympiad?

[optimousprime]

hello bro. i use rev l2jfrozen 1,5 the only code is adapted to the olympiad section java is the code that shows olympiad period ends.

but the problem waz before that code be adapted to  my server.!

 

and i don't have any error on eclipse :/

[Zake]

com.l2jfrozen.gameserver.model.entity.olympiad.Olympiad.saveNobleData(Olympiad.java:1098)

go to this line and see what happens

[optimousprime]

ok bro sec

/**
	 * Save noblesse data to database
	 */
	protected synchronized void saveNobleData()
	{
		if (nobles == null || nobles.isEmpty())
		{
			return;
		}
		
		try (Connection con = L2DatabaseFactory.getInstance().getConnection();)
		{
			for (int nobleId : nobles.keySet())
			{
				StatsSet nobleInfo = nobles.get(nobleId);
				
				if (nobleInfo == null)
				{
					continue;
				}
				
				int charId = nobleId;
				int classId = nobleInfo.getInteger(CLASS_ID);
				String charName = nobleInfo.getString(CHAR_NAME);
				int points = nobleInfo.getInteger(POINTS);
				int compDone = nobleInfo.getInteger(COMP_DONE);
				int compWon = nobleInfo.getInteger(COMP_WON);
				int compLost = nobleInfo.getInteger(COMP_LOST);
				int compDrawn = nobleInfo.getInteger(COMP_DRAWN);
				boolean toSave = nobleInfo.getBool("to_save");
				
				if (toSave)
				{
					try (PreparedStatement statement = con.prepareStatement(OLYMPIAD_SAVE_NOBLES))
					{
						statement.setInt(1, charId);
						statement.setInt(2, classId);
						statement.setString(3, charName);
						statement.setInt(4, points);
						statement.setInt(5, compDone);
						statement.setInt(6, compWon);
						statement.setInt(7, compLost);
						statement.setInt(8, compDrawn);
						
						nobleInfo.set("to_save", false);
						
						updateNobleStats(nobleId, nobleInfo);
						
						statement.executeUpdate();
					}
				}
				else
				{
					try (PreparedStatement statement = con.prepareStatement(OLYMPIAD_UPDATE_NOBLES))
					{
						statement.setInt(1, points);
						statement.setInt(2, compDone);
						statement.setInt(3, compWon);
						statement.setInt(4, compLost);
						statement.setInt(5, compDrawn);
						statement.setInt(6, charId);
						
						statement.executeUpdate();
					}
				}
			}
		}
		catch (SQLException e)
		{
			LOGGER.error("Olympiad.saveNobleData : Failed to save noblesse data to database: ", e);
		}
	}
	
	/**
	 * Save noblesse data to database
	 * @param nobleId
	 */
	protected synchronized void saveOldNobleData(final int nobleId)
	{
		try (Connection con = L2DatabaseFactory.getInstance().getConnection();
			PreparedStatement statement = con.prepareStatement(OLYMPIAD_UPDATE_OLD_NOBLES))
		{
			StatsSet nobleInfo = oldnobles.get(nobleId);
			
			if (nobleInfo == null)
			{
				return;
			}
			
			int charId = nobleId;
			int points = nobleInfo.getInteger(POINTS);
			int compDone = nobleInfo.getInteger(COMP_DONE);
			int compWon = nobleInfo.getInteger(COMP_WON);
			int compLost = nobleInfo.getInteger(COMP_LOST);
			int compDrawn = nobleInfo.getInteger(COMP_DRAWN);
			
			statement.setInt(1, points);
			statement.setInt(2, compDone);
			statement.setInt(3, compWon);
			statement.setInt(4, compLost);
			statement.setInt(5, compDrawn);
			statement.setInt(6, charId);
			statement.executeUpdate();
		}
		catch (SQLException e)
		{
			LOGGER.error("Olympiad.saveOldNobleData : Failed to save old noblesse data to database: ", e);
		}
	}
	
	/**
	 * Save olympiad.properties file with current olympiad status and update noblesse table in database
	 */
	public void saveOlympiadStatus()
	{
		saveNobleData();
		
		final Properties OlympiadProperties = new Properties();
		try (FileOutputStream fos = new FileOutputStream(new File("./" + OLYMPIAD_DATA_FILE));)
		{
			OlympiadProperties.setProperty("CurrentCycle", String.valueOf(currentCycle));
			OlympiadProperties.setProperty("Period", String.valueOf(period));
			OlympiadProperties.setProperty("OlympiadEnd", String.valueOf(olympiadEnd));
			OlympiadProperties.setProperty("ValdationEnd", String.valueOf(olympiadValidationEnd));
			OlympiadProperties.setProperty("NextWeeklyChange", String.valueOf(nextWeeklyChange));
			
			final GregorianCalendar gc = (GregorianCalendar) Calendar.getInstance();
			gc.clear();
			gc.setTimeInMillis(nextWeeklyChange);
			
			OlympiadProperties.setProperty("NextWeeklyChange_DateFormat", DateFormat.getDateTimeInstance().format(gc.getTime()));
			// LOGGER.info("NextPoints: "+DateFormat.getInstance().format(gc.getTime()));
			
			gc.clear();
			gc.setTimeInMillis(olympiadEnd);
			
			OlympiadProperties.setProperty("OlympiadEnd_DateFormat", DateFormat.getDateTimeInstance().format(gc.getTime()));
			// LOGGER.info("NextOlyDate: "+DateFormat.getInstance().format(gc.getTime()));
			
			OlympiadProperties.store(fos, "Olympiad Properties");
		}
		catch (final Exception e)
		{
			LOGGER.warn("Olympiad System: Unable to save olympiad properties to file: ", e);
		}
		
		LOGGER.info("Olympiad System: Data saved!!");
	}
	
	protected void updateMonthlyData()
	{
		try (Connection con = L2DatabaseFactory.getInstance().getConnection();)
		{
			try (PreparedStatement statement = con.prepareStatement(OLYMPIAD_MONTH_CLEAR))
			{
				statement.execute();
			}
			
			try (PreparedStatement statement = con.prepareStatement(OLYMPIAD_MONTH_CREATE))
			{
				statement.executeUpdate();
			}
		}
		catch (SQLException e)
		{
			LOGGER.error("Olympiad.updateMonthlyData : Failed to update monthly noblese data", e);
		}
	}

 

[Zake]

and the line 1098 is?

[TGSLineage2]

It seems to me that this is a concurrency error and it occurs when you take the same collection to make modifications to it at the same time from different methods, it could be solved by synchronizing the methods that at some point will take the same collection to work or in the particular case of MAPs declaring it as a concurrentHashMap in the latest java versions.

[optimousprime]

bro i can you contak me  lineage2jvc@gmail.com

this is all the line bro

 

/**
     * Save noblesse data to database
     */
    protected synchronized void saveNobleData()
    {
        if (nobles == null || nobles.isEmpty())
        {
            return;
        }
        
        try (Connection con = L2DatabaseFactory.getInstance().getConnection();)
        {
            for (int nobleId : nobles.keySet())
            {
                StatsSet nobleInfo = nobles.get(nobleId);
                
                if (nobleInfo == null)
                {
                    continue;
                }
                
                int charId = nobleId;
                int classId = nobleInfo.getInteger(CLASS_ID);
                String charName = nobleInfo.getString(CHAR_NAME);
                int points = nobleInfo.getInteger(POINTS);
                int compDone = nobleInfo.getInteger(COMP_DONE);
                int compWon = nobleInfo.getInteger(COMP_WON);
                int compLost = nobleInfo.getInteger(COMP_LOST);
                int compDrawn = nobleInfo.getInteger(COMP_DRAWN);
                boolean toSave = nobleInfo.getBool("to_save");
                
                if (toSave)
                {
                    try (PreparedStatement statement = con.prepareStatement(OLYMPIAD_SAVE_NOBLES))
                    {
                        statement.setInt(1, charId);
                        statement.setInt(2, classId);
                        statement.setString(3, charName);
                        statement.setInt(4, points);
                        statement.setInt(5, compDone);
                        statement.setInt(6, compWon);
                        statement.setInt(7, compLost);
                        statement.setInt(8, compDrawn);
                        
                        nobleInfo.set("to_save", false);
                        
                        updateNobleStats(nobleId, nobleInfo);
                        
                        statement.executeUpdate();
                    }
                }
                else
                {
                    try (PreparedStatement statement = con.prepareStatement(OLYMPIAD_UPDATE_NOBLES))
                    {
                        statement.setInt(1, points);
                        statement.setInt(2, compDone);
                        statement.setInt(3, compWon);
                        statement.setInt(4, compLost);
                        statement.setInt(5, compDrawn);
                        statement.setInt(6, charId);
                        
                        statement.executeUpdate();
                    }
                }
            }
        }
        catch (SQLException e)
        {
            LOGGER.error("Olympiad.saveNobleData : Failed to save noblesse data to database: ", e);
        }
    }