Jump to content

Recommended Posts

Posted
51 minutes ago, melron said:

 


public String onKill(Npc npc, Player killer, boolean isPet)
{
	if (npc.getNpcId() == MONSTER_IDS[0] || npc.getNpcId() == MONSTER_IDS[1])
		attack((Attackable) addSpawn(npc.getNpcId()+1, npc, true, 0, false), killer);
	return super.onKill(npc, killer, isPet);
}

 

 

 

Posted
7 minutes ago, .Elfocrash said:

You are wrong. Forget about this +1 bullshit. It's total shit because you are not guaranteed that the next ID will be a +1 of the previous. A queue will guarantee that you always get the next value.

 

.poll() with get the current head and remove it.

 

Here is an example of how it will work:

 

image.png.91407001cd5909993e20ab43a8ee2b11.png

 

I mean this

 

test1.PNG.0b5a395b00db1f73156bff69515524a9.PNG

test2.PNG.2c2d2078d4575119589471340ee3e67d.PNG

Posted (edited)
5 minutes ago, .Elfocrash said:

Nop the first id should not be the current mob. The first mob is the next mob. Why would you want the current mob in the list? It makes no sense.

 

Also, like I said, what if you wanna spawn a gremlin, and then a zombie and then valakas and then baium? Your whole ++ logic it out of the picture.

 

my point isn't the ++ logic. im trying to understand how you thought about it and i'm asking some questions in order to learn some new things.

 

When you have registered 3 IDS (1,2,3) at event onKill and the mob with ID 1 will die, onKill function will spawn the list.poll right?

the list.poll will return the ID of the head so for first time is the 1 .

 

 @Override
    protected void registerNpcs()
    {
        monsterIds.add(1009);

Lets say the 1009 will die ok?

 

public String onKill(Npc npc, Player killer, boolean isPet)
    {
        if(monsterIds.size() == 0)
            return super.onKill(npc, killer, isPet);

        Attackable newNpc = (Attackable) addSpawn(monsterIds.poll(), npc, true, 0, false);

What id will have the newNpc ?

 

if my questions are bothering you i will stop my stupid questions

Edited by melron
Posted (edited)
3 minutes ago, .Elfocrash said:

No. id 1 will not be in the monsterId queue. If your current mob id is 1 then your list will be [2,3,4] not [1,2,3,4] 

thats exactly what i was talking about. So the monsterId mustn't be registered at all and its usefull only for spawning purposes because we need to register the id 1 as registered id, or just register in new line the 1st id

Edited by melron
Posted
Just now, .Elfocrash said:

I never said to add the current id in the list. I was assuming that 1009 is the next monster's Id

I didn't noticed this way because you didn't registered the 'first id' at your code thats why. Alright thank you for your instructions 

Posted

shitcode fest, GG mates.

 

onDie(...)
{
    final int nextspawnId = template.getNextSpawnId();

    if (nextSpawnId)

            spawn(nextspawnId

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.




×
×
  • Create New...